Page MenuHomePhabricator

marbre (Marius Brehler)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2020, 1:53 AM (135 w, 12 h)

Recent Activity

Fri, Aug 12

marbre committed rGf3547fd541ca: [mlir][emitc][nfc] Clean up tests (authored by marbre).
[mlir][emitc][nfc] Clean up tests
Fri, Aug 12, 1:26 AM · Restricted Project, Restricted Project
marbre committed rG90736babcaeb: [mlir][EmitC] Remove the type from the OpaqueAttr (authored by marbre).
[mlir][EmitC] Remove the type from the OpaqueAttr
Fri, Aug 12, 12:14 AM · Restricted Project, Restricted Project
marbre closed D131666: [mlir][EmitC] Remove the type from the OpaqueAttr.
Fri, Aug 12, 12:14 AM · Restricted Project, Restricted Project

Thu, Aug 11

marbre requested review of D131666: [mlir][EmitC] Remove the type from the OpaqueAttr.
Thu, Aug 11, 3:46 AM · Restricted Project, Restricted Project
marbre committed rG91b6f76a582a: [mlir] Fix calling the native mlir-pdll-tblgen (authored by marbre).
[mlir] Fix calling the native mlir-pdll-tblgen
Thu, Aug 11, 2:35 AM · Restricted Project, Restricted Project
marbre closed D131596: [mlir] Fix calling the native mlir-pdll-tblgen.
Thu, Aug 11, 2:34 AM · Restricted Project, Restricted Project

Wed, Aug 10

marbre requested review of D131596: [mlir] Fix calling the native mlir-pdll-tblgen.
Wed, Aug 10, 10:31 AM · Restricted Project, Restricted Project

Mon, Aug 1

marbre accepted D130350: [mlir] Fix calling the native mlir-tblgen tool when cross compiling flang.
Mon, Aug 1, 9:44 AM · Restricted Project, Restricted Project, Restricted Project
marbre committed rGddb6c28638f9: Avoid comparison of integers of different signs (authored by marbre).
Avoid comparison of integers of different signs
Mon, Aug 1, 4:21 AM · Restricted Project, Restricted Project

Thu, Jul 28

marbre added a comment to D130350: [mlir] Fix calling the native mlir-tblgen tool when cross compiling flang.

I tried the patch locally to build torch-mlir https://github.com/llvm/torch-mlir/issues/1094 and it still fails cross-compile.

If you apply the to torch-mlir, you also need a corresponding change to the one in flang/CMakeLists.txt in this patch, where set(MLIR_TABLEGEN_EXE $<TARGET_FILE:mlir-tblgen>) is removed - I presume that torch-mlir has something similar.

Thu, Jul 28, 6:26 AM · Restricted Project, Restricted Project, Restricted Project

May 5 2022

marbre added a comment to D125010: [MLIR] Fix build with make.

I am currently out-of-office and don‘t have any access to my build machines. Therefore, I cannot test and confirm that the patch doesn‘t have unintended side effects. However, there is definitely a need to add a dependency to the tablgen generated header files. Sorry for missing this as part of https://reviews.llvm.org/D124851. I would suggest to take a look how this is done for MLIR dialects, where explicits deps to the generated targets are passed to add_mlir_dialect_library like in https://github.com/llvm/llvm-project/blob/04b419048955fc33718ba97e79f3558b6a27830e/mlir/lib/Dialect/EmitC/IR/CMakeLists.txt#L7-L9. It might not be necessary to touch AddLLVM and I assume the deps should rather be on the *IncGen target,

May 5 2022, 8:03 AM · Restricted Project, Restricted Project, Restricted Project

May 3 2022

marbre committed rG63aaf9a6e7f9: [mlir] Add missing CMake deps to mlir-pdll (authored by marbre).
[mlir] Add missing CMake deps to mlir-pdll
May 3 2022, 11:18 PM · Restricted Project, Restricted Project
marbre closed D124851: [mlir] Add missing CMake deps to mlir-pdll.
May 3 2022, 11:18 PM · Restricted Project, Restricted Project
marbre added a comment to D124851: [mlir] Add missing CMake deps to mlir-pdll.

The missing dep on MLIRIR actually showed up as a race condition in the build process on a GH runner.

May 3 2022, 6:56 AM · Restricted Project, Restricted Project
marbre requested review of D124851: [mlir] Add missing CMake deps to mlir-pdll.
May 3 2022, 5:59 AM · Restricted Project, Restricted Project

Apr 28 2022

marbre committed rG84fe39a45b73: [mlir][emitc] Add a cast op (authored by marbre).
[mlir][emitc] Add a cast op
Apr 28 2022, 8:52 AM · Restricted Project, Restricted Project
marbre closed D123514: [mlir][emitc] Add a cast op.
Apr 28 2022, 8:51 AM · Restricted Project, Restricted Project
marbre committed rG50d648b40ecd: [mlir][emitc] Replace !emitc.opaque pointers (authored by marbre).
[mlir][emitc] Replace !emitc.opaque pointers
Apr 28 2022, 8:21 AM · Restricted Project, Restricted Project
marbre committed rG39dd29736ffa: [mlir][emitc] Disallow !emitc.opaque pointers (authored by marbre).
[mlir][emitc] Disallow !emitc.opaque pointers
Apr 28 2022, 8:10 AM · Restricted Project, Restricted Project
marbre closed D124002: [mlir][emitc] Disallow !emitc.opaque pointers.
Apr 28 2022, 8:09 AM · Restricted Project, Restricted Project

Apr 25 2022

marbre added a comment to D123514: [mlir][emitc] Add a cast op.

Thanks for the review @jpienaar! I will address your comments before landing.

Apr 25 2022, 8:22 AM · Restricted Project, Restricted Project
marbre added inline comments to D124002: [mlir][emitc] Disallow !emitc.opaque pointers.
Apr 25 2022, 8:13 AM · Restricted Project, Restricted Project
marbre updated the diff for D124002: [mlir][emitc] Disallow !emitc.opaque pointers.

Updating D124002: [mlir][emitc] Disallow !emitc.opaque pointers

Apr 25 2022, 8:11 AM · Restricted Project, Restricted Project

Apr 19 2022

marbre requested review of D124002: [mlir][emitc] Disallow !emitc.opaque pointers.
Apr 19 2022, 6:43 AM · Restricted Project, Restricted Project
marbre added inline comments to D123514: [mlir][emitc] Add a cast op.
Apr 19 2022, 6:38 AM · Restricted Project, Restricted Project
marbre committed rG2ba865903dae: [mlir][emitc] Add test for invalid type (authored by marbre).
[mlir][emitc] Add test for invalid type
Apr 19 2022, 2:05 AM · Restricted Project, Restricted Project
marbre closed D123503: [mlir][emitc] Add test for invalid type.
Apr 19 2022, 2:05 AM · Restricted Project, Restricted Project

Apr 13 2022

marbre committed rGf71f105901da: [mlir][docs] Fix broken links (authored by marbre).
[mlir][docs] Fix broken links
Apr 13 2022, 7:19 AM · Restricted Project, Restricted Project

Apr 12 2022

marbre added inline comments to D123503: [mlir][emitc] Add test for invalid type.
Apr 12 2022, 1:26 AM · Restricted Project, Restricted Project

Apr 11 2022

marbre requested review of D123514: [mlir][emitc] Add a cast op.
Apr 11 2022, 7:30 AM · Restricted Project, Restricted Project
marbre requested review of D123503: [mlir][emitc] Add test for invalid type.
Apr 11 2022, 6:14 AM · Restricted Project, Restricted Project
marbre committed rG4f185fccc722: [mlir][emitc][nfc] Replace !emitc.opaque pointers (authored by marbre).
[mlir][emitc][nfc] Replace !emitc.opaque pointers
Apr 11 2022, 4:59 AM · Restricted Project, Restricted Project

Mar 28 2022

marbre committed rGc5c9d6e0d5ab: [mlir][emitc] Adapt to move of FuncOp (authored by marbre).
[mlir][emitc] Adapt to move of FuncOp
Mar 28 2022, 8:45 AM · Restricted Project, Restricted Project
marbre closed D122305: [mlir][emitc] Adapt to move of FuncOp.
Mar 28 2022, 8:45 AM · Restricted Project, Restricted Project

Mar 23 2022

marbre abandoned D106541: [mlir] Enable generation of type constraint docs.
Mar 23 2022, 4:52 AM · Restricted Project, Restricted Project
marbre requested review of D122305: [mlir][emitc] Adapt to move of FuncOp.
Mar 23 2022, 4:51 AM · Restricted Project, Restricted Project

Mar 14 2022

marbre added inline comments to D120788: [cmake] Add INTERFACE_INCLUDE_DIRECTORIES to LLVM and MLIR..
Mar 14 2022, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
marbre added inline comments to D120788: [cmake] Add INTERFACE_INCLUDE_DIRECTORIES to LLVM and MLIR..
Mar 14 2022, 9:49 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2022

marbre accepted D120788: [cmake] Add INTERFACE_INCLUDE_DIRECTORIES to LLVM and MLIR..

Please excuse if my previous reply was confusing. I checked more carefully and think these changes are good to go.

Mar 11 2022, 7:50 AM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

marbre added a comment to D120788: [cmake] Add INTERFACE_INCLUDE_DIRECTORIES to LLVM and MLIR..

Thanks for working on this Stella! Untangling the functions/marcos is a bit hard. Thus, I am mainly commenting to make sure I fully understand the patch :)

Mar 2 2022, 8:22 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2022

marbre added inline comments to D120098: [mlir][emitc] Add a variable op.
Feb 24 2022, 7:32 AM · Restricted Project
marbre committed rG1fa125111607: [mlir][emitc] Add a variable op (authored by marbre).
[mlir][emitc] Add a variable op
Feb 24 2022, 7:28 AM
marbre closed D120098: [mlir][emitc] Add a variable op.
Feb 24 2022, 7:28 AM · Restricted Project

Feb 23 2022

marbre added a comment to D120098: [mlir][emitc] Add a variable op.

As an example, the canonicalization pass would transform

func @myfunc() {
  %0 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %1 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %2 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  %3 = emitc.apply "&"(%1) : (i32) -> !emitc.ptr<i32>
  emitc.call "write"(%2, %3) : (!emitc.ptr<i32>, !emitc.ptr<i32>) -> ()
  return
}

into

func @myfunc() {
  %0 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %1 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  %2 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  emitc.call "write"(%1, %2) : (!emitc.ptr<i32>, !emitc.ptr<i32>) -> ()
  return
}

resulting in pointer aliasing. Here, the variable op would be helpful.

Could you elevate this to be part of the commit description and expand on the pains? (I think you'd want to expand in the op descriptions too what variety to use and why).

Feb 23 2022, 6:55 AM · Restricted Project
marbre updated the diff for D120098: [mlir][emitc] Add a variable op.

Address review comments

Feb 23 2022, 6:52 AM · Restricted Project
marbre updated the summary of D120098: [mlir][emitc] Add a variable op.
Feb 23 2022, 6:47 AM · Restricted Project

Feb 17 2022

marbre added a comment to D120098: [mlir][emitc] Add a variable op.

As an example, the canonicalization pass would transform

func @myfunc() {
  %0 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %1 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %2 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  %3 = emitc.apply "&"(%1) : (i32) -> !emitc.ptr<i32>
  emitc.call "write"(%2, %3) : (!emitc.ptr<i32>, !emitc.ptr<i32>) -> ()
  return
}

into

func @myfunc() {
  %0 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %1 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  %2 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  emitc.call "write"(%1, %2) : (!emitc.ptr<i32>, !emitc.ptr<i32>) -> ()
  return
}

resulting in pointer aliasing. Here, the variable op would be helpful.

Feb 17 2022, 4:08 PM · Restricted Project
marbre requested review of D120098: [mlir][emitc] Add a variable op.
Feb 17 2022, 4:05 PM · Restricted Project

Feb 14 2022

marbre committed rG88b9d1a49aba: [mlir][emitc] Add a pointer type (authored by marbre).
[mlir][emitc] Add a pointer type
Feb 14 2022, 8:45 AM
marbre closed D119337: [mlir][emitc] Add a pointer type.
Feb 14 2022, 8:45 AM · Restricted Project

Feb 10 2022

marbre committed rG44c158226549: [mlir] Add missing dep to new cf dialect (authored by marbre).
[mlir] Add missing dep to new cf dialect
Feb 10 2022, 6:17 AM
marbre updated the diff for D119337: [mlir][emitc] Add a pointer type.

Updating D119337: [mlir][emitc] Add a pointer type

Feb 10 2022, 3:42 AM · Restricted Project
marbre added a comment to D119337: [mlir][emitc] Add a pointer type.

@jpienaar I adressed your comments with the latest revision.

Feb 10 2022, 2:18 AM · Restricted Project
marbre updated the diff for D119337: [mlir][emitc] Add a pointer type.

Updating D119337: [mlir][emitc] Add a pointer type

Feb 10 2022, 2:09 AM · Restricted Project

Feb 9 2022

marbre added inline comments to D119337: [mlir][emitc] Add a pointer type.
Feb 9 2022, 8:47 AM · Restricted Project
marbre requested review of D119337: [mlir][emitc] Add a pointer type.
Feb 9 2022, 7:01 AM · Restricted Project

Jan 26 2022

marbre committed rG578122c18a2f: [mlir] Don't emit unused labels (authored by marbre).
[mlir] Don't emit unused labels
Jan 26 2022, 11:57 PM
marbre closed D118154: [mlir] Don't emit unused labels.
Jan 26 2022, 11:56 PM · Restricted Project
marbre added inline comments to D118154: [mlir] Don't emit unused labels.
Jan 26 2022, 6:20 AM · Restricted Project
marbre updated the diff for D118154: [mlir] Don't emit unused labels.

Updating D118154: [mlir] Don't emit unused labels

Jan 26 2022, 6:18 AM · Restricted Project

Jan 25 2022

marbre requested review of D118154: [mlir] Don't emit unused labels.
Jan 25 2022, 8:24 AM · Restricted Project

Nov 8 2021

marbre committed rG2494e9c5926c: [mlir][docs] Unify style (nfc) (authored by marbre).
[mlir][docs] Unify style (nfc)
Nov 8 2021, 2:44 PM

Oct 28 2021

marbre added a comment to D110797: [MLIR] Replace std ops with arith dialect ops.

I recently noticed that arith::ConstantOp support was added to the Cpp emitter with this commit. @jpienaar and @mehdi_amini, do we really want to add support for such ops to the printer? The alternative would be to add conversions, like the arith.constant to emitc.constant one which I have implemented in our mlir-emitc repo: https://github.com/iml130/mlir-emitc/blob/c3b7bf093417ecd50e4b246ffd85079dbd75e359/lib/Dialect/EmitC/Conversion/ArithToEmitC.cpp#L27-L38.

Oct 28 2021, 11:39 AM · Restricted Project, Restricted Project

Sep 15 2021

marbre accepted D109805: [mlir][emitc] Fix indent in CondBranchOp and block label.

LGTM. Thanks for improving the EmitC!

Sep 15 2021, 11:26 AM · Restricted Project
marbre committed rG1b79efdc72e6: [mlir] Fix printing of EmitC attrs/types with escape characters (authored by simon-camp).
[mlir] Fix printing of EmitC attrs/types with escape characters
Sep 15 2021, 11:18 AM
marbre closed D109143: [mlir] Fix printing of EmitC attrs/types with escape characters.
Sep 15 2021, 11:18 AM · Restricted Project
marbre accepted D109143: [mlir] Fix printing of EmitC attrs/types with escape characters.
Sep 15 2021, 11:12 AM · Restricted Project

Sep 13 2021

marbre committed rGec92f788f343: [mlir][emitc] Print signed integers properly (authored by simon-camp).
[mlir][emitc] Print signed integers properly
Sep 13 2021, 8:30 AM
marbre closed D109690: [mlir][emitc] Print signed integers properly.
Sep 13 2021, 8:29 AM · Restricted Project
marbre accepted D109690: [mlir][emitc] Print signed integers properly.

Thanks for taking over!

Sep 13 2021, 8:24 AM · Restricted Project

Sep 10 2021

marbre committed rG6593cd3fe989: [mlir] Replace `include_directories` (authored by marbre).
[mlir] Replace `include_directories`
Sep 10 2021, 12:07 AM
marbre closed D109494: [mlir] Replace `include_directories`.
Sep 10 2021, 12:06 AM · Restricted Project

Sep 9 2021

marbre requested review of D109494: [mlir] Replace `include_directories`.
Sep 9 2021, 2:57 AM · Restricted Project

Sep 5 2021

marbre committed rG779368bd9fc6: [mlir][docs] Complement list of supported scf ops (authored by marbre).
[mlir][docs] Complement list of supported scf ops
Sep 5 2021, 10:55 PM

Sep 3 2021

marbre committed rG36895cd8d83f: [mlir] Update EmitC documentation (authored by marbre).
[mlir] Update EmitC documentation
Sep 3 2021, 8:24 AM

Sep 2 2021

marbre committed rGf6063fedb428: [mlir] Add missing dep on MLIRTranslation (authored by marbre).
[mlir] Add missing dep on MLIRTranslation
Sep 2 2021, 9:55 AM
marbre committed rG2f0750dd2ec0: [mlir] Add Cpp emitter (authored by marbre).
[mlir] Add Cpp emitter
Sep 2 2021, 6:56 AM
marbre closed D104632: [mlir] Add Cpp emitter.
Sep 2 2021, 6:55 AM · Restricted Project

Aug 30 2021

marbre added a comment to D104632: [mlir] Add Cpp emitter.

I'll leave approval to @jpienaar, the current version is fine with me, thanks!

Aug 30 2021, 12:22 PM · Restricted Project

Aug 26 2021

marbre updated the diff for D104632: [mlir] Add Cpp emitter.

Refactor translation cmdline arguments

Aug 26 2021, 9:45 AM · Restricted Project
marbre added inline comments to D104632: [mlir] Add Cpp emitter.
Aug 26 2021, 8:57 AM · Restricted Project
marbre added inline comments to D104632: [mlir] Add Cpp emitter.
Aug 26 2021, 12:04 AM · Restricted Project

Aug 25 2021

marbre added a comment to D104632: [mlir] Add Cpp emitter.

Thanks for the review @jpienaar! I have updated our patch accordingly.

Aug 25 2021, 8:49 AM · Restricted Project
marbre updated the diff for D104632: [mlir] Add Cpp emitter.

Address review comments

Aug 25 2021, 8:26 AM · Restricted Project

Aug 20 2021

marbre added a comment to D104632: [mlir] Add Cpp emitter.

With https://github.com/llvm/mlir-www/pull/83 merged (allowing to include custom docs in auto-generated ones) and me having finally had some time to write a first markdown documentation (we can still iterate and improve that one!) I would kindly ask @rriddle, @mehdi_amini and @jpienaar to re-review the patch :)

Aug 20 2021, 10:47 AM · Restricted Project
marbre updated the diff for D104632: [mlir] Add Cpp emitter.

Add markdown documentation and dialect description

Aug 20 2021, 10:42 AM · Restricted Project

Jul 22 2021

marbre committed rG49d840c35c69: [mlir] Improve description of interface options (authored by marbre).
[mlir] Improve description of interface options
Jul 22 2021, 10:37 AM
marbre closed D106539: [mlir] Improve description of interface options.
Jul 22 2021, 10:36 AM · Restricted Project
marbre added a comment to D106541: [mlir] Enable generation of type constraint docs.

Have you looked into fixing the issues with gen-dialect-doc? Or is it not easily feasible?

Jul 22 2021, 10:30 AM · Restricted Project, Restricted Project
marbre added a comment to D106541: [mlir] Enable generation of type constraint docs.

OOC when would one want to just have the type constraints? I was thinking most were moving towards full doc generation

Jul 22 2021, 6:35 AM · Restricted Project, Restricted Project
marbre requested review of D106541: [mlir] Enable generation of type constraint docs.
Jul 22 2021, 5:31 AM · Restricted Project, Restricted Project
marbre requested review of D106539: [mlir] Improve description of interface options.
Jul 22 2021, 5:22 AM · Restricted Project

Jul 10 2021

post.kadirselcuk awarded D104632: [mlir] Add Cpp emitter a Hungry Hippo token.
Jul 10 2021, 8:37 PM · Restricted Project

Jul 9 2021

marbre updated the diff for D104632: [mlir] Add Cpp emitter.

Updating D104632: [mlir] Add Cpp emitter

Jul 9 2021, 11:17 AM · Restricted Project
marbre added a comment to D104632: [mlir] Add Cpp emitter.

Thanks for all review comments. Most comments should be addressed with the next revision. As discussed, the emitter's API is now significantly closed (only translateToCpp is accessible). The revision also drops the emitter's restriction to only generate C code. This is of course still possible and depends (as before) on the implemented conversions, but isn't checked in the emitter itself anymore. What the revision lacks is a dedicated markdown documentation. Suggestion to where to place such docs in the docs/ folder are welcome. So far the other targets don't have separate docs or should those live side-by-side to the EmitC dialect?

Jul 9 2021, 11:16 AM · Restricted Project

Jul 5 2021

marbre committed rG96e3fb2416f6: [mlir] Unbreak building mlir-reduce (authored by marbre).
[mlir] Unbreak building mlir-reduce
Jul 5 2021, 8:10 AM
marbre closed D105434: [mlir] Unbreak building mlir-reduce.
Jul 5 2021, 8:10 AM · Restricted Project
marbre requested review of D105434: [mlir] Unbreak building mlir-reduce.
Jul 5 2021, 8:04 AM · Restricted Project
marbre committed rG4ff440b0efb0: [mlir] Change custom syntax of emitc.include op to resemble C (authored by simon-camp).
[mlir] Change custom syntax of emitc.include op to resemble C
Jul 5 2021, 7:42 AM
marbre closed D105281: [mlir] Change custom syntax of emitc.include op to resemble C.
Jul 5 2021, 7:42 AM · Restricted Project