Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

marbre (Marius Brehler)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2020, 1:53 AM (202 w, 5 d)

Recent Activity

Aug 30 2023

marbre committed rG36c9afc7a811: [mlir][emitc][nfc] List supported comparisons (authored by marbre).
[mlir][emitc][nfc] List supported comparisons
Aug 30 2023, 7:29 AM · Restricted Project, Restricted Project
marbre closed D159195: [mlir][emitc][nfc] List supported comparisons.
Aug 30 2023, 7:29 AM · Restricted Project, Restricted Project
marbre requested review of D159195: [mlir][emitc][nfc] List supported comparisons.
Aug 30 2023, 6:16 AM · Restricted Project, Restricted Project

Aug 29 2023

marbre committed rGadea7e7032ad: [mlir][emitc] Add comparison operation (authored by simon-camp).
[mlir][emitc] Add comparison operation
Aug 29 2023, 9:51 AM · Restricted Project, Restricted Project
marbre closed D158180: [mlir][emitc] Add comparison operation.
Aug 29 2023, 9:50 AM · Restricted Project, Restricted Project

Jul 27 2023

marbre accepted D150356: [mlir][emitc] Add literal constant..

Thanks for updating the PR @jpienaar.

Jul 27 2023, 6:42 AM · Restricted Project, Restricted Project

Jul 11 2023

marbre committed rGa2426eb603af: [mlir][emitc] Add div, mul and rem operators (authored by marbre).
[mlir][emitc] Add div, mul and rem operators
Jul 11 2023, 11:45 PM · Restricted Project, Restricted Project
marbre closed D154846: [mlir][emitc] Add div, mul and rem operators.
Jul 11 2023, 11:44 PM · Restricted Project, Restricted Project
marbre added a comment to D154846: [mlir][emitc] Add div, mul and rem operators.

Thanks for your review @jpienaar!

Jul 11 2023, 11:39 PM · Restricted Project, Restricted Project

Jul 10 2023

marbre requested review of D154846: [mlir][emitc] Add div, mul and rem operators.
Jul 10 2023, 7:13 AM · Restricted Project, Restricted Project

Jul 4 2023

marbre committed rGd954d9758a4f: [mlir][emitc][nfc] Update summary of opaque type (authored by marbre).
[mlir][emitc][nfc] Update summary of opaque type
Jul 4 2023, 11:36 AM · Restricted Project, Restricted Project
marbre closed D154453: [mlir][emitc][nfc] Update summary of opaque type.
Jul 4 2023, 11:36 AM · Restricted Project, Restricted Project
marbre requested review of D154453: [mlir][emitc][nfc] Update summary of opaque type.
Jul 4 2023, 9:29 AM · Restricted Project, Restricted Project

Jun 23 2023

marbre added inline comments to D149963: [mlir][emitc] Add add and sub operations.
Jun 23 2023, 5:28 AM · Restricted Project, Restricted Project
marbre committed rG0f1ac5e110cc: [mlir][emitc] Add add and sub operations (authored by marbre).
[mlir][emitc] Add add and sub operations
Jun 23 2023, 5:27 AM · Restricted Project, Restricted Project
marbre closed D149963: [mlir][emitc] Add add and sub operations.
Jun 23 2023, 5:27 AM · Restricted Project, Restricted Project

May 11 2023

marbre added a comment to D150356: [mlir][emitc] Add literal constant..

Could you also add tests to test/Dialect/EmitC/ops.mlir and maybe also to test/Dialect/EmitC/invalid_ops.mlir?

May 11 2023, 5:41 AM · Restricted Project, Restricted Project

May 10 2023

marbre added inline comments to D149963: [mlir][emitc] Add add and sub operations.
May 10 2023, 6:32 AM · Restricted Project, Restricted Project

May 9 2023

marbre updated the diff for D149963: [mlir][emitc] Add add and sub operations.

Updating D149963: [mlir][emitc] Add add and sub operations

May 9 2023, 5:33 AM · Restricted Project, Restricted Project
marbre updated the diff for D149963: [mlir][emitc] Add add and sub operations.

Updating D149963: [mlir][emitc] Add add and sub operations

May 9 2023, 4:22 AM · Restricted Project, Restricted Project
marbre updated the diff for D149963: [mlir][emitc] Add add and sub operations.

Updating D149963: [mlir][emitc] Add add and sub operations

May 9 2023, 4:19 AM · Restricted Project, Restricted Project

May 8 2023

marbre updated the diff for D149963: [mlir][emitc] Add add and sub operations.

Updating D149963: [mlir][emitc] Add add and sub operations

May 8 2023, 7:00 AM · Restricted Project, Restricted Project

May 5 2023

marbre requested review of D149963: [mlir][emitc] Add add and sub operations.
May 5 2023, 8:09 AM · Restricted Project, Restricted Project

May 4 2023

marbre added a comment to D147570: Add option to emit stateful functions to the emitc backend..

I added myself and especially @simon-camp as reviewer, since I might be oof when this is ready for review.

May 4 2023, 11:40 PM · Restricted Project, Restricted Project
marbre added reviewers for D147570: Add option to emit stateful functions to the emitc backend.: marbre, simon-camp.
May 4 2023, 11:40 PM · Restricted Project, Restricted Project
marbre committed rG9b21cb27b15c: [mlir][emitc][nfc] Update ApplyOp example (authored by marbre).
[mlir][emitc][nfc] Update ApplyOp example
May 4 2023, 5:40 AM · Restricted Project, Restricted Project

Apr 27 2023

marbre committed rGeb22971bfb84: [MLIR][EmitC] Add empty emitc.constant check (authored by QuqqU).
[MLIR][EmitC] Add empty emitc.constant check
Apr 27 2023, 9:04 AM · Restricted Project, Restricted Project
marbre closed D147907: [MLIR][EmitC] Add empty emitc.constant check.
Apr 27 2023, 9:04 AM · Restricted Project, Restricted Project
marbre accepted D147907: [MLIR][EmitC] Add empty emitc.constant check.

Thanks!

Apr 27 2023, 9:03 AM · Restricted Project, Restricted Project
marbre added a comment to D147992: [MLIR][EmitC] Disallow to apply the op & to const.

Thanks for the patch! Tested locally, LGTM. Unfortunately, I have some problems with arcanist grabbing the complete patch. I will try to land it tomorrow.

I greatly appreciate for your help :>
If there is an issue(eg. metadata) on my patch, please let me know.

Apr 27 2023, 8:46 AM · Restricted Project, Restricted Project
marbre committed rG2aa1818a767d: Disallow to apply the op & to const (authored by QuqqU).
Disallow to apply the op & to const
Apr 27 2023, 8:45 AM · Restricted Project, Restricted Project
marbre closed D147992: [MLIR][EmitC] Disallow to apply the op & to const.
Apr 27 2023, 8:44 AM · Restricted Project, Restricted Project

Apr 26 2023

marbre accepted D147992: [MLIR][EmitC] Disallow to apply the op & to const.

Thanks for the patch! Tested locally, LGTM. Unfortunately, I have some problems with arcanist grabbing the complete patch. I will try to land it tomorrow.

Apr 26 2023, 10:22 AM · Restricted Project, Restricted Project
marbre added inline comments to D146483: [mlgo] Add infrastructure to use EmitC-generated models for inlining..
Apr 26 2023, 9:15 AM · Restricted Project, Restricted Project
marbre added a comment to D147992: [MLIR][EmitC] Disallow to apply the op & to const.

@marbre @simon-camp Could you mind if I ask you push it on my behalf?
I have no commit access because this is the first time.
I really appreciate!

Apr 26 2023, 8:23 AM · Restricted Project, Restricted Project

Apr 18 2023

marbre updated subscribers of D147570: Add option to emit stateful functions to the emitc backend..

Currently no reviewers are specified. Would you like @simon-camp and me to review? We initially pushed the code and mostly maintain it.

Apr 18 2023, 2:40 AM · Restricted Project, Restricted Project
marbre added a comment to D147907: [MLIR][EmitC] Add empty emitc.constant check.

I added @simon-camp and myself as reviewers, as we initial pushed the code and mostly maintain it. We will take a look early next week.

Apr 18 2023, 2:38 AM · Restricted Project, Restricted Project
marbre added reviewers for D147907: [MLIR][EmitC] Add empty emitc.constant check: marbre, simon-camp.
Apr 18 2023, 2:38 AM · Restricted Project, Restricted Project
marbre added a comment to D147992: [MLIR][EmitC] Disallow to apply the op & to const.

ping

Please take a look, and let me know if there is an issue :)

Apr 18 2023, 2:36 AM · Restricted Project, Restricted Project
marbre added reviewers for D147992: [MLIR][EmitC] Disallow to apply the op & to const: marbre, simon-camp.
Apr 18 2023, 2:35 AM · Restricted Project, Restricted Project

Mar 10 2023

marbre accepted D145351: [cmake] Export component info needed to determine which libraries are in libLLVM.so..

As far as I see this should be fine, even though I am not 100% familiar with the exact mechanism implemented here.

Mar 10 2023, 2:59 AM · Restricted Project, Restricted Project

Mar 1 2023

marbre committed rG7c081a5675ca: [mlir][standalone] Enable to build as LLVM external project (authored by marbre).
[mlir][standalone] Enable to build as LLVM external project
Mar 1 2023, 5:16 AM · Restricted Project, Restricted Project
marbre closed D143718: [mlir][standalone] Enable to build as LLVM external project.
Mar 1 2023, 5:16 AM · Restricted Project, Restricted Project

Feb 17 2023

marbre committed rG83e9ef7e519a: [mlir][standalone] Extend sample with custom type (authored by marbre).
[mlir][standalone] Extend sample with custom type
Feb 17 2023, 6:15 AM · Restricted Project, Restricted Project
marbre closed D143715: [mlir][standalone] Extend sample with custom type.
Feb 17 2023, 6:15 AM · Restricted Project, Restricted Project

Feb 10 2023

marbre added a comment to D143718: [mlir][standalone] Enable to build as LLVM external project.

This was presented as part of my talk How to Build your own MLIR Dialect at FOSDEM 2023.

Feb 10 2023, 2:49 AM · Restricted Project, Restricted Project
marbre requested review of D143718: [mlir][standalone] Enable to build as LLVM external project.
Feb 10 2023, 2:48 AM · Restricted Project, Restricted Project
marbre added a comment to D141093: [mlir][emitc][mlir-translate] Add support for function attributes in emitc.

Thanks for driving this! We actually had something similar on our long term roadmap and think something function meta attribute like would be desirable. However, for the omp dialect there it is currently discussed on discourse if to go for an omp.function instead of a dialect attribute, see https://discourse.llvm.org/t/rfc-omp-module-and-omp-function-vs-dialect-attributes-to-encode-openmp-properties/67998. I think the same discussion applies here as well. Instead of having emitc.func_attr together with func.func we might want to have emitc.func?

Feb 10 2023, 2:18 AM · Restricted Project, Restricted Project
marbre added a comment to D143715: [mlir][standalone] Extend sample with custom type.

This was presented as part of my talk How to Build your own MLIR Dialect at FOSDEM 2023.

Feb 10 2023, 2:03 AM · Restricted Project, Restricted Project
marbre requested review of D143715: [mlir][standalone] Extend sample with custom type.
Feb 10 2023, 2:01 AM · Restricted Project, Restricted Project

Jan 30 2023

marbre committed rG75488a287b9c: [mlir][nfc] Migrate standalone to new fold API (authored by marbre).
[mlir][nfc] Migrate standalone to new fold API
Jan 30 2023, 2:06 AM · Restricted Project, Restricted Project

Jan 16 2023

marbre accepted D141704: [mlir][EmitC] Remove Pure trait from `emitc.include`.

Thanks for adding me @jpienaar and thanks @christopherbate for improving the EmitC dialect! LGTM.

Jan 16 2023, 9:15 AM · Restricted Project, Restricted Project

Aug 12 2022

marbre committed rGf3547fd541ca: [mlir][emitc][nfc] Clean up tests (authored by marbre).
[mlir][emitc][nfc] Clean up tests
Aug 12 2022, 1:26 AM · Restricted Project, Restricted Project
marbre committed rG90736babcaeb: [mlir][EmitC] Remove the type from the OpaqueAttr (authored by marbre).
[mlir][EmitC] Remove the type from the OpaqueAttr
Aug 12 2022, 12:14 AM · Restricted Project, Restricted Project
marbre closed D131666: [mlir][EmitC] Remove the type from the OpaqueAttr.
Aug 12 2022, 12:14 AM · Restricted Project, Restricted Project

Aug 11 2022

marbre requested review of D131666: [mlir][EmitC] Remove the type from the OpaqueAttr.
Aug 11 2022, 3:46 AM · Restricted Project, Restricted Project
marbre committed rG91b6f76a582a: [mlir] Fix calling the native mlir-pdll-tblgen (authored by marbre).
[mlir] Fix calling the native mlir-pdll-tblgen
Aug 11 2022, 2:35 AM · Restricted Project, Restricted Project
marbre closed D131596: [mlir] Fix calling the native mlir-pdll-tblgen.
Aug 11 2022, 2:34 AM · Restricted Project, Restricted Project

Aug 10 2022

marbre requested review of D131596: [mlir] Fix calling the native mlir-pdll-tblgen.
Aug 10 2022, 10:31 AM · Restricted Project, Restricted Project

Aug 1 2022

marbre accepted D130350: [mlir] Fix calling the native mlir-tblgen tool when cross compiling flang.
Aug 1 2022, 9:44 AM · Restricted Project, Restricted Project, Restricted Project
marbre committed rGddb6c28638f9: Avoid comparison of integers of different signs (authored by marbre).
Avoid comparison of integers of different signs
Aug 1 2022, 4:21 AM · Restricted Project, Restricted Project

Jul 28 2022

marbre added a comment to D130350: [mlir] Fix calling the native mlir-tblgen tool when cross compiling flang.

I tried the patch locally to build torch-mlir https://github.com/llvm/torch-mlir/issues/1094 and it still fails cross-compile.

If you apply the to torch-mlir, you also need a corresponding change to the one in flang/CMakeLists.txt in this patch, where set(MLIR_TABLEGEN_EXE $<TARGET_FILE:mlir-tblgen>) is removed - I presume that torch-mlir has something similar.

Jul 28 2022, 6:26 AM · Restricted Project, Restricted Project, Restricted Project

May 5 2022

marbre added a comment to D125010: [MLIR] Fix build with make.

I am currently out-of-office and don‘t have any access to my build machines. Therefore, I cannot test and confirm that the patch doesn‘t have unintended side effects. However, there is definitely a need to add a dependency to the tablgen generated header files. Sorry for missing this as part of https://reviews.llvm.org/D124851. I would suggest to take a look how this is done for MLIR dialects, where explicits deps to the generated targets are passed to add_mlir_dialect_library like in https://github.com/llvm/llvm-project/blob/04b419048955fc33718ba97e79f3558b6a27830e/mlir/lib/Dialect/EmitC/IR/CMakeLists.txt#L7-L9. It might not be necessary to touch AddLLVM and I assume the deps should rather be on the *IncGen target,

May 5 2022, 8:03 AM · Restricted Project, Restricted Project, Restricted Project

May 3 2022

marbre committed rG63aaf9a6e7f9: [mlir] Add missing CMake deps to mlir-pdll (authored by marbre).
[mlir] Add missing CMake deps to mlir-pdll
May 3 2022, 11:18 PM · Restricted Project, Restricted Project
marbre closed D124851: [mlir] Add missing CMake deps to mlir-pdll.
May 3 2022, 11:18 PM · Restricted Project, Restricted Project
marbre added a comment to D124851: [mlir] Add missing CMake deps to mlir-pdll.

The missing dep on MLIRIR actually showed up as a race condition in the build process on a GH runner.

May 3 2022, 6:56 AM · Restricted Project, Restricted Project
marbre requested review of D124851: [mlir] Add missing CMake deps to mlir-pdll.
May 3 2022, 5:59 AM · Restricted Project, Restricted Project

Apr 28 2022

marbre committed rG84fe39a45b73: [mlir][emitc] Add a cast op (authored by marbre).
[mlir][emitc] Add a cast op
Apr 28 2022, 8:52 AM · Restricted Project, Restricted Project
marbre closed D123514: [mlir][emitc] Add a cast op.
Apr 28 2022, 8:51 AM · Restricted Project, Restricted Project
marbre committed rG50d648b40ecd: [mlir][emitc] Replace !emitc.opaque pointers (authored by marbre).
[mlir][emitc] Replace !emitc.opaque pointers
Apr 28 2022, 8:21 AM · Restricted Project, Restricted Project
marbre committed rG39dd29736ffa: [mlir][emitc] Disallow !emitc.opaque pointers (authored by marbre).
[mlir][emitc] Disallow !emitc.opaque pointers
Apr 28 2022, 8:10 AM · Restricted Project, Restricted Project
marbre closed D124002: [mlir][emitc] Disallow !emitc.opaque pointers.
Apr 28 2022, 8:09 AM · Restricted Project, Restricted Project

Apr 25 2022

marbre added a comment to D123514: [mlir][emitc] Add a cast op.

Thanks for the review @jpienaar! I will address your comments before landing.

Apr 25 2022, 8:22 AM · Restricted Project, Restricted Project
marbre added inline comments to D124002: [mlir][emitc] Disallow !emitc.opaque pointers.
Apr 25 2022, 8:13 AM · Restricted Project, Restricted Project
marbre updated the diff for D124002: [mlir][emitc] Disallow !emitc.opaque pointers.

Updating D124002: [mlir][emitc] Disallow !emitc.opaque pointers

Apr 25 2022, 8:11 AM · Restricted Project, Restricted Project

Apr 19 2022

marbre requested review of D124002: [mlir][emitc] Disallow !emitc.opaque pointers.
Apr 19 2022, 6:43 AM · Restricted Project, Restricted Project
marbre added inline comments to D123514: [mlir][emitc] Add a cast op.
Apr 19 2022, 6:38 AM · Restricted Project, Restricted Project
marbre committed rG2ba865903dae: [mlir][emitc] Add test for invalid type (authored by marbre).
[mlir][emitc] Add test for invalid type
Apr 19 2022, 2:05 AM · Restricted Project, Restricted Project
marbre closed D123503: [mlir][emitc] Add test for invalid type.
Apr 19 2022, 2:05 AM · Restricted Project, Restricted Project

Apr 13 2022

marbre committed rGf71f105901da: [mlir][docs] Fix broken links (authored by marbre).
[mlir][docs] Fix broken links
Apr 13 2022, 7:19 AM · Restricted Project, Restricted Project

Apr 12 2022

marbre added inline comments to D123503: [mlir][emitc] Add test for invalid type.
Apr 12 2022, 1:26 AM · Restricted Project, Restricted Project

Apr 11 2022

marbre requested review of D123514: [mlir][emitc] Add a cast op.
Apr 11 2022, 7:30 AM · Restricted Project, Restricted Project
marbre requested review of D123503: [mlir][emitc] Add test for invalid type.
Apr 11 2022, 6:14 AM · Restricted Project, Restricted Project
marbre committed rG4f185fccc722: [mlir][emitc][nfc] Replace !emitc.opaque pointers (authored by marbre).
[mlir][emitc][nfc] Replace !emitc.opaque pointers
Apr 11 2022, 4:59 AM · Restricted Project, Restricted Project

Mar 28 2022

marbre committed rGc5c9d6e0d5ab: [mlir][emitc] Adapt to move of FuncOp (authored by marbre).
[mlir][emitc] Adapt to move of FuncOp
Mar 28 2022, 8:45 AM · Restricted Project, Restricted Project
marbre closed D122305: [mlir][emitc] Adapt to move of FuncOp.
Mar 28 2022, 8:45 AM · Restricted Project, Restricted Project

Mar 23 2022

marbre abandoned D106541: [mlir] Enable generation of type constraint docs.
Mar 23 2022, 4:52 AM · Restricted Project, Restricted Project
marbre requested review of D122305: [mlir][emitc] Adapt to move of FuncOp.
Mar 23 2022, 4:51 AM · Restricted Project, Restricted Project

Mar 14 2022

marbre added inline comments to D120788: [cmake] Add INTERFACE_INCLUDE_DIRECTORIES to LLVM and MLIR..
Mar 14 2022, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
marbre added inline comments to D120788: [cmake] Add INTERFACE_INCLUDE_DIRECTORIES to LLVM and MLIR..
Mar 14 2022, 9:49 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2022

marbre accepted D120788: [cmake] Add INTERFACE_INCLUDE_DIRECTORIES to LLVM and MLIR..

Please excuse if my previous reply was confusing. I checked more carefully and think these changes are good to go.

Mar 11 2022, 7:50 AM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

marbre added a comment to D120788: [cmake] Add INTERFACE_INCLUDE_DIRECTORIES to LLVM and MLIR..

Thanks for working on this Stella! Untangling the functions/marcos is a bit hard. Thus, I am mainly commenting to make sure I fully understand the patch :)

Mar 2 2022, 8:22 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2022

marbre added inline comments to D120098: [mlir][emitc] Add a variable op.
Feb 24 2022, 7:32 AM · Restricted Project
marbre committed rG1fa125111607: [mlir][emitc] Add a variable op (authored by marbre).
[mlir][emitc] Add a variable op
Feb 24 2022, 7:28 AM
marbre closed D120098: [mlir][emitc] Add a variable op.
Feb 24 2022, 7:28 AM · Restricted Project

Feb 23 2022

marbre added a comment to D120098: [mlir][emitc] Add a variable op.

As an example, the canonicalization pass would transform

func @myfunc() {
  %0 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %1 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %2 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  %3 = emitc.apply "&"(%1) : (i32) -> !emitc.ptr<i32>
  emitc.call "write"(%2, %3) : (!emitc.ptr<i32>, !emitc.ptr<i32>) -> ()
  return
}

into

func @myfunc() {
  %0 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %1 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  %2 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  emitc.call "write"(%1, %2) : (!emitc.ptr<i32>, !emitc.ptr<i32>) -> ()
  return
}

resulting in pointer aliasing. Here, the variable op would be helpful.

Could you elevate this to be part of the commit description and expand on the pains? (I think you'd want to expand in the op descriptions too what variety to use and why).

Feb 23 2022, 6:55 AM · Restricted Project
marbre updated the diff for D120098: [mlir][emitc] Add a variable op.

Address review comments

Feb 23 2022, 6:52 AM · Restricted Project
marbre updated the summary of D120098: [mlir][emitc] Add a variable op.
Feb 23 2022, 6:47 AM · Restricted Project

Feb 17 2022

marbre added a comment to D120098: [mlir][emitc] Add a variable op.

As an example, the canonicalization pass would transform

func @myfunc() {
  %0 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %1 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %2 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  %3 = emitc.apply "&"(%1) : (i32) -> !emitc.ptr<i32>
  emitc.call "write"(%2, %3) : (!emitc.ptr<i32>, !emitc.ptr<i32>) -> ()
  return
}

into

func @myfunc() {
  %0 = "emitc.constant"() {value = 0 : i32} : () -> i32
  %1 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  %2 = emitc.apply "&"(%0) : (i32) -> !emitc.ptr<i32>
  emitc.call "write"(%1, %2) : (!emitc.ptr<i32>, !emitc.ptr<i32>) -> ()
  return
}

resulting in pointer aliasing. Here, the variable op would be helpful.

Feb 17 2022, 4:08 PM · Restricted Project
marbre requested review of D120098: [mlir][emitc] Add a variable op.
Feb 17 2022, 4:05 PM · Restricted Project