Page MenuHomePhabricator

marbre (Marius Brehler)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2020, 1:53 AM (74 w, 6 d)

Recent Activity

Yesterday

marbre committed rG876de062f946: [mlir] Add EmitC dialect (authored by marbre).
[mlir] Add EmitC dialect
Sat, Jun 19, 12:53 AM
marbre closed D103969: [mlir] Add EmitC dialect.
Sat, Jun 19, 12:53 AM · Restricted Project

Fri, Jun 18

marbre updated the diff for D103969: [mlir] Add EmitC dialect.

Address review comments before landing

Fri, Jun 18, 6:29 AM · Restricted Project
marbre added inline comments to D103969: [mlir] Add EmitC dialect.
Fri, Jun 18, 6:28 AM · Restricted Project
marbre added a comment to D103969: [mlir] Add EmitC dialect.

Thanks a lot for the work! This looks fine to land and build on.

Fri, Jun 18, 6:22 AM · Restricted Project

Tue, Jun 15

marbre updated the diff for D103969: [mlir] Add EmitC dialect.

Address review comments

Tue, Jun 15, 7:58 AM · Restricted Project
marbre added inline comments to D103969: [mlir] Add EmitC dialect.
Tue, Jun 15, 7:54 AM · Restricted Project

Mon, Jun 14

marbre added inline comments to D103969: [mlir] Add EmitC dialect.
Mon, Jun 14, 8:16 AM · Restricted Project
marbre added a comment to D103969: [mlir] Add EmitC dialect.

Thanks for the review @rriddle. I hope this addresses most suggestions.

Mon, Jun 14, 7:57 AM · Restricted Project
marbre updated the diff for D103969: [mlir] Add EmitC dialect.

Address review comments

Mon, Jun 14, 7:33 AM · Restricted Project

Fri, Jun 11

marbre committed rGf60d23c7381c: [mlir][docs] Reorder PassWrapper arguments (authored by marbre).
[mlir][docs] Reorder PassWrapper arguments
Fri, Jun 11, 12:50 PM
marbre closed D104132: [mlir][docs] Reorder PassWrapper arguments.
Fri, Jun 11, 12:50 PM · Restricted Project
marbre requested review of D104132: [mlir][docs] Reorder PassWrapper arguments.
Fri, Jun 11, 10:29 AM · Restricted Project

Wed, Jun 9

marbre requested review of D103969: [mlir] Add EmitC dialect.
Wed, Jun 9, 8:52 AM · Restricted Project

Tue, May 25

marbre added a comment to D103017: [3/4][mlir][doc] Fix links and references in documentation of Tutorials.

LGTM! Just a NIT regarding [TensorType].

Tue, May 25, 1:54 AM · Restricted Project

Fri, May 21

marbre committed rGb3127c94dddf: [mlir][docs] Fix links to index and integer types (authored by marbre).
[mlir][docs] Fix links to index and integer types
Fri, May 21, 9:22 AM
marbre closed D102922: [mlir][docs] Fix links to index and integer types.
Fri, May 21, 9:22 AM · Restricted Project

May 21 2021

marbre requested review of D102922: [mlir][docs] Fix links to index and integer types.
May 21 2021, 8:29 AM · Restricted Project

May 19 2021

marbre committed rGf878e1af9faa: [mlir] Harmonize TOSA include guards (authored by marbre).
[mlir] Harmonize TOSA include guards
May 19 2021, 1:45 PM
marbre closed D102802: [mlir] Harmonize TOSA include guards.
May 19 2021, 1:45 PM · Restricted Project
marbre requested review of D102802: [mlir] Harmonize TOSA include guards.
May 19 2021, 1:22 PM · Restricted Project
marbre committed rG745ddd27eaef: [mlir] Add include guard to TOSA tblgen passes (authored by marbre).
[mlir] Add include guard to TOSA tblgen passes
May 19 2021, 1:03 PM
marbre closed D102800: [mlir] Add include guard to TOSA tblgen passes.
May 19 2021, 1:03 PM · Restricted Project
marbre requested review of D102800: [mlir] Add include guard to TOSA tblgen passes.
May 19 2021, 12:46 PM · Restricted Project

May 18 2021

marbre committed rGdfd929d26174: [mlir][docs] Fix broken link to Toy example (authored by marbre).
[mlir][docs] Fix broken link to Toy example
May 18 2021, 12:47 AM

Apr 23 2021

marbre committed rGab78e09b9463: [mlir][docs] Update `add_mlir_doc` usage (authored by marbre).
[mlir][docs] Update `add_mlir_doc` usage
Apr 23 2021, 1:50 AM

Mar 11 2021

marbre committed rG849f8183fb99: [mlir] Fix ConstantOp verifier (authored by marbre).
[mlir] Fix ConstantOp verifier
Mar 11 2021, 11:50 PM
marbre closed D98216: [mlir] Fix ConstantOp verifier.
Mar 11 2021, 11:50 PM · Restricted Project
marbre updated the summary of D98216: [mlir] Fix ConstantOp verifier.
Mar 11 2021, 12:32 PM · Restricted Project
marbre added a comment to D98216: [mlir] Fix ConstantOp verifier.

All done.Address River's comment

Mar 11 2021, 12:31 PM · Restricted Project
marbre updated the diff for D98216: [mlir] Fix ConstantOp verifier.

Address River's comment

Mar 11 2021, 12:30 PM · Restricted Project
marbre added inline comments to D98216: [mlir] Fix ConstantOp verifier.
Mar 11 2021, 11:26 AM · Restricted Project
marbre added a comment to D98216: [mlir] Fix ConstantOp verifier.

Can you add a test?

Mar 11 2021, 11:18 AM · Restricted Project
marbre updated the diff for D98216: [mlir] Fix ConstantOp verifier.

Add test

Mar 11 2021, 11:17 AM · Restricted Project

Mar 9 2021

marbre updated the summary of D98216: [mlir] Fix ConstantOp verifier.
Mar 9 2021, 4:35 AM · Restricted Project
marbre updated the diff for D98216: [mlir] Fix ConstantOp verifier.

Updating D98216: [mlir] Fix ConstantOp verifier

Mar 9 2021, 4:34 AM · Restricted Project
marbre updated the diff for D98216: [mlir] Fix ConstantOp verifier.

Updating D98216: [mlir] Fix ConstantOp verifier

Mar 9 2021, 4:30 AM · Restricted Project
marbre updated the diff for D98216: [mlir] Fix ConstantOp verifier.

Updating D98216: [mlir] Fix ConstantOp verifier

Mar 9 2021, 3:53 AM · Restricted Project

Mar 8 2021

marbre added a reviewer for D98216: [mlir] Fix ConstantOp verifier: jpienaar.
Mar 8 2021, 2:05 PM · Restricted Project
marbre requested review of D98216: [mlir] Fix ConstantOp verifier.
Mar 8 2021, 1:35 PM · Restricted Project

Feb 26 2021

marbre added a comment to D97546: [mlir] Replace deprecated 'getAttrs'.

Thanks a lot Marius. You don't need to make these changes by hand though -- I have a clang tool.

Feb 26 2021, 5:55 AM · Restricted Project
marbre committed rG56774bdda578: [mlir] Replace deprecated 'getAttrs' (authored by marbre).
[mlir] Replace deprecated 'getAttrs'
Feb 26 2021, 5:54 AM
marbre closed D97546: [mlir] Replace deprecated 'getAttrs'.
Feb 26 2021, 5:53 AM · Restricted Project
marbre requested review of D97546: [mlir] Replace deprecated 'getAttrs'.
Feb 26 2021, 5:38 AM · Restricted Project

Feb 24 2021

marbre committed rG2d870a2f557b: [mlir][nfc] Fix typo in documentation comment (authored by marbre).
[mlir][nfc] Fix typo in documentation comment
Feb 24 2021, 11:35 PM
marbre committed rG699041123eba: [mlir] Fix emitting attribute documentation (authored by marbre).
[mlir] Fix emitting attribute documentation
Feb 24 2021, 11:24 PM
marbre closed D97267: Fix emitting attribute documentation.
Feb 24 2021, 11:24 PM · Restricted Project

Feb 23 2021

marbre added a comment to D97267: Fix emitting attribute documentation.

Can you show an example of before/after?

Feb 23 2021, 2:42 AM · Restricted Project
marbre requested review of D97267: Fix emitting attribute documentation.
Feb 23 2021, 2:36 AM · Restricted Project

Nov 25 2020

marbre closed D91823: [mlir] Add build configuration for Quant unittest.

Missed to update the commit message prior to committing. Closed by commit rGc5d017267dea.

Nov 25 2020, 2:00 PM · Restricted Project
marbre added a reviewer for D91823: [mlir] Add build configuration for Quant unittest: stellaraccident.
Nov 25 2020, 12:26 AM · Restricted Project

Nov 19 2020

marbre requested review of D91823: [mlir] Add build configuration for Quant unittest.
Nov 19 2020, 2:28 PM · Restricted Project

Nov 10 2020

marbre committed rG07f1047f41d6: [mlir] Refactor finding python (authored by marbre).
[mlir] Refactor finding python
Nov 10 2020, 12:22 PM
marbre closed D91197: [mlir] Refactor finding python.
Nov 10 2020, 12:22 PM · Restricted Project
marbre added a comment to D91197: [mlir] Refactor finding python.

LLVM already relies on find_package(Python3). Prior to the patch different Python versions are found on a system with multiple versions installed (here 3.9 and 3.7):

Nov 10 2020, 11:51 AM · Restricted Project
marbre requested review of D91197: [mlir] Refactor finding python.
Nov 10 2020, 11:47 AM · Restricted Project

Sep 11 2020

marbre committed rGa68673cc067a: [mlir] Fix generation of AVX512 dialect documentation (authored by marbre).
[mlir] Fix generation of AVX512 dialect documentation
Sep 11 2020, 1:10 AM
marbre closed D87460: [mlir] Fix generation of AVX512 dialect documentation.
Sep 11 2020, 1:10 AM · Restricted Project

Sep 10 2020

marbre requested review of D87460: [mlir] Fix generation of AVX512 dialect documentation.
Sep 10 2020, 8:38 AM · Restricted Project

Sep 4 2020

marbre committed rG4f7cdc10a83c: [mlir] Refactor standalone-translate to use mlirTranslateMain() (authored by marbre).
[mlir] Refactor standalone-translate to use mlirTranslateMain()
Sep 4 2020, 6:28 AM
marbre closed D87131: [mlir] Refactor standalone-translate to use mlirTranslateMain().
Sep 4 2020, 6:27 AM · Restricted Project
marbre committed rGc633842f1341: [mlir] Fix includes in mlir-translate (authored by marbre).
[mlir] Fix includes in mlir-translate
Sep 4 2020, 6:23 AM
marbre closed D87129: [mlir] Fix includes in mlir-translate.
Sep 4 2020, 6:23 AM · Restricted Project
marbre retitled D87131: [mlir] Refactor standalone-translate to use mlirTranslateMain() from [mlir] Refactor standalone-opt to use mlirTranslateMain() to [mlir] Refactor standalone-translate to use mlirTranslateMain().
Sep 4 2020, 2:28 AM · Restricted Project
marbre retitled D87131: [mlir] Refactor standalone-translate to use mlirTranslateMain() from [mlir] Refactor standalone-opt to use main() of helper to [mlir] Refactor standalone-opt to use mlirTranslateMain().
Sep 4 2020, 2:01 AM · Restricted Project
marbre updated the diff for D87131: [mlir] Refactor standalone-translate to use mlirTranslateMain().

[mlir] Refactor standalone-opt to use main() of helper

Sep 4 2020, 1:59 AM · Restricted Project
marbre requested review of D87131: [mlir] Refactor standalone-translate to use mlirTranslateMain().
Sep 4 2020, 1:57 AM · Restricted Project
marbre requested review of D87129: [mlir] Fix includes in mlir-translate.
Sep 4 2020, 1:41 AM · Restricted Project

Aug 18 2020

marbre committed rG45901ebd4305: [mlir] Check libraries linked into standalone-opt (authored by marbre).
[mlir] Check libraries linked into standalone-opt
Aug 18 2020, 1:20 PM

Aug 14 2020

marbre committed rG36f524f454a8: Test commit (authored by marbre).
Test commit
Aug 14 2020, 12:33 PM

Aug 13 2020

marbre requested review of D85957: [mlir] Make mlir_check_link_libraries() work with interface libraries.
Aug 13 2020, 11:28 PM · Restricted Project

Jun 30 2020

marbre added a comment to D82843: [mlir] Fix case in MLIRGPUtoROCDLTransforms.

Thanks for the review! I would appreciate if you could commit on my behalf.

Jun 30 2020, 2:08 AM · Restricted Project
marbre added a comment to D82841: [mlir] Fix case in MLIRGPUtoGPURuntimeTransforms.

Thanks for the review! I would appreciate if you could commit on my behalf.

Jun 30 2020, 2:08 AM · Restricted Project
marbre added a comment to D82842: [mlir] Fix case in MLIRGPUtoNVVMTransforms.

Thanks for the review! I would appreciate if you could commit on my behalf.

Jun 30 2020, 2:08 AM · Restricted Project
marbre added a comment to D82840: [mlir] Fix case in MLIRGPUtoVulkanTransforms.

Thanks for the review. I would appreciate if you could commit on my behalf.

Jun 30 2020, 1:02 AM · Restricted Project
marbre added a reviewer for D82840: [mlir] Fix case in MLIRGPUtoVulkanTransforms: ThomasRaoux.
Jun 30 2020, 12:30 AM · Restricted Project

Jun 29 2020

marbre created D82843: [mlir] Fix case in MLIRGPUtoROCDLTransforms.
Jun 29 2020, 11:57 PM · Restricted Project
marbre created D82842: [mlir] Fix case in MLIRGPUtoNVVMTransforms.
Jun 29 2020, 11:57 PM · Restricted Project
marbre created D82840: [mlir] Fix case in MLIRGPUtoVulkanTransforms.
Jun 29 2020, 11:57 PM · Restricted Project
marbre created D82841: [mlir] Fix case in MLIRGPUtoGPURuntimeTransforms.
Jun 29 2020, 11:57 PM · Restricted Project
marbre retitled D82840: [mlir] Fix case in MLIRGPUtoVulkanTransforms from Fix case in MLIRGPUtoVulkanTransforms to [mlir] Fix case in MLIRGPUtoVulkanTransforms.
Jun 29 2020, 11:57 PM · Restricted Project

May 28 2020

marbre created D80764: [mlir] Add test to check if standalone dialect is registered.
May 28 2020, 3:25 PM · Restricted Project
marbre updated the diff for D80737: [mlir] Extend standalone example by standalone-translate.

Add standalone-translate test, rename test from check-standalone-opt to check-standalone

May 28 2020, 12:38 PM · Restricted Project
marbre updated the diff for D80737: [mlir] Extend standalone example by standalone-translate.

Replace add_llvm_tool by add_llvm_executable

May 28 2020, 10:56 AM · Restricted Project
marbre added a comment to D80737: [mlir] Extend standalone example by standalone-translate.

Needs a test?

May 28 2020, 10:27 AM · Restricted Project
marbre created D80737: [mlir] Extend standalone example by standalone-translate.
May 28 2020, 9:50 AM · Restricted Project

May 14 2020

marbre added a comment to D79946: [mlir] Adopt changes in mlir-opt to standalone example.

Thanks for the fast review. I would appreciate if somebody could commit on my behalf.

May 14 2020, 9:10 AM · Restricted Project
marbre added a reviewer for D79946: [mlir] Adopt changes in mlir-opt to standalone example: Kayjukh.
May 14 2020, 9:10 AM · Restricted Project
marbre added a reviewer for D79946: [mlir] Adopt changes in mlir-opt to standalone example: antiagainst.
May 14 2020, 8:38 AM · Restricted Project
marbre created D79946: [mlir] Adopt changes in mlir-opt to standalone example.
May 14 2020, 8:38 AM · Restricted Project

Apr 3 2020

marbre accepted D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 1:33 PM · Restricted Project
marbre added inline comments to D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 6:56 AM · Restricted Project
marbre added inline comments to D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 3:43 AM · Restricted Project

Mar 29 2020

marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

This was committed, but I did fix up the link back to the review so it wasn't automatically closed. @marbre clearly I need to get better at this :)

Mar 29 2020, 12:50 PM · Restricted Project
marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.

That's strange, I am quite sure I followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Without arc, many things aren't working as smoothly (like the CI), it would be much better if you could use it.

Mar 29 2020, 12:50 PM · Restricted Project

Mar 26 2020

marbre added a comment to D74867: [MLIR] add out of tree version of mlir-opt.

No, this is just a little old. Currently, calling registerAllDialects() and registerAllPasses() is required if you want any of the standard stuff. The .cpp code was just a copy of what's in tools/mlir-opt. The critical part of this is the CMakeLists.txt, which was intended as a test for linking against libMLIR.so. If you actually want to build an external project see: https://reviews.llvm.org/D76047

Mar 26 2020, 11:22 AM · Restricted Project
marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.

Mar 26 2020, 10:50 AM · Restricted Project
marbre added a comment to D74867: [MLIR] add out of tree version of mlir-opt.
Mar 26 2020, 8:06 AM · Restricted Project
marbre added a comment to D74867: [MLIR] add out of tree version of mlir-opt.

Out of curiosity, no need to call define and registerTestPasses()? Further, calling registerAllDialects() and registerAllPasses() can be skipped? Is that due linking against libMLIR.so?

Mar 26 2020, 8:06 AM · Restricted Project
marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

Gentle ping. I would be happy if someone could commit the patch on my behalf.

Mar 26 2020, 7:33 AM · Restricted Project