Address review comments before landing

In D103969#2824035, @rriddle wrote:

Thanks a lot for the work! This looks fine to land and build on.

Address review comments

Thanks for the review @rriddle. I hope this addresses most suggestions.

Address review comments

LGTM! Just a NIT regarding [TensorType].

All done.Address River's comment

Address River's comment

In D98216#2617349, @mehdi_amini wrote:

Can you add a test?

Add test

Updating D98216: [mlir] Fix ConstantOp verifier

Updating D98216: [mlir] Fix ConstantOp verifier

Updating D98216: [mlir] Fix ConstantOp verifier

In D97546#2590083, @csigg wrote:

Thanks a lot Marius. You don't need to make these changes by hand though -- I have a clang tool.

In D97267#2581276, @rriddle wrote:

Can you show an example of before/after?

Missed to update the commit message prior to committing. Closed by commit rGc5d017267dea.

LLVM already relies on find_package(Python3). Prior to the patch different Python versions are found on a system with multiple versions installed (here 3.9 and 3.7):

[mlir] Refactor standalone-opt to use main() of helper

Thanks for the review! I would appreciate if you could commit on my behalf.

Thanks for the review! I would appreciate if you could commit on my behalf.

Thanks for the review! I would appreciate if you could commit on my behalf.

Thanks for the review. I would appreciate if you could commit on my behalf.

Add standalone-translate test, rename test from check-standalone-opt to check-standalone

Replace add_llvm_tool by add_llvm_executable

In D80737#2060574, @stephenneuendorffer wrote:

Needs a test?

Thanks for the fast review. I would appreciate if somebody could commit on my behalf.

In D76436#1944559, @stephenneuendorffer wrote:

This was committed, but I did fix up the link back to the review so it wasn't automatically closed. @marbre clearly I need to get better at this :)

In D76436#1946853, @mehdi_amini wrote:

In D76436#1944337, @marbre wrote:

In D76436#1944181, @stephenneuendorffer wrote:

@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.

That's strange, I am quite sure I followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Without arc, many things aren't working as smoothly (like the CI), it would be much better if you could use it.

In D74867#1944069, @stephenneuendorffer wrote:

No, this is just a little old. Currently, calling registerAllDialects() and registerAllPasses() is required if you want any of the standard stuff. The .cpp code was just a copy of what's in tools/mlir-opt. The critical part of this is the CMakeLists.txt, which was intended as a test for linking against libMLIR.so. If you actually want to build an external project see: https://reviews.llvm.org/D76047

In D76436#1944181, @stephenneuendorffer wrote:

@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.

Out of curiosity, no need to call define and registerTestPasses()? Further, calling registerAllDialects() and registerAllPasses() can be skipped? Is that due linking against libMLIR.so?

Gentle ping. I would be happy if someone could commit the patch on my behalf.