Page MenuHomePhabricator

marbre (Marius Brehler)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2020, 1:53 AM (36 w, 2 d)

Recent Activity

Fri, Sep 11

marbre committed rGa68673cc067a: [mlir] Fix generation of AVX512 dialect documentation (authored by marbre).
[mlir] Fix generation of AVX512 dialect documentation
Fri, Sep 11, 1:10 AM
marbre closed D87460: [mlir] Fix generation of AVX512 dialect documentation.
Fri, Sep 11, 1:10 AM · Restricted Project

Thu, Sep 10

marbre requested review of D87460: [mlir] Fix generation of AVX512 dialect documentation.
Thu, Sep 10, 8:38 AM · Restricted Project

Fri, Sep 4

marbre committed rG4f7cdc10a83c: [mlir] Refactor standalone-translate to use mlirTranslateMain() (authored by marbre).
[mlir] Refactor standalone-translate to use mlirTranslateMain()
Fri, Sep 4, 6:28 AM
marbre closed D87131: [mlir] Refactor standalone-translate to use mlirTranslateMain().
Fri, Sep 4, 6:27 AM · Restricted Project
marbre committed rGc633842f1341: [mlir] Fix includes in mlir-translate (authored by marbre).
[mlir] Fix includes in mlir-translate
Fri, Sep 4, 6:23 AM
marbre closed D87129: [mlir] Fix includes in mlir-translate.
Fri, Sep 4, 6:23 AM · Restricted Project
marbre retitled D87131: [mlir] Refactor standalone-translate to use mlirTranslateMain() from [mlir] Refactor standalone-opt to use mlirTranslateMain() to [mlir] Refactor standalone-translate to use mlirTranslateMain().
Fri, Sep 4, 2:28 AM · Restricted Project
marbre retitled D87131: [mlir] Refactor standalone-translate to use mlirTranslateMain() from [mlir] Refactor standalone-opt to use main() of helper to [mlir] Refactor standalone-opt to use mlirTranslateMain().
Fri, Sep 4, 2:01 AM · Restricted Project
marbre updated the diff for D87131: [mlir] Refactor standalone-translate to use mlirTranslateMain().

[mlir] Refactor standalone-opt to use main() of helper

Fri, Sep 4, 1:59 AM · Restricted Project
marbre requested review of D87131: [mlir] Refactor standalone-translate to use mlirTranslateMain().
Fri, Sep 4, 1:57 AM · Restricted Project
marbre requested review of D87129: [mlir] Fix includes in mlir-translate.
Fri, Sep 4, 1:41 AM · Restricted Project

Aug 18 2020

marbre committed rG45901ebd4305: [mlir] Check libraries linked into standalone-opt (authored by marbre).
[mlir] Check libraries linked into standalone-opt
Aug 18 2020, 1:20 PM

Aug 14 2020

marbre committed rG36f524f454a8: Test commit (authored by marbre).
Test commit
Aug 14 2020, 12:33 PM

Aug 13 2020

marbre requested review of D85957: [mlir] Make mlir_check_link_libraries() work with interface libraries.
Aug 13 2020, 11:28 PM · Restricted Project

Jun 30 2020

marbre added a comment to D82843: [mlir] Fix case in MLIRGPUtoROCDLTransforms.

Thanks for the review! I would appreciate if you could commit on my behalf.

Jun 30 2020, 2:08 AM · Restricted Project
marbre added a comment to D82841: [mlir] Fix case in MLIRGPUtoGPURuntimeTransforms.

Thanks for the review! I would appreciate if you could commit on my behalf.

Jun 30 2020, 2:08 AM · Restricted Project
marbre added a comment to D82842: [mlir] Fix case in MLIRGPUtoNVVMTransforms.

Thanks for the review! I would appreciate if you could commit on my behalf.

Jun 30 2020, 2:08 AM · Restricted Project
marbre added a comment to D82840: [mlir] Fix case in MLIRGPUtoVulkanTransforms.

Thanks for the review. I would appreciate if you could commit on my behalf.

Jun 30 2020, 1:02 AM · Restricted Project
marbre added a reviewer for D82840: [mlir] Fix case in MLIRGPUtoVulkanTransforms: ThomasRaoux.
Jun 30 2020, 12:30 AM · Restricted Project

Jun 29 2020

marbre created D82843: [mlir] Fix case in MLIRGPUtoROCDLTransforms.
Jun 29 2020, 11:57 PM · Restricted Project
marbre created D82842: [mlir] Fix case in MLIRGPUtoNVVMTransforms.
Jun 29 2020, 11:57 PM · Restricted Project
marbre created D82840: [mlir] Fix case in MLIRGPUtoVulkanTransforms.
Jun 29 2020, 11:57 PM · Restricted Project
marbre created D82841: [mlir] Fix case in MLIRGPUtoGPURuntimeTransforms.
Jun 29 2020, 11:57 PM · Restricted Project
marbre retitled D82840: [mlir] Fix case in MLIRGPUtoVulkanTransforms from Fix case in MLIRGPUtoVulkanTransforms to [mlir] Fix case in MLIRGPUtoVulkanTransforms.
Jun 29 2020, 11:57 PM · Restricted Project

May 28 2020

marbre created D80764: [mlir] Add test to check if standalone dialect is registered.
May 28 2020, 3:25 PM · Restricted Project
marbre updated the diff for D80737: [mlir] Extend standalone example by standalone-translate.

Add standalone-translate test, rename test from check-standalone-opt to check-standalone

May 28 2020, 12:38 PM · Restricted Project
marbre updated the diff for D80737: [mlir] Extend standalone example by standalone-translate.

Replace add_llvm_tool by add_llvm_executable

May 28 2020, 10:56 AM · Restricted Project
marbre added a comment to D80737: [mlir] Extend standalone example by standalone-translate.

Needs a test?

May 28 2020, 10:27 AM · Restricted Project
marbre created D80737: [mlir] Extend standalone example by standalone-translate.
May 28 2020, 9:50 AM · Restricted Project

May 14 2020

marbre added a comment to D79946: [mlir] Adopt changes in mlir-opt to standalone example.

Thanks for the fast review. I would appreciate if somebody could commit on my behalf.

May 14 2020, 9:10 AM · Restricted Project
marbre added a reviewer for D79946: [mlir] Adopt changes in mlir-opt to standalone example: Kayjukh.
May 14 2020, 9:10 AM · Restricted Project
marbre added a reviewer for D79946: [mlir] Adopt changes in mlir-opt to standalone example: antiagainst.
May 14 2020, 8:38 AM · Restricted Project
marbre created D79946: [mlir] Adopt changes in mlir-opt to standalone example.
May 14 2020, 8:38 AM · Restricted Project

Apr 3 2020

marbre accepted D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 1:33 PM · Restricted Project
marbre added inline comments to D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 6:56 AM · Restricted Project
marbre added inline comments to D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 3:43 AM · Restricted Project

Mar 29 2020

marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

This was committed, but I did fix up the link back to the review so it wasn't automatically closed. @marbre clearly I need to get better at this :)

Mar 29 2020, 12:50 PM · Restricted Project
marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.

That's strange, I am quite sure I followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Without arc, many things aren't working as smoothly (like the CI), it would be much better if you could use it.

Mar 29 2020, 12:50 PM · Restricted Project

Mar 26 2020

marbre added a comment to D74867: [MLIR] add out of tree version of mlir-opt.

No, this is just a little old. Currently, calling registerAllDialects() and registerAllPasses() is required if you want any of the standard stuff. The .cpp code was just a copy of what's in tools/mlir-opt. The critical part of this is the CMakeLists.txt, which was intended as a test for linking against libMLIR.so. If you actually want to build an external project see: https://reviews.llvm.org/D76047

Mar 26 2020, 11:22 AM · Restricted Project
marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.

Mar 26 2020, 10:50 AM · Restricted Project
marbre added a comment to D74867: [MLIR] add out of tree version of mlir-opt.
Mar 26 2020, 8:06 AM · Restricted Project
marbre added a comment to D74867: [MLIR] add out of tree version of mlir-opt.

Out of curiosity, no need to call define and registerTestPasses()? Further, calling registerAllDialects() and registerAllPasses() can be skipped? Is that due linking against libMLIR.so?

Mar 26 2020, 8:06 AM · Restricted Project
marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

Gentle ping. I would be happy if someone could commit the patch on my behalf.

Mar 26 2020, 7:33 AM · Restricted Project

Mar 19 2020

marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

@rriddle I would appreciate if you or someone else could commit on my behalf.

Mar 19 2020, 4:27 PM · Restricted Project
marbre added reviewers for D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant: rsuderman, rriddle.
Mar 19 2020, 10:52 AM · Restricted Project
marbre created D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.
Mar 19 2020, 10:52 AM · Restricted Project
marbre updated the summary of D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.
Mar 19 2020, 10:52 AM · Restricted Project

Mar 17 2020

marbre accepted D76047: [MLIR] Add support for out of tree external projects using MLIR.
Mar 17 2020, 2:02 PM · Restricted Project
marbre added inline comments to D76047: [MLIR] Add support for out of tree external projects using MLIR.
Mar 17 2020, 2:02 PM · Restricted Project

Feb 12 2020

marbre added a comment to D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.

Thanks!

Feb 12 2020, 2:06 AM · Restricted Project
marbre added a comment to D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.

Gentle ping. I would be happy if someone could commit the patch on my behalf.

Feb 12 2020, 12:06 AM · Restricted Project

Feb 6 2020

marbre updated the diff for D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.

Rebased onto 6bfc45cf6. The patch should apply now.

Feb 6 2020, 12:21 AM · Restricted Project

Feb 4 2020

marbre added a comment to D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.

Thanks for the review. I would appreciate if someone could commit the patch on my behalf.

Feb 4 2020, 11:46 PM · Restricted Project
marbre updated the diff for D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.

I went for the second option to get close to TensorFlow's Bazel configuration.

Feb 4 2020, 8:13 AM · Restricted Project

Feb 3 2020

marbre added a comment to D73770: [mlir] Fix link to 'Getting started with MLIR'.

Thanks for the fast review. I would appreciate if someone could commit this on my behalf.

Feb 3 2020, 3:04 AM · Restricted Project

Feb 1 2020

marbre planned changes to D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.
Feb 1 2020, 4:33 AM · Restricted Project

Jan 31 2020

marbre created D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.
Jan 31 2020, 5:11 AM · Restricted Project
marbre created D73770: [mlir] Fix link to 'Getting started with MLIR'.
Jan 31 2020, 1:56 AM · Restricted Project