Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/include/llvm/CodeGen/SelectionDAG.h | ||
---|---|---|
455 | As we don't prefer to use static_cast, then why not delete original getSubtarget. Or it can't replace all places with template one? |
llvm/include/llvm/CodeGen/SelectionDAG.h | ||
---|---|---|
455 | Somewhere may just need the abstract sub-target, so we need to keep the original getSubtarget. The MF->getSubtarget<> did the static_cast in fact, so we don't want static_cast the abstract sub-target into himself. |
Comment Actions
I can help you with that. Please make sure the patch here has been rebased to tip-of-tree and please provide the name and email you would like to use in the commit.
As we don't prefer to use static_cast, then why not delete original getSubtarget. Or it can't replace all places with template one?