This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Use check-prefixes to reduce check lines
ClosedPublic

Authored by sunshaoce on May 6 2022, 1:41 AM.

Diff Detail

Event Timeline

sunshaoce created this revision.May 6 2022, 1:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2022, 1:41 AM
sunshaoce requested review of this revision.May 6 2022, 1:41 AM
frasercrmck added inline comments.May 6 2022, 4:58 AM
llvm/test/CodeGen/RISCV/float-arith.ll
3

RV32IF is unused and that's an error. You should see this when running locally?

llvm/test/CodeGen/RISCV/float-fcmp-strict.ll
4

RV32IF is unused

llvm/test/CodeGen/RISCV/float-fcmp.ll
3

RV32IF unused

sunshaoce updated this revision to Diff 427626.May 6 2022, 6:58 AM
sunshaoce marked 3 inline comments as done.

Address @frasercrmck's comments. Thanks!

sunshaoce updated this revision to Diff 427940.May 8 2022, 8:26 AM

Add more tests

frasercrmck added inline comments.May 10 2022, 2:20 AM
llvm/test/CodeGen/RISCV/float-isnan.ll
3

--check-prefixes=CHECK is redundant

8

These dead check prefixes can be removed

llvm/test/CodeGen/RISCV/float-select-fcmp.ll
3

Why's this CHECKIF and not CHECK?

8

Dead check prefixes here.

sunshaoce updated this revision to Diff 430237.May 17 2022, 9:39 PM
sunshaoce marked 4 inline comments as done.

Address @frasercrmck's comments.

frasercrmck added inline comments.May 19 2022, 12:19 AM
llvm/test/CodeGen/RISCV/double-arith-strict.ll
4 ↗(On Diff #430237)

I think CHECK only fits if it's common to all RUN lines in the test. Here I'd prefer CHECKIFD, for instance, as it's a combined check for the IFD cases.

sunshaoce marked an inline comment as done.

Address @frasercrmck's comments.

frasercrmck added inline comments.Jun 1 2022, 12:25 AM
llvm/test/CodeGen/RISCV/double-fcmp-strict.ll
3 ↗(On Diff #430596)

CHECKIFD here I think since we still have RV32I and RV64I separate

llvm/test/CodeGen/RISCV/double-fcmp.ll
3 ↗(On Diff #430596)

CHECKIFD here too

llvm/test/CodeGen/RISCV/float-arith-strict.ll
4

CHECKIF - there's no D in this test.

llvm/test/CodeGen/RISCV/float-arith.ll
3

CHECKIF here because RV32I/RV64I are still used

llvm/test/CodeGen/RISCV/float-convert-strict.ll
4

CHECKIF - no D

llvm/test/CodeGen/RISCV/float-convert.ll
3

CHECKIF

llvm/test/CodeGen/RISCV/float-fcmp-strict.ll
4

CHECKIF

llvm/test/CodeGen/RISCV/float-fcmp.ll
3

CHECKIF

llvm/test/CodeGen/RISCV/float-imm.ll
7

I think this comment should be left where it is - it refers to the architecture, not the check prefix.

llvm/test/CodeGen/RISCV/float-intrinsics-strict.ll
4

CHECKIF - no D

llvm/test/CodeGen/RISCV/float-mem.ll
3

CHECKIF

llvm/test/CodeGen/RISCV/float-round-conv-sat.ll
3

CHECKIF

llvm/test/CodeGen/RISCV/half-arith.ll
3 ↗(On Diff #430596)

CHECKIFZFH so that CHECK doesn't look like it should cover RV32I and RV64I too

llvm/test/CodeGen/RISCV/half-convert-strict.ll
4 ↗(On Diff #430596)

CHECKIZFH

llvm/test/CodeGen/RISCV/half-convert.ll
3 ↗(On Diff #430596)

No F or D here - CHECKIZFH

llvm/test/CodeGen/RISCV/half-fcmp.ll
3 ↗(On Diff #430596)

CHECKIZFH

llvm/test/CodeGen/RISCV/half-intrinsics.ll
4 ↗(On Diff #430596)

CHECKIZFH

llvm/test/CodeGen/RISCV/half-mem.ll
3 ↗(On Diff #430596)

CHECKIZFH or CHECK

llvm/test/CodeGen/RISCV/half-round-conv-sat.ll
3 ↗(On Diff #430596)

CHECKIZFH or CHECK

llvm/test/CodeGen/RISCV/half-round-conv.ll
3 ↗(On Diff #430596)

CHECKIZFH or CHECK

sunshaoce updated this revision to Diff 434063.Jun 3 2022, 10:33 AM
sunshaoce marked 20 inline comments as done.

Address comments.

frasercrmck accepted this revision.Jun 5 2022, 11:51 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 5 2022, 11:51 PM
This revision was landed with ongoing or failed builds.Jun 6 2022, 12:59 AM
This revision was automatically updated to reflect the committed changes.