This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][Clang][NFC] Update vid intrinsic tests.
ClosedPublic

Authored by khchen on Apr 19 2022, 8:49 PM.

Details

Summary

Re-run the update_cc_test_checks.py to update expected result.
I'm not sure why those tests are passed before.

Diff Detail

Event Timeline

khchen created this revision.Apr 19 2022, 8:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2022, 8:49 PM
khchen requested review of this revision.Apr 19 2022, 8:49 PM
frasercrmck accepted this revision.Apr 19 2022, 11:44 PM

Were they perhaps passing because i64 [[VL:%.*]] was matching the , i64 0 too? Seems like a flaw in the checks generated by the script, but I can see how the majority of the time the brevity is nice.

This revision is now accepted and ready to land.Apr 19 2022, 11:44 PM
This revision was automatically updated to reflect the committed changes.

Were they perhaps passing because i64 [[VL:%.*]] was matching the , i64 0 too? Seems like a flaw in the checks generated by the script, but I can see how the majority of the time the brevity is nice.

Yes, agree.

Thanks for reviewing.