This is an archive of the discontinued LLVM Phabricator instance.

[VPlan] Turn external defs in Value -> VPValue mapping.
ClosedPublic

Authored by fhahn on Apr 13 2022, 11:37 AM.

Details

Summary

This addresses an existing TODO by keeping a mapping of external IR
Value * definitions wrapped in VPValues for use in a VPlan.

Diff Detail

Event Timeline

fhahn created this revision.Apr 13 2022, 11:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2022, 11:37 AM
fhahn requested review of this revision.Apr 13 2022, 11:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2022, 11:37 AM
Herald added a subscriber: vkmr. · View Herald Transcript
Ayal accepted this revision.Apr 13 2022, 1:54 PM

Ship it!
minor nits.

llvm/lib/Transforms/Vectorize/VPlan.h
2467–2468

Can keep the explanation that external defs are immutable wrappers of underlying values.

2566–2567

Comment deserves updating.

2567–2573

nit: clearer to start code block on next line.

This revision is now accepted and ready to land.Apr 13 2022, 1:54 PM
This revision was landed with ongoing or failed builds.Apr 14 2022, 3:03 AM
This revision was automatically updated to reflect the committed changes.
fhahn marked 2 inline comments as done.
fhahn added a comment.Apr 14 2022, 3:04 AM

Ship it!
minor nits.

Thanks, they should be addressed in the committed version!