This is an archive of the discontinued LLVM Phabricator instance.

[mlir][ods][NFC] Move enum attribute definitions from OpBase.td to EnumAttr.td
ClosedPublic

Authored by jfurtek on Apr 11 2022, 3:41 PM.

Details

Summary

This diff moves EnumAttr tablegen definitions (specifically, IntEnumAttr and
BitEnumAttr-related classes) from OpBase.td to EnumAttr.td. No
functionality is changed.

Diff Detail

Event Timeline

jfurtek created this revision.Apr 11 2022, 3:41 PM
jfurtek requested review of this revision.Apr 11 2022, 3:41 PM
rriddle accepted this revision.Apr 11 2022, 3:43 PM

Thanks! Very appreciated.

mlir/include/mlir/Dialect/Arithmetic/IR/ArithmeticBase.td
12

Can we keep these sorted? Same in several other places.

This revision is now accepted and ready to land.Apr 11 2022, 3:43 PM
jfurtek updated this revision to Diff 422084.Apr 11 2022, 5:55 PM

Update include sort errors

jfurtek marked an inline comment as done.Apr 11 2022, 5:56 PM
jfurtek updated this revision to Diff 422085.Apr 11 2022, 6:01 PM
  • Fix include sorting

I don't have commit privileges - it would be great if someone could merge this when convenient.

Can you rebase?

jfurtek updated this revision to Diff 422826.Apr 14 2022, 5:30 AM
  • Fix include sorting
  • Remove defunct string attribute from attribute classes being moved
  • Rebase
This revision was landed with ongoing or failed builds.Apr 15 2022, 9:51 AM
This revision was automatically updated to reflect the committed changes.