Page MenuHomePhabricator

jfurtek (Jeremy Furtek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 17 2016, 7:58 AM (322 w, 3 d)

Recent Activity

Fri, May 20

jfurtek requested review of D126108: [mlir][ods] Add codegen support for custom verifiers (for attributes and types).
Fri, May 20, 5:27 PM · Restricted Project, Restricted Project

Thu, May 19

jfurtek added a comment to D124717: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder arguments in generated Python bindings.

@stellaraccident - I don't have commit privileges. Can you (or someone else) land this diff at your convenience? Thanks!

Thu, May 19, 9:15 AM · Restricted Project, Restricted Project
jfurtek updated the diff for D124717: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder arguments in generated Python bindings.
  • Update _ml_program_ops_ext.py to use FuncOp keyword arg
Thu, May 19, 9:05 AM · Restricted Project, Restricted Project
jfurtek updated the diff for D124717: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder arguments in generated Python bindings.
  • Fix clang-format errors
Thu, May 19, 7:57 AM · Restricted Project, Restricted Project

Thu, May 12

jfurtek updated the diff for D124717: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder arguments in generated Python bindings.

(rebase)

Thu, May 12, 10:47 AM · Restricted Project, Restricted Project
jfurtek updated the diff for D124720: [mlir] Update LLVMIR Fastmath flags use of MLIR BitEnum functionality.
  • Update handling of separators with spaces for nicer printing.
  • Fix clang formatting
  • rebase
Thu, May 12, 9:24 AM · Restricted Project, Restricted Project

Fri, May 6

jfurtek updated the diff for D124720: [mlir] Update LLVMIR Fastmath flags use of MLIR BitEnum functionality.
  • Fix clang formatting
Fri, May 6, 12:51 PM · Restricted Project, Restricted Project
jfurtek added inline comments to D124720: [mlir] Update LLVMIR Fastmath flags use of MLIR BitEnum functionality.
Fri, May 6, 10:28 AM · Restricted Project, Restricted Project
jfurtek updated the diff for D124720: [mlir] Update LLVMIR Fastmath flags use of MLIR BitEnum functionality.
  • Update handling of separators with spaces for nicer printing.
Fri, May 6, 10:25 AM · Restricted Project, Restricted Project

Mon, May 2

jfurtek added inline comments to D124720: [mlir] Update LLVMIR Fastmath flags use of MLIR BitEnum functionality.
Mon, May 2, 10:03 AM · Restricted Project, Restricted Project

Sat, Apr 30

jfurtek requested review of D124720: [mlir] Update LLVMIR Fastmath flags use of MLIR BitEnum functionality.
Sat, Apr 30, 2:11 PM · Restricted Project, Restricted Project
jfurtek added reviewers for D124717: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder arguments in generated Python bindings: jpienaar, mehdi_amini.
Sat, Apr 30, 12:39 PM · Restricted Project, Restricted Project
jfurtek requested review of D124717: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder arguments in generated Python bindings.
Sat, Apr 30, 12:36 PM · Restricted Project, Restricted Project

Mon, Apr 25

jfurtek updated the diff for D124043: [mlir][tblgen] Generate builders with inferred return types and unwrapped attributes.
  • Rebase
Mon, Apr 25, 11:39 AM · Restricted Project, Restricted Project
jfurtek updated the diff for D123871: [mlir][ods] Add tablegen field for concise printing of BitEnum attributes.
  • Rebase
Mon, Apr 25, 9:06 AM · Restricted Project, Restricted Project
jfurtek updated the diff for D123880: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.
  • Rebase
Mon, Apr 25, 9:04 AM · Restricted Project, Restricted Project

Apr 22 2022

jfurtek updated the diff for D123871: [mlir][ods] Add tablegen field for concise printing of BitEnum attributes.
  • Correct formatting, add comments, use llvm::reverse()
  • Make formatting code more readable
  • Properly punctuate comments.
Apr 22 2022, 12:01 PM · Restricted Project, Restricted Project
jfurtek added inline comments to D124043: [mlir][tblgen] Generate builders with inferred return types and unwrapped attributes.
Apr 22 2022, 11:36 AM · Restricted Project, Restricted Project
jfurtek updated the diff for D124043: [mlir][tblgen] Generate builders with inferred return types and unwrapped attributes.
  • Improve code flow and rebase
Apr 22 2022, 11:31 AM · Restricted Project, Restricted Project

Apr 20 2022

jfurtek updated the diff for D123871: [mlir][ods] Add tablegen field for concise printing of BitEnum attributes.
  • Correct formatting, add comments, use llvm::reverse()
Apr 20 2022, 2:12 PM · Restricted Project, Restricted Project
jfurtek added inline comments to D123880: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.
Apr 20 2022, 8:10 AM · Restricted Project, Restricted Project
jfurtek updated the diff for D123880: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.
  • Update lexer to support vertical bar token, and add test for vertical bar case
Apr 20 2022, 8:08 AM · Restricted Project, Restricted Project
jfurtek added a comment to D124043: [mlir][tblgen] Generate builders with inferred return types and unwrapped attributes.

Adding @mehdi_amini and @rriddle to reviewers to either review or suggest a reviewer...

Apr 20 2022, 7:24 AM · Restricted Project, Restricted Project
jfurtek added reviewers for D124043: [mlir][tblgen] Generate builders with inferred return types and unwrapped attributes: mehdi_amini, rriddle.
Apr 20 2022, 7:23 AM · Restricted Project, Restricted Project

Apr 19 2022

jfurtek planned changes to D123880: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.

Adding vertical bar test...

Apr 19 2022, 9:24 PM · Restricted Project, Restricted Project
jfurtek planned changes to D123871: [mlir][ods] Add tablegen field for concise printing of BitEnum attributes.
Apr 19 2022, 6:19 PM · Restricted Project, Restricted Project
jfurtek requested review of D124043: [mlir][tblgen] Generate builders with inferred return types and unwrapped attributes.
Apr 19 2022, 1:59 PM · Restricted Project, Restricted Project

Apr 15 2022

jfurtek added a reviewer for D123880: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes: Mogball.
Apr 15 2022, 3:55 PM · Restricted Project, Restricted Project
jfurtek abandoned D123389: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.

Abandoning - separate diff submitted to reflect repository changes since first draft.

Apr 15 2022, 3:55 PM · Restricted Project, Restricted Project
jfurtek requested review of D123880: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.
Apr 15 2022, 3:54 PM · Restricted Project, Restricted Project
jfurtek requested review of D123871: [mlir][ods] Add tablegen field for concise printing of BitEnum attributes.
Apr 15 2022, 12:57 PM · Restricted Project, Restricted Project
jfurtek abandoned D123410: [mlir][ods] Add tablegen field for (optional) concise printing of BitEnum attributes.

abandoning - will resubmit new diff from updated repo

Apr 15 2022, 12:57 PM · Restricted Project, Restricted Project

Apr 14 2022

jfurtek updated the diff for D123551: [mlir][ods][NFC] Move enum attribute definitions from OpBase.td to EnumAttr.td.
  • Fix include sorting
  • Remove defunct string attribute from attribute classes being moved
  • Rebase
Apr 14 2022, 5:30 AM · Restricted Project, Restricted Project

Apr 13 2022

jfurtek added a comment to D123551: [mlir][ods][NFC] Move enum attribute definitions from OpBase.td to EnumAttr.td.

I don't have commit privileges - it would be great if someone could merge this when convenient.

Apr 13 2022, 4:14 PM · Restricted Project, Restricted Project

Apr 11 2022

jfurtek planned changes to D123410: [mlir][ods] Add tablegen field for (optional) concise printing of BitEnum attributes.

Will wait for pending EnumAttr.td changes to land...

Apr 11 2022, 6:08 PM · Restricted Project, Restricted Project
jfurtek updated the diff for D123551: [mlir][ods][NFC] Move enum attribute definitions from OpBase.td to EnumAttr.td.
  • Fix include sorting
Apr 11 2022, 6:01 PM · Restricted Project, Restricted Project
jfurtek updated the diff for D123551: [mlir][ods][NFC] Move enum attribute definitions from OpBase.td to EnumAttr.td.

Update include sort errors

Apr 11 2022, 5:55 PM · Restricted Project, Restricted Project
jfurtek requested review of D123551: [mlir][ods][NFC] Move enum attribute definitions from OpBase.td to EnumAttr.td.
Apr 11 2022, 3:41 PM · Restricted Project, Restricted Project
jfurtek planned changes to D123389: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.
Apr 11 2022, 12:25 PM · Restricted Project, Restricted Project
jfurtek added inline comments to D123389: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.
Apr 11 2022, 11:49 AM · Restricted Project, Restricted Project

Apr 8 2022

jfurtek added inline comments to D123389: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.
Apr 8 2022, 2:55 PM · Restricted Project, Restricted Project
jfurtek updated the diff for D123389: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.
  • Move parse/print implementations out of OpBase.td
Apr 8 2022, 2:40 PM · Restricted Project, Restricted Project
jfurtek requested review of D123410: [mlir][ods] Add tablegen field for (optional) concise printing of BitEnum attributes.
Apr 8 2022, 10:28 AM · Restricted Project, Restricted Project
jfurtek added a reviewer for D123389: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes: Mogball.
Apr 8 2022, 6:56 AM · Restricted Project, Restricted Project
jfurtek requested review of D123389: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.
Apr 8 2022, 6:55 AM · Restricted Project, Restricted Project

Apr 7 2022

jfurtek added a comment to D123095: [mlir] Width parameterization of BitEnum attributes.

(updated diff to rebase...)

Apr 7 2022, 12:44 PM · Restricted Project, Restricted Project
jfurtek updated the diff for D123095: [mlir] Width parameterization of BitEnum attributes.

This diff contains:

Apr 7 2022, 12:41 PM · Restricted Project, Restricted Project

Apr 4 2022

jfurtek requested review of D123095: [mlir] Width parameterization of BitEnum attributes.
Apr 4 2022, 4:12 PM · Restricted Project, Restricted Project
jfurtek abandoned D123082: [mlir] BitEnum attributes: width parameterization, default/optional value support.

Apologies @mehdi_amini - I didn't see your previous "breakdown" recommendation until after I started the follow-up. Let me abandon this and try one more time with "even more" trimming...

Apr 4 2022, 3:28 PM · Restricted Project, Restricted Project
jfurtek requested review of D123082: [mlir] BitEnum attributes: width parameterization, default/optional value support.
Apr 4 2022, 3:15 PM · Restricted Project, Restricted Project
jfurtek abandoned D123069: [mlir][arith] Initial support for fastmath flag attributes in the Arithmetic dialect.

Will do...

Apr 4 2022, 1:21 PM · Restricted Project, Restricted Project
jfurtek requested review of D123069: [mlir][arith] Initial support for fastmath flag attributes in the Arithmetic dialect.
Apr 4 2022, 1:05 PM · Restricted Project, Restricted Project

Jan 21 2022

jfurtek added a comment to D117029: [mlir] Add ODS support for enum attributes with grouped bit cases.

Could someone with commit privileges land these changes (when convenient)? Thanks!

Jan 21 2022, 1:30 PM · Restricted Project

Jan 20 2022

jfurtek updated the diff for D117029: [mlir] Add ODS support for enum attributes with grouped bit cases.

[mlir] Add ODS support for enum attributes with grouped bit cases

Jan 20 2022, 1:41 PM · Restricted Project

Jan 18 2022

jfurtek added inline comments to D117029: [mlir] Add ODS support for enum attributes with grouped bit cases.
Jan 18 2022, 4:25 PM · Restricted Project
jfurtek updated the diff for D117029: [mlir] Add ODS support for enum attributes with grouped bit cases.

[mlir] Add ODS support for enum attributes with grouped bit cases

Jan 18 2022, 3:54 PM · Restricted Project
jfurtek updated the diff for D117029: [mlir] Add ODS support for enum attributes with grouped bit cases.

[mlir] Add ODS support for enum attributes with grouped bit cases (update)

Jan 18 2022, 3:46 PM · Restricted Project

Jan 11 2022

jfurtek requested review of D117029: [mlir] Add ODS support for enum attributes with grouped bit cases.
Jan 11 2022, 8:25 AM · Restricted Project