[Verifier] Add verifier for min-legal-vector-width
Needs ReviewPublic
Actions

Authored by pengfei on Apr 5 2022, 5:58 AM.

Details

Reviewers

efriedma
craig.topper
andrew.w.kaylor
jdoerfert

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	60,040 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg_mask_mf.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -triple riscv64 -target-feature +f -target-feature +d -target-feature +zfh -target-feature +experimental-zvfh -target-feature +v -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg_mask_mf.c -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -mem2reg \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg_mask_mf.c
	60,090 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vluxseg_mask_mf.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -triple riscv64 -target-feature +f -target-feature +d -target-feature +zfh -target-feature +experimental-zvfh -target-feature +v -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vluxseg_mask_mf.c -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -mem2reg \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vluxseg_mask_mf.c
	330 ms	x64 debian > LLVM.Transforms/ArgumentPromotion/X86::min-legal-vector-width.ll Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -argpromotion < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Transforms/ArgumentPromotion/X86/min-legal-vector-width.ll \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Transforms/ArgumentPromotion/X86/min-legal-vector-width.ll
	430 ms	x64 debian > LLVM.Transforms/Attributor/ArgumentPromotion/X86::min-legal-vector-width.ll Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -attributor -enable-new-pm=0 -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=3 -S < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Transforms/Attributor/ArgumentPromotion/X86/min-legal-vector-width.ll \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --allow-unused-prefixes /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Transforms/Attributor/ArgumentPromotion/X86/min-legal-vector-width.ll --check-prefixes=CHECK,NOT_CGSCC_NPM,NOT_CGSCC_OPM,NOT_TUNIT_NPM,IS__TUNIT____,IS________OPM,IS__TUNIT_OPM
	50 ms	x64 debian > ScudoStandalone-Unit-GwpAsanTorture._/ScudoCUnitTest-x86_64-Test::ScudoWrappersCTest.MallocInfo Script: -- /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/lib/scudo/standalone/tests/./ScudoCUnitTest-x86_64-Test --gtest_filter=ScudoWrappersCTest.MallocInfo
		View Full Test Results (6 Failed)

Event Timeline

pengfei created this revision.Apr 5 2022, 5:58 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2022, 5:58 AM

Herald added subscribers: StephenFan, wenlei, jdoerfert, hiraditya. · View Herald Transcript

pengfei requested review of this revision.Apr 5 2022, 5:58 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2022, 5:58 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

pengfei mentioned this in D122594: [ArgPromotion] Update min-legal-vector-width when do promotion.Apr 5 2022, 6:15 AM

pengfei added parent revisions: D122594: [ArgPromotion] Update min-legal-vector-width when do promotion, D123125: [Attributor] Update min-legal-vector-width when do promotion.

Harbormaster completed remote builds in B157958: Diff 420477.Apr 5 2022, 6:36 AM

pengfei edited parent revisions, added: D123284: [ArgPromotion][Attributor] Update min-legal-vector-width when do promotion; removed: D123125: [Attributor] Update min-legal-vector-width when do promotion, D122594: [ArgPromotion] Update min-legal-vector-width when do promotion.Apr 7 2022, 12:40 AM

I think this is missing a check: for call instructions, you need to check the min-legal-vector-width of both the call itself, and the function containing the call.

I'm still not really convinced this is the best approach, but maybe it's good enough.