This is an archive of the discontinued LLVM Phabricator instance.

[Attributor] Update min-legal-vector-width when do promotion
AbandonedPublic

Authored by pengfei on Apr 5 2022, 6:01 AM.

Diff Detail

Event Timeline

pengfei created this revision.Apr 5 2022, 6:01 AM
Herald added a project: Restricted Project. · View Herald Transcript
pengfei requested review of this revision.Apr 5 2022, 6:01 AM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript

Thanks for the patch!

Could you add a commit message explaining the motivation and what this does.
I also left a question below.

llvm/lib/Transforms/IPO/Attributor.cpp
2498

Should this be a helper, seems reausable, no?

pengfei added inline comments.Apr 7 2022, 12:36 AM
llvm/lib/Transforms/IPO/Attributor.cpp
2498

Good point! Added a helper and merged D122594 together to D123284 .