[flang][OpenMP] Fixed symbol details type for critical construct names

[NimishMishra]

Summary

D110502 (https://reviews.llvm.org/D110502) added UnknownDetails for the newly created symbols for critical construct names. That was undesirable. This patch fixes the same.

Also added an XFAIL test case regarding name collision involving a critical construct.

[NimishMishra]

Ping for review!

[shraiysh]

Please rebase.

gfortran and flang accept the testcase and compile successfully. Can you please make sure we are not implementing an incorrect check?

Also, can we display a graceful error message instead of a crash dump and check for that in the testcase?

[shraiysh]

Requesting changes/addressing for the comments mentioned above.

[TIFitis]

@NimishMishra Can you please address the previous comments. I'd be happy to review it further.

Cheers

flang/lib/Semantics/resolve-directives.cpp

void OmpAttributeVisitor::ResolveOmpName(
     const parser::Name &name, Symbol::Flag ompFlag) {
   if (ResolveName(&name)) {
     if (auto *resolvedSymbol{ResolveOmp(name, ompFlag, currScope())}) {
       if (dataSharingAttributeFlags.test(ompFlag)) {
         AddToContextObjectWithDSA(*resolvedSymbol, ompFlag);
       }
     }
   } else if (ompFlag == Symbol::Flag::OmpCriticalLock) {
-    const auto pair{
-        GetContext().scope.try_emplace(name.source, Attrs{}, UnknownDetails{})};
+    const auto pair{GetContext().scope.try_emplace(
+        name.source, Attrs{}, MiscDetails::Kind::ConstructName)};
     CHECK(pair.second);
     name.symbol = &pair.first->second.get();
   }
 }
 
 void OmpAttributeVisitor::ResolveOmpNameList(
     const std::list<parser::Name> &nameList, Symbol::Flag ompFlag) {
   for (const auto &name : nameList) {

flang/test/Semantics/critical05.f90

+! RUN: %python %S/test_symbols.py %s %flang_fc1 -fopenmp
+! XFAIL: *
+! Checking for name collision of a critical construct with other elements of a program
+
+!DEF: /check_symbols MainProgram
+program check_symbols
+    !DEF: /check_symbols/i ObjectEntity INTEGER(4)
+    integer i, bar
+    !REF: /check_symbols/i
+    foo: do i = 1, 10
+    end do foo
+
+    !$omp critical(foo)
+    !$omp end critical(foo)
+
+    !$omp critical (bar)
+    !$omp end critical (bar)
+end program check_symbols