Page MenuHomePhabricator

shraiysh (Shraiysh)
shraiysh

Projects

User does not belong to any projects.

User Details

User Since
Dec 24 2019, 1:39 AM (13 w, 5 d)

Recent Activity

Thu, Mar 19

shraiysh added a comment to D74916: [MLIR] Added llvm.indirectbr.

Hi @ftynse ! I will update this diff accordingly. I'll figure out how to handle BlockAddresses first.

Thu, Mar 19, 6:26 AM · Restricted Project
shraiysh updated the diff for D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.

Addressed comments.

Thu, Mar 19, 4:49 AM · Restricted Project

Wed, Mar 11

shraiysh updated the diff for D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.

Addressed comments.

Wed, Mar 11, 7:58 AM · Restricted Project

Tue, Mar 10

shraiysh added a comment to D74889: [mlir] Generalize intrinsic builders in the LLVM dialect definition.

Hi, I was trying to implement some llvm intrinsics and wanted to understand the purpose of overloaded operands. The LLVM reference manual does not say that prefetch is overloaded.

Tue, Mar 10, 12:53 AM · Restricted Project

Mon, Mar 9

shraiysh added a comment to D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.

@ftynse @rriddle please review this.

Mon, Mar 9, 4:48 AM · Restricted Project

Feb 28 2020

shraiysh added a comment to D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.

Addressed comments.

Feb 28 2020, 12:19 AM · Restricted Project
shraiysh updated the diff for D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.
Feb 28 2020, 12:19 AM · Restricted Project

Feb 23 2020

shraiysh added inline comments to D74916: [MLIR] Added llvm.indirectbr.
Feb 23 2020, 9:49 AM · Restricted Project
shraiysh updated the diff for D74916: [MLIR] Added llvm.indirectbr.
Feb 23 2020, 9:42 AM · Restricted Project

Feb 21 2020

shraiysh updated the diff for D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.

Updated with full context.

Feb 21 2020, 10:09 PM · Restricted Project

Feb 20 2020

shraiysh added a comment to D74916: [MLIR] Added llvm.indirectbr.

Hi @rriddle ! Thanks for the comments. I have updated the patch with more context now. Also, I have addressed all comments except one. Please let me know if you think I should change it to ArrayRef (I mentioned my reason in the inline comment).

Feb 20 2020, 12:01 PM · Restricted Project
shraiysh updated the diff for D74916: [MLIR] Added llvm.indirectbr.
Feb 20 2020, 12:01 PM · Restricted Project
shraiysh created D74916: [MLIR] Added llvm.indirectbr.
Feb 20 2020, 11:06 AM · Restricted Project

Feb 18 2020

shraiysh added a comment to D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.

I do not have write access to the repository. If would be great if someone could commit for me. Thanks.

Feb 18 2020, 5:50 AM · Restricted Project
shraiysh updated the diff for D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.
Feb 18 2020, 5:50 AM · Restricted Project
shraiysh added inline comments to D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.
Feb 18 2020, 5:50 AM · Restricted Project

Feb 17 2020

shraiysh added inline comments to D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.
Feb 17 2020, 8:59 AM · Restricted Project
shraiysh updated the diff for D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.
Feb 17 2020, 6:07 AM · Restricted Project
shraiysh added inline comments to D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.
Feb 17 2020, 6:07 AM · Restricted Project

Feb 12 2020

shraiysh updated the diff for D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.
Feb 12 2020, 7:31 PM · Restricted Project
shraiysh added inline comments to D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.
Feb 12 2020, 7:31 PM · Restricted Project

Feb 6 2020

shraiysh added a comment to D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.

Hi, can someone please provide a review for this patch.
Thanks.

Feb 6 2020, 7:25 PM · Restricted Project

Feb 1 2020

shraiysh updated the diff for D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.

Please review this.

Feb 1 2020, 3:07 AM · Restricted Project

Jan 30 2020

shraiysh added a comment to D72006: [MLIR] Added llvm.invoke and llvm.landingpad.

I do not have write access to the repository. If would be great if someone could commit for me.
I have updated the patch.

Jan 30 2020, 3:42 AM · Restricted Project
shraiysh updated the diff for D72006: [MLIR] Added llvm.invoke and llvm.landingpad.
Jan 30 2020, 3:42 AM · Restricted Project

Jan 26 2020

shraiysh updated the diff for D72006: [MLIR] Added llvm.invoke and llvm.landingpad.
Jan 26 2020, 9:15 AM · Restricted Project
shraiysh added inline comments to D72006: [MLIR] Added llvm.invoke and llvm.landingpad.
Jan 26 2020, 9:11 AM · Restricted Project
shraiysh updated the diff for D72006: [MLIR] Added llvm.invoke and llvm.landingpad.
Jan 26 2020, 9:11 AM · Restricted Project

Jan 22 2020

shraiysh updated the diff for D72006: [MLIR] Added llvm.invoke and llvm.landingpad.
Jan 22 2020, 11:10 AM · Restricted Project
shraiysh added inline comments to D72006: [MLIR] Added llvm.invoke and llvm.landingpad.
Jan 22 2020, 11:10 AM · Restricted Project
shraiysh added a comment to D72006: [MLIR] Added llvm.invoke and llvm.landingpad.

I realized that I had forgotten to add function personality in our dialect. I will be adding it in another patch, once this gets accepted.
Apart from that, I have tried to address all the all inline comments. Please let me know if anything has to be changed. Thanks.

Jan 22 2020, 11:10 AM · Restricted Project

Jan 20 2020

shraiysh updated the diff for D72006: [MLIR] Added llvm.invoke and llvm.landingpad.
Jan 20 2020, 4:54 AM · Restricted Project
shraiysh added inline comments to D72006: [MLIR] Added llvm.invoke and llvm.landingpad.
Jan 20 2020, 3:30 AM · Restricted Project
shraiysh updated the diff for D72006: [MLIR] Added llvm.invoke and llvm.landingpad.

I have tried to address all the comments pointed out by @rriddle . I have also made the builder for llvm.InvokeOp. Please let me know if anything else has to be done.

Jan 20 2020, 3:30 AM · Restricted Project

Jan 19 2020

shraiysh updated the diff for D72006: [MLIR] Added llvm.invoke and llvm.landingpad.

I have tried to address almost all the comments.

Jan 19 2020, 9:56 AM · Restricted Project

Dec 31 2019

shraiysh added a comment to D72006: [MLIR] Added llvm.invoke and llvm.landingpad.

Haven't looked at the code, let met know if you want me to. Please see design comments inline.

No, the code is not finished yet. I just wanted reviews on the design. Thanks.

Dec 31 2019, 4:36 AM · Restricted Project

Dec 30 2019

shraiysh added a comment to D72006: [MLIR] Added llvm.invoke and llvm.landingpad.

Yes, I'm sorry for the confusion.

Dec 30 2019, 11:49 AM · Restricted Project
shraiysh added a reviewer for D72006: [MLIR] Added llvm.invoke and llvm.landingpad: ftynse.
Dec 30 2019, 9:08 AM · Restricted Project
shraiysh updated the summary of D72006: [MLIR] Added llvm.invoke and llvm.landingpad.
Dec 30 2019, 9:00 AM · Restricted Project
shraiysh created D72006: [MLIR] Added llvm.invoke and llvm.landingpad.
Dec 30 2019, 8:50 AM · Restricted Project

Dec 27 2019

shraiysh added a comment to D71912: [mlir] Floating constants for import-llvm.

Thanks for the clarification. I will use arc in my future patches.

Dec 27 2019, 9:19 AM · Restricted Project
shraiysh added a comment to D71912: [mlir] Floating constants for import-llvm.

I would also add an error message in cases where constant conversion failed and made sure the callers of getConstantAsAttr are aware that it can return null (there may be x86_fp80 and fp128 values, that are not supported in MLIR at all). Fine for a separate commit.

Sure!

Dec 27 2019, 6:49 AM · Restricted Project

Dec 26 2019

shraiysh added a comment to D71912: [mlir] Floating constants for import-llvm.

Also, @mehdi_amini I do not have permissions to commit. It would be great if you could commit this.

Dec 26 2019, 11:11 PM · Restricted Project
shraiysh updated the diff for D71912: [mlir] Floating constants for import-llvm.

The order of instructions in the test for FP arithmetic wasn't right. Fixed it.

Dec 26 2019, 8:51 PM · Restricted Project
shraiysh created D71912: [mlir] Floating constants for import-llvm.
Dec 26 2019, 11:19 AM · Restricted Project
shraiysh added a reviewer for D71912: [mlir] Floating constants for import-llvm: ftynse.
Dec 26 2019, 11:19 AM · Restricted Project
shraiysh added a comment to D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.

Thank you all for your comments. I will get back to this issue after doing the landingpad instruction.

Dec 26 2019, 11:10 AM · Restricted Project
shraiysh updated the diff for D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.

Removed printOptionalAttrDict from printResumeOp as it is not in syntax.

Dec 26 2019, 1:45 AM · Restricted Project
shraiysh created D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect.
Dec 26 2019, 1:27 AM · Restricted Project