- User Since
- Dec 24 2019, 1:39 AM (13 w, 5 d)
Thu, Mar 19
Hi @ftynse ! I will update this diff accordingly. I'll figure out how to handle BlockAddresses first.
Wed, Mar 11
Tue, Mar 10
Hi, I was trying to implement some llvm intrinsics and wanted to understand the purpose of overloaded operands. The LLVM reference manual does not say that prefetch is overloaded.
Mon, Mar 9
Feb 28 2020
Feb 23 2020
Feb 21 2020
Updated with full context.
Feb 20 2020
Hi @rriddle ! Thanks for the comments. I have updated the patch with more context now. Also, I have addressed all comments except one. Please let me know if you think I should change it to ArrayRef (I mentioned my reason in the inline comment).
Feb 18 2020
I do not have write access to the repository. If would be great if someone could commit for me. Thanks.
Feb 17 2020
Feb 12 2020
Feb 6 2020
Hi, can someone please provide a review for this patch.
Feb 1 2020
Please review this.
Jan 30 2020
I do not have write access to the repository. If would be great if someone could commit for me.
I have updated the patch.
Jan 26 2020
Jan 22 2020
I realized that I had forgotten to add function personality in our dialect. I will be adding it in another patch, once this gets accepted.
Apart from that, I have tried to address all the all inline comments. Please let me know if anything has to be changed. Thanks.
Jan 20 2020
I have tried to address all the comments pointed out by @rriddle . I have also made the builder for llvm.InvokeOp. Please let me know if anything else has to be done.
Jan 19 2020
I have tried to address almost all the comments.
Dec 31 2019
Haven't looked at the code, let met know if you want me to. Please see design comments inline.
No, the code is not finished yet. I just wanted reviews on the design. Thanks.
Dec 30 2019
Yes, I'm sorry for the confusion.
Dec 27 2019
Thanks for the clarification. I will use arc in my future patches.
I would also add an error message in cases where constant conversion failed and made sure the callers of getConstantAsAttr are aware that it can return null (there may be x86_fp80 and fp128 values, that are not supported in MLIR at all). Fine for a separate commit.
Dec 26 2019
Also, @mehdi_amini I do not have permissions to commit. It would be great if you could commit this.
The order of instructions in the test for FP arithmetic wasn't right. Fixed it.
Thank you all for your comments. I will get back to this issue after doing the landingpad instruction.
Removed printOptionalAttrDict from printResumeOp as it is not in syntax.