Page MenuHomePhabricator

shraiysh (Shraiysh)
shraiysh

Projects

User does not belong to any projects.

User Details

User Since
Dec 24 2019, 1:39 AM (108 w, 2 d)

Compiler Engineer at AMD

Recent Activity

Mon, Jan 17

shraiysh accepted D116073: [MLIR][OpenMP] Support schedule chunk size with various bit width.

Apologies for not accepting this earlier.

Mon, Jan 17, 10:51 AM · Restricted Project, Restricted Project

Thu, Jan 13

shraiysh updated the diff for D115851: [mlir][OpenMP] Added omp.atomic.capture operation.

Addressed SingleBlockImplicitTerminator comment.

Thu, Jan 13, 3:42 AM · Restricted Project

Wed, Jan 12

shraiysh added a comment to D115851: [mlir][OpenMP] Added omp.atomic.capture operation.

Thank you for the reviews @kiranchandramohan and @peixin. I will address the terminator comment soon. I have been busy with some other work recently. Apologies for the delay.

Wed, Jan 12, 2:48 AM · Restricted Project

Mon, Jan 10

shraiysh committed rGa8586b573e07: [mlir][OpenMP] Change the syntax of omp.atomic.read op (authored by shraiysh).
[mlir][OpenMP] Change the syntax of omp.atomic.read op
Mon, Jan 10, 2:50 AM
shraiysh closed D116396: [mlir][OpenMP] Change the syntax of omp.atomic.read op.
Mon, Jan 10, 2:50 AM · Restricted Project
shraiysh updated the diff for D116396: [mlir][OpenMP] Change the syntax of omp.atomic.read op.

Rebase with main.

Mon, Jan 10, 2:20 AM · Restricted Project
shraiysh added a comment to D116073: [MLIR][OpenMP] Support schedule chunk size with various bit width.

LGTM.

Mon, Jan 10, 12:48 AM · Restricted Project, Restricted Project

Sun, Jan 9

shraiysh accepted D113399: [flang][OpenMP] Add semantic checks of nesting of region about ordered construct.

Thanks for addressing the comments @peixin. One minor comment, rest LGTM. (Please wait for one more review because I am not an expert in this part of the code).

Sun, Jan 9, 11:32 PM · Restricted Project, Restricted Project

Thu, Jan 6

shraiysh committed rG6bcb4c44de0c: [mlir][OpenMP] Added omp.atomic.write lowering to LLVM IR (authored by shraiysh).
[mlir][OpenMP] Added omp.atomic.write lowering to LLVM IR
Thu, Jan 6, 8:32 PM
shraiysh closed D116416: [mlir][OpenMP] Added omp.atomic.write lowering to LLVM IR.
Thu, Jan 6, 8:32 PM · Restricted Project
shraiysh added inline comments to D116416: [mlir][OpenMP] Added omp.atomic.write lowering to LLVM IR.
Thu, Jan 6, 8:28 PM · Restricted Project
shraiysh updated the diff for D116416: [mlir][OpenMP] Added omp.atomic.write lowering to LLVM IR.

Thanks for the review @kiranchandramohan and @peixin. Addressed comments and rebase with main.

Thu, Jan 6, 8:16 PM · Restricted Project

Wed, Jan 5

shraiysh accepted D116300: [OMPIRBuilder] Fix store inst alignment for ordered depend directive.

LGTM.

Wed, Jan 5, 8:27 PM · Restricted Project, Restricted Project
shraiysh accepted D116706: [mlir][LLVM] Implement mapping of phi source values of `llvm.invoke`.
Wed, Jan 5, 8:16 PM · Restricted Project
shraiysh added a comment to D116396: [mlir][OpenMP] Change the syntax of omp.atomic.read op.

@shraiysh Can you go ahead and try this method (using atomic.read in atomic.capture structured-block) and verify it in D115851? It may be better to show one whole design instead of part of it.

Another question is that will atomic.write and atomic.update will be used in atomic.capture structured-block and should their syntax also be updated?

Wed, Jan 5, 4:25 AM · Restricted Project
shraiysh added a comment to D116300: [OMPIRBuilder] Fix store inst alignment for ordered depend directive.

Thanks Kiran. The i64 vec change LGTM (I still didn't understand why the alignment has to be 8).

Wed, Jan 5, 4:14 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D116416: [mlir][OpenMP] Added omp.atomic.write lowering to LLVM IR.

Thanks for the review @kiranchandramohan. Addressed comments.

Wed, Jan 5, 4:09 AM · Restricted Project
shraiysh updated the diff for D115851: [mlir][OpenMP] Added omp.atomic.capture operation.

Fix missing semi-colon error

Wed, Jan 5, 3:29 AM · Restricted Project
shraiysh updated the diff for D115851: [mlir][OpenMP] Added omp.atomic.capture operation.

Depends on D116396

Wed, Jan 5, 3:18 AM · Restricted Project
shraiysh updated the diff for D115851: [mlir][OpenMP] Added omp.atomic.capture operation.

Updated patch to use omp.atomic.read and omp.atomic.update

Wed, Jan 5, 2:53 AM · Restricted Project
shraiysh added a comment to D116300: [OMPIRBuilder] Fix store inst alignment for ordered depend directive.

Thanks for this patch @peixin. Can you please provide a reference to this requirement? (I was looking for the __kmpc_doacross_post in the RTL reference here but could not find it)

Wed, Jan 5, 2:08 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D116396: [mlir][OpenMP] Change the syntax of omp.atomic.read op.

Changed argument variable names to be more consistent with other operations and the standard.

Wed, Jan 5, 1:51 AM · Restricted Project

Thu, Dec 30

shraiysh added a comment to D116396: [mlir][OpenMP] Change the syntax of omp.atomic.read op.

Thanks @peixin. Can you please review this patch?

Thu, Dec 30, 7:23 PM · Restricted Project
shraiysh accepted D114941: [flang][OpenMP] Add some semantic checks for threadprivate and declare target directives.

@peixin I think we can merge this to make progress and if Kiran has any post-commit comments, we can address them later.

Thu, Dec 30, 7:21 PM · Restricted Project, Restricted Project
shraiysh added reviewers for D116416: [mlir][OpenMP] Added omp.atomic.write lowering to LLVM IR: kiranktp, AMDChirag, NimishMishra, kiranchandramohan, peixin, clementval, jeanPerier.
Thu, Dec 30, 8:54 AM · Restricted Project
shraiysh requested review of D116416: [mlir][OpenMP] Added omp.atomic.write lowering to LLVM IR.
Thu, Dec 30, 8:52 AM · Restricted Project
shraiysh added a comment to D115851: [mlir][OpenMP] Added omp.atomic.capture operation.

Thanks for the detailed review @peixin. I will work on this patch and address comments based on the discussion from patch D116396.

Thu, Dec 30, 7:57 AM · Restricted Project
shraiysh added a comment to D116396: [mlir][OpenMP] Change the syntax of omp.atomic.read op.

I was planning to add the atomic capture operation like this

// v = x; x = x binop expr;
omp.atomic.capture {
  omp.atomic.read %v = %x : !llvm.ptr<i32>
  omp.atomic.update %x = %x add %expr : !llvm.ptr<i32>, i32
}

This cannot be done with the current syntax because the read value will be limited by scope. All the forms of atomic capture constructs can be captured like this (with certain restrictions). This will make it less complicated. Also, the `equal

Thu, Dec 30, 7:55 AM · Restricted Project

Wed, Dec 29

shraiysh updated the diff for D116396: [mlir][OpenMP] Change the syntax of omp.atomic.read op.

Added check for not allowing same values of src and dest.

Wed, Dec 29, 11:26 PM · Restricted Project
shraiysh added reviewers for D116396: [mlir][OpenMP] Change the syntax of omp.atomic.read op: kiranktp, AMDChirag, NimishMishra, kiranchandramohan, peixin, jeanPerier, clementval.
Wed, Dec 29, 11:18 PM · Restricted Project
shraiysh requested review of D116396: [mlir][OpenMP] Change the syntax of omp.atomic.read op.
Wed, Dec 29, 11:17 PM · Restricted Project

Dec 21 2021

shraiysh added a comment to D116073: [MLIR][OpenMP] Support schedule chunk size with various bit width.

Hi @peixin. Thanks for the patch! I had a few comments.

Dec 21 2021, 7:21 AM · Restricted Project, Restricted Project

Dec 16 2021

shraiysh added a comment to D115445: [NFC][mlir][OpenMP] Added documentation for omp.atomic ops.

As this has been merged already, I will change those specific points in a separate patch.

Dec 16 2021, 5:53 AM · Restricted Project

Dec 15 2021

shraiysh added reviewers for D115851: [mlir][OpenMP] Added omp.atomic.capture operation: kiranktp, AMDChirag, NimishMishra, peixin, clementval, kiranchandramohan, MatsPetersson, jeanPerier.
Dec 15 2021, 10:54 PM · Restricted Project
shraiysh requested review of D115851: [mlir][OpenMP] Added omp.atomic.capture operation.
Dec 15 2021, 10:52 PM · Restricted Project
shraiysh added a comment to D115650: [clangd] Disable support for clang-tidy suppression blocks (NOLINTBEGIN).

Hey folks, this commit seems to cause multiple buildbot failures 1 2 3. Can someone please revert this change while it gets fixed? Thanks!

Dec 15 2021, 2:53 AM · Restricted Project
shraiysh committed rG3425b1bcb4bf: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR (authored by shraiysh).
[mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR
Dec 15 2021, 2:11 AM
shraiysh closed D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR.
Dec 15 2021, 2:11 AM · Restricted Project, Restricted Project
shraiysh added a comment to D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR.

@ftynse @kiranchandramohan there are unrelated build failures (and this is happening for other patches too). Looks like there is an issue with the build job. Should I land this change without waiting for the build jobs to be rectified?

Dec 15 2021, 1:44 AM · Restricted Project, Restricted Project
shraiysh added inline comments to D115215: [mlir] Added oilist primitive.
Dec 15 2021, 1:40 AM · Restricted Project
shraiysh updated the diff for D115215: [mlir] Added oilist primitive.

Thanks for the review @Mogball. Addressed Comments.

Dec 15 2021, 1:39 AM · Restricted Project

Dec 14 2021

shraiysh updated the diff for D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR.

Rebase with main

Dec 14 2021, 9:42 PM · Restricted Project, Restricted Project
shraiysh added a comment to D114457: [z/OS] Implement prologue and epilogue generation for z/OS target..

Hey folks, it looks like this commit has caused the buildbot here to run into failures. Can someone please revert this change, fix it and then commit it again?

Dec 14 2021, 10:23 AM · Restricted Project
shraiysh updated the diff for D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR.

Rebase with main. (Unrelated build failure)

Dec 14 2021, 9:48 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR.

Rebase with main. Addressed comment. Sure @kiranchandramohan. Will address if there are any post-commit reviews.

Dec 14 2021, 5:13 AM · Restricted Project, Restricted Project

Dec 13 2021

shraiysh updated the diff for D115215: [mlir] Added oilist primitive.

Thanks for the review @Mogball and @rriddle. I have tried to address all your comments.

Dec 13 2021, 12:39 PM · Restricted Project

Dec 9 2021

shraiysh committed rGd4865393b5da: [NFC][mlir][OpenMP] Added documentation for omp.atomic ops (authored by shraiysh).
[NFC][mlir][OpenMP] Added documentation for omp.atomic ops
Dec 9 2021, 8:17 AM
shraiysh closed D115445: [NFC][mlir][OpenMP] Added documentation for omp.atomic ops.
Dec 9 2021, 8:17 AM · Restricted Project
shraiysh updated the diff for D115445: [NFC][mlir][OpenMP] Added documentation for omp.atomic ops.

Addressed comments. Thanks for the review!

Dec 9 2021, 7:29 AM · Restricted Project
shraiysh added reviewers for D115445: [NFC][mlir][OpenMP] Added documentation for omp.atomic ops: peixin, kiranktp, NimishMishra, kiranchandramohan, clementval, AMDChirag.
Dec 9 2021, 6:58 AM · Restricted Project
shraiysh requested review of D115445: [NFC][mlir][OpenMP] Added documentation for omp.atomic ops.
Dec 9 2021, 6:56 AM · Restricted Project
shraiysh added a comment to D114941: [flang][OpenMP] Add some semantic checks for threadprivate and declare target directives.

Thanks for the explanation!

Dec 9 2021, 3:09 AM · Restricted Project, Restricted Project
shraiysh added a comment to D113399: [flang][OpenMP] Add semantic checks of nesting of region about ordered construct.

Hi @peixin. Thanks for the patch. I had a few comments.

Dec 9 2021, 2:59 AM · Restricted Project, Restricted Project
shraiysh committed rGd82c1f4e4b72: [MLIR][OpenMP] Added omp.atomic.update (authored by shraiysh).
[MLIR][OpenMP] Added omp.atomic.update
Dec 9 2021, 1:51 AM
shraiysh closed D112982: [MLIR][OpenMP] Added omp.atomic.update.
Dec 9 2021, 1:51 AM · Restricted Project, Restricted Project

Dec 8 2021

shraiysh updated the diff for D112982: [MLIR][OpenMP] Added omp.atomic.update.

Thanks for the review. Rebase with main.

Dec 8 2021, 10:52 PM · Restricted Project, Restricted Project
shraiysh added inline comments to D115215: [mlir] Added oilist primitive.
Dec 8 2021, 1:31 PM · Restricted Project
shraiysh updated the diff for D115215: [mlir] Added oilist primitive.

Thanks for the detailed review @Mogball. I have tried to address all your comments. Please let me know if I missed something!

Dec 8 2021, 1:31 PM · Restricted Project
shraiysh added a comment to D114941: [flang][OpenMP] Add some semantic checks for threadprivate and declare target directives.

The patch functionally LGTM, but I have not worked on these files and would suggest you to wait for someone else's review (someone who has worked on semantic checks for flang) before merging this.

Dec 8 2021, 4:44 AM · Restricted Project, Restricted Project

Dec 6 2021

shraiysh committed rG31cf42bd9a71: [mlir][OpenMP] Added omp.atomic.read lowering (authored by shraiysh).
[mlir][OpenMP] Added omp.atomic.read lowering
Dec 6 2021, 9:48 PM
shraiysh closed D115134: [mlir][OpenMP] Added omp.atomic.read lowering.
Dec 6 2021, 9:47 PM · Restricted Project
shraiysh updated the diff for D115134: [mlir][OpenMP] Added omp.atomic.read lowering.

Addressed comments

Dec 6 2021, 9:19 PM · Restricted Project
shraiysh updated the diff for D115215: [mlir] Added oilist primitive.

Remove unrelated change

Dec 6 2021, 8:29 PM · Restricted Project
shraiysh added reviewers for D115215: [mlir] Added oilist primitive: jpienaar, Mogball, stephenneuendorffer, mehdi_amini, ftynse, kiranktp, AMDChirag, rriddle, NimishMishra, clementval, kiranchandramohan.
Dec 6 2021, 8:24 PM · Restricted Project
shraiysh requested review of D115215: [mlir] Added oilist primitive.
Dec 6 2021, 8:20 PM · Restricted Project

Dec 5 2021

shraiysh added reviewers for D115134: [mlir][OpenMP] Added omp.atomic.read lowering: kiranktp, NimishMishra, AMDChirag, kiranchandramohan, peixin, clementval, abidmalikwaterloo, MatsPetersson, Meinersbur, jeanPerier, arnamoy10.
Dec 5 2021, 11:52 PM · Restricted Project
shraiysh updated the diff for D115134: [mlir][OpenMP] Added omp.atomic.read lowering.

Added new line at EOF

Dec 5 2021, 11:49 PM · Restricted Project
shraiysh requested review of D115134: [mlir][OpenMP] Added omp.atomic.read lowering.
Dec 5 2021, 11:48 PM · Restricted Project
shraiysh added a comment to D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR.

Thanks for the review @NimishMishra.

Dec 5 2021, 12:29 AM · Restricted Project, Restricted Project

Dec 4 2021

shraiysh added a reviewer for D114941: [flang][OpenMP] Add some semantic checks for threadprivate and declare target directives: NimishMishra.
Dec 4 2021, 11:46 PM · Restricted Project, Restricted Project
shraiysh added a comment to D114941: [flang][OpenMP] Add some semantic checks for threadprivate and declare target directives.

Hi @peixin . Thanks for this patch. I have a few comments and questions for the declare target checks. I will review the threadprivate checks soon.

Dec 4 2021, 11:38 PM · Restricted Project, Restricted Project
shraiysh updated the diff for D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR.

Thanks for the review @ftynse. Addressed comments. Waiting for review on OpenMP Part.

Dec 4 2021, 1:09 PM · Restricted Project, Restricted Project

Dec 3 2021

shraiysh added a comment to D110714: [Flang][openmp] Added semantic checks for atomic construct with update clause.

Thanks for the patch Nimish. I had a few minor comments about testcases. Rest LGTM.

Dec 3 2021, 2:49 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh added reviewers for D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR: kiranktp, AMDChirag, NimishMishra, kiranchandramohan, clementval, peixin, abidmalikwaterloo, MatsPetersson, Meinersbur, jeanPerier, arnamoy10.
Dec 3 2021, 1:35 AM · Restricted Project, Restricted Project
shraiysh requested review of D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR.
Dec 3 2021, 1:31 AM · Restricted Project, Restricted Project
shraiysh added a comment to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

Hi @abidmalikwaterloo Thanks for this patch. There are a couple of issues with the styling which is causing the builds to fail. For example trailing spaces, 80-character line wraps and maybe some indentation. I have a few comments.

Dec 3 2021, 12:55 AM · Restricted Project

Dec 1 2021

shraiysh committed rGec97e1206abd: [OpenMP][IRBuilder] Fix createSections (authored by shraiysh).
[OpenMP][IRBuilder] Fix createSections
Dec 1 2021, 1:42 AM
shraiysh closed D114143: [OpenMP][IRBuilder] Fix createSections.
Dec 1 2021, 1:42 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D114143: [OpenMP][IRBuilder] Fix createSections.

Thanks for the review @Meinersbur . Rebase with main.

Dec 1 2021, 12:19 AM · Restricted Project, Restricted Project

Nov 30 2021

shraiysh added inline comments to D112982: [MLIR][OpenMP] Added omp.atomic.update.
Nov 30 2021, 4:02 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D112982: [MLIR][OpenMP] Added omp.atomic.update.

Addressed Comments.

Nov 30 2021, 4:02 AM · Restricted Project, Restricted Project
shraiysh added a comment to D112982: [MLIR][OpenMP] Added omp.atomic.update.

Thanks for the review @kiranchandramohan.

Nov 30 2021, 2:58 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D112982: [MLIR][OpenMP] Added omp.atomic.update.

Rebase with main

Nov 30 2021, 1:45 AM · Restricted Project, Restricted Project

Nov 26 2021

shraiysh updated the diff for D112982: [MLIR][OpenMP] Added omp.atomic.update.

Modified the other test case for shiftr too (missed in previous diff)

Nov 26 2021, 1:39 AM · Restricted Project, Restricted Project
shraiysh added inline comments to D112982: [MLIR][OpenMP] Added omp.atomic.update.
Nov 26 2021, 1:36 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D112982: [MLIR][OpenMP] Added omp.atomic.update.

Rebase with main, addressed comments

Nov 26 2021, 1:36 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D112982: [MLIR][OpenMP] Added omp.atomic.update.

Rebase with main. Addressed comments.

Nov 26 2021, 1:35 AM · Restricted Project, Restricted Project

Nov 24 2021

shraiysh added a comment to D114143: [OpenMP][IRBuilder] Fix createSections.

Ping!

Nov 24 2021, 7:34 PM · Restricted Project, Restricted Project

Nov 18 2021

shraiysh updated the diff for D112982: [MLIR][OpenMP] Added omp.atomic.update.

Changed argument name in comments and arguments. This is ready for review now.

Nov 18 2021, 10:36 PM · Restricted Project, Restricted Project
shraiysh updated the diff for D112982: [MLIR][OpenMP] Added omp.atomic.update.

Removed extra return in one test case (was added by mistake during rebase)

Nov 18 2021, 8:35 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D112982: [MLIR][OpenMP] Added omp.atomic.update.

Address comments and rebase with main

Nov 18 2021, 8:31 AM · Restricted Project, Restricted Project
shraiysh added reviewers for D114143: [OpenMP][IRBuilder] Fix createSections: kiranktp, kiranchandramohan, AMDChirag, NimishMishra, clementval, peixin, MatsPetersson, jeanPerier.
Nov 18 2021, 12:21 AM · Restricted Project, Restricted Project
shraiysh requested review of D114143: [OpenMP][IRBuilder] Fix createSections.
Nov 18 2021, 12:19 AM · Restricted Project, Restricted Project

Nov 7 2021

shraiysh added a comment to D112982: [MLIR][OpenMP] Added omp.atomic.update.

Thanks for the comments @peixin! I have tried to address them all, and will include the comments as mentioned if it is okay with you.

Nov 7 2021, 10:33 PM · Restricted Project, Restricted Project

Nov 6 2021

shraiysh committed rG19a7e4729da5: [MLIR][OpenMP] Added omp.sections and omp.section (authored by shraiysh).
[MLIR][OpenMP] Added omp.sections and omp.section
Nov 6 2021, 6:58 AM
shraiysh closed D110844: [MLIR][OpenMP] Added omp.sections and omp.section.
Nov 6 2021, 6:57 AM · Restricted Project
shraiysh updated the diff for D110844: [MLIR][OpenMP] Added omp.sections and omp.section.

Rebase with main

Nov 6 2021, 6:42 AM · Restricted Project

Nov 4 2021

shraiysh added a comment to D111051: [mlir][OpenMP] Add support for SIMD modifier.

Thanks for this patch. I have a few comments @Leporacanthicus.

Nov 4 2021, 10:37 PM · Restricted Project, Restricted Project

Nov 2 2021

shraiysh updated the diff for D110844: [MLIR][OpenMP] Added omp.sections and omp.section.

Addressed comments, rebase with main

Nov 2 2021, 1:12 AM · Restricted Project

Nov 1 2021

shraiysh retitled D112982: [MLIR][OpenMP] Added omp.atomic.update from [MLIR][OpenMP] Added omp.atomic.update This patch supports the atomic construct (update) following section 2.17.7 of OpenMP 5.0 standard. Also added tests and verifier for the same. to [MLIR][OpenMP] Added omp.atomic.update.
Nov 1 2021, 10:32 PM · Restricted Project, Restricted Project