Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

shraiysh (Shraiysh)
shraiysh

Projects

User does not belong to any projects.

User Details

User Since
Dec 24 2019, 1:39 AM (205 w, 12 h)

Compiler Engineer at AMD

Recent Activity

Sep 5 2023

shraiysh added a comment to D155765: [OpenMP Dialect] Add omp.canonical_loop operation..

Moved to https://github.com/llvm/llvm-project/pull/65380 because phabricator has been unresponsive lately (I have to hit reply multiple times before it sends one).

Sep 5 2023, 9:49 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh added a comment to D155765: [OpenMP Dialect] Add omp.canonical_loop operation..

There are two possible approaches for the unrolled operation here -

%unrolled1 = omp.unroll loops(%tiled) at(1)
%unrolled2 = omp.unroll loops(%tiled#1)

I realized that we cannot really do the first approach, because unroll could be present without nested loops. The nesting of openmp constructs could help with this. It might require complex indexing though. @kiranchandramohan do we have the details on loop-fission or the loop-modifiers for apply (like intratile)? I checked the technical report document here but it doesn't mention too much detail about these modifiers.

Sep 5 2023, 9:46 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh added a comment to D155765: [OpenMP Dialect] Add omp.canonical_loop operation..

There are two possible approaches for the unrolled operation here -

%unrolled1 = omp.unroll loops(%tiled) at(1)
%unrolled2 = omp.unroll loops(%tiled#1)
Sep 5 2023, 8:47 AM · Restricted Project, Restricted Project, Restricted Project

Aug 29 2023

shraiysh added a comment to D155765: [OpenMP Dialect] Add omp.canonical_loop operation..

I like @jsjodin's idea about nesting these. It avoids generating problematic IR like this

%cli1, %cli2, %cli3 = omp.canonical_loop ... {
  %cli2, %cli3 = omp.canonical_loop ... {
    %cli3 = omp.canonical_loop ... {
    }
    omp.yield(%cli3)
  }
  omp.yield(%cli2, %cli3)
}
%mergedcli = omp.collapse(%cli1, %cli3) // Problem here - collapsing innermost and outermost loops
Aug 29 2023, 11:27 AM · Restricted Project, Restricted Project, Restricted Project

Aug 28 2023

shraiysh updated the diff for D155765: [OpenMP Dialect] Add omp.canonical_loop operation..

Fix build by adding enums and attributes in CMakeLists.txt

Aug 28 2023, 11:01 PM · Restricted Project, Restricted Project, Restricted Project
shraiysh added reviewers for D155765: [OpenMP Dialect] Add omp.canonical_loop operation.: raghavendhra, dpalermo.
Aug 28 2023, 5:34 PM · Restricted Project, Restricted Project, Restricted Project
shraiysh updated the diff for D155765: [OpenMP Dialect] Add omp.canonical_loop operation..

Address comments and nits

Aug 28 2023, 5:29 PM · Restricted Project, Restricted Project, Restricted Project
shraiysh commandeered D155765: [OpenMP Dialect] Add omp.canonical_loop operation..

After discussing with Michael, I will be trying to implement this operation. @domada I have added an example of intended use in the operation with teams distribute construct. Hope it helps.

Aug 28 2023, 5:29 PM · Restricted Project, Restricted Project, Restricted Project
shraiysh added a comment to D158807: [Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause..

Please make sure that there are testcases for all the checks that have checkExclusiveLists.

Aug 28 2023, 8:53 AM · Restricted Project, Restricted Project
shraiysh abandoned D121583: [flang][OpenMP][WIP] Separate clause translation from directive translation.
Aug 28 2023, 6:53 AM · Restricted Project, Restricted Project
shraiysh added a comment to D121583: [flang][OpenMP][WIP] Separate clause translation from directive translation.

Thank you for working on this @skatrak. I will abandon this patch now.

Aug 28 2023, 6:52 AM · Restricted Project, Restricted Project

Aug 25 2023

shraiysh resigned from D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..
Aug 25 2023, 4:26 PM · Restricted Project, Restricted Project, Restricted Project
shraiysh added a comment to D155765: [OpenMP Dialect] Add omp.canonical_loop operation..

Hi @Meinersbur. Thank you for this patch. This looks like it would make the IR cleaner. It isn't clear to me how the loop info result of this operation is going to be used in the IR. Can you please elaborate on that? Also, an example of how it would look under omp.parallel would be helpful to understand.

Aug 25 2023, 7:15 AM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2023

shraiysh abandoned D126645: [flang] Remove non-constant folding for multiply.

Abandoning this.

Jul 13 2023, 2:08 PM · Restricted Project, Restricted Project

Apr 17 2023

shraiysh committed rG7021182d6b43: [nfc][llvm] Replace pointer cast functions in PointerUnion by llvm casting… (authored by shraiysh).
[nfc][llvm] Replace pointer cast functions in PointerUnion by llvm casting…
Apr 17 2023, 11:41 AM · Restricted Project, Restricted Project
shraiysh closed D148449: [nfc][llvm] Replace pointer cast functions in PointerUnion by llvm casting functions..
Apr 17 2023, 11:41 AM · Restricted Project, Restricted Project

Apr 16 2023

shraiysh added reviewers for D148449: [nfc][llvm] Replace pointer cast functions in PointerUnion by llvm casting functions.: mehdi_amini, 0x59616e, jrtc27.
Apr 16 2023, 11:25 AM · Restricted Project, Restricted Project

Apr 15 2023

shraiysh requested review of D148449: [nfc][llvm] Replace pointer cast functions in PointerUnion by llvm casting functions..
Apr 15 2023, 10:20 PM · Restricted Project, Restricted Project

Jan 17 2023

shraiysh added a comment to D141651: [OMPIRBuilder] Pass dependencies to createTask by value.

Please add a test case which would fail with the old implementation but passes with the new one.

Jan 17 2023, 7:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 13 2022

shraiysh added inline comments to D71989: [OpenMP][IRBuilder] `omp task` support.
Oct 13 2022, 11:29 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 22 2022

shraiysh committed rG95eb5109afa4: [OpenMP][IRBuilder] Added if clause to task (authored by shraiysh).
[OpenMP][IRBuilder] Added if clause to task
Sep 22 2022, 6:40 PM · Restricted Project, Restricted Project
shraiysh closed D130615: [OpenMP][IRBuilder] Added if clause to task.
Sep 22 2022, 6:40 PM · Restricted Project, Restricted Project
shraiysh updated the diff for D130615: [OpenMP][IRBuilder] Added if clause to task.

Rebase with main. Thanks for the review @raghavendhra.

Sep 22 2022, 6:38 PM · Restricted Project, Restricted Project
shraiysh added a comment to D130615: [OpenMP][IRBuilder] Added if clause to task.

Ping for review!

Sep 22 2022, 8:11 AM · Restricted Project, Restricted Project

Sep 15 2022

shraiysh added a comment to D133918: [flang][OpenMP] Lower OpenMP `taskgroup` construct.

Thanks for the patch @SouraVX. LGTM.

Sep 15 2022, 9:06 AM · Restricted Project, Restricted Project

Sep 13 2022

shraiysh added a comment to D130615: [OpenMP][IRBuilder] Added if clause to task.

Ping for review.

Sep 13 2022, 10:02 AM · Restricted Project, Restricted Project

Sep 4 2022

shraiysh updated the diff for D130615: [OpenMP][IRBuilder] Added if clause to task.

Rebase with main. Adressed comment.

Sep 4 2022, 10:49 AM · Restricted Project, Restricted Project

Aug 31 2022

shraiysh added inline comments to D127272: [flang][OpenMP] Lowering support for atomic capture.
Aug 31 2022, 9:19 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 30 2022

shraiysh committed rG80c1be8d147f: [mlir][OpenMP] Translation to LLVM IR for omp.taskgroup (authored by shraiysh).
[mlir][OpenMP] Translation to LLVM IR for omp.taskgroup
Aug 30 2022, 9:55 PM · Restricted Project, Restricted Project
shraiysh closed D130157: [mlir][OpenMP] Translation to LLVM IR for omp.taskgroup.
Aug 30 2022, 9:55 PM · Restricted Project, Restricted Project
shraiysh updated the diff for D130157: [mlir][OpenMP] Translation to LLVM IR for omp.taskgroup.

Addressed review comment.

Aug 30 2022, 9:38 PM · Restricted Project, Restricted Project
shraiysh updated the diff for D130157: [mlir][OpenMP] Translation to LLVM IR for omp.taskgroup.

Addressed review comment.

Aug 30 2022, 9:37 PM · Restricted Project, Restricted Project
shraiysh updated the diff for D130157: [mlir][OpenMP] Translation to LLVM IR for omp.taskgroup.

Rebase with main

Aug 30 2022, 9:35 PM · Restricted Project, Restricted Project
shraiysh added a comment to D130157: [mlir][OpenMP] Translation to LLVM IR for omp.taskgroup.

@shraiysh Possible to land this? If not, do let me know. I will land it on your behalf.

Aug 30 2022, 11:44 AM · Restricted Project, Restricted Project

Aug 25 2022

shraiysh added a comment to D127272: [flang][OpenMP] Lowering support for atomic capture.

Apologies for the delay in review. Please let me know what you think. I will join the next OpenMP call and we can maybe discuss this.

Aug 25 2022, 1:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 15 2022

shraiysh added inline comments to D131526: [OMPIRBuilder] Add support for safelen clause.
Aug 15 2022, 4:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 14 2022

shraiysh added a comment to D131526: [OMPIRBuilder] Add support for safelen clause.

Minor comments. Thank you for working on this!

Aug 14 2022, 7:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 13 2022

Herald added a reviewer for D130157: [mlir][OpenMP] Translation to LLVM IR for omp.taskgroup: dcaballe.

Ping for review.

Aug 13 2022, 11:47 PM · Restricted Project, Restricted Project

Aug 9 2022

shraiysh committed rGdd14d471a549: [mlir][OpenMP] omp.parallel side effects (authored by shraiysh).
[mlir][OpenMP] omp.parallel side effects
Aug 9 2022, 1:41 AM · Restricted Project, Restricted Project
shraiysh closed D130657: [mlir][OpenMP] omp.parallel side effects.
Aug 9 2022, 1:41 AM · Restricted Project, Restricted Project

Jul 29 2022

shraiysh added a comment to D125407: Prepare for inlining of SUM intrinsic.

LGTM, minor comments. Please let me know what you think!

Jul 29 2022, 1:50 AM · Restricted Project, Restricted Project

Jul 28 2022

shraiysh updated the diff for D130657: [mlir][OpenMP] omp.parallel side effects.

Removed NoSideEffect.

Jul 28 2022, 8:28 AM · Restricted Project, Restricted Project
shraiysh edited reviewers for D130704: [mlir][OpenMP] Translating if and final clauses for task construct, added: raghavendhra; removed: raghu.gandham.
Jul 28 2022, 5:25 AM · Restricted Project, Restricted Project
shraiysh added reviewers for D130704: [mlir][OpenMP] Translating if and final clauses for task construct: kiranktp, kiranchandramohan, NimishMishra, peixin, raghu.gandham, dpalermo, arnamoy10, Dominik_A.
Jul 28 2022, 5:24 AM · Restricted Project, Restricted Project
shraiysh requested review of D130704: [mlir][OpenMP] Translating if and final clauses for task construct.
Jul 28 2022, 5:23 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D130615: [OpenMP][IRBuilder] Added if clause to task.

Rebase with main

Jul 28 2022, 5:22 AM · Restricted Project, Restricted Project
shraiysh added inline comments to D130657: [mlir][OpenMP] omp.parallel side effects.
Jul 28 2022, 1:55 AM · Restricted Project, Restricted Project

Jul 27 2022

shraiysh added reviewers for D130657: [mlir][OpenMP] omp.parallel side effects: ftynse, kiranktp, kiranchandramohan, mehdi_amini, clementval, peixin.
Jul 27 2022, 8:00 PM · Restricted Project, Restricted Project
shraiysh requested review of D130657: [mlir][OpenMP] omp.parallel side effects.
Jul 27 2022, 12:24 PM · Restricted Project, Restricted Project
shraiysh added inline comments to D130027: [Flang][OpenMP] Add support for lastprivate clause for worksharing loop..
Jul 27 2022, 12:06 PM · Restricted Project, Restricted Project
shraiysh committed rG57ef6332597b: [mlir][OpenMP] Add omp.atomic.update canonicalization (authored by shraiysh).
[mlir][OpenMP] Add omp.atomic.update canonicalization
Jul 27 2022, 11:49 AM · Restricted Project, Restricted Project
shraiysh closed D126531: [mlir][OpenMP] Add omp.atomic.update canonicalization.
Jul 27 2022, 11:49 AM · Restricted Project, Restricted Project
shraiysh accepted D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.

LGTM.

Jul 27 2022, 8:09 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh added inline comments to D126531: [mlir][OpenMP] Add omp.atomic.update canonicalization.
Jul 27 2022, 4:41 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D126531: [mlir][OpenMP] Add omp.atomic.update canonicalization.

Addressed comments.

Jul 27 2022, 4:40 AM · Restricted Project, Restricted Project
shraiysh added inline comments to D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.
Jul 27 2022, 4:28 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh added a reviewer for D130615: [OpenMP][IRBuilder] Added if clause to task: Meinersbur.
Jul 27 2022, 1:06 AM · Restricted Project, Restricted Project
shraiysh added reviewers for D130615: [OpenMP][IRBuilder] Added if clause to task: kiranktp, kiranchandramohan, NimishMishra, peixin, arnamoy10, raghavendhra, dpalermo, MatsPetersson.
Jul 27 2022, 1:06 AM · Restricted Project, Restricted Project
shraiysh requested review of D130615: [OpenMP][IRBuilder] Added if clause to task.
Jul 27 2022, 1:05 AM · Restricted Project, Restricted Project

Jul 26 2022

shraiysh added a comment to D123930: [flang][OpenMP] Lowering support for default clause.

Could you fix the minor spelling nit and the comments from Peixin and then submit it with an approval from @shraiysh or @peixin today? (Don't wait for me)

Jul 26 2022, 7:54 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh added a comment to D123930: [flang][OpenMP] Lowering support for default clause.

I have reverted this change for now, we can discuss and add TODOs for the unhandled cases and then merge it.

Jul 26 2022, 6:55 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh reopened D123930: [flang][OpenMP] Lowering support for default clause.
Jul 26 2022, 6:50 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh added a reverting change for rG05e6fce84fd3: [flang][OpenMP] Lowering support for default clause: rGf2b7f18e6375: Revert "[flang][OpenMP] Lowering support for default clause".
Jul 26 2022, 6:49 AM · Restricted Project, Restricted Project
shraiysh committed rGf2b7f18e6375: Revert "[flang][OpenMP] Lowering support for default clause" (authored by shraiysh).
Revert "[flang][OpenMP] Lowering support for default clause"
Jul 26 2022, 6:49 AM · Restricted Project, Restricted Project
shraiysh added a reverting change for D123930: [flang][OpenMP] Lowering support for default clause: rGf2b7f18e6375: Revert "[flang][OpenMP] Lowering support for default clause".
Jul 26 2022, 6:49 AM · Restricted Project, Restricted Project, Restricted Project

Jul 25 2022

shraiysh added inline comments to D130077: [Flang][OpenMP] Initial support for integer reduction in worksharing-loop.
Jul 25 2022, 5:00 AM · Restricted Project, Restricted Project, Restricted Project

Jul 22 2022

shraiysh added a comment to D130077: [Flang][OpenMP] Initial support for integer reduction in worksharing-loop.

Just a thought - for the long run, would it make sense to have OpenMPConverter class inheriting from FirConverter and overriding some functions- like genFIR for OpenMP constructs and genFIR for assignment statement? IMO this would make the file more structured, while separating OpenMP and Fortran code. Right now, OpenMP.cpp is just a bunch of functions.

Jul 22 2022, 5:20 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh accepted D130343: [MLIR,OpenMP] : Add Conversion pattern for Critical Op.
Jul 22 2022, 4:56 AM · Restricted Project, Restricted Project

Jul 21 2022

shraiysh added a comment to D126531: [mlir][OpenMP] Add omp.atomic.update canonicalization.

Ping for review. (This is not urgent for the drop on July 26th, and patches related to those are high priority. This is just a gentle reminder, if anyone is willing to look into this patch. :) )

Jul 21 2022, 3:12 AM · Restricted Project, Restricted Project

Jul 20 2022

shraiysh committed rG61fa7a88c7b6: [clang][OpenMP] Add IRBuilder support for taskgroup (authored by shraiysh).
[clang][OpenMP] Add IRBuilder support for taskgroup
Jul 20 2022, 10:44 PM · Restricted Project, Restricted Project
shraiysh closed D129992: [clang][OpenMP] Add IRBuilder support for taskgroup.
Jul 20 2022, 10:44 PM · Restricted Project, Restricted Project
shraiysh updated the diff for D129992: [clang][OpenMP] Add IRBuilder support for taskgroup.

Rebase with main

Jul 20 2022, 10:23 PM · Restricted Project, Restricted Project
shraiysh added reviewers for D130157: [mlir][OpenMP] Translation to LLVM IR for omp.taskgroup: kiranktp, NimishMishra, peixin, kiranchandramohan, clementval, do, arnamoy10, raghavendhra, dpalermo.
Jul 20 2022, 3:05 AM · Restricted Project, Restricted Project
shraiysh requested review of D130157: [mlir][OpenMP] Translation to LLVM IR for omp.taskgroup.
Jul 20 2022, 3:04 AM · Restricted Project, Restricted Project

Jul 19 2022

shraiysh added a comment to D128203: [OpenMP][IRBuilder] Add support for taskgroup.

Nevermind, this has been fixed in https://github.com/llvm/llvm-project/commit/2c488a6b35c6d03e34fdd4e7ec87ed6bdc3d3010

Jul 19 2022, 7:09 AM · Restricted Project, Restricted Project
shraiysh added a comment to D128203: [OpenMP][IRBuilder] Add support for taskgroup.

The OpenMPIRBuilderTest.cpp test fails to build on AIX. https://lab.llvm.org/buildbot/#/builders/214/builds/2398/steps/6/logs/stdio Can you take a look please?

Jul 19 2022, 7:05 AM · Restricted Project, Restricted Project
shraiysh added a comment to D128203: [OpenMP][IRBuilder] Add support for taskgroup.

The OpenMPIRBuilderTest.cpp test fails to build on AIX. https://lab.llvm.org/buildbot/#/builders/214/builds/2398/steps/6/logs/stdio Can you take a look please?

Jul 19 2022, 7:02 AM · Restricted Project, Restricted Project

Jul 18 2022

shraiysh added inline comments to D129992: [clang][OpenMP] Add IRBuilder support for taskgroup.
Jul 18 2022, 10:46 PM · Restricted Project, Restricted Project
shraiysh updated the diff for D129992: [clang][OpenMP] Add IRBuilder support for taskgroup.

Moved checking to isSupportedByOpenMPIRBuilder.

Jul 18 2022, 10:46 PM · Restricted Project, Restricted Project
shraiysh committed rG35fc666877e0: [OpenMP][IRBuilder] Add support for taskgroup (authored by shraiysh).
[OpenMP][IRBuilder] Add support for taskgroup
Jul 18 2022, 10:20 PM · Restricted Project, Restricted Project
shraiysh closed D128203: [OpenMP][IRBuilder] Add support for taskgroup.
Jul 18 2022, 10:19 PM · Restricted Project, Restricted Project
shraiysh added reviewers for D129992: [clang][OpenMP] Add IRBuilder support for taskgroup: Meinersbur, peixin, kiranchandramohan, kiranktp, NimishMishra, clementval, raghavendhra, dpalermo.
Jul 18 2022, 2:48 AM · Restricted Project, Restricted Project
shraiysh requested review of D129992: [clang][OpenMP] Add IRBuilder support for taskgroup.
Jul 18 2022, 2:46 AM · Restricted Project, Restricted Project
shraiysh updated the diff for D128203: [OpenMP][IRBuilder] Add support for taskgroup.

Rebase with main

Jul 18 2022, 2:45 AM · Restricted Project, Restricted Project

Jul 14 2022

shraiysh added a comment to D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..

Any pointer to this presentation?

This was discussed today in the OpenMP work for llvm-flang call.

Jul 14 2022, 10:26 AM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2022

shraiysh added inline comments to D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Jul 12 2022, 12:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 11 2022

shraiysh added inline comments to D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Jul 11 2022, 9:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
shraiysh added a comment to D126531: [mlir][OpenMP] Add omp.atomic.update canonicalization.

Could you also check whether it is OK to accept atomic updates like the following?

func.func @update_unnecessary_computations(%arg0: memref<i32>) {
  %c0_i32 = arith.constant 0 : i32
  omp.atomic.update   %arg0 : memref<i32> {
  ^bb0(%arg1: i32):
    %0 = arith.cmpi ne, %arg1, %c0_i32 : i32
    %1 = arith.extui %0 : i1 to i32
    %2 = arith.addi %arg1, %1 : i32
    omp.yield(%2 : i32)
  }
  return
}
Jul 11 2022, 3:17 AM · Restricted Project, Restricted Project

Jul 10 2022

shraiysh added a reviewer for D126531: [mlir][OpenMP] Add omp.atomic.update canonicalization: clementval.
Jul 10 2022, 9:12 PM · Restricted Project, Restricted Project
shraiysh added a comment to D126531: [mlir][OpenMP] Add omp.atomic.update canonicalization.

Ping for review.

Jul 10 2022, 9:11 PM · Restricted Project, Restricted Project
shraiysh added inline comments to D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..
Jul 10 2022, 1:14 PM · Restricted Project, Restricted Project, Restricted Project

Jul 6 2022

shraiysh added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 6 2022, 6:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
shraiysh added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 6 2022, 1:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 5 2022

shraiysh added a comment to D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.

@shraiysh Do you plan to continue that work?

Not at the moment no. I am working on other tasks at the moment and might not be able to spend time on it for a couple weeks. If there is an urgent requirement, it's okay if someone else commandeers that revision - D121583.

Jul 5 2022, 4:36 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh accepted D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.

LGTM. Thank you!

Jul 5 2022, 3:34 AM · Restricted Project, Restricted Project, Restricted Project

Jul 4 2022

shraiysh accepted D128595: [flang][OpenMP] Fix the data race problem for firstprivate clause.
Jul 4 2022, 10:53 PM · Restricted Project, Restricted Project
shraiysh added a comment to D125668: [flang][OpenMP] Lowering support for atomic update construct.

The generated code in testcases looks good. Please wait for @peixin's approval for the code part, but functionality-wise this LGTM.

Jul 4 2022, 10:43 PM · Restricted Project, Restricted Project, Restricted Project
shraiysh committed rGfdf505f3f223: [mlir][OpenMP] omp.task translation to LLVM IR (authored by shraiysh).
[mlir][OpenMP] omp.task translation to LLVM IR
Jul 4 2022, 8:33 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh closed D123919: [mlir][OpenMP] omp.task translation to LLVM IR.
Jul 4 2022, 8:33 AM · Restricted Project, Restricted Project, Restricted Project
shraiysh added inline comments to D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.
Jul 4 2022, 12:30 AM · Restricted Project, Restricted Project, Restricted Project