This is an archive of the discontinued LLVM Phabricator instance.

[X86SchedSandyBridge] update cost of COPY to 1 cycle from 0
ClosedPublic

Authored by nickdesaulniers on Mar 23 2022, 2:00 PM.

Details

Summary

To match the cost of other scheduling models. This is expected to
schedule mov instructions around INLINEASM less frequently for the
default machineschedule (pre-RA scheduling).

Suggested by Craig Topper.

Link: https://github.com/llvm/llvm-project/issues/41914

Diff Detail

Event Timeline

nickdesaulniers requested review of this revision.Mar 23 2022, 2:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2022, 2:01 PM

I think this is a correct fix, most good X86Schedule*.td already do that.

Do we still need this one?

Do we still need this one?

Yes; I need to rebase and fix the newly failing test cases first though.

  • fix up tests
nickdesaulniers retitled this revision from [WIP][X86SchedSandyBridge] update cost of COPY to 1 cycle from 0 to [X86SchedSandyBridge] update cost of COPY to 1 cycle from 0.May 3 2022, 1:56 PM
nickdesaulniers edited the summary of this revision. (Show Details)
nickdesaulniers added a reviewer: lebedev.ri.
RKSimon accepted this revision.May 5 2022, 2:46 AM
RKSimon added a reviewer: RKSimon.
RKSimon added a subscriber: RKSimon.

LGTM - we should have this on all our current x86 models tbh

RKSimon accepted this revision.May 5 2022, 3:01 AM
This revision is now accepted and ready to land.May 5 2022, 3:01 AM
This revision was landed with ongoing or failed builds.May 5 2022, 11:14 AM
This revision was automatically updated to reflect the committed changes.