These have been replaced by hasCustomAssemblyFormat and hasVerifier
fields and aren't needed anymore.
Ops deriving from fir_IntegralSwitchTerminatorOp and region_Op are
not handled in this patch for ease of review.
Paths
| Differential D119776
[flang][mlir][NFC] Remove deprecated parser/printer/verifier utilities ClosedPublic Authored by shraiysh on Feb 14 2022, 1:50 PM.
Details Summary These have been replaced by hasCustomAssemblyFormat and hasVerifier Ops deriving from fir_IntegralSwitchTerminatorOp and region_Op are
Diff Detail
Event Timelineshraiysh added reviewers: kiranktp, NimishMishra, AMDChirag, clementval, rriddle, kiranchandramohan, peixin.Feb 14 2022, 2:29 PM Comment Actions Really nice, thanks!
This revision is now accepted and ready to land.Feb 14 2022, 9:20 PM Closed by commit rGcc120e36c31a: [flang][mlir][NFC] Remove deprecated parser/printer/verifier utilities (authored by shraiysh). · Explain WhyFeb 14 2022, 10:24 PM This revision was automatically updated to reflect the committed changes. Comment Actions Thanks for the patch @shraiysh! With the upstreaming going on we felt a bit behind on this kind of stuff. Comment Actions
No worries! It is a collective effort and it is understandable that they will sometimes be out-of-sync. Happy to help! :)
Revision Contents
Diff 408707 flang/include/flang/Optimizer/Dialect/FIROps.td
flang/lib/Optimizer/Dialect/FIROps.cpp
|
Can you drop the () here? (and a few others)