This is an archive of the discontinued LLVM Phabricator instance.

[flang][mlir][NFC] Remove deprecated parser/printer/verifier utilities
ClosedPublic

Authored by shraiysh on Feb 14 2022, 1:50 PM.

Details

Summary

These have been replaced by hasCustomAssemblyFormat and hasVerifier
fields and aren't needed anymore.

Ops deriving from fir_IntegralSwitchTerminatorOp and region_Op are
not handled in this patch for ease of review.

Diff Detail

Event Timeline

shraiysh created this revision.Feb 14 2022, 1:50 PM
shraiysh requested review of this revision.Feb 14 2022, 1:50 PM
shraiysh updated this revision to Diff 408604.Feb 14 2022, 1:51 PM

Remove commented code.

shraiysh updated this revision to Diff 408623.Feb 14 2022, 2:28 PM

Updated missed verifiers. This is ready for review now.

rriddle accepted this revision.Feb 14 2022, 9:20 PM

Really nice, thanks!

flang/lib/Optimizer/Dialect/FIROps.cpp
245

Can you drop the () here? (and a few others)

This revision is now accepted and ready to land.Feb 14 2022, 9:20 PM
shraiysh updated this revision to Diff 408706.Feb 14 2022, 10:09 PM

Addressed comment. Thanks for the review @rriddle.

Thanks for the patch @shraiysh! With the upstreaming going on we felt a bit behind on this kind of stuff.

Thanks for the patch @shraiysh! With the upstreaming going on we felt a bit behind on this kind of stuff.

No worries! It is a collective effort and it is understandable that they will sometimes be out-of-sync. Happy to help! :)