This is an archive of the discontinued LLVM Phabricator instance.

Differential D118895

[Modules] A utility to identify compilations that produce BMIs.
AbandonedPublicDraft

Authored by iains on Feb 3 2022, 6:14 AM.

Details

Reviewers
None
Summary

We want to be able to decide if a given compilation should emit a
BMI if an appropriate module line is found. We must not confuse
these cases with an implementation that implicitly pulls in its
respective interface.

Diff Detail

Event Timeline

iains created this revision.Feb 3 2022, 6:14 AM
iains added a child revision: D118896: [Modules] Allow outputing BMIs in the same job as other artefacts..Feb 3 2022, 6:20 AM
Harbormaster completed remote builds in B147373: Diff 405609.Feb 3 2022, 7:17 AM
iains mentioned this in D134267: [C++] [Modules] Support one phase compilation model for named modules.Oct 10 2022, 12:15 AM
iains updated this revision to Diff 536583.Jul 2 2023, 5:28 AM
iains retitled this revision from [Modules] Provide a way to differentiate Interface from Implementation. to [Modules] A utility to identify compilations that produce BMIs..
iains edited the summary of this revision. (Show Details)

rebased, updated the description to use BMI instead of CMI.

Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2023, 5:28 AM
Harbormaster completed remote builds in B242675: Diff 536583.Jul 2 2023, 5:55 AM
iains abandoned this revision.Oct 3 2023, 1:29 AM

this will be updated and moved to a pull request

Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2023, 1:29 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
include/
clang/
Sema/
6 lines

Diff 405609

clang/include/clang/Sema/Sema.h

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,246 Lines • ▼ Show 20 Linespublic:
} }
/// Make a merged definition of an existing hidden definition \p ND /// Make a merged definition of an existing hidden definition \p ND
/// visible at the specified location. /// visible at the specified location.
void makeMergedDefinitionVisible(NamedDecl *ND); void makeMergedDefinitionVisible(NamedDecl *ND);
bool isModuleVisible(const Module *M, bool ModulePrivate = false); bool isModuleVisible(const Module *M, bool ModulePrivate = false);
/// Determine if the current module scope is the implementation.
bool isModuleImplementation() const {
return ModuleScopes.empty() ? false
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    return ModuleScopes.empty() ? false
-                                : !ModuleScopes.back().ModuleInterface;
+    return ModuleScopes.empty() ? false : !ModuleScopes.back().ModuleInterface;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - return ModuleScopes.empty() ? false…
: !ModuleScopes.back().ModuleInterface;
}
// When loading a non-modular PCH files, this is used to restore module // When loading a non-modular PCH files, this is used to restore module
// visibility. // visibility.
void makeModuleVisible(Module *Mod, SourceLocation ImportLoc) { void makeModuleVisible(Module *Mod, SourceLocation ImportLoc) {
VisibleModules.setVisible(Mod, ImportLoc); VisibleModules.setVisible(Mod, ImportLoc);
} }
/// Determine whether a declaration is visible to name lookup. /// Determine whether a declaration is visible to name lookup.
bool isVisible(const NamedDecl *D) { bool isVisible(const NamedDecl *D) {
▲ Show 20 Lines • Show All 10,999 Lines • Show Last 20 Lines