Page MenuHomePhabricator
Differential D118487

[AArch64] Allow strict opcodes in indexed fmul and fma patterns
ClosedPublic
Actions

Authored by john.brawn on Jan 28 2022, 9:40 AM.

Details

Reviewers
t.p.northover
kpn
dmgreen
bsmith
Commits
rGb670da798d35: [AArch64] Allow strict opcodes in indexed fmul and fma patterns
Summary

Using an indexed version instead of a non-indexed version doesn't change anything with regards to exceptions or rounding.

Diff Detail

Event Timeline

john.brawn created this revision.Jan 28 2022, 9:40 AM
Herald added subscribers: arphaman, hiraditya, kristof.beyls. · View Herald TranscriptJan 28 2022, 9:40 AM
john.brawn requested review of this revision.Jan 28 2022, 9:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2022, 9:40 AM
Harbormaster completed remote builds in B146314: Diff 404058.Jan 28 2022, 9:42 AM
john.brawn mentioned this in D114946: [AArch64] Add instruction selection for strict FP.Jan 28 2022, 9:53 AM
john.brawn added a child revision: D115620: [AArch64] Lowering and legalization of strict FP16.Jan 31 2022, 2:42 AM
john.brawn added a parent revision: D114946: [AArch64] Add instruction selection for strict FP.
dmgreen accepted this revision.Feb 7 2022, 3:56 AM

Sounds OK, from what I can tell. LGTM

This revision is now accepted and ready to land.Feb 7 2022, 3:56 AM
This revision was landed with ongoing or failed builds.Feb 17 2022, 5:12 AM
Closed by commit rGb670da798d35: [AArch64] Allow strict opcodes in indexed fmul and fma patterns (authored by john.brawn). · Explain Why
This revision was automatically updated to reflect the committed changes.
john.brawn added a commit: rGb670da798d35: [AArch64] Allow strict opcodes in indexed fmul and fma patterns.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AArch64/
22 lines
test/
CodeGen/
AArch64/
84 lines
106 lines

Diff 409601

View Options

llvm/lib/Target/AArch64/AArch64InstrInfo.td

Loading...
View Options

llvm/test/CodeGen/AArch64/arm64-vmul.ll

Loading...
View Options

llvm/test/CodeGen/AArch64/neon-scalar-by-elem-fma.ll

Loading...