Page MenuHomePhabricator

john.brawn (John Brawn)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2015, 7:44 AM (423 w, 3 d)

Recent Activity

Thu, Mar 23

john.brawn added a comment to D144651: [Serialization] Place command line defines in the correct file.

Unfortunately I still can't reproduce this even using exactly the same cmake command as you gave. Looking at above cmake log some possible causes of difference are:

  • I'm doing this on an M1 macbook with host triple arm64-apple-darwin21.6.0 but the host triple on that bot is x86_64-apple-darwin20.6.0
  • I'm using python 3.9, bot is using python 3.10
  • I'm doing a build from clean whereas the bot is doing an incremental build
Thu, Mar 23, 2:06 PM · Restricted Project, Restricted Project, Restricted Project
john.brawn added a comment to D136675: [MachineCSE] Allow PRE of instructions that read physical registers.

Please let me know if you need any more details. :)

Thu, Mar 23, 10:28 AM · Restricted Project, Restricted Project

Wed, Mar 22

john.brawn added a comment to D144651: [Serialization] Place command line defines in the correct file.

According to git-bisect, this patch is causing the LLDB bots to crash.
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52690/console

(They were failing for other reasons before, which is why it took a while for this to be identified)

Clang is crashing with: Assertion failed: (0 && "Invalid SLocOffset or bad function choice"

In particular, this is true for the test lldb-api :: commands/expression/import_builtin_fileid/TestImportBuiltinFileID.py
I'm currently investigating the other failures reported by the bot, but we've also seen this assert fire internally in some other flows.

Wed, Mar 22, 10:48 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 20

john.brawn committed rG72073fc95cd4: [Serialization] Place command line defines in the correct file (authored by john.brawn).
[Serialization] Place command line defines in the correct file
Mon, Mar 20, 10:36 AM · Restricted Project, Restricted Project, Restricted Project
john.brawn closed D144651: [Serialization] Place command line defines in the correct file.
Mon, Mar 20, 10:36 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 15

john.brawn updated the diff for D145691: [libc++] Adjust tests using ext/* headers that undefine __DEPRECATED.

Remove only the generated tests, use -Wno-deprecated elsewhere.

Wed, Mar 15, 10:30 AM · Restricted Project, Restricted Project

Tue, Mar 14

john.brawn accepted D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK.

LGTM, with one minor nitpick.

Tue, Mar 14, 5:12 AM · Restricted Project, Restricted Project, Restricted Project
john.brawn added a comment to D144651: [Serialization] Place command line defines in the correct file.

Ping.

Tue, Mar 14, 3:15 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 13

john.brawn added inline comments to D144654: [Lex] Warn when defining or undefining any builtin macro.
Mon, Mar 13, 10:47 AM · Restricted Project, Restricted Project
john.brawn updated the diff for D145691: [libc++] Adjust tests using ext/* headers that undefine __DEPRECATED.

Changed to removing testing of the ext/* headers.

Mon, Mar 13, 7:55 AM · Restricted Project, Restricted Project

Thu, Mar 9

john.brawn added a comment to D144654: [Lex] Warn when defining or undefining any builtin macro.

D145691 should fix the libc++ CI failures.

Thu, Mar 9, 7:37 AM · Restricted Project, Restricted Project
john.brawn requested review of D145691: [libc++] Adjust tests using ext/* headers that undefine __DEPRECATED.
Thu, Mar 9, 7:34 AM · Restricted Project, Restricted Project

Wed, Mar 8

john.brawn updated the diff for D144654: [Lex] Warn when defining or undefining any builtin macro.

Add command line test and release note, and run clang-format.

Wed, Mar 8, 3:46 AM · Restricted Project, Restricted Project

Tue, Mar 7

john.brawn committed rG9b2895469bad: Use explicit target in clang/test/Preprocessor/directives_asm.S (authored by john.brawn).
Use explicit target in clang/test/Preprocessor/directives_asm.S
Tue, Mar 7, 10:08 AM · Restricted Project, Restricted Project
john.brawn committed rG128f7dac82ea: [Lex] Use line markers in preprocessed assembly predefines file (authored by john.brawn).
[Lex] Use line markers in preprocessed assembly predefines file
Tue, Mar 7, 8:21 AM · Restricted Project, Restricted Project
john.brawn closed D145397: [Lex] Use line markers in preprocessed assembly predefines file.
Tue, Mar 7, 8:21 AM · Restricted Project, Restricted Project
john.brawn updated the diff for D144651: [Serialization] Place command line defines in the correct file.

Ran clang-format.

Tue, Mar 7, 3:44 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 6

john.brawn added a comment to D144654: [Lex] Warn when defining or undefining any builtin macro.

This seems to cause precommit CI failures that should be addressed, and it should also have a release note about the fix.

Failures in CI should be fixed by D145397 and D144651. I'll also add a release note.

Mon, Mar 6, 9:20 AM · Restricted Project, Restricted Project
john.brawn updated the diff for D144651: [Serialization] Place command line defines in the correct file.

Fixed a couple of things causing failures in clangd tests (path being prepended in front of <command line>, and a bit of code assuming that command-line macros were builtin).

Mon, Mar 6, 9:16 AM · Restricted Project, Restricted Project, Restricted Project
john.brawn requested review of D145397: [Lex] Use line markers in preprocessed assembly predefines file.
Mon, Mar 6, 9:10 AM · Restricted Project, Restricted Project

Feb 23 2023

john.brawn requested review of D144654: [Lex] Warn when defining or undefining any builtin macro.
Feb 23 2023, 9:24 AM · Restricted Project, Restricted Project
john.brawn requested review of D144651: [Serialization] Place command line defines in the correct file.
Feb 23 2023, 9:06 AM · Restricted Project, Restricted Project, Restricted Project
john.brawn committed rG25d23b1970ea: [Clang][NFC] Remove pointless defines from test command lines (authored by john.brawn).
[Clang][NFC] Remove pointless defines from test command lines
Feb 23 2023, 8:22 AM · Restricted Project, Restricted Project

Feb 14 2023

john.brawn committed rG463fa25c34d6: [clang][NFC] Adjust tests to not un/define predefined macros (authored by john.brawn).
[clang][NFC] Adjust tests to not un/define predefined macros
Feb 14 2023, 6:04 AM · Restricted Project, Restricted Project

Feb 13 2023

john.brawn added a comment to D142989: [extract_symbols.py] Better handling of templates.

I noticed that llvm-nm has slightly different output for undefined symbols to GNU nm: GNU nm doesn't list value and size, llvm-nm list value and size zero. I've pushed a fix for that in https://reviews.llvm.org/rGe5d914672233, which may possibly also fix the AIX failure if AIX nm behaves in a similar way to llvm-nm.

Feb 13 2023, 11:54 AM · Restricted Project, Restricted Project
john.brawn committed rGe5d914672233: [extract_symbols.py] Be more permissive when examining nm output (authored by john.brawn).
[extract_symbols.py] Be more permissive when examining nm output
Feb 13 2023, 11:48 AM · Restricted Project, Restricted Project
john.brawn committed rG1edb04bc70f3: [extract_symbols.py] Adjust usage of nm again (authored by john.brawn).
[extract_symbols.py] Adjust usage of nm again
Feb 13 2023, 8:32 AM · Restricted Project, Restricted Project

Feb 10 2023

john.brawn added a comment to D142989: [extract_symbols.py] Better handling of templates.

I could reproduce the failure in PluginInlineAdvisorTest.PluginLoad to find _ZN4llvm13AllAnalysesOnINS_6ModuleEE6SetKeyE on Linux as well, when using a suitable build configuration. Fixed in
https://reviews.llvm.org/rG78f13ea093afdebcaa3b5c5690530b9217bbdfac on Linux, and hopefully also on AIX. I don't expect it to fix the failure to find _ZN4llvm15SmallVectorBaseIjE13mallocForGrowEPvmmRm though, so I'll try to figure out what's going on there also.

Feb 10 2023, 8:02 AM · Restricted Project, Restricted Project
john.brawn committed rG78f13ea093af: [extract_symbols.py] Adjust how the output of nm is interpreted (authored by john.brawn).
[extract_symbols.py] Adjust how the output of nm is interpreted
Feb 10 2023, 7:56 AM · Restricted Project, Restricted Project
john.brawn added a comment to D142989: [extract_symbols.py] Better handling of templates.

Hi, this caused some failures on AIX, could you take a look?

Feb 10 2023, 2:18 AM · Restricted Project, Restricted Project

Feb 6 2023

john.brawn committed rG5de5f66b984a: [extract_symbols.py] Better handling of templates (authored by john.brawn).
[extract_symbols.py] Better handling of templates
Feb 6 2023, 7:37 AM · Restricted Project, Restricted Project
john.brawn closed D142989: [extract_symbols.py] Better handling of templates.
Feb 6 2023, 7:36 AM · Restricted Project, Restricted Project

Feb 1 2023

john.brawn updated the diff for D142989: [extract_symbols.py] Better handling of templates.

Adjusted summary, removed superfluous \.

Feb 1 2023, 6:02 AM · Restricted Project, Restricted Project
john.brawn updated subscribers of D142989: [extract_symbols.py] Better handling of templates.

Could you add before/after figures of the numbers of symbols in, say, clang.symbols in the summary?

Feb 1 2023, 5:37 AM · Restricted Project, Restricted Project

Jan 31 2023

john.brawn requested review of D142989: [extract_symbols.py] Better handling of templates.
Jan 31 2023, 8:28 AM · Restricted Project, Restricted Project

Jan 26 2023

john.brawn accepted D142431: [extract_symbols.py] Filter out more symbols for MSVC.

LGTM

Jan 26 2023, 8:29 AM · Restricted Project, Restricted Project

Jan 25 2023

john.brawn added inline comments to D142431: [extract_symbols.py] Filter out more symbols for MSVC.
Jan 25 2023, 7:24 AM · Restricted Project, Restricted Project

Jan 18 2023

john.brawn added a comment to D141748: [WoA] Use fences for sequentially consistent stores/writes.

It looks like if MSVC is implementing sequentially-consistent atomic operations in the manner described then we will need to stores (but not loads) in the same way, so it looks like this patch is doing the right thing. Reasoning below:

Jan 18 2023, 8:29 AM · Restricted Project, Restricted Project

Nov 29 2022

john.brawn committed rG6b8900f7f91d: [clang][CodeGen] Add default attributes to __clang_call_terminate (authored by john.brawn).
[clang][CodeGen] Add default attributes to __clang_call_terminate
Nov 29 2022, 5:10 AM · Restricted Project, Restricted Project
john.brawn closed D138679: [clang][CodeGen] Add default attributes to __clang_call_terminate.
Nov 29 2022, 5:10 AM · Restricted Project, Restricted Project

Nov 24 2022

john.brawn requested review of D138679: [clang][CodeGen] Add default attributes to __clang_call_terminate.
Nov 24 2022, 8:57 AM · Restricted Project, Restricted Project

Nov 21 2022

john.brawn committed rG9e3264ab2021: [FPEnv] Enable strict fp for AArch64 in clang (authored by john.brawn).
[FPEnv] Enable strict fp for AArch64 in clang
Nov 21 2022, 8:03 AM · Restricted Project, Restricted Project
john.brawn closed D138143: [FPEnv] Enable strict fp for AArch64 in clang.
Nov 21 2022, 8:03 AM · Restricted Project, Restricted Project

Nov 18 2022

john.brawn added inline comments to D138143: [FPEnv] Enable strict fp for AArch64 in clang.
Nov 18 2022, 4:22 AM · Restricted Project, Restricted Project

Nov 17 2022

john.brawn added a comment to D137980: [ARM] Pretend atomics are always lock-free for small widths..

Looking at GCC it looks like there (for cortex-m0 at least) the behaviour is that loads and stores are generated inline, but more complex operations go to the atomic library calls (not the sync library calls). e.g. for

Nov 17 2022, 7:07 AM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2022

john.brawn requested review of D138143: [FPEnv] Enable strict fp for AArch64 in clang.
Nov 16 2022, 9:54 AM · Restricted Project, Restricted Project
john.brawn committed rG49510c50200c: [AArch64] Mark all instructions that read/write FPCR as doing so (authored by john.brawn).
[AArch64] Mark all instructions that read/write FPCR as doing so
Nov 16 2022, 4:30 AM · Restricted Project, Restricted Project
john.brawn closed D121929: [AArch64] Mark all instructions that read/write FPCR as doing so.
Nov 16 2022, 4:30 AM · Restricted Project, Restricted Project

Nov 14 2022

john.brawn added a comment to D121929: [AArch64] Mark all instructions that read/write FPCR as doing so.

Ping.

Nov 14 2022, 8:25 AM · Restricted Project, Restricted Project

Nov 3 2022

john.brawn updated the diff for D121929: [AArch64] Mark all instructions that read/write FPCR as doing so.

Rebased again.

Nov 3 2022, 9:01 AM · Restricted Project, Restricted Project

Nov 2 2022

john.brawn committed rG88ac25b357aa: [MachineCSE] Allow PRE of instructions that read physical registers (authored by john.brawn).
[MachineCSE] Allow PRE of instructions that read physical registers
Nov 2 2022, 6:54 AM · Restricted Project, Restricted Project
john.brawn committed rG2d8c1597e51c: [MIRVRegNamer] Avoid opcode hash collision (authored by john.brawn).
[MIRVRegNamer] Avoid opcode hash collision
Nov 2 2022, 6:54 AM · Restricted Project, Restricted Project
john.brawn closed D137155: [MIRVRegNamer] Avoid opcode hash collision.
Nov 2 2022, 6:53 AM · Restricted Project, Restricted Project
john.brawn closed D136675: [MachineCSE] Allow PRE of instructions that read physical registers.
Nov 2 2022, 6:53 AM · Restricted Project, Restricted Project
john.brawn added a comment to D137155: [MIRVRegNamer] Avoid opcode hash collision.

LGTM, Nice work John.

Would format_hex_no_prefix be replaceable with std::format once C++20 for LLVM drops?

Nov 2 2022, 6:19 AM · Restricted Project, Restricted Project

Nov 1 2022

john.brawn requested review of D137155: [MIRVRegNamer] Avoid opcode hash collision.
Nov 1 2022, 5:08 AM · Restricted Project, Restricted Project

Oct 31 2022

john.brawn updated the diff for D136675: [MachineCSE] Allow PRE of instructions that read physical registers.

Adjusted to find physical register uses and defs by iterating through all operands, as the defs list doesn't include implicit defs. Added a test based on the code in ffmpeg that was getting incorrectly optimised.

Oct 31 2022, 8:31 AM · Restricted Project, Restricted Project

Oct 28 2022

john.brawn reopened D136675: [MachineCSE] Allow PRE of instructions that read physical registers.

I've reverted. Looks like there's something going on with a flags-setting SUBS being hosted above a conditional branch.

Oct 28 2022, 6:41 AM · Restricted Project, Restricted Project
john.brawn added a reverting change for rG628467e53f4c: [MachineCSE] Allow PRE of instructions that read physical registers: rG7a7b36e96b94: Revert "[MachineCSE] Allow PRE of instructions that read physical registers".
Oct 28 2022, 6:40 AM · Restricted Project, Restricted Project
john.brawn committed rG7a7b36e96b94: Revert "[MachineCSE] Allow PRE of instructions that read physical registers" (authored by john.brawn).
Revert "[MachineCSE] Allow PRE of instructions that read physical registers"
Oct 28 2022, 6:40 AM · Restricted Project, Restricted Project
john.brawn added a reverting change for D136675: [MachineCSE] Allow PRE of instructions that read physical registers: rG7a7b36e96b94: Revert "[MachineCSE] Allow PRE of instructions that read physical registers".
Oct 28 2022, 6:40 AM · Restricted Project, Restricted Project

Oct 27 2022

john.brawn committed rG628467e53f4c: [MachineCSE] Allow PRE of instructions that read physical registers (authored by john.brawn).
[MachineCSE] Allow PRE of instructions that read physical registers
Oct 27 2022, 6:15 AM · Restricted Project, Restricted Project
john.brawn closed D136675: [MachineCSE] Allow PRE of instructions that read physical registers.
Oct 27 2022, 6:15 AM · Restricted Project, Restricted Project

Oct 25 2022

john.brawn updated the diff for D121929: [AArch64] Mark all instructions that read/write FPCR as doing so.

Rebased. Also adjust invalidateWindowsRegisterPairing to use encoded register numbers which should be more robust.

Oct 25 2022, 7:08 AM · Restricted Project, Restricted Project
john.brawn requested review of D136675: [MachineCSE] Allow PRE of instructions that read physical registers.
Oct 25 2022, 4:42 AM · Restricted Project, Restricted Project

Sep 6 2022

john.brawn committed rGe26cadcc32a2: [ARM] Constant pools need 4-byte alignment if we only have tADR (authored by john.brawn).
[ARM] Constant pools need 4-byte alignment if we only have tADR
Sep 6 2022, 3:36 AM · Restricted Project, Restricted Project
john.brawn closed D133199: [ARM] Constant pools need 4-byte alignment if we only have tADR.
Sep 6 2022, 3:36 AM · Restricted Project, Restricted Project

Sep 5 2022

john.brawn added a comment to D133199: [ARM] Constant pools need 4-byte alignment if we only have tADR.

the expansion of cttz to a table

Can you explain what that means?

Sep 5 2022, 4:12 AM · Restricted Project, Restricted Project

Sep 2 2022

john.brawn requested review of D133199: [ARM] Constant pools need 4-byte alignment if we only have tADR.
Sep 2 2022, 5:35 AM · Restricted Project, Restricted Project

Aug 8 2022

john.brawn added inline comments to D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math..
Aug 8 2022, 3:57 AM · Restricted Project, Restricted Project

Aug 5 2022

john.brawn accepted D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math..

LGTM

Aug 5 2022, 9:49 AM · Restricted Project, Restricted Project

Jul 11 2022

john.brawn committed rGddd9485129b5: [MVE] Don't distribute add of vecreduce if it has more than one use (authored by john.brawn).
[MVE] Don't distribute add of vecreduce if it has more than one use
Jul 11 2022, 6:14 AM · Restricted Project, Restricted Project
john.brawn closed D129361: [MVE] Don't distribute add of vecreduce if it has more than one use.
Jul 11 2022, 6:13 AM · Restricted Project, Restricted Project

Jul 8 2022

john.brawn added a comment to D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math..

Looking at the descriptions of maths functions in C99 (and I expect C11 will be the same) it looks like there are three kinds:

  • Those that can report error by errno and floating-point exeption, and may also raise the inexact exception
  • Those that don't set errno, but may raise the inexact exception
  • Those that neither set errno or raise an exception
Jul 8 2022, 8:07 AM · Restricted Project, Restricted Project
john.brawn edited reviewers for D129361: [MVE] Don't distribute add of vecreduce if it has more than one use, added: dmgreen; removed: greened.
Jul 8 2022, 4:12 AM · Restricted Project, Restricted Project
john.brawn requested review of D129361: [MVE] Don't distribute add of vecreduce if it has more than one use.
Jul 8 2022, 4:11 AM · Restricted Project, Restricted Project

May 19 2022

john.brawn accepted D125980: [AArch64] Fix the generation of BE Nops.

LGTM.

May 19 2022, 9:08 AM · Restricted Project, Restricted Project

May 18 2022

john.brawn accepted D125775: [ARM] Don't Enable AES Pass for Generic Cores.

LGTM.

May 18 2022, 4:55 AM · Restricted Project, Restricted Project, Restricted Project

May 6 2022

john.brawn committed rGf3a970a82552: [libc++] Mark tests that use check_assertion.h as requiring unix headers (authored by john.brawn).
[libc++] Mark tests that use check_assertion.h as requiring unix headers
May 6 2022, 3:04 AM · Restricted Project, Restricted Project
john.brawn closed D124623: [libc++] Mark tests that use check_assertion.h as requiring unix headers.
May 6 2022, 3:03 AM · Restricted Project, Restricted Project

May 3 2022

john.brawn updated the diff for D124623: [libc++] Mark tests that use check_assertion.h as requiring unix headers.

Also check for sys/wait.h, and rename the feature to has-unix-headers.

May 3 2022, 10:33 AM · Restricted Project, Restricted Project
john.brawn committed rGbd606afe26f2: [ARM] Only update the successor edges for immediate predecessors of PrologueMBB (authored by ZhiyaoMa98).
[ARM] Only update the successor edges for immediate predecessors of PrologueMBB
May 3 2022, 4:42 AM · Restricted Project, Restricted Project
john.brawn closed D122959: [ARM] Only update the successor edges for immediate predecessors of PrologueMBB..
May 3 2022, 4:42 AM · Restricted Project, Restricted Project
john.brawn accepted D122959: [ARM] Only update the successor edges for immediate predecessors of PrologueMBB..

Looks good, I'll commit this for you.

May 3 2022, 4:36 AM · Restricted Project, Restricted Project

Apr 28 2022

john.brawn requested review of D124623: [libc++] Mark tests that use check_assertion.h as requiring unix headers.
Apr 28 2022, 9:03 AM · Restricted Project, Restricted Project
john.brawn added a comment to D122959: [ARM] Only update the successor edges for immediate predecessors of PrologueMBB..

I would like to add a test, but I do not know how. My understanding is that I will need to create an example that PrologueMBB has non-immediate predecessors. Is there any example I can follow? Thanks!

Apr 28 2022, 8:29 AM · Restricted Project, Restricted Project
john.brawn abandoned D124255: [libc++] Make check_assertion.h use setjmp/longjmp instead of fork.

After doing some more experimentation I don't think it's possible to get this to work in all cases. If we make a copy of the closure then any containers in it will be copied, but copies of iterators will still point to the container outside of the closure copy, and this causes a bunch of tests to fail.

Apr 28 2022, 4:11 AM · Restricted Project, Restricted Project

Apr 26 2022

john.brawn planned changes to D124255: [libc++] Make check_assertion.h use setjmp/longjmp instead of fork.

This looks really interesting! However, doesn't that mean that we can't assert that the process terminates if a certain condition is met?

Apr 26 2022, 10:06 AM · Restricted Project, Restricted Project

Apr 22 2022

john.brawn updated subscribers of D124255: [libc++] Make check_assertion.h use setjmp/longjmp instead of fork.
Apr 22 2022, 6:00 AM · Restricted Project, Restricted Project
john.brawn requested review of D124255: [libc++] Make check_assertion.h use setjmp/longjmp instead of fork.
Apr 22 2022, 5:59 AM · Restricted Project, Restricted Project

Apr 14 2022

john.brawn committed rG27a8735a444f: [AArch64] Add mayRaiseFPException to appropriate instructions (authored by john.brawn).
[AArch64] Add mayRaiseFPException to appropriate instructions
Apr 14 2022, 8:52 AM · Restricted Project, Restricted Project
john.brawn committed rG12c1022679d4: [AArch64] Lowering and legalization of strict FP16 (authored by john.brawn).
[AArch64] Lowering and legalization of strict FP16
Apr 14 2022, 8:52 AM · Restricted Project, Restricted Project
john.brawn committed rG1b1466c34669: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL (authored by john.brawn).
[AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL
Apr 14 2022, 8:52 AM · Restricted Project, Restricted Project
john.brawn closed D115352: [AArch64] Add mayRaiseFPException to appropriate instructions.
Apr 14 2022, 8:52 AM · Restricted Project, Restricted Project
john.brawn closed D118259: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL.
Apr 14 2022, 8:52 AM · Restricted Project, Restricted Project
john.brawn closed D115620: [AArch64] Lowering and legalization of strict FP16.
Apr 14 2022, 8:51 AM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2022

john.brawn updated the diff for D118259: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL.

Also adjust aarch64-v8.2a-fp16-intrinsics-constrained.c in this patch (was previously done in
D115620) and remove the checks of the generated asm.

Apr 12 2022, 10:26 AM · Restricted Project, Restricted Project
john.brawn added inline comments to D115620: [AArch64] Lowering and legalization of strict FP16.
Apr 12 2022, 9:24 AM · Restricted Project, Restricted Project, Restricted Project
john.brawn updated the diff for D115620: [AArch64] Lowering and legalization of strict FP16.

Removed clang test changes.

Apr 12 2022, 9:13 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2022

john.brawn added a comment to D115620: [AArch64] Lowering and legalization of strict FP16.

Ping.

Apr 11 2022, 5:17 AM · Restricted Project, Restricted Project, Restricted Project