LGTM.

Fair enough.

On second though, looking at D94971, do you want to add a test to llvm/test/MC/AArch64/directive-arch_extension-negative.s?

LGTM.

This commit is causing the following

This also causes the AnnotateFunctions example to no longer build:

Abandoning as I've committed D89573.

Adjusted to give an error when the specified float abi is incompatible with the default. Was a bit trickier than I expected as it required extracting out the logic to determine the default into a separate function (we could instead emit the error in arm::getARMFloatABI but then it would be emitted several times as the function is called from several places).

D89573 is a fix for this by adjusting the triple. I'll abandon this if that gets accepted.

Clang treats C library calls the same as any other function calls when it comes to the calling convention, so they get a non-C calling convention in the same circumstances that other functions do.

LGTM.

LGTM.

LGTM (looks like the other example plugins just use PRIVATE as well).

This is causing libcxx test failures in AArch64 -O0. Reduced testcase (the inline asm ultimately comes from DoNotOptimize in libcxx/test/support/test_macros.h):

Don't print the diagnostic with -gen-reproducer.

It looks like this patch is causing incorrect code generation for

Print the bug report message when forcing a crash, but also have the message available even with LLVM_ENABLE_BACKTRACES=OFF.

Moved BugReportMsg printing into CrashRecoveryContext, and stopped printing of backtrace when forcing a crash.

Added a couple of reviewers that have recently worked on CrashRecoveryContext.

Changes look OK, though as I said before please add tests for this.

It look like there have been recent changes to BranchProbabilityInfo that mean this patch needs to be rebased.

Detect more kinds of local class.

Use the tag of the anonymous struct when emitting a diagnostic.

Adjusted to not give multiple errors when more than one error criteria is met.

Please add some tests for this to llvm/test/CodeGen/ARM/.

Could you add some tests (unless they're added in a later patch)?

Adjust comments. Also, after double-checking the 8-A and 8-M ARMARMs it's OK if the base register being stored is the lowest one so adjusted to allow that.

With this patch the Threading.PhysicalConcurrency unit test fails when run with an affinity less than the number of physical cpus. I've raised https://bugs.llvm.org/show_bug.cgi?id=45556.

Rebase.

Rebase and add adjust MVE masked load handling. Also make use of update_llc_checks - I tried it again and this time it did use a single CHECK when both little-endian and big-endian code generation are the same, so it looks like I was using it wrong somehow before (though I don't know in what way).

Do this in ARMTargetLowering::PerformDAGCombine

Release note added: https://reviews.llvm.org/rG0cff81cff05d

LGTM.

In D76514#1937042, @dmgreen wrote:

Would it make sense to do this as a DAG fold? That way we would get MVE for free too.

A few small changes:

• Don't start C++11 spelling with :: (changes to name normalisation to allow this are in D76704)
• Don't check that the Decl is null in diagAppertainsToDecl
• Return AttributeNotApplied on errors in handleDeclAttribute

Apply clang-format changes.

Use an enum for the return value.

Updated to match the changes to D31342

Adjust GEP handling to reduce AllocSize by Offset instead of using the result size.

Use the allocation size instead of the allocation type.