Page MenuHomePhabricator

[AArch64] Make machine combiner patterns preserve MIFlags
ClosedPublic

Authored by john.brawn on Jan 31 2022, 8:50 AM.

Details

Summary

This is mainly done so that we don't lose the nofpexcept flag once we start emitting it.

Diff Detail

Event Timeline

john.brawn created this revision.Jan 31 2022, 8:50 AM
john.brawn requested review of this revision.Jan 31 2022, 8:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2022, 8:50 AM
Matt added a subscriber: Matt.Jan 31 2022, 9:27 AM

Thanks for looking into this. Is the same or something similar needed in TargetInstrInfo::genAlternativeCodeSequence, for the commutative fp instructions?

john.brawn updated this revision to Diff 404952.Feb 1 2022, 8:49 AM

Also preserve flags in TargetInstrInfo::reassociateOps (which is called from TargetInstrInfo::genAlternativeCodeSequence).

dmgreen accepted this revision.Feb 2 2022, 11:14 AM

LGTM Thanks

This revision is now accepted and ready to land.Feb 2 2022, 11:14 AM