This is an archive of the discontinued LLVM Phabricator instance.

Apply clang-tidy fixes for llvm-header-guard in MLIR (NFC)
ClosedPublic

Authored by mehdi_amini on Jan 13 2022, 1:58 PM.

Diff Detail

Event Timeline

mehdi_amini created this revision.Jan 13 2022, 1:58 PM
mehdi_amini requested review of this revision.Jan 13 2022, 1:58 PM
rriddle accepted this revision.Jan 13 2022, 2:01 PM

Nice!

jpienaar accepted this revision.Jan 13 2022, 2:06 PM
This revision is now accepted and ready to land.Jan 13 2022, 2:06 PM
aartbik accepted this revision.Jan 13 2022, 2:17 PM
jsetoain added inline comments.
mlir/lib/Bindings/Python/Globals.h
9–10 ↗(On Diff #399782)

You've got some spillage over here (and several other files) :-)

mehdi_amini added inline comments.Jan 13 2022, 3:04 PM
mlir/lib/Bindings/Python/Globals.h
9–10 ↗(On Diff #399782)

Thanks for catching this, I need to look into what's wrong in the clang-tidy config (that may be a CMake thing instead?).

Seems like it is like this for all the files in lib/..

Limit the change to the public include directory

This revision was landed with ongoing or failed builds.Jan 13 2022, 3:14 PM
This revision was automatically updated to reflect the committed changes.
jsetoain added a comment.EditedJan 13 2022, 3:46 PM

Did you rename your LLVM source directory to something other than "llvm-project" (case sensitive)? That will mess up the bit of the code that figures out the guard name (check HeaderGuardCheck.cpp).