Page MenuHomePhabricator

arjunp (Arjun P)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2020, 9:41 PM (122 w, 3 d)

Recent Activity

Tue, Sep 20

arjunp added a comment to D134219: [mlir] Fix ambiguity when building with Clang 14.0.6.

Explicit conversion is almost always better than relying on hacks, especially the clever ones, that may not be obvious to anyone or even the author in retrospect. With the conversion, the comment isn't really necessary while adding the two-line comment to explain the hack defies the purpose of using the hack for brevity.

Tue, Sep 20, 2:31 AM · Restricted Project, Restricted Project

Mon, Sep 19

arjunp accepted D134219: [mlir] Fix ambiguity when building with Clang 14.0.6.
Mon, Sep 19, 1:11 PM · Restricted Project, Restricted Project

Thu, Sep 15

arjunp committed rGedd173201c52: [MLIR][Presburger] clarify why -0 is used instead of 0 (NFC) (authored by arjunp).
[MLIR][Presburger] clarify why -0 is used instead of 0 (NFC)
Thu, Sep 15, 5:24 AM · Restricted Project, Restricted Project
arjunp accepted D133937: [mlir] Remove the unused source file..
Thu, Sep 15, 5:17 AM · Restricted Project, Restricted Project
arjunp accepted D133654: [MLIR][Presburger] Improve unittest parsing.

Ah right, I should have read more carefully.

Thu, Sep 15, 4:07 AM · Restricted Project, Restricted Project
arjunp added inline comments to D133654: [MLIR][Presburger] Improve unittest parsing.
Thu, Sep 15, 3:53 AM · Restricted Project, Restricted Project
arjunp added inline comments to D133654: [MLIR][Presburger] Improve unittest parsing.
Thu, Sep 15, 3:05 AM · Restricted Project, Restricted Project

Wed, Sep 14

arjunp requested changes to D133654: [MLIR][Presburger] Improve unittest parsing.
Wed, Sep 14, 8:32 AM · Restricted Project, Restricted Project
arjunp accepted D133654: [MLIR][Presburger] Improve unittest parsing.
Wed, Sep 14, 8:30 AM · Restricted Project, Restricted Project
arjunp accepted D133510: [MLIR][Presburger] Add hermite normal form computation to Matrix.
Wed, Sep 14, 7:53 AM · Restricted Project, Restricted Project
arjunp committed rG6d6f6c4d3f40: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of… (authored by arjunp).
[MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of…
Wed, Sep 14, 7:47 AM · Restricted Project, Restricted Project
arjunp closed D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.
Wed, Sep 14, 7:47 AM · Restricted Project, Restricted Project
arjunp added a comment to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Uday, Alex, Kunwar, thanks for your reviews!

Wed, Sep 14, 7:46 AM · Restricted Project, Restricted Project
arjunp updated the diff for D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Rebase.

Wed, Sep 14, 7:11 AM · Restricted Project, Restricted Project
arjunp added inline comments to D133510: [MLIR][Presburger] Add hermite normal form computation to Matrix.
Wed, Sep 14, 7:09 AM · Restricted Project, Restricted Project

Sat, Sep 10

arjunp accepted D131864: [MLIR][Presburger] Refactor MultiAffineFunction to be defined over universe.
Sat, Sep 10, 2:35 PM · Restricted Project, Restricted Project

Fri, Sep 9

arjunp added inline comments to D133510: [MLIR][Presburger] Add hermite normal form computation to Matrix.
Fri, Sep 9, 5:11 AM · Restricted Project, Restricted Project

Thu, Sep 8

arjunp added a comment to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Thanks for clarifying. This part from the commit summary still seems confusing to me - trying to understand this better. Did 18a06d4f3a7474d062d1fe7d405813ed2e40b4fc improve perf of this pass from 0.80s to 0.76s? But at 18a06d4f3a7474d062d1fe7d405813ed2e40b4fc, I assume simplify-affine-structures didn't use any MPInt based stuff (or did it) in which case 18a06d4f3a7474d062d1fe7d405813ed2e40b4fc shouldn't have impacted it?

The performance impact of this has been tested by checking test runtimes after copy-pasting 100 copies of each function. Affine/simplify-structures.mlir goes from 0.76s to 0.80s after this patch. Its performance sees no regression compared to its original performance at commit 18a06d4f3a7474d062d1fe7d405813ed2e40b4fc before a series of patches that I landed to offset the performance overhead of switching to arbitrary precision.
Thu, Sep 8, 9:34 AM · Restricted Project, Restricted Project

Aug 23 2022

arjunp updated the summary of D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.
Aug 23 2022, 11:29 AM · Restricted Project, Restricted Project
arjunp updated the summary of D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.
Aug 23 2022, 11:27 AM · Restricted Project, Restricted Project
arjunp added a comment to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Thanks for digging into this. removeTrivialRedundancy is expected to only perform really trivial checks -- I just verified, and it doesn't (and shouldn't) depend on the Presburger library. So your changes here should have nil impact on -simplify-affine-structures. I now looked at changes above again, and you've modified removeTrivialRedundancy to use MPInt (switched from int64) although this method doesn't in any way depend on the Presburger library. I'm pretty sure the change causes a significant impact on that method alone (which is reflecting as a small overall slowdown on the pass that exercises many things). Do we need MPInt for removeTrivialRedundancy? (It only does divisions and normalization.) I'm concerned by this impact to a trivial method that is used on several paths where speed is deserved. Should we be templating the method to allow MPInt and int64 (have both versions) and use the latter almost everywhere?

The above impact also goes against the commit summary that only the Presburger library has been changed -- the change to removeTrivialRedundancy impacts things in affine analysis completely unrelated to and non-dependent on the Presburger library.

Aug 23 2022, 11:26 AM · Restricted Project, Restricted Project

Aug 22 2022

arjunp added a comment to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Can you better capture in the commit summary what the changes are and the rationale?

Reg. the increase from 0.76s to 0.80s for simplify-affine-structures, I'm trying to under why there is an impact at all? Is the slowdown reproducible or an error in measurement? (If the run was multithreaded, consider timing with -mlir-disable-threading to get more reproducible runs.)

There is an impact associated with switching from plain unsafe int64_ts. For example, after this patch whenever we perform integer operations, we check whether overflow occurs and, if it does, switch to arbitrary precision. This adds some overhead.

Right - I'm trying to understand/recall which part of simplify-affine-structures is using the Presburger library.

Aug 22 2022, 6:13 AM · Restricted Project, Restricted Project
arjunp added a comment to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

I spent quite a bit of time performance tuning this implementation. Also, I tuned the rest of the library a little bit more to offset some of the impact. But there is some non-zero impact in going from the unsafe 64-bit to overflow-checked arithmetic with fallback to arbitrary precision.

Aug 22 2022, 6:07 AM · Restricted Project, Restricted Project
arjunp added a comment to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Can you better capture in the commit summary what the changes are and the rationale?

Reg. the increase from 0.76s to 0.80s for simplify-affine-structures, I'm trying to under why there is an impact at all? Is the slowdown reproducible or an error in measurement? (If the run was multithreaded, consider timing with -mlir-disable-threading to get more reproducible runs.)

Aug 22 2022, 5:37 AM · Restricted Project, Restricted Project

Aug 20 2022

arjunp added inline comments to D131864: [MLIR][Presburger] Refactor MultiAffineFunction to be defined over universe.
Aug 20 2022, 9:14 AM · Restricted Project, Restricted Project

Aug 11 2022

arjunp added a comment to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

@ftynse @bondhugula do you have any further comments on this patch? :)

Aug 11 2022, 6:00 AM · Restricted Project, Restricted Project

Aug 8 2022

arjunp updated the diff for D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Slightly improve test.

Aug 8 2022, 6:53 AM · Restricted Project, Restricted Project
arjunp updated the diff for D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Rebase to fix build.

Aug 8 2022, 6:50 AM · Restricted Project, Restricted Project
arjunp committed rGdc07d2c91dfd: [MLIR][Presburger] make sample test with integer lexmin use containsPointNoLocal (authored by arjunp).
[MLIR][Presburger] make sample test with integer lexmin use containsPointNoLocal
Aug 8 2022, 6:46 AM · Restricted Project, Restricted Project

Aug 5 2022

arjunp updated the diff for D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Add test case to test emptiness checks and integer lexmin.

Aug 5 2022, 8:22 AM · Restricted Project, Restricted Project

Aug 4 2022

arjunp added a comment to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Updated the summary with some performance statistics.

Aug 4 2022, 12:54 PM · Restricted Project, Restricted Project
arjunp updated the diff for D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Rebase.

Aug 4 2022, 12:46 PM · Restricted Project, Restricted Project
arjunp updated the summary of D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.
Aug 4 2022, 12:43 PM · Restricted Project, Restricted Project
arjunp updated the summary of D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.
Aug 4 2022, 12:42 PM · Restricted Project, Restricted Project
arjunp committed rG1486a2eaf0bd: [MLIR][Presburger] SlowMPInt::gcd: fix crash when sizes differ (authored by arjunp).
[MLIR][Presburger] SlowMPInt::gcd: fix crash when sizes differ
Aug 4 2022, 11:16 AM · Restricted Project, Restricted Project
arjunp closed D131186: [MLIR][Presburger] SlowMPInt::gcd: fix crash when sizes differ.
Aug 4 2022, 11:15 AM · Restricted Project, Restricted Project
arjunp committed rGbad95b72eed0: [MLIR][Presburger] fourier-motzkin: check if all LCMs are 1 using a bool… (authored by arjunp).
[MLIR][Presburger] fourier-motzkin: check if all LCMs are 1 using a bool…
Aug 4 2022, 11:14 AM · Restricted Project, Restricted Project
arjunp closed D131184: [MLIR][Presburger] fourier-motzkin: check if all LCMs are 1 using a bool instead of by multiplying them.
Aug 4 2022, 11:14 AM · Restricted Project, Restricted Project
arjunp requested review of D131186: [MLIR][Presburger] SlowMPInt::gcd: fix crash when sizes differ.
Aug 4 2022, 11:01 AM · Restricted Project, Restricted Project
arjunp updated the summary of D131184: [MLIR][Presburger] fourier-motzkin: check if all LCMs are 1 using a bool instead of by multiplying them.
Aug 4 2022, 10:50 AM · Restricted Project, Restricted Project
arjunp updated the summary of D131184: [MLIR][Presburger] fourier-motzkin: check if all LCMs are 1 using a bool instead of by multiplying them.
Aug 4 2022, 10:48 AM · Restricted Project, Restricted Project
arjunp requested review of D131184: [MLIR][Presburger] fourier-motzkin: check if all LCMs are 1 using a bool instead of by multiplying them.
Aug 4 2022, 10:47 AM · Restricted Project, Restricted Project
arjunp added inline comments to D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.
Aug 4 2022, 10:05 AM · Restricted Project, Restricted Project

Aug 3 2022

arjunp accepted D131060: [mlir] Fix Analysis/Presburger/Utils.cpp compilation with GCC 11.

Please clang-format before landing.

Aug 3 2022, 2:30 AM · Restricted Project, Restricted Project

Jul 19 2022

arjunp added inline comments to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.
Jul 19 2022, 3:51 PM · Restricted Project, Restricted Project
arjunp updated the diff for D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Address the inline comments; test cases to be added soon

Jul 19 2022, 3:50 PM · Restricted Project, Restricted Project

Jul 18 2022

arjunp committed rG477c2c6f4a5a: [MLIR][Presburger] fix warning under g++ (NFC) (authored by arjunp).
[MLIR][Presburger] fix warning under g++ (NFC)
Jul 18 2022, 10:02 AM · Restricted Project, Restricted Project
arjunp updated the diff for D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Format.

Jul 18 2022, 9:40 AM · Restricted Project, Restricted Project
arjunp updated the diff for D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Rebase.

Jul 18 2022, 9:38 AM · Restricted Project, Restricted Project
arjunp committed rGffb8b7b2a0b9: [MLIR][Presburger] Provide functions to convert between arrays of MPInt and… (authored by arjunp).
[MLIR][Presburger] Provide functions to convert between arrays of MPInt and…
Jul 18 2022, 9:35 AM · Restricted Project, Restricted Project
arjunp closed D129509: [MLIR][Presburger] Provide functions to convert between arrays of MPInt and int64_t.
Jul 18 2022, 9:34 AM · Restricted Project, Restricted Project
arjunp committed rGca6a5afbb285: [MLIR][Presburger] SlowMPInt: fix bug in ceilDiv, floorDiv where widths weren't… (authored by arjunp).
[MLIR][Presburger] SlowMPInt: fix bug in ceilDiv, floorDiv where widths weren't…
Jul 18 2022, 9:34 AM · Restricted Project, Restricted Project
arjunp closed D129816: [MLIR][Presburger] SlowMPInt: fix bug in ceilDiv, floorDiv where widths weren't harmonized.
Jul 18 2022, 9:34 AM · Restricted Project, Restricted Project

Jul 15 2022

arjunp added a comment to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

For classes other than IntegerRelation, I don't think the public API should have int64_t methods. They should be MPInt only. Can you please change this?

Jul 15 2022, 11:18 AM · Restricted Project, Restricted Project
arjunp updated the diff for D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.
  • address kunwar's comment
Jul 15 2022, 11:17 AM · Restricted Project, Restricted Project
arjunp updated the diff for D129509: [MLIR][Presburger] Provide functions to convert between arrays of MPInt and int64_t.

Rebase.

Jul 15 2022, 9:32 AM · Restricted Project, Restricted Project
arjunp committed rG821fe9efa483: [MLIR][Presburger] reintroduce int64_t versions of floorDiv, ceilDiv in mlir… (authored by arjunp).
[MLIR][Presburger] reintroduce int64_t versions of floorDiv, ceilDiv in mlir…
Jul 15 2022, 9:29 AM · Restricted Project, Restricted Project
arjunp closed D129820: [MLIR][Presburger] reintroduce int64_t versions of floorDiv, ceilDiv in mlir::presburger namespace.
Jul 15 2022, 9:29 AM · Restricted Project, Restricted Project
arjunp committed rG9390b8d34ce3: [MLIR][Presburger] MPInt: add missing fastpath in ceilDiv (authored by arjunp).
[MLIR][Presburger] MPInt: add missing fastpath in ceilDiv
Jul 15 2022, 9:27 AM · Restricted Project, Restricted Project
arjunp closed D129815: [MLIR][Presburger] MPInt: add missing fastpath in ceilDiv.
Jul 15 2022, 9:26 AM · Restricted Project, Restricted Project
arjunp updated the diff for D129816: [MLIR][Presburger] SlowMPInt: fix bug in ceilDiv, floorDiv where widths weren't harmonized.

Address kunwar's comment

Jul 15 2022, 9:24 AM · Restricted Project, Restricted Project
arjunp committed rG86d73c11cff6: [MLIR][Presburger] SlowMPInt: gcd: assert that operands are non-negative (authored by arjunp).
[MLIR][Presburger] SlowMPInt: gcd: assert that operands are non-negative
Jul 15 2022, 7:50 AM · Restricted Project, Restricted Project
arjunp committed rGec5f18e38afa: [MLIR][Presburger] MPInt: gcd: assert that operands are non-negative (authored by arjunp).
[MLIR][Presburger] MPInt: gcd: assert that operands are non-negative
Jul 15 2022, 6:14 AM · Restricted Project, Restricted Project

Jul 14 2022

arjunp requested review of D129820: [MLIR][Presburger] reintroduce int64_t versions of floorDiv, ceilDiv in mlir::presburger namespace.
Jul 14 2022, 4:41 PM · Restricted Project, Restricted Project
arjunp committed rGd6fbe1394f77: [MLIR][Presburger] MPInt: use /// for top-level comment, not // (NFC) (authored by arjunp).
[MLIR][Presburger] MPInt: use /// for top-level comment, not // (NFC)
Jul 14 2022, 4:30 PM · Restricted Project, Restricted Project
arjunp requested review of D129816: [MLIR][Presburger] SlowMPInt: fix bug in ceilDiv, floorDiv where widths weren't harmonized.
Jul 14 2022, 4:16 PM · Restricted Project, Restricted Project
arjunp requested review of D129815: [MLIR][Presburger] MPInt: add missing fastpath in ceilDiv.
Jul 14 2022, 4:16 PM · Restricted Project, Restricted Project

Jul 11 2022

arjunp added a comment to D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.

It should be fixed already: https://lab.llvm.org/buildbot/#/builders/172/builds/14775

Jul 11 2022, 6:03 PM · Restricted Project, Restricted Project
arjunp added a reviewer for D129171: [mlir][affine] Option to unroll cleanup loop if smaller trip count.: Groverkss.
Jul 11 2022, 3:38 PM · Restricted Project, Restricted Project
arjunp requested review of D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.
Jul 11 2022, 12:13 PM · Restricted Project, Restricted Project
arjunp requested review of D129509: [MLIR][Presburger] Provide functions to convert between arrays of MPInt and int64_t.
Jul 11 2022, 12:09 PM · Restricted Project, Restricted Project
arjunp committed rGcdbc5f1e10d0: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in… (authored by arjunp).
[MLIR][Presburger] introduce MPInt to support fast arbitrary precision in…
Jul 11 2022, 7:47 AM · Restricted Project, Restricted Project
arjunp committed rG1e10d35ea9c0: Revert "[MLIR][Presburger] introduce MPInt to support fast arbitrary precision… (authored by arjunp).
Revert "[MLIR][Presburger] introduce MPInt to support fast arbitrary precision…
Jul 11 2022, 6:26 AM · Restricted Project, Restricted Project
arjunp added a reverting change for rGc9035df2fad4: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in…: rG1e10d35ea9c0: Revert "[MLIR][Presburger] introduce MPInt to support fast arbitrary precision….
Jul 11 2022, 6:26 AM · Restricted Project, Restricted Project
arjunp added a reverting change for D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger: rG1e10d35ea9c0: Revert "[MLIR][Presburger] introduce MPInt to support fast arbitrary precision….
Jul 11 2022, 6:26 AM · Restricted Project, Restricted Project
arjunp added a comment to D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.

Taking a look.

Jul 11 2022, 6:12 AM · Restricted Project, Restricted Project
arjunp committed rGc9035df2fad4: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in… (authored by arjunp).
[MLIR][Presburger] introduce MPInt to support fast arbitrary precision in…
Jul 11 2022, 3:41 AM · Restricted Project, Restricted Project
arjunp closed D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.
Jul 11 2022, 3:41 AM · Restricted Project, Restricted Project
arjunp added inline comments to D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.
Jul 11 2022, 3:32 AM · Restricted Project, Restricted Project

Jul 7 2022

arjunp accepted D129146: [MLIR][Presburger] Refactor division representation to DivisionRepr.
Jul 7 2022, 6:48 AM · Restricted Project, Restricted Project

Jul 6 2022

arjunp added inline comments to D129146: [MLIR][Presburger] Refactor division representation to DivisionRepr.
Jul 6 2022, 8:56 AM · Restricted Project, Restricted Project
arjunp accepted D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jul 6 2022, 8:06 AM · Restricted Project, Restricted Project
arjunp added inline comments to D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jul 6 2022, 8:03 AM · Restricted Project, Restricted Project
arjunp added inline comments to D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jul 6 2022, 7:38 AM · Restricted Project, Restricted Project
arjunp added inline comments to D129146: [MLIR][Presburger] Refactor division representation to DivisionRepr.
Jul 6 2022, 7:24 AM · Restricted Project, Restricted Project
arjunp added a comment to D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.

Can you write a little bit more detailed explanations for the complex test cases?

Jul 6 2022, 7:02 AM · Restricted Project, Restricted Project
arjunp updated the diff for D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.
  • really fix comment
Jul 6 2022, 5:08 AM · Restricted Project, Restricted Project
arjunp updated the diff for D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.

I accidentally pushed an outdated diff. Revert to diff 441903.

Jul 6 2022, 5:07 AM · Restricted Project, Restricted Project
arjunp updated the diff for D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.

fix comment

Jul 6 2022, 5:04 AM · Restricted Project, Restricted Project

Jul 4 2022

arjunp added inline comments to D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jul 4 2022, 10:12 AM · Restricted Project, Restricted Project

Jul 3 2022

arjunp accepted D128751: [MLIR][Presburger] Rename attachments to identifiers in PresburgerSpace.

SGTM

Jul 3 2022, 2:29 PM · Restricted Project, Restricted Project
arjunp added inline comments to D128751: [MLIR][Presburger] Rename attachments to identifiers in PresburgerSpace.
Jul 3 2022, 11:43 AM · Restricted Project, Restricted Project
arjunp updated the summary of D128751: [MLIR][Presburger] Rename attachments to identifiers in PresburgerSpace.
Jul 3 2022, 11:37 AM · Restricted Project, Restricted Project
arjunp added inline comments to D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jul 3 2022, 10:24 AM · Restricted Project, Restricted Project

Jul 2 2022

arjunp updated the diff for D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.
  • format
Jul 2 2022, 1:18 PM · Restricted Project, Restricted Project
arjunp added inline comments to D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jul 2 2022, 1:13 PM · Restricted Project, Restricted Project
arjunp updated the diff for D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.
  • improve assert error
Jul 2 2022, 12:48 PM · Restricted Project, Restricted Project

Jul 1 2022

arjunp updated the diff for D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.

fix typo

Jul 1 2022, 1:02 PM · Restricted Project, Restricted Project
arjunp updated the diff for D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.

Use LLVM_ATTRIBUTE_ALWAYS_INLINE instead of attributes directly.

Jul 1 2022, 10:31 AM · Restricted Project, Restricted Project
arjunp committed rGc4abef28a3bd: [MLIR][Presburger] support symbolicLexMin for IntegerRelation (authored by arjunp).
[MLIR][Presburger] support symbolicLexMin for IntegerRelation
Jul 1 2022, 10:00 AM · Restricted Project, Restricted Project