Page MenuHomePhabricator

arjunp (Arjun P)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2020, 9:41 PM (68 w, 3 d)

Recent Activity

Today

arjunp added a comment to D110138: [MLIR] PresburgerSet: support divisions in operations.

Thanks for the review!

Tue, Sep 21, 6:40 AM · Restricted Project
arjunp updated the diff for D110138: [MLIR] PresburgerSet: support divisions in operations.

Improve documentation and incorporate Kunwar's suggestions.

Tue, Sep 21, 6:39 AM · Restricted Project
arjunp updated the diff for D110138: [MLIR] PresburgerSet: support divisions in operations.

Update documentation again.

Tue, Sep 21, 2:18 AM · Restricted Project
arjunp updated the diff for D110138: [MLIR] PresburgerSet: support divisions in operations.

Update documentation.

Tue, Sep 21, 2:14 AM · Restricted Project
arjunp requested review of D110138: [MLIR] PresburgerSet: support divisions in operations.
Tue, Sep 21, 2:09 AM · Restricted Project
arjunp committed rG0d12c99191de: [MLIR] Add mergeLocalIds and mergeSymbolIds (authored by Groverkss).
[MLIR] Add mergeLocalIds and mergeSymbolIds
Tue, Sep 21, 12:33 AM
arjunp closed D110045: [MLIR] Add mergeLocalIds and mergeSymbolIds.
Tue, Sep 21, 12:33 AM · Restricted Project

Yesterday

arjunp added a comment to D109962: [MLIR] Simplex: support adding new variables dynamically.

Thanks for the review!

Mon, Sep 20, 12:47 AM · Restricted Project
arjunp committed rG76cb876563d0: [MLIR] Simplex::appendVariable: early return if count == 0 (authored by arjunp).
[MLIR] Simplex::appendVariable: early return if count == 0
Mon, Sep 20, 12:47 AM

Sat, Sep 18

arjunp added inline comments to D109955: [MLIR] Generalize Affine dependence analysis using Affine Relations.
Sat, Sep 18, 10:43 AM · Restricted Project
arjunp committed rG33afea548892: [MLIR] Simplex: rename num{Variables,Constraints} to getNum{Variables… (authored by arjunp).
[MLIR] Simplex: rename num{Variables,Constraints} to getNum{Variables…
Sat, Sep 18, 10:10 AM
arjunp committed rG2b44a7325c56: [MLIR] Simplex: support adding new variables dynamically (authored by arjunp).
[MLIR] Simplex: support adding new variables dynamically
Sat, Sep 18, 9:02 AM
arjunp closed D109962: [MLIR] Simplex: support adding new variables dynamically.
Sat, Sep 18, 9:02 AM · Restricted Project
arjunp added a comment to D109962: [MLIR] Simplex: support adding new variables dynamically.

Thanks for the review!

Sat, Sep 18, 3:37 AM · Restricted Project
arjunp updated the diff for D109962: [MLIR] Simplex: support adding new variables dynamically.

Address Kunwar's comments.

Sat, Sep 18, 3:35 AM · Restricted Project

Fri, Sep 17

arjunp updated the diff for D109962: [MLIR] Simplex: support adding new variables dynamically.

Fix a bug.

Fri, Sep 17, 6:11 AM · Restricted Project
arjunp requested review of D109962: [MLIR] Simplex: support adding new variables dynamically.
Fri, Sep 17, 5:58 AM · Restricted Project
arjunp committed rG58719f61535e: [MLIR] PresbugerSet: slightly expand documentation (authored by arjunp).
[MLIR] PresbugerSet: slightly expand documentation
Fri, Sep 17, 5:35 AM
arjunp committed rG44db07f11f00: [MLIR] AffineStructures: support removing a range of constraints at once (authored by arjunp).
[MLIR] AffineStructures: support removing a range of constraints at once
Fri, Sep 17, 3:58 AM
arjunp closed D109892: [MLIR] AffineStructures: support removing a range of constraints at once.
Fri, Sep 17, 3:58 AM · Restricted Project
arjunp committed rG6607bd9fd819: [MLIR] AffineStructures::removeIdRange: support specifying a range within an… (authored by arjunp).
[MLIR] AffineStructures::removeIdRange: support specifying a range within an…
Fri, Sep 17, 3:55 AM
arjunp closed D109896: [MLIR] AffineStructures::removeIdRange: support specifying a range within an IdKind.
Fri, Sep 17, 3:55 AM · Restricted Project
arjunp committed rGf263ea157113: [MLIR] Matrix: support resizing horizontally (authored by arjunp).
[MLIR] Matrix: support resizing horizontally
Fri, Sep 17, 3:52 AM
arjunp closed D109897: [MLIR] Matrix: support resizing horizontally.
Fri, Sep 17, 3:52 AM · Restricted Project
arjunp updated the diff for D109897: [MLIR] Matrix: support resizing horizontally.

Add support for resizing just horizontally

Fri, Sep 17, 3:51 AM · Restricted Project
arjunp updated the diff for D109897: [MLIR] Matrix: support resizing horizontally.

Add support for resizing just horizontally

Fri, Sep 17, 12:45 AM · Restricted Project

Thu, Sep 16

arjunp updated the diff for D109892: [MLIR] AffineStructures: support removing a range of constraints at once.

If begin >= end just return, in line with the behaviour of removeIdRange.

Thu, Sep 16, 12:28 PM · Restricted Project
arjunp added a comment to D109896: [MLIR] AffineStructures::removeIdRange: support specifying a range within an IdKind.

Thanks for the review!

Thu, Sep 16, 12:25 PM · Restricted Project
arjunp updated the diff for D109896: [MLIR] AffineStructures::removeIdRange: support specifying a range within an IdKind.

Address Kunwar's comments.

Thu, Sep 16, 12:24 PM · Restricted Project
arjunp updated the diff for D109892: [MLIR] AffineStructures: support removing a range of constraints at once.

Address Kunwar's comments.

Thu, Sep 16, 11:53 AM · Restricted Project
arjunp requested review of D109897: [MLIR] Matrix: support resizing horizontally.
Thu, Sep 16, 9:08 AM · Restricted Project
arjunp updated the diff for D109892: [MLIR] AffineStructures: support removing a range of constraints at once.

Add a comment.

Thu, Sep 16, 8:57 AM · Restricted Project
arjunp requested review of D109896: [MLIR] AffineStructures::removeIdRange: support specifying a range within an IdKind.
Thu, Sep 16, 8:55 AM · Restricted Project
arjunp requested review of D109892: [MLIR] AffineStructures: support removing a range of constraints at once.
Thu, Sep 16, 8:33 AM · Restricted Project
arjunp abandoned D109238: [MLIR] PresburgerSet: support divisions in subtract, intersect, and equality checks.

Splitting this into mutliple patches.

Thu, Sep 16, 8:32 AM · Restricted Project

Wed, Sep 8

arjunp committed rGdea76ccaf40f: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation… (authored by Groverkss).
[MLIR] FlatAffineConstraints: Refactored computation of explicit representation…
Wed, Sep 8, 7:55 AM
arjunp closed D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
Wed, Sep 8, 7:55 AM · Restricted Project

Sat, Sep 4

arjunp added a comment to D109238: [MLIR] PresburgerSet: support divisions in subtract, intersect, and equality checks.

Personally, I believe that the removeId overload where the identifier kind is not specified should not be public. I think the interface should only be on a per-kind basis rather than exposing the implementation detail of the ordering among kinds. The build failure occurs in LoopUtils.cpp.

Sat, Sep 4, 7:55 AM · Restricted Project
arjunp updated the diff for D109238: [MLIR] PresburgerSet: support divisions in subtract, intersect, and equality checks.

Fix build by making removeId overload with unspecified kind public.

Sat, Sep 4, 7:50 AM · Restricted Project

Fri, Sep 3

arjunp updated the diff for D109238: [MLIR] PresburgerSet: support divisions in subtract, intersect, and equality checks.

Fixed typo.

Fri, Sep 3, 10:33 AM · Restricted Project
arjunp requested review of D109238: [MLIR] PresburgerSet: support divisions in subtract, intersect, and equality checks.
Fri, Sep 3, 9:01 AM · Restricted Project

Thu, Sep 2

arjunp added inline comments to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
Thu, Sep 2, 8:23 AM · Restricted Project

Tue, Aug 24

arjunp accepted D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Seems good to me. Let's also wait to see if @bondhugula or @vinayaka-polymage have any additional comments.

Tue, Aug 24, 2:08 AM · Restricted Project

Aug 4 2021

arjunp added a comment to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Looks good to me, please resolve the clang-format issues though.

Aug 4 2021, 7:49 AM · Restricted Project

Aug 2 2021

arjunp committed rG7eeaa782c430: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being… (authored by Groverkss).
[MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being…
Aug 2 2021, 5:24 AM
arjunp closed D107214: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being detected.
Aug 2 2021, 5:24 AM · Restricted Project

Jul 31 2021

arjunp added a comment to D107214: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being detected.

Thanks for the patch! Please fix the clang-format errors. Other than that, this seems good to me. Let's wait for one of the others to take a look as well.

Jul 31 2021, 8:52 AM · Restricted Project

Jul 29 2021

arjunp added inline comments to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
Jul 29 2021, 8:29 AM · Restricted Project

Jul 26 2021

arjunp added inline comments to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
Jul 26 2021, 5:58 AM · Restricted Project
arjunp added inline comments to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
Jul 26 2021, 5:52 AM · Restricted Project

Jul 23 2021

arjunp requested changes to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
Jul 23 2021, 8:17 AM · Restricted Project
arjunp added a comment to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Thanks for the patch!

Jul 23 2021, 8:16 AM · Restricted Project

Jul 19 2021

arjunp abandoned D106268: [MLIR] AffineStructures: resolve clang-tidy warnings [NFC].

Okay, I've pushed the changes directly.

Jul 19 2021, 6:16 AM · Restricted Project
arjunp committed rGeacbd7d25ae0: [MLIR] AffineStructures: resolve clang-tidy warnings [NFC] (authored by arjunp).
[MLIR] AffineStructures: resolve clang-tidy warnings [NFC]
Jul 19 2021, 6:16 AM
arjunp retitled D106268: [MLIR] AffineStructures: resolve clang-tidy warnings [NFC] from [MLIR] AffineStructures: resolve clang-tidy warnings [NFL] to [MLIR] AffineStructures: resolve clang-tidy warnings [NFC].
Jul 19 2021, 5:54 AM · Restricted Project
arjunp requested review of D106268: [MLIR] AffineStructures: resolve clang-tidy warnings [NFC].
Jul 19 2021, 5:54 AM · Restricted Project

Jul 16 2021

arjunp added inline comments to D106145: [MLIR] FlatAffineConstraints : Store explicit division representation for local identifiers.
Jul 16 2021, 7:54 AM · Restricted Project
arjunp added a comment to D106145: [MLIR] FlatAffineConstraints : Store explicit division representation for local identifiers.

Thanks for the patch!

Jul 16 2021, 7:23 AM · Restricted Project

Jul 1 2021

arjunp committed rGc605dfcfc0c1: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints (authored by arjunp).
[MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints
Jul 1 2021, 9:35 AM
arjunp closed D105152: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints.
Jul 1 2021, 9:35 AM · Restricted Project
arjunp updated the summary of D105152: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints.
Jul 1 2021, 7:46 AM · Restricted Project
arjunp updated the diff for D105152: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints.

Added regression tests for the bugs in the patch I fixed.

Jul 1 2021, 7:44 AM · Restricted Project
arjunp updated the diff for D105152: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints.

Fixed another bug, the tests should pass now.

Jul 1 2021, 7:16 AM · Restricted Project
arjunp added a comment to D105152: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints.

Thanks for the quick review!

Jul 1 2021, 6:39 AM · Restricted Project
arjunp updated the diff for D105152: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints.

Addressed review comments and fixed some bugs.

Jul 1 2021, 6:37 AM · Restricted Project

Jun 30 2021

arjunp retitled D105152: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints from [MLIR] FlatAffineConstraints: Use Marix objects to store the constraints to [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints.
Jun 30 2021, 1:16 AM · Restricted Project

Jun 29 2021

arjunp added inline comments to D105152: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints.
Jun 29 2021, 2:33 PM · Restricted Project
arjunp updated the diff for D105152: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints.

This patch is not expected to change any functionality, it's just some simplification in preparation for future work.

Jun 29 2021, 2:32 PM · Restricted Project
arjunp added reviewers for D105152: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints: ftynse, bondhugula, andydavis1.
Jun 29 2021, 2:28 PM · Restricted Project
arjunp requested review of D105152: [MLIR] FlatAffineConstraints: Use Matrix objects to store the constraints.
Jun 29 2021, 2:25 PM · Restricted Project

May 31 2021

arjunp committed rG73b759a33a9c: [MLIR] Add dialect prefix to all operations from Math (authored by andidr).
[MLIR] Add dialect prefix to all operations from Math
May 31 2021, 10:30 AM
arjunp closed D103248: [MLIR] Add dialect prefix to all operations from Math.
May 31 2021, 10:29 AM · Restricted Project
arjunp committed rGe4034881c353: [MLIR] Specify namespace for standard dialect using cppNamespace field (authored by andidr).
[MLIR] Specify namespace for standard dialect using cppNamespace field
May 31 2021, 10:14 AM
arjunp closed D103234: [MLIR] Specify namespace for standard dialect using cppNamespace field.
May 31 2021, 10:13 AM · Restricted Project

Apr 13 2021

arjunp committed rGeff067440e78: [MLIR] PresburgerSet subtraction: add documentation and assertion saying we… (authored by arjunp).
[MLIR] PresburgerSet subtraction: add documentation and assertion saying we…
Apr 13 2021, 5:27 PM
arjunp closed D100324: [MLIR] PresburgerSet subtraction: add documentation and assertion saying we don't support divisions yet.
Apr 13 2021, 5:26 PM · Restricted Project

Apr 12 2021

arjunp committed rG7f9e36b209dd: [MLIR] PresburgerSet emptiness check: remove assertions that there are no… (authored by arjunp).
[MLIR] PresburgerSet emptiness check: remove assertions that there are no…
Apr 12 2021, 10:41 AM
arjunp closed D100327: [MLIR] PresburgerSet emptiness check: remove assertions that there are no symbols.
Apr 12 2021, 10:41 AM · Restricted Project
arjunp retitled D100324: [MLIR] PresburgerSet subtraction: add documentation and assertion saying we don't support divisions yet from [MLIR] PrebsurgerSet subtraction: add documentation and assertion saying we don't support divisions yet to [MLIR] PresburgerSet subtraction: add documentation and assertion saying we don't support divisions yet.
Apr 12 2021, 10:38 AM · Restricted Project
arjunp requested review of D100327: [MLIR] PresburgerSet emptiness check: remove assertions that there are no symbols.
Apr 12 2021, 10:32 AM · Restricted Project
arjunp requested review of D100324: [MLIR] PresburgerSet subtraction: add documentation and assertion saying we don't support divisions yet.
Apr 12 2021, 10:27 AM · Restricted Project

Apr 8 2021

arjunp committed rG2690d4d45a63: [MLIR] Support symbols in emptiness checks for FlatAffineConstraints (authored by arjunp).
[MLIR] Support symbols in emptiness checks for FlatAffineConstraints
Apr 8 2021, 9:09 AM
arjunp closed D100114: [MLIR] Support symbols in emptiness checks for FlatAffineConstraints.
Apr 8 2021, 9:08 AM · Restricted Project
arjunp updated the diff for D100114: [MLIR] Support symbols in emptiness checks for FlatAffineConstraints.

Fixed the unit test to actually EXPECT_ the expected result.

Apr 8 2021, 8:30 AM · Restricted Project
arjunp added reviewers for D100114: [MLIR] Support symbols in emptiness checks for FlatAffineConstraints: andydavis1, bondhugula.
Apr 8 2021, 8:15 AM · Restricted Project
arjunp requested review of D100114: [MLIR] Support symbols in emptiness checks for FlatAffineConstraints.
Apr 8 2021, 8:12 AM · Restricted Project

Jan 22 2021

arjunp committed rG14056dfb4dc7: [MLIR] Add support for extracting an integer sample point (if one exists) from… (authored by arjunp).
[MLIR] Add support for extracting an integer sample point (if one exists) from…
Jan 22 2021, 8:59 AM
arjunp closed D95047: [MLIR] Add support for extracting an integer sample point (if one exists) from an unbounded FlatAffineConstraints..
Jan 22 2021, 8:59 AM · Restricted Project
arjunp added inline comments to D95047: [MLIR] Add support for extracting an integer sample point (if one exists) from an unbounded FlatAffineConstraints..
Jan 22 2021, 7:35 AM · Restricted Project
arjunp updated the diff for D95047: [MLIR] Add support for extracting an integer sample point (if one exists) from an unbounded FlatAffineConstraints..

Addressed Alex's comments.

Jan 22 2021, 7:35 AM · Restricted Project

Jan 21 2021

arjunp updated the diff for D95047: [MLIR] Add support for extracting an integer sample point (if one exists) from an unbounded FlatAffineConstraints..

Address another comment

Jan 21 2021, 2:28 PM · Restricted Project
arjunp updated the diff for D95047: [MLIR] Add support for extracting an integer sample point (if one exists) from an unbounded FlatAffineConstraints..

Addressed most of Siddharth's comments.

Jan 21 2021, 2:23 PM · Restricted Project

Jan 20 2021

arjunp requested review of D95047: [MLIR] Add support for extracting an integer sample point (if one exists) from an unbounded FlatAffineConstraints..
Jan 20 2021, 7:06 AM · Restricted Project

Jan 18 2021

arjunp committed rGfa9851ebfee4: [MLIR] NFC: simplify PresburgerSet::isEqual (authored by arjunp).
[MLIR] NFC: simplify PresburgerSet::isEqual
Jan 18 2021, 9:17 AM
arjunp closed D94918: [MLIR] NFC: simplify PresburgerSet::isEqual.
Jan 18 2021, 9:17 AM · Restricted Project
arjunp added a comment to D94918: [MLIR] NFC: simplify PresburgerSet::isEqual.

It's unclear to me, does something like this need pre-commit review?

Jan 18 2021, 8:46 AM · Restricted Project
arjunp requested review of D94918: [MLIR] NFC: simplify PresburgerSet::isEqual.
Jan 18 2021, 8:44 AM · Restricted Project
arjunp committed rG9f32f1d6fbfa: [MLIR] Support checking if two FlatAffineConstraints are equal (authored by arjunp).
[MLIR] Support checking if two FlatAffineConstraints are equal
Jan 18 2021, 8:16 AM
arjunp closed D94915: [MLIR] Support checking if two FlatAffineConstraints are equal.
Jan 18 2021, 8:16 AM · Restricted Project
arjunp updated the diff for D94915: [MLIR] Support checking if two FlatAffineConstraints are equal.

Addressed Alex's comment.

Jan 18 2021, 7:31 AM · Restricted Project