This is an archive of the discontinued LLVM Phabricator instance.

[LV] Make sure prefer-predicate-over-epilogue works for short TC loops
Needs ReviewPublic

Authored by ebrevnov on Dec 14 2021, 1:37 AM.

Details

Summary

Currently "short trip count" heuristic overrides user settings of PreferPredicateOverEpilogue and llvm.loop.vectorize.predicate.enable. That doesn't seem right for several reasons. Typically user settings are expected to override compiler chosen heuristics. Another reason is surprising difference in behavior for "known" short trip count loops and all other cases.

PS: This change is exploited in https://reviews.llvm.org/D115713 to be able to keep testing coverage.

Diff Detail

Event Timeline

ebrevnov created this revision.Dec 14 2021, 1:37 AM
ebrevnov requested review of this revision.Dec 14 2021, 1:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2021, 1:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2022, 7:24 AM
lebedev.ri resigned from this revision.Jan 12 2023, 5:31 PM

This review may be stuck/dead, consider abandoning if no longer relevant.
Removing myself as reviewer in attempt to clean dashboard.

nikic resigned from this revision.Jan 20 2023, 12:33 PM

(not familiar with LV)