Page MenuHomePhabricator

Quote some more destination paths with variables
ClosedPublic

Authored by Ericson2314 on Dec 10 2021, 6:00 PM.

Details

Reviewers
jdoerfert
ldionne
Group Reviewers
Restricted Project
Commits
rGddcc02dbcc47: Quote some more destination paths with variables
Summary

Just defensive CMake-ing. I pulled this from D115544 and D99484 which
are blocked on some lldb CI failures I don't yet understand. Hoping to land
something smaller in the meantime.

Diff Detail

Unit TestsFailed

TimeTest
120 msx64 windows > Clangd Unit Tests._/ClangdTests_exe::IncludeFixerTest.IncompleteEnum
Script: -- C:\ws\w9\llvm-project\premerge-checks\build\tools\clang\tools\extra\clangd\unittests\.\ClangdTests.exe --gtest_filter=IncludeFixerTest.IncompleteEnum

Event Timeline

Ericson2314 created this revision.Dec 10 2021, 6:00 PM
Ericson2314 requested review of this revision.Dec 10 2021, 6:00 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptDec 10 2021, 6:00 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
  1. Updating D115566: Quote some more destination paths with variables #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

Find some more

Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
ldionne accepted this revision.Dec 13 2021, 6:46 AM
ldionne added a subscriber: ldionne.

This looks reasonable to me.

This revision is now accepted and ready to land.Dec 13 2021, 6:46 AM
This revision was landed with ongoing or failed builds.Dec 13 2021, 9:29 AM
This revision was automatically updated to reflect the committed changes.