Page MenuHomePhabricator

Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""
ClosedPublic

Authored by Ericson2314 on Dec 10 2021, 11:26 AM.

Details

Summary

This reverts commit 797b50d4be873b4662983413a06806fca544c276.

See the original D99484. @mib who noticed the original problem could not longer
reproduce it, after I tried and also failed. We are threfore hoping it went
away on its own!

Diff Detail

Event Timeline

Ericson2314 created this revision.Dec 10 2021, 11:26 AM
Ericson2314 requested review of this revision.Dec 10 2021, 11:26 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptDec 10 2021, 11:27 AM
mib accepted this revision.Dec 10 2021, 11:32 AM
This revision is now accepted and ready to land.Dec 10 2021, 11:32 AM
Ericson2314 added a comment.EditedDec 10 2021, 12:47 PM

This pre-merge build failure is in the ASAN tests and thus seems entirely unrelated, so I cam going to land this is and watch careful as instructed.

Nevermind , there is a conflict?

Oh, just can't do arc land from rebase.

This revision was landed with ongoing or failed builds.Dec 10 2021, 12:59 PM
This revision was automatically updated to reflect the committed changes.

I see a build failure in https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ and think I know how to fix it.

Sorry for this new build failure. I think I found the culprit and fixed it with https://reviews.llvm.org/D115553