This is an archive of the discontinued LLVM Phabricator instance.

[fir] Add fir numeric intrinsic runtime call builder
ClosedPublic

Authored by clementval on Nov 23 2021, 2:45 PM.

Details

Summary

This patch adds the FIR builder to generate the numeric intrinsic
runtime call.

This patch is part of the upstreaming effort from fir-dev branch.

Co-authored-by: Jean Perier <jperier@nvidia.com>
Co-authored-by: mleair <leairmark@gmail.com>

Diff Detail

Event Timeline

clementval created this revision.Nov 23 2021, 2:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2021, 2:45 PM
clementval requested review of this revision.Nov 23 2021, 2:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2021, 2:45 PM

Rebase on top of D114557

rovka added inline comments.Nov 26 2021, 5:04 AM
flang/lib/Optimizer/Builder/Runtime/Numeric.cpp
286

Nit: Some places use TODO, some use fir::emitFatalError. Should we settle on just one of them?

flang/unittests/Optimizer/Builder/Runtime/NumericTest.cpp
56

Can we also check the SelectOp and CmpFOp?

clementval marked 2 inline comments as done.

Address review comments

flang/lib/Optimizer/Builder/Runtime/Numeric.cpp
286

I switched to fir::emitFatalError where it was a TODO.

rovka accepted this revision.Dec 1 2021, 6:52 PM

Thanks, LGTM

This revision is now accepted and ready to land.Dec 1 2021, 6:52 PM
This revision was landed with ongoing or failed builds.Dec 2 2021, 1:22 AM
This revision was automatically updated to reflect the committed changes.