Page MenuHomePhabricator

pmccormick (Pat McCormick)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2020, 7:04 AM (121 w, 6 d)

Recent Activity

Mar 9 2022

pmccormick added inline comments to D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.
Mar 9 2022, 8:53 AM · Restricted Project, Restricted Project, Restricted Project

Dec 8 2021

pmccormick accepted D115289: [flang] Add CALL FLUSH(n) legacy extension.

LGTM -- thanks for the quick turnaround.

Dec 8 2021, 7:49 AM · Restricted Project, Restricted Project

Nov 9 2021

pmccormick added a comment to D113484: [fir] Add fir.select_case conversion.

LGTM, would be nice if someone else would also have a look at it.

Nov 9 2021, 3:55 PM · Restricted Project, Restricted Project

Nov 3 2021

pmccormick added a comment to D112445: [fir] Add fir.array_access op.

The the extra documentation here would be really helpful. In particular, from my 30,000 ft. view, it is not always clear when something is driven by a lower-level design choice tradeoff versus a goal of maintaining/capturing aspects of Fortran-level semantics that are necessary/beneficial for FIR-specific analysis and optimization.

Nov 3 2021, 9:03 AM · Restricted Project, Restricted Project

Jun 15 2020

pmccormick added a comment to D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable.

I said this on today's call but wanted to also add a note here.

Jun 15 2020, 9:45 AM · Restricted Project, Restricted Project

May 29 2020

pmccormick added a comment to D80794: [flang] Fix release build flags..

@tskeith Did you or perhaps @pmccormick report the original problem on mac?

I don't think I reported it.

May 29 2020, 1:09 PM · Restricted Project, Restricted Project