Page MenuHomePhabricator

jeanPerier (Jean Perier)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2020, 6:35 AM (119 w, 4 d)

Recent Activity

Today

jeanPerier accepted D128990: [flang][NFC] Add embox test with character.

Thanks

Fri, Jul 1, 8:10 AM · Restricted Project, Restricted Project
jeanPerier accepted D128976: [flang] File omp_lib.f90 is not a standard intrinsic module.

LGTM

Fri, Jul 1, 2:39 AM · Restricted Project, Restricted Project
jeanPerier accepted D128973: [flang] Fix for broken/degenerate forall case.
Fri, Jul 1, 1:14 AM · Restricted Project, Restricted Project
jeanPerier accepted D128970: [flang] Add correct number of args for wait.

LGTM

Fri, Jul 1, 1:13 AM · Restricted Project, Restricted Project

Yesterday

jeanPerier accepted D128597: [flang] Fix one corner case in reshape intrinsic.

Thanks

Thu, Jun 30, 7:42 AM · Restricted Project, Restricted Project
jeanPerier accepted D128894: [flang] Convert assertion to a TODO.
Thu, Jun 30, 4:51 AM · Restricted Project, Restricted Project
jeanPerier accepted D128889: [flang] Fix for array upper bounds with *.

LGTM

Thu, Jun 30, 1:32 AM · Restricted Project, Restricted Project
jeanPerier accepted D128888: [flang][NFC] Add FIR array test.
Thu, Jun 30, 1:32 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D128009: [flang] Add semantics test for image_status and add a check.

I am not sure how to ask this question, but if I have an instance of Expr<SomeType> and I know that it is an array (through checking the rank of the argument) , is there a way to unpack the Expr<SomeType> so that I have something like an array of Expr<SomeType>, so that I can iterate over the array and do the check for a non-positive value? This is what I was trying to track down and I couldn't find. I would appreciate any advice or pointing towards portions of code that might be helpful for me to look at, thanks!

Thu, Jun 30, 1:31 AM · Restricted Project, Restricted Project, Restricted Project
jeanPerier accepted D128884: [flang] Correct bug in literal CHARACTER constant names.

LGTM

Thu, Jun 30, 12:36 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D128597: [flang] Fix one corner case in reshape intrinsic.

Thanks for the update, preserving more constant shape information in the FIR types looks better to me.

Thu, Jun 30, 12:35 AM · Restricted Project, Restricted Project

Wed, Jun 29

jeanPerier added a comment to D128597: [flang] Fix one corner case in reshape intrinsic.

Even if all the failed tests passed the execution. I am still worried if this patch will crash some other code

Wed, Jun 29, 4:53 AM · Restricted Project, Restricted Project
jeanPerier accepted D128760: [flang] Better error recovery for bad submodules.

Looks good

Wed, Jun 29, 4:44 AM · Restricted Project, Restricted Project
jeanPerier accepted D128622: [flang] Don't use Optional::hasValue (NFC).

Thanks

Wed, Jun 29, 4:43 AM · Restricted Project, Restricted Project
jeanPerier accepted D128799: [flang][NFC] Cosmetic changes to make the file more homogenous.

Thanks

Wed, Jun 29, 4:38 AM · Restricted Project, Restricted Project
jeanPerier accepted D128788: [flang] Switch attr name to bindc_name.
Wed, Jun 29, 4:38 AM · Restricted Project, Restricted Project
jeanPerier accepted D128759: flang] Fix folding of LEN(f(...)).

LGTM

Wed, Jun 29, 4:37 AM · Restricted Project, Restricted Project

Tue, Jun 28

jeanPerier accepted D128723: [flang] Fix bugs relating to support for characters of different kinds.

LGTM

Tue, Jun 28, 6:26 AM · Restricted Project, Restricted Project
jeanPerier accepted D128721: [flang] Add lowering tests.

Thanks !

Tue, Jun 28, 5:52 AM · Restricted Project, Restricted Project
jeanPerier accepted D128724: [flang] Make sure that conversions are applied in FORALL degenerate contexts.
Tue, Jun 28, 5:51 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D128597: [flang] Fix one corner case in reshape intrinsic.

The execution result for the test case in this patch would be 0 0 1 2 if you change it into one main program. The expected result is 1 2 3 4.

Tue, Jun 28, 2:43 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D128622: [flang] Don't use Optional::hasValue (NFC).

Hi @kazu, thanks for making a review and making the code style consistent. It seems part of the change is breaking builds (see bots).

Tue, Jun 28, 2:21 AM · Restricted Project, Restricted Project

Mon, Jun 27

jeanPerier added a comment to D128597: [flang] Fix one corner case in reshape intrinsic.

Thanks for finding this bug and proposing a fix.

Mon, Jun 27, 9:10 AM · Restricted Project, Restricted Project
jeanPerier accepted D128632: [flang][NFC] Add array lowering tests.

LGTM, thanks

Mon, Jun 27, 5:01 AM · Restricted Project, Restricted Project

Thu, Jun 23

jeanPerier accepted D128431: [flang] Increase support for intrinsic module procedures.

Looks good, thanks

Thu, Jun 23, 7:08 AM · Restricted Project, Restricted Project
jeanPerier accepted D128412: [flang] Add lowering TODO for separate module procedures.

LGTM

Thu, Jun 23, 5:29 AM · Restricted Project, Restricted Project
jeanPerier accepted D128385: [flang] Lower Fortran math intrinsic operations into MLIR ops or libm calls..

Looks great to me thanks !

Thu, Jun 23, 2:44 AM · Restricted Project, Restricted Project, Restricted Project
jeanPerier added a comment to D128009: [flang] Add semantics test for image_status and add a check.

Thanks, it is great to be able to provide more compile time feedback. I think KindCode is not the right place to encode and complain about illegal argument values when they can be known and checked at compile time.

Thu, Jun 23, 2:24 AM · Restricted Project, Restricted Project, Restricted Project
jeanPerier accepted D128395: [flang] Make SQRT folding exact.

LGTM, maybe some leftover debugging in unittests/Evaluate/real.cpp though.

Thu, Jun 23, 1:19 AM · Restricted Project, Restricted Project

Wed, Jun 22

jeanPerier accepted D128331: [flang] Add FIR tests missing from fir-dev.

LGTM

Wed, Jun 22, 6:28 AM · Restricted Project, Restricted Project

Tue, Jun 21

jeanPerier accepted D128258: [flang] Cleanup code and add test from fir-dev.

LGTM (I am not sure why the patch application failed with the bots).

Tue, Jun 21, 5:53 AM · Restricted Project, Restricted Project

Mon, Jun 20

jeanPerier accepted D128186: [flang][NFC] Unify todo messages.

LGTM

Mon, Jun 20, 5:35 AM · Restricted Project, Restricted Project

Fri, Jun 17

jeanPerier accepted D128047: [flang] Fix bug in character casting. Add missing sext/trunc in code gen..
Fri, Jun 17, 6:58 AM · Restricted Project, Restricted Project

Thu, Jun 16

jeanPerier added a comment to D127525: [flang] Fix analyze of negate expression.

Thanks for the answer Peixin, now I see what you meant. I however think that may be a "feature", not a bug. With your patch the following code would be rejected:

Thu, Jun 16, 3:08 AM · Restricted Project, Restricted Project

Wed, Jun 15

jeanPerier accepted D127793: [flang][runtime] Make ASSOCIATED() conform with standard.

Looks good

Wed, Jun 15, 11:50 PM · Restricted Project, Restricted Project
jeanPerier accepted D127785: [flang] NINT(-.4999) is 0, not overflow.

LGTM

Wed, Jun 15, 11:34 PM · Restricted Project, Restricted Project
jeanPerier accepted D127784: [flang] Handle module subprogram with interface in same (sub)module when writing module file.
Wed, Jun 15, 11:33 PM · Restricted Project, Restricted Project
jeanPerier added a comment to D127525: [flang] Fix analyze of negate expression.

However, I think it still needs analyze the negate expression when it is not in module/submodule since doing the similar analysis as the unary plus expression is reasonable. What do you think? @jeanPerier Would it affect the lowering if the negate expression in execution part not analyzed?

Wed, Jun 15, 8:36 AM · Restricted Project, Restricted Project

Tue, Jun 14

jeanPerier committed rGac64c7b987f1: [flang] Support PDT declaration with initial comp value in internal procedure (authored by jeanPerier).
[flang] Support PDT declaration with initial comp value in internal procedure
Tue, Jun 14, 5:47 AM · Restricted Project, Restricted Project
jeanPerier closed D127735: [flang] Support PDT declaration with initial comp value in internal procedure.
Tue, Jun 14, 5:46 AM · Restricted Project, Restricted Project
jeanPerier accepted D127738: [flang] Avoid losing type parameter information.

LGTM

Tue, Jun 14, 5:30 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D126473: [flang] Fix semantic analysis for PDT component init.

It will result in fatal internal error when collecting host association variables if not folded. Here is the example: ....

Tue, Jun 14, 3:36 AM · Restricted Project, Restricted Project
jeanPerier requested review of D127735: [flang] Support PDT declaration with initial comp value in internal procedure.
Tue, Jun 14, 3:35 AM · Restricted Project, Restricted Project
jeanPerier accepted D127722: Add lowering TODO for bindings returning derived types or arrays.

LGTM

Tue, Jun 14, 1:45 AM · Restricted Project, Restricted Project

Mon, Jun 13

jeanPerier accepted D126961: [flang] Complement one-to-one association check of bind name and entity name.
Mon, Jun 13, 7:15 AM · Restricted Project, Restricted Project
jeanPerier accepted D127634: [flang][NFC] Add source location information to report unsupported complex types.

LGTM

Mon, Jun 13, 7:08 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D126473: [flang] Fix semantic analysis for PDT component init.

What is the motivation of this folding: is it required for semantics check, or does it lead to better code ?

Mon, Jun 13, 7:08 AM · Restricted Project, Restricted Project
jeanPerier accepted D127633: [flang] Avoid raising a TODO in fir.boxproc rewrite when not needed (#1560).

Thanks

Mon, Jun 13, 6:39 AM · Restricted Project, Restricted Project
jeanPerier accepted D127622: [flang] Add TODO for half-precision intrinsic reductions.
Mon, Jun 13, 6:38 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D127622: [flang] Add TODO for half-precision intrinsic reductions.

Looks good

Mon, Jun 13, 6:38 AM · Restricted Project, Restricted Project
jeanPerier accepted D127619: [flang][NFC] Add TODOs for KIND = 2.

LGTM

Mon, Jun 13, 6:37 AM · Restricted Project, Restricted Project
jeanPerier accepted D127617: [flang] Handle reversed bounds and negative length in inlined allocation.
Mon, Jun 13, 6:37 AM · Restricted Project, Restricted Project

Wed, Jun 8

jeanPerier accepted D127297: Fixes assertion that arose from bad FIR being constructed..
Wed, Jun 8, 8:50 AM · Restricted Project, Restricted Project
jeanPerier accepted D127295: [flang][NFC] Move genMaxWithZero into fir:::factory.
Wed, Jun 8, 8:49 AM · Restricted Project, Restricted Project
jeanPerier accepted D127292: [flang][NFC] Move Todo.h from Lower to Optimizer.

Thanks

Wed, Jun 8, 8:48 AM · Restricted Project, Restricted Project
jeanPerier accepted D127282: [flang] Add proper todo in BoxValue.

LGTM

Wed, Jun 8, 8:47 AM · Restricted Project, Restricted Project
jeanPerier added inline comments to D114134: [flang] Add co_sum to the list of intrinsics and update test.
Wed, Jun 8, 1:31 AM · Restricted Project, Restricted Project, Restricted Project
jeanPerier accepted D126805: [flang] Add failed_images to list of intrinsics and add test.

LGTM, thanks

Wed, Jun 8, 1:18 AM · Restricted Project, Restricted Project, Restricted Project
jeanPerier accepted D127121: [flang] Add one semantic check for procedure bind(C) interface-name.

LGTM, thanks

Wed, Jun 8, 1:11 AM · Restricted Project, Restricted Project

May 18 2022

jeanPerier requested review of D125867: [flang] Alternate entry points with unused arguments.
May 18 2022, 2:53 AM · Restricted Project, Restricted Project

May 17 2022

jeanPerier accepted D125672: [flang][Runtime] Use proper prototypes in Fortran_main. NFCI.

LGTM

May 17 2022, 3:28 AM · Restricted Project, Restricted Project

May 16 2022

jeanPerier accepted D125632: [flang] Move TODO for elemental call with parentheses on argument.

Is the above analysis the right direction? Is there someone working on this?

May 16 2022, 12:05 AM · Restricted Project, Restricted Project

May 11 2022

jeanPerier accepted D125342: [flang] Fix check for assumed-size arguments to SHAPE() & al..

LGTM

May 11 2022, 1:28 AM · Restricted Project, Restricted Project
jeanPerier accepted D125341: [flang] Fold complex component references.

Looks good

May 11 2022, 1:14 AM · Restricted Project, Restricted Project
jeanPerier accepted D125336: [flang] Upstream fix for performance issue.

clang-format should be run on lib/Lower/ConvertExpr.cpp, otherwise LGTM.

May 11 2022, 1:13 AM · Restricted Project, Restricted Project

May 10 2022

jeanPerier accepted D125267: [flang] Change "bad kind" messages in the runtime to "not yet implemented".

LGTM

May 10 2022, 6:11 AM · Restricted Project, Restricted Project

May 9 2022

jeanPerier committed rGd38915ffebee: [flang] Fix windows bot after D125140 (authored by jeanPerier).
[flang] Fix windows bot after D125140
May 9 2022, 6:25 AM · Restricted Project, Restricted Project
jeanPerier closed D125211: [flang] Fix windows bot after D125140.
May 9 2022, 6:24 AM · Restricted Project, Restricted Project
jeanPerier added a reviewer for D125211: [flang] Fix windows bot after D125140: PeteSteinfeld.
May 9 2022, 4:25 AM · Restricted Project, Restricted Project
jeanPerier accepted D125151: [flang] Fold real-valued MODULO() and MOD().
May 9 2022, 1:49 AM · Restricted Project, Restricted Project
jeanPerier accepted D125139: [flang] Accept POINTER followed by INTERFACE.

Looks good

May 9 2022, 1:46 AM · Restricted Project, Restricted Project
jeanPerier accepted D125123: [flang] Correct actual/dummy procedure compatibility for ALLOCATABLE/POINTER functions.
May 9 2022, 1:43 AM · Restricted Project, Restricted Project
jeanPerier accepted D125135: [flang] Reverse a reversed type compatibility check.
May 9 2022, 1:39 AM · Restricted Project, Restricted Project
jeanPerier accepted D125119: [flang] Fix to UnwrapConvertedExpr().

LGTM

May 9 2022, 1:38 AM · Restricted Project, Restricted Project
jeanPerier accepted D125115: [flang] Refine handling of short character actual arguments.
May 9 2022, 1:34 AM · Restricted Project, Restricted Project
jeanPerier requested review of D125211: [flang] Fix windows bot after D125140.
May 9 2022, 1:29 AM · Restricted Project, Restricted Project
jeanPerier accepted D125062: [flang] Fold intrinsic inquiry functions SAME_TYPE_AS() and EXTENDS_TYPE_OF().

Looks good

May 9 2022, 1:27 AM · Restricted Project, Restricted Project
jeanPerier committed rGed0341788af2: [flang] retain binding label of entry subprograms (authored by jeanPerier).
[flang] retain binding label of entry subprograms
May 9 2022, 12:52 AM · Restricted Project, Restricted Project
jeanPerier closed D125097: [flang] retain binding label of entry subprograms.
May 9 2022, 12:51 AM · Restricted Project, Restricted Project

May 6 2022

jeanPerier requested review of D125097: [flang] retain binding label of entry subprograms.
May 6 2022, 8:02 AM · Restricted Project, Restricted Project
jeanPerier accepted D124766: [flang] Fix AllocaOp/AllocMemOp type conversion.

Thanks a lot @peixin, it is great to have this code shared and to have more regression tests here !

May 6 2022, 1:25 AM · Restricted Project, Restricted Project

May 5 2022

jeanPerier committed rGb910cf986ab9: [flang] use 1-based dim in transformational runtime error msg (authored by jeanPerier).
[flang] use 1-based dim in transformational runtime error msg
May 5 2022, 1:34 AM · Restricted Project, Restricted Project
jeanPerier closed D124941: [flang] use 1-based dim in transformational runtime error msg.
May 5 2022, 1:34 AM · Restricted Project, Restricted Project

May 4 2022

jeanPerier requested review of D124941: [flang] use 1-based dim in transformational runtime error msg.
May 4 2022, 10:08 AM · Restricted Project, Restricted Project
jeanPerier added inline comments to D124737: [flang] Support lowering assignment to (sub)string in forall.
May 4 2022, 2:06 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D124766: [flang] Fix AllocaOp/AllocMemOp type conversion.

Thanks for the bug fix

May 4 2022, 1:57 AM · Restricted Project, Restricted Project
jeanPerier accepted D124345: [flang] Support external procedure passed as actual argument with implicit character type.

Thanks

May 4 2022, 1:46 AM · Restricted Project, Restricted Project

May 2 2022

jeanPerier added inline comments to D124345: [flang] Support external procedure passed as actual argument with implicit character type.
May 2 2022, 5:57 AM · Restricted Project, Restricted Project

Apr 29 2022

jeanPerier committed rG2c8cb9acb51e: [flang] Handle common block with different sizes in same file (authored by jeanPerier).
[flang] Handle common block with different sizes in same file
Apr 29 2022, 5:53 AM · Restricted Project, Restricted Project
jeanPerier closed D124622: [flang] Handle common block with different sizes in same file.
Apr 29 2022, 5:53 AM · Restricted Project, Restricted Project
jeanPerier updated the diff for D124622: [flang] Handle common block with different sizes in same file.
  • Add note in docs/Extensions.md.
  • Inlcude semantics.h in PFTBuilder.h instead of redefining the typdef
  • Fix typos
Apr 29 2022, 1:12 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D124622: [flang] Handle common block with different sizes in same file.

Could you add comments to docs/Extensions.md to describe that (1) initializations of common outside BLOCK DATA and (2) initializations of blank COMMON are both non-standard, but are near-universal extensions that we have to support?

Apr 29 2022, 1:10 AM · Restricted Project, Restricted Project

Apr 28 2022

jeanPerier requested review of D124622: [flang] Handle common block with different sizes in same file.
Apr 28 2022, 8:47 AM · Restricted Project, Restricted Project
jeanPerier accepted D123944: [flang] Fix UBOUND() constant folding for parentheses expr.

LGTM, thanks for the update

Apr 28 2022, 1:25 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D123520: [flang] Fix UBOUND() folding for constant arrays.

Windows buildbot failed https://lab.llvm.org/buildbot/#/builders/172/builds/11593 after this patch in flang\test\Semantics\select-rank.f90:
[...]
but for now I don't understand the root cause yet (no lbound/ubound in testcase)
(CC @jeanPerier / @klausler )

Apr 28 2022, 1:22 AM · Restricted Project, Restricted Project

Apr 27 2022

jeanPerier added inline comments to D124484: [flang] Fix MAXLOC/MINLOC when MASK is scalar .FALSE..
Apr 27 2022, 12:58 AM · Restricted Project, Restricted Project

Apr 26 2022

jeanPerier accepted D124423: [flang] Get ppc64le build bot back up.

I am surprised because the dispatching uses host::FortranType<HostT> (at [1]) to avoid making assumptions regarding what the host floating points are. So I would have expected this code to automatically map long double to REAL(16) on ppc64le, but obviously, there is a bug/issue somewhere. Thanks for the fix.

Apr 26 2022, 5:02 AM · Restricted Project, Restricted Project

Apr 25 2022

jeanPerier accepted D124295: [flang] Avoid global name conflict when BIND(C,NAME=) is used.

LGTM

Apr 25 2022, 1:17 AM · Restricted Project, Restricted Project
jeanPerier accepted D124299: [flang] Disambiguate F(X)=Y case where F is a function returning a pointer.

Looks good

Apr 25 2022, 1:13 AM · Restricted Project, Restricted Project
jeanPerier committed rGfca52e82185a: [flang] fix LBOUND lowering with KIND and no DIM arguments (authored by jeanPerier).
[flang] fix LBOUND lowering with KIND and no DIM arguments
Apr 25 2022, 12:22 AM · Restricted Project, Restricted Project