Page MenuHomePhabricator

jeanPerier (Jean Perier)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2020, 6:35 AM (157 w, 4 d)

Recent Activity

Today

jeanPerier added a comment to D146751: Support for PowerPC vector type.

It is a nice implementation dealing with all compilation stages, kudos for that! I am not in favor of extending TypeCategory with Vector, which is rather central in your patch after parsing, and I am suggesting an alternative (please wait for more feedback before spending too much time trying it though).

Fri, Mar 24, 3:08 AM · Restricted Project

Yesterday

jeanPerier added a comment to D146487: [flang] HLFIR to FIR lowering for complex parts.

Thanks, this looks great to me.

Thu, Mar 23, 9:55 AM · Restricted Project, Restricted Project
jeanPerier accepted D146594: [flang] Lower fir.dispatch in the fir-polymorphic-op pass.

Looks good to me, thanks for simplifying codegen and making transformations more modular.

Thu, Mar 23, 3:09 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Mar 17

jeanPerier accepted D146186: [flang] Replace !fir.ref<BoxType> -> BoxType conversion with a load prior to calling fir.dispatch.
Fri, Mar 17, 1:16 AM · Restricted Project, Restricted Project, Restricted Project
jeanPerier accepted D145961: [flang][hlfir] lower hlfir.matmul_transpose to runtime call.

LGTM

Fri, Mar 17, 1:15 AM · Restricted Project, Restricted Project
jeanPerier accepted D145502: [flang][hlfir] move intrinsic lowering out of BufferizeHLFIR.

Thanks, LGTM. Please beware there is a bot failure, but I think it is unrelated to your patch (you could rebase if this was fixed to check that).

Fri, Mar 17, 1:12 AM · Restricted Project, Restricted Project

Tue, Mar 14

jeanPerier added a reviewer for D145960: [flang] add fused matmul-transpose to the runtime: klausler.
Tue, Mar 14, 2:55 AM · Restricted Project, Restricted Project
jeanPerier added a reviewer for D145960: [flang] add fused matmul-transpose to the runtime: vzakhari.
Tue, Mar 14, 2:55 AM · Restricted Project, Restricted Project
jeanPerier added a reviewer for D145959: [flang][hlfir] add matmul canonicalizer: vzakhari.
Tue, Mar 14, 2:55 AM · Restricted Project, Restricted Project
jeanPerier added a reviewer for D145957: [flang][hlfir] add hlfir.matmul_transpose operation: vzakhari.
Tue, Mar 14, 2:54 AM · Restricted Project, Restricted Project
jeanPerier accepted D145601: [flang] Handle mismatches of procedure type args.

Looks good.

Tue, Mar 14, 2:52 AM · Restricted Project, Restricted Project
jeanPerier accepted D145504: [flang][hlfir] add a test chaining intrinsics.

LGTM

Tue, Mar 14, 2:50 AM · Restricted Project, Restricted Project
jeanPerier accepted D145503: [flang][hlfir] clean up intrinsic arg extended values.

LGTM

Tue, Mar 14, 2:49 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D145502: [flang][hlfir] move intrinsic lowering out of BufferizeHLFIR.

I think the cause of the issue mentioned in the second bullet point is that the patterns were actually not using the OpAdaptor adaptor to get the operands as they should have in a full translation pass (sorry for not catching that, I always miss this....). E.g: sum.getArray() sould have been getBufferizedExprStorage(adaptor.getArray()). And the hlfir::AsExprOp in processReturnValue could have been repaced by packageBufferizedExpr(loc, builder, *resultEntity, mustBeFreed). This would have avoided using/introducing again hlfir.expr in the pass that gets rid of them. This would also address the first point in some way (but I agree the hlfir.expr operands would still also be transformed).

Tue, Mar 14, 2:42 AM · Restricted Project, Restricted Project

Tue, Mar 7

jeanPerier accepted D145384: [flang] Align same_type_as result to other compilers.

LGTM

Tue, Mar 7, 7:01 PM · Restricted Project, Restricted Project
jeanPerier accepted D145537: [flang] Enable target rewrite for int args/rets of bind(c) functions..

LGTM

Tue, Mar 7, 6:58 PM · Restricted Project, Restricted Project
jeanPerier added inline comments to D145418: [Flang] Fix ALLOCATE with MOLD where MOLD is a scalar.
Tue, Mar 7, 12:33 AM · Restricted Project, Restricted Project
jeanPerier accepted D145005: [flang] Lower complex part.

Looks great, thanks.

Tue, Mar 7, 12:05 AM · Restricted Project, Restricted Project
jeanPerier committed rG30bfb6a7f641: [flang][hlfir] Map scalar character symbols in internal procedures (authored by jeanPerier).
[flang][hlfir] Map scalar character symbols in internal procedures
Tue, Mar 7, 12:01 AM · Restricted Project, Restricted Project
jeanPerier closed D145361: [flang][hlfir] Map scalar character symbols in internal procedures.
Tue, Mar 7, 12:00 AM · Restricted Project, Restricted Project

Mon, Mar 6

jeanPerier added inline comments to D145384: [flang] Align same_type_as result to other compilers.
Mon, Mar 6, 9:02 AM · Restricted Project, Restricted Project
jeanPerier accepted D145380: [flang] Do not query type_desc for unlimited polymoprhic entities in move_alloc.

Makes sense to me.

Mon, Mar 6, 8:57 AM · Restricted Project, Restricted Project
jeanPerier committed rG6ed4a8b9b1f3: [flang][hlfir] Lower intrinsic module procedures to HLFIR (authored by jeanPerier).
[flang][hlfir] Lower intrinsic module procedures to HLFIR
Mon, Mar 6, 5:01 AM · Restricted Project, Restricted Project
jeanPerier closed D145360: [flang][hlfir] Lower intrinsic module procedures to HLFIR.
Mon, Mar 6, 5:01 AM · Restricted Project, Restricted Project
jeanPerier committed rG4aec70c0c930: [flang][hlfir] use new runtime for whole allocatable assignment (authored by jeanPerier).
[flang][hlfir] use new runtime for whole allocatable assignment
Mon, Mar 6, 5:00 AM · Restricted Project, Restricted Project
jeanPerier closed D145363: [flang][hlfir] use new runtime for whole allocatable assignment.
Mon, Mar 6, 4:59 AM · Restricted Project, Restricted Project
jeanPerier accepted D145367: [flang] Handle parent component in select type.

Looks good to me

Mon, Mar 6, 4:58 AM · Restricted Project, Restricted Project
jeanPerier requested review of D145363: [flang][hlfir] use new runtime for whole allocatable assignment.
Mon, Mar 6, 2:00 AM · Restricted Project, Restricted Project
jeanPerier requested review of D145361: [flang][hlfir] Map scalar character symbols in internal procedures.
Mon, Mar 6, 1:06 AM · Restricted Project, Restricted Project
jeanPerier requested review of D145360: [flang][hlfir] Lower intrinsic module procedures to HLFIR.
Mon, Mar 6, 12:28 AM · Restricted Project, Restricted Project

Sun, Mar 5

jeanPerier accepted D145324: [flang] Use AssignPolymorphic when LHS is polymorphic.

LGTM

Sun, Mar 5, 11:53 PM · Restricted Project, Restricted Project

Fri, Mar 3

jeanPerier accepted D145080: [Flang] [PowerPC} Implement the floating-point conversion PowerPC intrinsics.
Fri, Mar 3, 12:52 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D145165: [Flang] Give fir.if RegionBranchOpInterface.

It makes sense to me to add this interface to fir.if and LGTM. Just adding @vzakhari here to ensure I am not missing something.

Fri, Mar 3, 12:50 AM · Restricted Project, Restricted Project, Restricted Project
jeanPerier added a reviewer for D145165: [Flang] Give fir.if RegionBranchOpInterface: vzakhari.
Fri, Mar 3, 12:39 AM · Restricted Project, Restricted Project, Restricted Project
jeanPerier added inline comments to D145005: [flang] Lower complex part.
Fri, Mar 3, 12:20 AM · Restricted Project, Restricted Project
jeanPerier accepted D144743: [flang] Fix lowering of optional char proc args.

Thanks for having dealt with all the comments, LGTM

Fri, Mar 3, 12:19 AM · Restricted Project, Restricted Project

Thu, Mar 2

jeanPerier added inline comments to D145005: [flang] Lower complex part.
Thu, Mar 2, 8:19 AM · Restricted Project, Restricted Project
jeanPerier added inline comments to D144743: [flang] Fix lowering of optional char proc args.
Thu, Mar 2, 7:53 AM · Restricted Project, Restricted Project
jeanPerier accepted D145114: [flang] Fix CONTIGUOUS attribute for construct entities.

LGTM

Thu, Mar 2, 7:30 AM · Restricted Project, Restricted Project

Wed, Mar 1

jeanPerier accepted D145084: [flang] Check for BIND(C) through use association..
Wed, Mar 1, 10:44 AM · Restricted Project, Restricted Project
jeanPerier accepted D144869: [Flang][Tool][bbc] Emit Module Wrapper in addition to body.
Wed, Mar 1, 8:45 AM · Restricted Project, Restricted Project
jeanPerier accepted D145060: [flang] MERGE result is polymorphic only if TSOURCE and FSOURCE are polymorphic.

LGTM

Wed, Mar 1, 6:00 AM · Restricted Project, Restricted Project
jeanPerier accepted D145058: [flang] Allow scalar boxed record type in intrinsic elemental lowering.

Looks good

Wed, Mar 1, 5:58 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D144869: [Flang][Tool][bbc] Emit Module Wrapper in addition to body.

From what I can tell there unfortunately isn't sadly, but my knowledge of LLVM/MLIR's pretty printing is a little lack luster.

Too bad, but not a blocker on my side. We will revisit pretty printing at some point to enable type alias usage for FIR derived types. Maybe we could see if it is possible to not add extra indentation to module content at that point.

Wed, Mar 1, 5:52 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D145005: [flang] Lower complex part.

Great job finding out the pieces, designator lowering is not the easiest piece of lowering. Looks good overall, some comment inline.

Wed, Mar 1, 4:16 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D144743: [flang] Fix lowering of optional char proc args.

Thanks a lot, I think the IR can be slightly further simplify by merging the fir.absent and fir.emboxproc into a single fir.absent. Looks great otherwise.

Wed, Mar 1, 2:22 AM · Restricted Project, Restricted Project
jeanPerier committed rG25db7cb70c31: [flang][hlfir] Implement hlfir.declare optional codegen (authored by jeanPerier).
[flang][hlfir] Implement hlfir.declare optional codegen
Wed, Mar 1, 1:44 AM · Restricted Project, Restricted Project
jeanPerier closed D144962: [flang][hlfir] Implement hlfir.declare optional codegen.
Wed, Mar 1, 1:44 AM · Restricted Project, Restricted Project

Tue, Feb 28

jeanPerier added a comment to D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.

We are looking for community input regarding the error handling for these intrinsics (and more PowerPC intrinsics to come):

  • Are we ok we doing semantic checking in the handler functions like we are doing for mtfsf/mtfsfi (ie checking if constant op and in valid range)
Tue, Feb 28, 6:55 AM · Restricted Project, Restricted Project
jeanPerier requested review of D144962: [flang][hlfir] Implement hlfir.declare optional codegen.
Tue, Feb 28, 6:19 AM · Restricted Project, Restricted Project
jeanPerier committed rGd8d91b2a25db: [flang][hlfir] Support type descriptor for initialized character component (authored by jeanPerier).
[flang][hlfir] Support type descriptor for initialized character component
Tue, Feb 28, 6:16 AM · Restricted Project, Restricted Project
jeanPerier closed D144960: [flang][hlfir] Support type descriptor for initialized character component.
Tue, Feb 28, 6:16 AM · Restricted Project, Restricted Project
jeanPerier requested review of D144960: [flang][hlfir] Support type descriptor for initialized character component.
Tue, Feb 28, 5:32 AM · Restricted Project, Restricted Project
jeanPerier committed rGa98b031e4f38: [flang][hlfir] Support type bound procedure in type descriptors (authored by jeanPerier).
[flang][hlfir] Support type bound procedure in type descriptors
Tue, Feb 28, 5:12 AM · Restricted Project, Restricted Project
jeanPerier closed D144952: [flang][hlfir] Support type bound procedure in type descriptors.
Tue, Feb 28, 5:12 AM · Restricted Project, Restricted Project
jeanPerier committed rG88be49599f3a: [flang][hlfir] Lower parent component references (authored by jeanPerier).
[flang][hlfir] Lower parent component references
Tue, Feb 28, 5:11 AM · Restricted Project, Restricted Project
jeanPerier closed D144948: [flang][hlfir] Lower parent component references.
Tue, Feb 28, 5:11 AM · Restricted Project, Restricted Project
jeanPerier committed rG131c9174d9f1: [flang][hlfir] Add hlfir.parent_comp for leaf parent component references (authored by jeanPerier).
[flang][hlfir] Add hlfir.parent_comp for leaf parent component references
Tue, Feb 28, 5:09 AM · Restricted Project, Restricted Project
jeanPerier closed D144946: [flang][hlfir] Add hlfir.parent_comp for leaf parent component references.
Tue, Feb 28, 5:09 AM · Restricted Project, Restricted Project
jeanPerier updated the diff for D144946: [flang][hlfir] Add hlfir.parent_comp for leaf parent component references.

Correct typo in verifier error message.

Tue, Feb 28, 4:23 AM · Restricted Project, Restricted Project
jeanPerier accepted D144881: [flang] lower transpose intrinsic to hlfir.transpose operation.

LGTM

Tue, Feb 28, 4:18 AM · Restricted Project, Restricted Project
jeanPerier accepted D144949: [flang] Fix potential segfault in PointerAssociateRemapping.

LGTM

Tue, Feb 28, 4:17 AM · Restricted Project, Restricted Project
jeanPerier requested review of D144952: [flang][hlfir] Support type bound procedure in type descriptors.
Tue, Feb 28, 3:03 AM · Restricted Project, Restricted Project
jeanPerier requested review of D144948: [flang][hlfir] Lower parent component references.
Tue, Feb 28, 2:27 AM · Restricted Project, Restricted Project
jeanPerier accepted D144921: [flang] Polymorphic Operations Conversion Pass .
Tue, Feb 28, 2:23 AM · Restricted Project, Restricted Project, Restricted Project
jeanPerier requested review of D144946: [flang][hlfir] Add hlfir.parent_comp for leaf parent component references.
Tue, Feb 28, 1:55 AM · Restricted Project, Restricted Project
jeanPerier accepted D144916: [flang] Block construct.

It's great to have a generic solution to deal with the clean-ups of construct entities when branching out of them, thanks Val.

Tue, Feb 28, 12:37 AM · Restricted Project, Restricted Project
jeanPerier accepted D144761: [Flang] Fix code for ALLOCATE statement with MOLD argument for scalars.

Thanks Pete, LGTM.

Tue, Feb 28, 12:11 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D144869: [Flang][Tool][bbc] Emit Module Wrapper in addition to body.

adding it as a discussion point in one of the weekly meetings or is an RFC on discourse perhaps better?

We can briefly discuss it at the meeting tomorrow to check no one rely on not having the module printed.

Tue, Feb 28, 12:10 AM · Restricted Project, Restricted Project
jeanPerier added inline comments to D144881: [flang] lower transpose intrinsic to hlfir.transpose operation.
Tue, Feb 28, 12:01 AM · Restricted Project, Restricted Project

Mon, Feb 27

jeanPerier accepted D144882: [flang] lower hlfir.transpose into fir runtime call.

LGTM

Mon, Feb 27, 9:07 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D144881: [flang] lower transpose intrinsic to hlfir.transpose operation.

Nits in the result type computation, looks good otherwise.

Mon, Feb 27, 9:04 AM · Restricted Project, Restricted Project
jeanPerier accepted D144880: [flang] add hlfir.transpose operation.

Small nit, looks good otherwise.

Mon, Feb 27, 8:55 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D144743: [flang] Fix lowering of optional char proc args.

Thanks a lot for the fix!

Mon, Feb 27, 4:24 AM · Restricted Project, Restricted Project
jeanPerier committed rGe5921ef021ef: [flang][hlfir] Lower associate construct to HLFIR (authored by jeanPerier).
[flang][hlfir] Lower associate construct to HLFIR
Mon, Feb 27, 12:06 AM · Restricted Project, Restricted Project
jeanPerier closed D144740: [flang][hlfir] Lower associate construct to HLFIR.
Mon, Feb 27, 12:06 AM · Restricted Project, Restricted Project
jeanPerier committed rG713b3ad43850: [flang][hlfir] Lower allocatable assignment to HLFIR (authored by jeanPerier).
[flang][hlfir] Lower allocatable assignment to HLFIR
Mon, Feb 27, 12:05 AM · Restricted Project, Restricted Project
jeanPerier closed D144727: [flang][hlfir] Lower allocatable assignment to HLFIR.
Mon, Feb 27, 12:04 AM · Restricted Project, Restricted Project
jeanPerier committed rG275c272c39a2: [flang][hlfir] add allocatable assignment semantic to hlfir.assign (authored by jeanPerier).
[flang][hlfir] add allocatable assignment semantic to hlfir.assign
Mon, Feb 27, 12:04 AM · Restricted Project, Restricted Project
jeanPerier closed D144723: [flang][hlfir] add allocatable assignment semantic to hlfir.assign.
Mon, Feb 27, 12:04 AM · Restricted Project, Restricted Project

Sun, Feb 26

jeanPerier added a comment to D144761: [Flang] Fix code for ALLOCATE statement with MOLD argument for scalars.

I think removing this check is not correct from a semantic point of view because we are required to gracefully catch double allocation errors when STAT/ERRMSG is provided.

Sun, Feb 26, 5:09 AM · Restricted Project, Restricted Project

Fri, Feb 24

jeanPerier requested review of D144740: [flang][hlfir] Lower associate construct to HLFIR.
Fri, Feb 24, 8:37 AM · Restricted Project, Restricted Project
jeanPerier added inline comments to D144649: [flang] Implement isnan and ieee_is_nan intrinsics.
Fri, Feb 24, 7:45 AM · Restricted Project, Restricted Project
jeanPerier requested review of D144727: [flang][hlfir] Lower allocatable assignment to HLFIR.
Fri, Feb 24, 5:27 AM · Restricted Project, Restricted Project
jeanPerier requested review of D144723: [flang][hlfir] add allocatable assignment semantic to hlfir.assign.
Fri, Feb 24, 4:38 AM · Restricted Project, Restricted Project
jeanPerier added inline comments to D144649: [flang] Implement isnan and ieee_is_nan intrinsics.
Fri, Feb 24, 1:38 AM · Restricted Project, Restricted Project
jeanPerier committed rGbc991d940f9a: [flang][hlfir] Array constructor lowering [part 4/4] (authored by jeanPerier).
[flang][hlfir] Array constructor lowering [part 4/4]
Fri, Feb 24, 12:19 AM · Restricted Project, Restricted Project
jeanPerier closed D144548: [flang][hlfir] Array constructor lowering [part 4/4].
Fri, Feb 24, 12:18 AM · Restricted Project, Restricted Project
jeanPerier committed rG9683a9c9989a: [flang][hlfir] Array constructor lowering [part 3/4] (authored by jeanPerier).
[flang][hlfir] Array constructor lowering [part 3/4]
Fri, Feb 24, 12:12 AM · Restricted Project, Restricted Project
jeanPerier closed D144513: [flang][hlfir] Array constructor lowering [part 3/4].
Fri, Feb 24, 12:11 AM · Restricted Project, Restricted Project
jeanPerier committed rGce8dbe3c2531: [flang] Do not include dangling ac-implied-do-index in folded shape inquiry (authored by jeanPerier).
[flang] Do not include dangling ac-implied-do-index in folded shape inquiry
Fri, Feb 24, 12:09 AM · Restricted Project, Restricted Project
jeanPerier closed D144655: [flang] Do not include dangling ac-implied-do-index in folded shape inquiry.
Fri, Feb 24, 12:09 AM · Restricted Project, Restricted Project
jeanPerier committed rG91bd4c6e81ac: [flang] Preserve useResultSymbolShape_ option when folding array constructor… (authored by jeanPerier).
[flang] Preserve useResultSymbolShape_ option when folding array constructor…
Fri, Feb 24, 12:07 AM · Restricted Project, Restricted Project
jeanPerier closed D144512: [flang] Preserve useResultSymbolShape_ option when folding array constructor shape.
Fri, Feb 24, 12:07 AM · Restricted Project, Restricted Project

Thu, Feb 23

jeanPerier requested review of D144655: [flang] Do not include dangling ac-implied-do-index in folded shape inquiry.
Thu, Feb 23, 9:58 AM · Restricted Project, Restricted Project
jeanPerier accepted D144576: [Flang] Don't crash when BOZ literals are on the rhs of an assignment.

LGTM

Thu, Feb 23, 1:38 AM · Restricted Project, Restricted Project
jeanPerier committed rG3064d6b7b062: [flang][hlfir] Simplify hlfir.assign default codegen for arrays (authored by jeanPerier).
[flang][hlfir] Simplify hlfir.assign default codegen for arrays
Thu, Feb 23, 12:13 AM · Restricted Project, Restricted Project
jeanPerier closed D144567: [flang][hlfir] Simplify hlfir.assign default codegen for arrays.
Thu, Feb 23, 12:13 AM · Restricted Project, Restricted Project

Wed, Feb 22

jeanPerier updated the diff for D144567: [flang][hlfir] Simplify hlfir.assign default codegen for arrays.

Remove genTempFromSourceBox that is now unused. Thanks Pete.

Wed, Feb 22, 9:39 AM · Restricted Project, Restricted Project
jeanPerier requested review of D144567: [flang][hlfir] Simplify hlfir.assign default codegen for arrays.
Wed, Feb 22, 8:57 AM · Restricted Project, Restricted Project