Page MenuHomePhabricator

AlexisPerry (Alexis Perry-Holby)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2020, 8:29 AM (111 w, 1 d)

Recent Activity

Fri, Apr 29

AlexisPerry committed rG68ee5ad0082c: [flang] Update Google Doc link for Flang Biweekly Sync call notes (authored by AlexisPerry).
[flang] Update Google Doc link for Flang Biweekly Sync call notes
Fri, Apr 29, 11:36 AM · Unknown Object (Project), Restricted Project
AlexisPerry closed D124689: [flang] Update Google Doc link for Flang Biweekly Sync call notes.
Fri, Apr 29, 11:35 AM · Restricted Project, Unknown Object (Project)
AlexisPerry retitled D124689: [flang] Update Google Doc link for Flang Biweekly Sync call notes from Update Google Doc link for Flang Biweekly Sync call notes to [flang] Update Google Doc link for Flang Biweekly Sync call notes.
Fri, Apr 29, 11:05 AM · Restricted Project, Unknown Object (Project)
AlexisPerry requested review of D124689: [flang] Update Google Doc link for Flang Biweekly Sync call notes.
Fri, Apr 29, 11:03 AM · Restricted Project, Unknown Object (Project)

Dec 7 2021

AlexisPerry committed rGc2acd4539396: Convert fir.allocmem and fir.freemem operations to calls to malloc and free… (authored by AlexisPerry).
Convert fir.allocmem and fir.freemem operations to calls to malloc and free…
Dec 7 2021, 2:59 PM
AlexisPerry closed D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.
Dec 7 2021, 2:59 PM · Restricted Project, Unknown Object (Project)

Dec 6 2021

AlexisPerry added a comment to D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Thanks @awarzynski ! Yes, the namespace changes (and use of "static") were requested in a previous comment on this review :

The coding standard indicates that anonymous namespace should be made as small as possible and only include class declarations.
Functions should be made static and outside the namespace instead.

https://llvm.org/docs/CodingStandards.html#anonymous-namespaces

Dec 6 2021, 2:59 PM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

address latest review comments

Dec 6 2021, 2:59 PM · Restricted Project, Unknown Object (Project)
AlexisPerry added a comment to D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

I believe I have corrected all the build errors and addressed all the comments. There should now be appropriate working testing as well. Is this patch ready to go? Thanks!

Dec 6 2021, 11:46 AM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

clang-format

Dec 6 2021, 11:10 AM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

fix build error

Dec 6 2021, 10:11 AM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Fix whitespace errors (hopefully)

Dec 6 2021, 9:04 AM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Rebase on main

Dec 6 2021, 8:39 AM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

move definition of computeDerivedTypeSize to fix build error

Dec 6 2021, 8:22 AM · Restricted Project, Unknown Object (Project)

Dec 3 2021

AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Fixed build error - removed duplicate function definition

Dec 3 2021, 2:52 PM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

rebase on upstream main

Dec 3 2021, 1:40 PM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Address review comments - clearer comments and reduced use of auto

Dec 3 2021, 11:49 AM · Restricted Project, Unknown Object (Project)
AlexisPerry added a comment to D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Address review comments - add a test that triggers the TODO in AllocMemOp Conversion

Dec 3 2021, 11:36 AM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

rebase on main - add TODO back in
get successfull test of TODO in AllocMemOp converion of derived type with LEN params

Dec 3 2021, 11:32 AM · Restricted Project, Unknown Object (Project)

Nov 23 2021

AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Rebase on main

Nov 23 2021, 12:47 PM · Restricted Project, Unknown Object (Project)
AlexisPerry added inline comments to D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.
Nov 23 2021, 11:18 AM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Remove TODO in favor of notifyMatchFailure

Nov 23 2021, 11:17 AM · Restricted Project, Unknown Object (Project)

Nov 22 2021

AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Fix a couple namespacing errors

Nov 22 2021, 1:17 PM · Restricted Project, Unknown Object (Project)
AlexisPerry added a comment to D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Fix a couple namespacing errors

Nov 22 2021, 1:17 PM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Rebase on main

Nov 22 2021, 12:56 PM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Address review comments

  • move CHECK blocks to after the mlir code in the test file
  • fix style with respect to anonymous namespaces: only include class definitions in the namespace and make functions static and outside the namespace
  • fix a few nits
Nov 22 2021, 12:46 PM · Restricted Project, Unknown Object (Project)
AlexisPerry added inline comments to D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.
Nov 22 2021, 12:42 PM · Restricted Project, Unknown Object (Project)

Nov 17 2021

AlexisPerry added a comment to D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Thanks so much for the review! I've been a little preoccupied of late, so this patch wasn't quite as polished as I would have like. Thanks for helping me get it in better shape!

Nov 17 2021, 12:28 PM · Restricted Project, Unknown Object (Project)
AlexisPerry updated the diff for D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.

Address review comments.

Nov 17 2021, 12:27 PM · Restricted Project, Unknown Object (Project)
AlexisPerry retitled D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively from Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively to [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.
Nov 17 2021, 10:08 AM · Restricted Project, Unknown Object (Project)
AlexisPerry requested review of D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively.
Nov 17 2021, 10:07 AM · Restricted Project, Unknown Object (Project)

Oct 25 2021

AlexisPerry removed a reviewer for D90515: Add -S option: AlexisPerry.
Oct 25 2021, 8:26 AM
AlexisPerry accepted D112418: [fir][NFC] Move MLIR includes to FIRDialect.td.

LGTM

Oct 25 2021, 8:25 AM · Restricted Project, Unknown Object (Project)
AlexisPerry accepted D112436: [fir][NFC] Format and make FIROps.td homogenous.

Looks good to me.

Oct 25 2021, 8:22 AM · Restricted Project, Unknown Object (Project)

Oct 19 2021

AlexisPerry accepted D112074: [fir] Add character utility functions in FIRBuilder.

LGTM, apart from a few minor typos in various comments.

Oct 19 2021, 12:23 PM · Restricted Project, Unknown Object (Project)

Sep 28 2021

AlexisPerry added a comment to D109108: [flang] Use CMake to determine endianness..
Sep 28 2021, 10:30 AM · Restricted Project, Unknown Object (Project)

Dec 23 2020

AlexisPerry committed rG3b3a9d24188a: Updated GettingInvolved.md to reflect Flang Biweekly Call changes (authored by AlexisPerry).
Updated GettingInvolved.md to reflect Flang Biweekly Call changes
Dec 23 2020, 10:59 AM
AlexisPerry closed D93770: Updated GettingInvolved.md to reflect Flang Biweekly Call changes.
Dec 23 2020, 10:59 AM · Restricted Project, Unknown Object (Project)
AlexisPerry requested review of D93770: Updated GettingInvolved.md to reflect Flang Biweekly Call changes.
Dec 23 2020, 10:02 AM · Restricted Project, Unknown Object (Project)

Nov 4 2020

AlexisPerry added a comment to D90515: Add -S option.

The idea seems solid to me, but I am also unsure how best to test this. Also, did you clang-format the code before uploading the patch?

Nov 4 2020, 3:54 PM

Sep 22 2020

AlexisPerry updated subscribers of D84334: [flang] Version information in flang/f18.
Sep 22 2020, 3:52 PM · Restricted Project, Unknown Object (Project)

Aug 6 2020

AlexisPerry accepted D84334: [flang] Version information in flang/f18.
Aug 6 2020, 12:10 PM · Restricted Project, Unknown Object (Project)

Jul 28 2020

AlexisPerry added a comment to D84334: [flang] Version information in flang/f18.

@richard.barton.arm, I don't think I have any code that relies on __F18 being defined, so I'm alright with removing it and the related macros. You also make a very good point about following clang behavior. I wasn't aware of clang's use of lowercase macros and just assumed everyone uses uppercase macros based on my previous experiences with other codes. I think your proposal is likely the better way to go, first because matching style across LLVM projects is generally a good thing and second because your proposal does not require changes to classic Flang so we don't have to impose on those developers.

Jul 28 2020, 8:24 AM · Restricted Project, Unknown Object (Project)
AlexisPerry committed rGca0bf440dbf9: Order of libraries and source files in the f18 frontend (authored by coti).
Order of libraries and source files in the f18 frontend
Jul 28 2020, 8:03 AM
AlexisPerry closed D84340: Order of libraries and source files in the f18 frontend.
Jul 28 2020, 8:03 AM · Restricted Project, Unknown Object (Project)

Jul 27 2020

AlexisPerry accepted D84340: Order of libraries and source files in the f18 frontend.
Jul 27 2020, 4:01 PM · Restricted Project, Unknown Object (Project)
AlexisPerry accepted D84340: Order of libraries and source files in the f18 frontend.
Jul 27 2020, 2:59 PM · Restricted Project, Unknown Object (Project)
AlexisPerry added a comment to D84334: [flang] Version information in flang/f18.

I am assuming that f18 will have a MAJOR version number matching the LLVM release? Does classic flang do that as well? Both compilers will probably co-exist for a while and it would be desirable to make them distinguishable to build systems as CMake.

I don't have a solution, but maybe we need to #define __CLASSIC_FLANG in classic flang. I am just throwing out ideas.

Jul 27 2020, 9:38 AM · Restricted Project, Unknown Object (Project)
AlexisPerry accepted D84340: Order of libraries and source files in the f18 frontend.

This looks good to me. I think these changes mean that the vector relocatables never actually gets populated, so it could be removed since the patch uses objlist and liblist exclusively, which are clearer names anyway.

Jul 27 2020, 9:33 AM · Restricted Project, Unknown Object (Project)
AlexisPerry added a comment to D84266: [flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC.

I don't know what changed between my last patch and now, but I am unable to land this patch myself. I keep getting the following error:
EXCEPTION: (ConduitClientException) ERR-CONDUIT-CALL: Conduit API method "harbormaster.buildable.search" does not exist. at [<arcanist>/src/conduit/ConduitFuture.php:65]

Jul 27 2020, 7:56 AM · Restricted Project, Unknown Object (Project)

Jul 22 2020

AlexisPerry accepted D84334: [flang] Version information in flang/f18.

Looks good to me. Please wait for approval from at least one of the other reviewers before merging.

Jul 22 2020, 12:51 PM · Restricted Project, Unknown Object (Project)
AlexisPerry requested changes to D84334: [flang] Version information in flang/f18.

Thanks for the patch! I had a couple questions and one small change request (see inline comments). The questions truly should be treated as questions rather than requests for changes, since I'm not 100% sure of the right answer to them.

Jul 22 2020, 10:07 AM · Restricted Project, Unknown Object (Project)

Jul 21 2020

AlexisPerry added reviewers for D84266: [flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC: naromero77, sscalpone, richard.barton.arm.
Jul 21 2020, 1:24 PM · Restricted Project, Unknown Object (Project)
Herald added a project to D84266: [flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC: Restricted Project.
Jul 21 2020, 1:16 PM · Restricted Project, Unknown Object (Project)

Jul 14 2020

AlexisPerry committed rG02c3f70b47b8: [flang] Change the default F18_FC to gfortran (authored by AlexisPerry).
[flang] Change the default F18_FC to gfortran
Jul 14 2020, 12:12 PM
AlexisPerry closed D83488: [flang] Change the default F18_FC to gfortran.
Jul 14 2020, 12:11 PM · Unknown Object (Project), Restricted Project
AlexisPerry added a comment to D83488: [flang] Change the default F18_FC to gfortran.

@richard.barton.arm Is this patch acceptable now? Thanks!

Jul 14 2020, 7:40 AM · Unknown Object (Project), Restricted Project

Jul 13 2020

AlexisPerry updated the diff for D83488: [flang] Change the default F18_FC to gfortran.

Updates following a rebase on master (due to changes on D83687)

Jul 13 2020, 2:38 PM · Unknown Object (Project), Restricted Project
AlexisPerry committed rGf630b8590f0c: [flang] Extended the flang driver options to include gfortran equivalents to… (authored by AlexisPerry).
[flang] Extended the flang driver options to include gfortran equivalents to…
Jul 13 2020, 1:26 PM
AlexisPerry closed D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options..
Jul 13 2020, 1:26 PM · Unknown Object (Project), Restricted Project
AlexisPerry updated the diff for D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options..

Extended the flang driver options to include gfortran equivalents to pgf90 specific options.

Jul 13 2020, 11:17 AM · Unknown Object (Project), Restricted Project
AlexisPerry added a comment to D83488: [flang] Change the default F18_FC to gfortran.

@richard.barton.arm I have made the requested adjustments in the other patch. Thanks for the feedback!

Jul 13 2020, 11:08 AM · Unknown Object (Project), Restricted Project
AlexisPerry updated the diff for D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options..

Correction for handling of OpenMP enabling flags

Jul 13 2020, 10:58 AM · Unknown Object (Project), Restricted Project
AlexisPerry added a comment to D83488: [flang] Change the default F18_FC to gfortran.

The second part of the split can be found here: https://reviews.llvm.org/D83687

Jul 13 2020, 9:40 AM · Unknown Object (Project), Restricted Project
Herald added a reviewer for D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options.: jdoerfert.
Jul 13 2020, 9:39 AM · Unknown Object (Project), Restricted Project
Herald added a project to D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options.: Restricted Project.
Jul 13 2020, 9:39 AM · Unknown Object (Project), Restricted Project
AlexisPerry updated the diff for D83488: [flang] Change the default F18_FC to gfortran.

Splitting this into two patches as requested by reviewers.

Jul 13 2020, 9:17 AM · Unknown Object (Project), Restricted Project

Jul 9 2020

AlexisPerry added a comment to D83488: [flang] Change the default F18_FC to gfortran.

I'll admit, this is my first time trying to commit to LLVM directly and using Phabricator (rather than on a fork that uses pull requests), and I'm definitely still learning the workflow. I had some git issues when first creating the patch that meant my first commit was lost locally, so when I went to update the patch it only had the second commit which caused the original changes to disappear. I then created a new branch and re-did the changes and updated again, using only a single commit, so that the diff would now have everything in it.

Jul 9 2020, 5:10 PM · Unknown Object (Project), Restricted Project
AlexisPerry added a comment to D83488: [flang] Change the default F18_FC to gfortran.

I don't see the previous change made to set gfortran as default. Are they gone with your diff update?

Jul 9 2020, 4:58 PM · Unknown Object (Project), Restricted Project
AlexisPerry updated the diff for D83488: [flang] Change the default F18_FC to gfortran.

Changed the default external compiler used by the flang temporary driver.

Jul 9 2020, 4:55 PM · Unknown Object (Project), Restricted Project
AlexisPerry updated the diff for D83488: [flang] Change the default F18_FC to gfortran.

Extended the flang driver options to include gfortran equivalents to pgf90 specific options.

Jul 9 2020, 4:41 PM · Unknown Object (Project), Restricted Project
AlexisPerry updated subscribers of D83488: [flang] Change the default F18_FC to gfortran.
Jul 9 2020, 9:06 AM · Unknown Object (Project), Restricted Project
Herald added a reviewer for D83488: [flang] Change the default F18_FC to gfortran: jdoerfert.
Jul 9 2020, 9:05 AM · Unknown Object (Project), Restricted Project
Herald added a project to D83488: [flang] Change the default F18_FC to gfortran: Restricted Project.
Jul 9 2020, 9:01 AM · Unknown Object (Project), Restricted Project