Page MenuHomePhabricator

schweitz (Eric Schweitz)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 22 2015, 10:25 AM (251 w, 9 h)

Recent Activity

Yesterday

schweitz updated subscribers of D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..

+1 @DavidTruby - For pointing the reason for MLIR to use .md files.
It's correct that LLVM uses Sphinx infrastructure to build docs for any sub-project except MLIR.

Wed, Aug 12, 3:21 PM · Restricted Project

Fri, Aug 7

schweitz accepted D85465: [flang] Remove extra CMAKE_CXX_FLAGS in Lower and Optimizer.
Fri, Aug 7, 10:13 AM · Restricted Project, Restricted Project

Thu, Jul 30

schweitz accepted D84936: [flang] Fix CMPLX folding with complex arguments.
Thu, Jul 30, 3:35 PM · Restricted Project, Restricted Project

Wed, Jul 29

schweitz accepted D84842: [flang] Expose specific to generic intrinsic name mapping.
Wed, Jul 29, 8:28 AM · Restricted Project, Restricted Project

Thu, Jul 23

schweitz added inline comments to D84195: [flang][openacc] Skeleton for OpenACC construct lowering.
Thu, Jul 23, 8:42 AM · Restricted Project, Restricted Project

Thu, Jul 16

schweitz added a comment to D83522: [flang] Adopt NoRegionArguments (WhereOp) and ParentOneOf (ResultOp) traits.

Fix build failure

Thu, Jul 16, 8:33 AM · Restricted Project
schweitz accepted D83522: [flang] Adopt NoRegionArguments (WhereOp) and ParentOneOf (ResultOp) traits.
Thu, Jul 16, 8:32 AM · Restricted Project

Wed, Jul 15

schweitz added a reviewer for D83522: [flang] Adopt NoRegionArguments (WhereOp) and ParentOneOf (ResultOp) traits: sscalpone.
Wed, Jul 15, 7:09 AM · Restricted Project
schweitz added a comment to D83522: [flang] Adopt NoRegionArguments (WhereOp) and ParentOneOf (ResultOp) traits.

Ping. Not sure if flang is accepting such changes, if not please let me know and I will abandon this.

Wed, Jul 15, 7:03 AM · Restricted Project

Jul 14 2020

schweitz accepted D83771: [flang] Fix shared library builds for lib/Lower..
Jul 14 2020, 1:00 PM · Restricted Project
schweitz accepted D83659: [flang][OpenMP] upstream OpenMP lowering.
Jul 14 2020, 5:13 AM · Restricted Project, Restricted Project, Restricted Project

Jul 9 2020

schweitz committed rG9263e08251ae: [flang] ifdef to avoid warning about supposedly dead function (authored by schweitz).
[flang] ifdef to avoid warning about supposedly dead function
Jul 9 2020, 4:10 PM
schweitz committed rG7cd1b0ff347d: [flang] partially revert upstreamed code to support complex values in runtime… (authored by schweitz).
[flang] partially revert upstreamed code to support complex values in runtime…
Jul 9 2020, 7:40 AM

Jul 8 2020

schweitz added a comment to D83397: [flang] Replace uses of _Complex with std::complex.

You also still haven't replied with "what bot/compiler/etc is going to break by making this change". Would you please do that?

Jul 8 2020, 8:58 AM · Restricted Project, Restricted Project
schweitz resigned from D83397: [flang] Replace uses of _Complex with std::complex.

I've reverted these models from the upstreamed code for now. It will avoid the warnings.

Jul 8 2020, 8:55 AM · Restricted Project, Restricted Project
schweitz committed rGc54a013e5a82: partial revert on RTBuilder.h to avoid warnings. (authored by schweitz).
partial revert on RTBuilder.h to avoid warnings.
Jul 8 2020, 8:47 AM
schweitz added a comment to D83397: [flang] Replace uses of _Complex with std::complex.

Hi Eric,

There is an active development branch for the flang middle end. https://github.com/flang-compiler/f18-llvm-project/tree/fir-dev

That's not part of the llvm project.

That code base is being upstreamed piecemeal. Not all of the code is upstreamed at this point. It is simply a false impression that code in the middle of being upstreamed is "unused" or "unnecessary". Since it not all of it is upstreamed, changing interfaces and support code in llvm-project directly is going to cause problems that can become hard to track and resolve while the upstreaming is ongoing.

It very much is unused and unnecessary as there are no pieces of that code in the repository.

Jul 8 2020, 8:07 AM · Restricted Project, Restricted Project
schweitz added a comment to D83397: [flang] Replace uses of _Complex with std::complex.

Hi Eric,

Jul 8 2020, 7:44 AM · Restricted Project, Restricted Project
schweitz committed rG24b62f28c5da: [flang] Upstreaming intrinsic call lowering. (authored by schweitz).
[flang] Upstreaming intrinsic call lowering.
Jul 8 2020, 7:34 AM
schweitz closed D83355: [flang] upstream intrinsic call lowering.
Jul 8 2020, 7:34 AM · Restricted Project, Restricted Project
schweitz requested changes to D83397: [flang] Replace uses of _Complex with std::complex.

This will not compile in our builds.

Jul 8 2020, 7:30 AM · Restricted Project, Restricted Project

Jul 7 2020

Herald added a project to D83355: [flang] upstream intrinsic call lowering: Restricted Project.
Jul 7 2020, 4:08 PM · Restricted Project, Restricted Project
schweitz committed rG216a54a04b9b: [flang] Add lowering of I/O statements. (authored by schweitz).
[flang] Add lowering of I/O statements.
Jul 7 2020, 7:32 AM
schweitz closed D83267: [flang] Add lowering of I/O statements.
Jul 7 2020, 7:32 AM · Restricted Project, Restricted Project
schweitz added a comment to D83267: [flang] Add lowering of I/O statements.

Thanks for pointing out those comments. Yes, the I/O runtime is much further along now. I'll update them.

Jul 7 2020, 7:28 AM · Restricted Project, Restricted Project

Jul 6 2020

Herald added a reviewer for D83267: [flang] Add lowering of I/O statements: DavidTruby.
Jul 6 2020, 5:05 PM · Restricted Project, Restricted Project

Jul 3 2020

schweitz committed rG35808ab8e18c: [flang] Add FIRBuilder.cpp (authored by schweitz).
[flang] Add FIRBuilder.cpp
Jul 3 2020, 11:59 AM
schweitz closed D83107: [flang] Add FIR builder.
Jul 3 2020, 11:53 AM · Restricted Project, Restricted Project

Jul 2 2020

schweitz created D83107: [flang] Add FIR builder.
Jul 2 2020, 6:22 PM · Restricted Project, Restricted Project
schweitz accepted D83051: [flang][NFC] Move and rework pgmath description used in folding.
Jul 2 2020, 8:05 AM · Restricted Project, Restricted Project
schweitz committed rG5c02a2421b95: [flang] Add inliner pass. (authored by schweitz).
[flang] Add inliner pass.
Jul 2 2020, 6:27 AM
schweitz committed rGffa1f8198e6e: [flang] Add changes to codegen to convert it to tablegen passes. (authored by schweitz).
[flang] Add changes to codegen to convert it to tablegen passes.
Jul 2 2020, 6:27 AM
schweitz closed D83018: [flang] Add changes to codegen to convert it to tablegen passes..
Jul 2 2020, 6:27 AM · Restricted Project, Restricted Project
schweitz closed D83010: [flang] Add inliner pass..

Commit 5c02a2421b951a14d1294598d0082b32659c7082

Jul 2 2020, 6:25 AM · Restricted Project, Restricted Project

Jul 1 2020

schweitz created D83018: [flang] Add changes to codegen to convert it to tablegen passes..
Jul 1 2020, 6:54 PM · Restricted Project, Restricted Project
schweitz created D83010: [flang] Add inliner pass..
Jul 1 2020, 5:18 PM · Restricted Project, Restricted Project
schweitz accepted D83007: [flang] Add more support for alternate returns.
Jul 1 2020, 4:13 PM · Restricted Project, Restricted Project
schweitz accepted D82989: [flang][NFC] Get formatting in sync with latest clang-format.
Jul 1 2020, 4:13 PM · Restricted Project, Restricted Project
schweitz committed rG5a580bbb8187: [flang] Add the Runtime.h to prepare for more code being upstreamed. (authored by schweitz).
[flang] Add the Runtime.h to prepare for more code being upstreamed.
Jul 1 2020, 1:32 PM
schweitz closed D82991: [flang] Add the Runtime.h to prepare for more code being upstreamed..
Jul 1 2020, 1:32 PM · Restricted Project, Restricted Project
schweitz committed rGe1581540876f: [clang-tidy] Allows the prevailing include header guard in Flang to be… (authored by schweitz).
[clang-tidy] Allows the prevailing include header guard in Flang to be…
Jul 1 2020, 1:00 PM
schweitz closed D82807: [clang-tidy] Allows the prevailing include header guard in Flang ....
Jul 1 2020, 12:59 PM · Restricted Project, Restricted Project
schweitz created D82991: [flang] Add the Runtime.h to prepare for more code being upstreamed..
Jul 1 2020, 12:59 PM · Restricted Project, Restricted Project

Jun 30 2020

schweitz closed D82790: [flang] Coarray lowering.

Committed as bd2c3014e120949c4acc1d107ac71c4091f00a3d

Jun 30 2020, 8:39 AM · Restricted Project, Restricted Project

Jun 29 2020

schweitz updated the diff for D82807: [clang-tidy] Allows the prevailing include header guard in Flang ....
Jun 29 2020, 4:22 PM · Restricted Project, Restricted Project
schweitz committed rGbd2c3014e120: [flang] Add coarray lowering hooks. (authored by schweitz).
[flang] Add coarray lowering hooks.
Jun 29 2020, 2:26 PM
schweitz created D82807: [clang-tidy] Allows the prevailing include header guard in Flang ....
Jun 29 2020, 2:25 PM · Restricted Project, Restricted Project
schweitz created D82790: [flang] Coarray lowering.
Jun 29 2020, 10:48 AM · Restricted Project, Restricted Project
schweitz added a comment to D82693: [flang] Upstream two FIR transformation passes.

In the passes files there are 6 pass creators declared. I failed to find all the definitions in this patch.
It seems sensible to split this into multiple commits. I would also recommend tests for new functionality.

[EDIT: Took too long to write my comments, seems abandoned now]

Jun 29 2020, 10:48 AM · Restricted Project, Restricted Project, Restricted Project
schweitz abandoned D82693: [flang] Upstream two FIR transformation passes.
Jun 29 2020, 7:32 AM · Restricted Project, Restricted Project, Restricted Project

Jun 26 2020

schweitz created D82693: [flang] Upstream two FIR transformation passes.
Jun 26 2020, 4:48 PM · Restricted Project, Restricted Project, Restricted Project
schweitz committed rGc3477c51e599: [flang] Add CHARACTER type lowering helpers and runtime. (authored by schweitz).
[flang] Add CHARACTER type lowering helpers and runtime.
Jun 26 2020, 11:30 AM
schweitz closed D82608: [flang] upstream of CHARACTER helper and runtime lowering.
Jun 26 2020, 11:29 AM · Restricted Project, Restricted Project
schweitz accepted D82168: [flang] Port test_any.sh tests to FileCheck.

Did you remove the test_any.sh script in one of these?

Jun 26 2020, 9:17 AM · Restricted Project, Restricted Project
schweitz accepted D82166: [flang] Port test_any.sh tests to FileCheck: Hand port getsymbols tests.
Jun 26 2020, 9:17 AM · Restricted Project, Restricted Project
schweitz accepted D82167: [flang] Port test_any.sh tests to FileCheck: Hand port canondo{08-18} tests.
Jun 26 2020, 9:17 AM · Restricted Project, Restricted Project
schweitz accepted D82164: [flang] Port test_any.sh tests to FileCheck: Hand port tests which use regexes.
Jun 26 2020, 9:17 AM · Restricted Project, Restricted Project
schweitz accepted D82165: [flang] Port test_any.sh tests to FileCheck: Hand port getdefinition* tests.
Jun 26 2020, 9:17 AM · Restricted Project, Restricted Project

Jun 25 2020

schweitz created D82608: [flang] upstream of CHARACTER helper and runtime lowering.
Jun 25 2020, 4:23 PM · Restricted Project, Restricted Project

Jun 23 2020

schweitz committed rG84f380580531: [flang] add RTBuilder.h (authored by schweitz).
[flang] add RTBuilder.h
Jun 23 2020, 3:07 PM
schweitz closed D82387: [flang] add RTBuilder.
Jun 23 2020, 3:06 PM · Restricted Project, Restricted Project
Herald added a reviewer for D82387: [flang] add RTBuilder: jdoerfert.
Jun 23 2020, 8:31 AM · Restricted Project, Restricted Project

Jun 22 2020

schweitz committed rGa9c478acd090: add copy of MLIR .clang-tidy to squelch noise in phabricator reviews (authored by schweitz).
add copy of MLIR .clang-tidy to squelch noise in phabricator reviews
Jun 22 2020, 3:37 PM
schweitz added a comment to D82164: [flang] Port test_any.sh tests to FileCheck: Hand port tests which use regexes.

Note that the test has issues in that it checks for "error:" but the parser diagnostics that are emitted do not start with this. Because of this, the test misses the fact that even without -Mstandard, there is a diagnostic emitted on one of the testcases.
I propose the fix for this test is a separate change.

Jun 22 2020, 9:39 AM · Restricted Project, Restricted Project
schweitz committed rG3a84d84adcd5: [flang] Finish adding AbstractConverter.h (authored by schweitz).
[flang] Finish adding AbstractConverter.h
Jun 22 2020, 8:36 AM
schweitz closed D82268: [flang] finish adding AbstractConverter.h.
Jun 22 2020, 8:36 AM · Restricted Project, Restricted Project

Jun 20 2020

Herald added a reviewer for D82268: [flang] finish adding AbstractConverter.h: jdoerfert.
Jun 20 2020, 4:57 PM · Restricted Project, Restricted Project
schweitz committed rGb938eaec55b0: [flang] Add BoxValue.h (authored by schweitz).
[flang] Add BoxValue.h
Jun 20 2020, 2:18 PM
schweitz closed D82228: [flang] Add BoxValue (part of upstreaming flang lowering).
Jun 20 2020, 2:18 PM · Restricted Project, Restricted Project

Jun 19 2020

schweitz created D82228: [flang] Add BoxValue (part of upstreaming flang lowering).
Jun 19 2020, 1:04 PM · Restricted Project, Restricted Project
schweitz committed rGb5d51c24488b: [flang] Add SymbolMap (authored by schweitz).
[flang] Add SymbolMap
Jun 19 2020, 11:59 AM
schweitz closed D82140: [flang] Upstream SymbolMap.
Jun 19 2020, 11:59 AM · Restricted Project, Restricted Project
schweitz added inline comments to D82164: [flang] Port test_any.sh tests to FileCheck: Hand port tests which use regexes.
Jun 19 2020, 11:58 AM · Restricted Project, Restricted Project
schweitz added a comment to D82066: [mlir] Allow for patterns to match any root kind..

Do you have any thoughts on matching roots based on their properties such as a supported interface? I could imagine patterns that match on any op that has memory effects, for example.

Jun 19 2020, 8:37 AM · Restricted Project
schweitz added a reviewer for D82140: [flang] Upstream SymbolMap: clementval.
Jun 19 2020, 8:05 AM · Restricted Project, Restricted Project
schweitz added a comment to D82140: [flang] Upstream SymbolMap.

@schweitz did you miss flang/Lower/Support/BoxValue.h or is that in a separate patch?

Jun 19 2020, 8:05 AM · Restricted Project, Restricted Project

Jun 18 2020

Herald added a reviewer for D82140: [flang] Upstream SymbolMap: jdoerfert.
Jun 18 2020, 8:43 PM · Restricted Project, Restricted Project
schweitz abandoned D82067: [flang] addition of Coarray and some header files.
Jun 18 2020, 4:26 PM · Restricted Project, Restricted Project
schweitz added inline comments to D82067: [flang] addition of Coarray and some header files.
Jun 18 2020, 2:46 PM · Restricted Project, Restricted Project
schweitz added a comment to D82067: [flang] addition of Coarray and some header files.

I have a few comments/questions.

Could this have been better as more than one patch? Box, symbolmap in one, RTBuilder in another, and corray in another?

Jun 18 2020, 2:46 PM · Restricted Project, Restricted Project
schweitz added a comment to D82067: [flang] addition of Coarray and some header files.

I'm not qualified to comment on the contents of this patch, but everything builds and tests correctly in an out-of-tree build.

Jun 18 2020, 8:06 AM · Restricted Project, Restricted Project

Jun 17 2020

schweitz updated the diff for D82067: [flang] addition of Coarray and some header files.

minor edits on a comments

Jun 17 2020, 6:54 PM · Restricted Project, Restricted Project
schweitz created D82067: [flang] addition of Coarray and some header files.
Jun 17 2020, 6:54 PM · Restricted Project, Restricted Project
schweitz committed rGb46e2548b67d: [flang] Fix fallout from varous changes to the cmake files. (authored by schweitz).
[flang] Fix fallout from varous changes to the cmake files.
Jun 17 2020, 3:07 PM
schweitz closed D82050: [flang] Fixes build problems stemming from changes to cmake files.
Jun 17 2020, 3:07 PM · Restricted Project, Restricted Project
schweitz updated the diff for D82050: [flang] Fixes build problems stemming from changes to cmake files.

Resolve new conflicts.

Jun 17 2020, 2:34 PM · Restricted Project, Restricted Project
schweitz added a comment to D82038: [flang] Fix out-of-tree builds.

Not the correct change. See https://reviews.llvm.org/D82050

Jun 17 2020, 1:29 PM · Restricted Project, Restricted Project
schweitz created D82050: [flang] Fixes build problems stemming from changes to cmake files.
Jun 17 2020, 1:29 PM · Restricted Project, Restricted Project

Jun 16 2020

schweitz committed rG30db1776935e: [flang] Upstream the Mangler module from lowering. (authored by schweitz).
[flang] Upstream the Mangler module from lowering.
Jun 16 2020, 3:25 PM
schweitz closed D81764: [flang] Add the Mangler module to flang lowering.
Jun 16 2020, 3:24 PM · Restricted Project, Restricted Project
schweitz added inline comments to D81764: [flang] Add the Mangler module to flang lowering.
Jun 16 2020, 3:23 PM · Restricted Project, Restricted Project
schweitz accepted D81940: [flang] AMAX0, MIN1... rewrite to MAX/MIN: make result conversion explicit.
Jun 16 2020, 11:00 AM · Restricted Project, Restricted Project
schweitz updated the diff for D81764: [flang] Add the Mangler module to flang lowering.

Rebase and update with the functional unittest.

Jun 16 2020, 8:49 AM · Restricted Project, Restricted Project
schweitz added a comment to D81764: [flang] Add the Mangler module to flang lowering.

Unit tests on internal naming don't have that dependency. But they do have a dependency on the fixes included in this patch.

I don't think they have dependency, the tests are updated.

IIRC, first the bugs were found using tests and later changes were made to code in fir-dev.
Here's one[1] such I recall

[1]https://github.com/flang-compiler/f18-llvm-project/pull/98/commits/0d0a47020f233f5ea7c10ffb6cd24fb6b9da7b46

Jun 16 2020, 7:42 AM · Restricted Project, Restricted Project

Jun 15 2020

schweitz added a comment to D81764: [flang] Add the Mangler module to flang lowering.

Right, it will take a functional bridge and test driver to run end-to-end tests. Neither has been upstreamed at this point, so it is a bit premature to start adding end-to-end tests.

Jun 15 2020, 9:13 AM · Restricted Project, Restricted Project

Jun 12 2020

schweitz added a comment to D81287: [flang] Add ComplexExpr code for lowering.

The dependences should be in now as part of https://reviews.llvm.org/D81692

Jun 12 2020, 6:15 PM · Restricted Project, Restricted Project
schweitz committed rG4741835e031b: [flang] Add the helper class for building fir.do_loop operations. A fir.do_loop… (authored by schweitz).
[flang] Add the helper class for building fir.do_loop operations. A fir.do_loop…
Jun 12 2020, 5:42 PM
schweitz closed D81692: [flang] add DoLoopHelper.
Jun 12 2020, 5:42 PM · Restricted Project, Restricted Project
schweitz updated the diff for D81692: [flang] add DoLoopHelper.

Add the reference to FIR ops table gen.
Update one of the MLIR table gen dependences (recent name change).

Jun 12 2020, 2:49 PM · Restricted Project, Restricted Project
schweitz added inline comments to D81692: [flang] add DoLoopHelper.
Jun 12 2020, 2:14 PM · Restricted Project, Restricted Project