Page MenuHomePhabricator

schweitz (Eric Schweitz)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 22 2015, 10:25 AM (349 w, 1 d)

Recent Activity

Fri, Jun 17

schweitz added inline comments to D127468: [flang][OpenMP] Initial support the lowering of copyin clause.
Fri, Jun 17, 10:10 AM · Restricted Project, Restricted Project

Mon, Jun 6

schweitz added a comment to D127128: [Flang] Add flag dependent code to execute the loop-body atleast once.

LGTM. (The bots are complaining.)

Mon, Jun 6, 2:36 PM · Restricted Project, Restricted Project
schweitz added a comment to D126643: [flang][fir] Added load-store elimination to fir.store.

Kiran makes a good point that there is a strong desire to perform a true mem-to-reg translation on FIR which would eliminate dead stores and register promote memory traffic to stack slots, etc.

Mon, Jun 6, 8:42 AM · Restricted Project, Restricted Project
schweitz added a comment to D125632: [flang] Move TODO for elemental call with parentheses on argument.

@jeanPerier @schweitz Sorry to bother you again for this issue.

Previously, I mainly tested gfortran and ifort, and did not check classic-flang too much. I checked classic-flang for this issue. It does not support this, either. We tested a lot of workloads using classic-flang and did not get the error for this. So I take it as edge case, and plan not to work on recently.

I tested a lot of F95 test cases. The good news is LLVM Flang in fir-dev performs kind of better than gfortran and classic-flang except for some TODOs. Next, I will include the tests for derived type (including PDT), interoperability with C, and some simple F2003 features. Please let me know if there are some features you cares more and I am happy to make some checks and tests.

Mon, Jun 6, 8:28 AM · Restricted Project, Restricted Project
schweitz accepted D125967: [flang] Fix XArrayCoorOp conversion for index type slices.

Thanks for adding the tests.

Mon, Jun 6, 8:12 AM · Restricted Project, Restricted Project
schweitz added a comment to D124610: [OpenMP] Support operation conversion to LLVM for threadprivate directive.

Yes, this looks good to me for the time being as memref isn't supported. Support for memref can be added later.

You'll want to be careful. The MLIR memref type, when lowered to LLVM, is incompatible with Fortran descriptors and as such might cause some grief. (In FIR, it is a requirement to manage memory references in a way that supports varied Fortran calling conventions.)

IIUC, the concern arises when FIR Dialect types are used in the same IR file as MemRef types. There should be no problem having a memref lowering independent of FIR, right? i.e. Both (OpenMP + Memref -> LLVM) and (OpenMP + FIR -> LLVM) should not be tricky but (OpenMP + FIR + Memref -> LLVM) could be tricky. Is that correct?

Mon, Jun 6, 8:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 27 2022

schweitz added a comment to D124610: [OpenMP] Support operation conversion to LLVM for threadprivate directive.

Yes, this looks good to me for the time being as memref isn't supported. Support for memref can be added later.

May 27 2022, 12:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
schweitz added inline comments to D125967: [flang] Fix XArrayCoorOp conversion for index type slices.
May 27 2022, 11:57 AM · Restricted Project, Restricted Project
schweitz added inline comments to D126375: [Flang][OpenMP] Fix for unstructured regions in OpenMP constructs - 2.
May 27 2022, 11:41 AM · Restricted Project, Restricted Project

May 17 2022

schweitz added a comment to D125632: [flang] Move TODO for elemental call with parentheses on argument.

array_modify is deprecated. It is no longer needed.

May 17 2022, 2:19 PM · Restricted Project, Restricted Project
schweitz accepted D125628: [flang][driver] Add support for generating executables on MacOSX/Darwin.
May 17 2022, 1:38 PM · Restricted Project, Restricted Project, Restricted Project
schweitz accepted D125672: [flang][Runtime] Use proper prototypes in Fortran_main. NFCI.
May 17 2022, 1:32 PM · Restricted Project, Restricted Project

May 12 2022

schweitz added inline comments to D124737: [flang] Support lowering assignment to (sub)string in forall.
May 12 2022, 8:26 AM · Restricted Project, Restricted Project
schweitz committed rG6822ed035f18: Fixes a performance problem with lowering of forall loops and creating (authored by schweitz).
Fixes a performance problem with lowering of forall loops and creating
May 12 2022, 8:12 AM · Restricted Project, Restricted Project
schweitz closed D125336: [flang] Upstream fix for performance issue.
May 12 2022, 8:12 AM · Restricted Project, Restricted Project

May 11 2022

schweitz updated the diff for D125336: [flang] Upstream fix for performance issue.
May 11 2022, 8:29 AM · Restricted Project, Restricted Project
schweitz updated the diff for D125336: [flang] Upstream fix for performance issue.

Fixes clang-format issues on the entire file.

May 11 2022, 8:23 AM · Restricted Project, Restricted Project

May 10 2022

schweitz added reviewers for D125336: [flang] Upstream fix for performance issue: jeanPerier, vdonaldson, PeteSteinfeld.
May 10 2022, 1:37 PM · Restricted Project, Restricted Project
schweitz updated the diff for D125336: [flang] Upstream fix for performance issue.
May 10 2022, 1:34 PM · Restricted Project, Restricted Project
schweitz requested review of D125336: [flang] Upstream fix for performance issue.
May 10 2022, 1:32 PM · Restricted Project, Restricted Project
schweitz accepted D124759: [flang] Install Fortran_main library.
May 10 2022, 1:20 PM · Restricted Project, Restricted Project

May 6 2022

schweitz committed rG1bffc75383a2: Upstream support for POINTER assignment in FORALL. (authored by schweitz).
Upstream support for POINTER assignment in FORALL.
May 6 2022, 7:53 PM · Restricted Project, Restricted Project
schweitz closed D125140: [flang] Upstream code to lower pointer assignment in FORALL constructs.
May 6 2022, 7:53 PM · Restricted Project, Restricted Project
schweitz requested review of D125140: [flang] Upstream code to lower pointer assignment in FORALL constructs.
May 6 2022, 3:51 PM · Restricted Project, Restricted Project

May 5 2022

schweitz abandoned D125033: Test diff.
May 5 2022, 4:25 PM · Restricted Project, Restricted Project
schweitz accepted D124669: [flang][driver] Add support for -save-temps.
May 5 2022, 12:43 PM · Restricted Project, Restricted Project, Restricted Project
schweitz requested review of D125033: Test diff.
May 5 2022, 12:00 PM · Restricted Project, Restricted Project
schweitz added a comment to D125007: [flang][driver] Switch to the MLIR coding style in the driver.

LGTM. It's consistent with the overall project and will be easier for the community to maintain in the long run.

May 5 2022, 10:52 AM · Restricted Project, Restricted Project
schweitz accepted D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.
May 5 2022, 10:45 AM · Restricted Project, Restricted Project, Restricted Project

Apr 29 2022

schweitz added inline comments to D124669: [flang][driver] Add support for -save-temps.
Apr 29 2022, 11:19 AM · Restricted Project, Restricted Project, Restricted Project
schweitz accepted D124682: [flang] Fix build bot problem.
Apr 29 2022, 11:05 AM · Restricted Project, Restricted Project

Apr 27 2022

schweitz added a comment to D124226: [flang][OpenMP] Support lowering parse-tree to MLIR for threadprivate directive.

If you want to write a Fortran with OpenMP test that tests more of the pipeline, say to LLVM IR, then flang/test/Driver seems to be one possibility of where to put such a test. That directory is not just driver tests, but more a sundry of tests.

Apr 27 2022, 8:23 AM · Restricted Project, Restricted Project, Restricted Project
schweitz accepted rGd902dd011c94: [flang][driver] NFC: Make code more in line with LLVM style.
Apr 27 2022, 8:11 AM · Restricted Project, Restricted Project

Apr 26 2022

schweitz committed rG8dc8e59eba49: Upstream test for wide character literals. (authored by schweitz).
Upstream test for wide character literals.
Apr 26 2022, 6:25 PM · Restricted Project, Restricted Project
schweitz closed D124488: Add test for wide character literals..
Apr 26 2022, 6:25 PM · Restricted Project, Restricted Project
schweitz requested review of D124488: Add test for wide character literals..
Apr 26 2022, 4:51 PM · Restricted Project, Restricted Project
schweitz committed rG44e58509be72: [NFC] More synching of sources for upstreaming. (authored by schweitz).
[NFC] More synching of sources for upstreaming.
Apr 26 2022, 2:55 PM · Restricted Project, Restricted Project
schweitz closed D124476: [NFC] Synchronize more code to reduce deltas for upstreaming..
Apr 26 2022, 2:55 PM · Restricted Project, Restricted Project
schweitz updated the diff for D124476: [NFC] Synchronize more code to reduce deltas for upstreaming..

Fix clang-format issue.

Apr 26 2022, 2:40 PM · Restricted Project, Restricted Project
schweitz requested review of D124476: [NFC] Synchronize more code to reduce deltas for upstreaming..
Apr 26 2022, 2:00 PM · Restricted Project, Restricted Project
schweitz added a comment to D124277: [Flang] Initial lowering of the Fortran Do loop.

I have changed the name to do_loop.f90 and will write tests in separate files.

I'm not against making test clearer to read but this is again changes that will make the end of upstreaming harder.

I don't quite see how. This was is not present in fir-dev anyway. Also, since we are near the end, perhaps it's OK to be a bit more relaxed?

These tests were present in fir-dev in their initial form. Near the end is exactly where it becomes harder to be sure everything is upstreamed if there is lots of noise in the diffs.

Apr 26 2022, 8:44 AM · Restricted Project, Restricted Project

Apr 25 2022

schweitz committed rG1f31795cb389: [NFC] Cleanup code to get back in synch for upstreaming. (authored by schweitz).
[NFC] Cleanup code to get back in synch for upstreaming.
Apr 25 2022, 3:57 PM · Restricted Project, Restricted Project
schweitz closed D124410: [NFC] More code cleanup for upstreaming..
Apr 25 2022, 3:57 PM · Restricted Project, Restricted Project
schweitz added a comment to D124277: [Flang] Initial lowering of the Fortran Do loop.

It's great to see do loop finally making its way into LLVM main, thanks for working on this @kiranchandramohan !

I would really appreciate if you could break the tests into smaller units. Currently, it's quite tricky to follow them. Indeed, do loop itself is quite complex and I think that it would be beneficial to keep the tests to the required minimum. For example, loop_test1 could be split into:

  • a test for a most basic do loop (i.e. just the loop),
  • a test for a nested do loop,
  • a test for do loop with accumulation that depends on the index variable.

I think that 2 nested loops should be enough, unless we know that things change when moving from 2 to 3 nested loops. Also:

  • is print ing really required in these tests? (that's adding complexity that's IMHO not really needed here)
  • why not use more descriptive names for tests?

Thank you!

Apr 25 2022, 1:58 PM · Restricted Project, Restricted Project
schweitz requested review of D124410: [NFC] More code cleanup for upstreaming..
Apr 25 2022, 12:20 PM · Restricted Project, Restricted Project

Apr 23 2022

schweitz committed rGde8a65f787cc: [NFC] Sync code for upstreaming. (authored by schweitz).
[NFC] Sync code for upstreaming.
Apr 23 2022, 6:10 AM · Restricted Project, Restricted Project
schweitz closed D124310: [NFC] Sync code for upstreaming.
Apr 23 2022, 6:10 AM · Restricted Project, Restricted Project

Apr 22 2022

schweitz added inline comments to D124261: [flang] Fix explicit space finalization.
Apr 22 2022, 4:32 PM · Restricted Project, Restricted Project
schweitz requested review of D124310: [NFC] Sync code for upstreaming.
Apr 22 2022, 4:25 PM · Restricted Project, Restricted Project
schweitz added a comment to D124160: [Flang} Fix issues in lowering loop variable of io implied do loop.

It doesn't look familiar to me, @kiranchandramohan .

Apr 22 2022, 10:37 AM · Restricted Project, Restricted Project
schweitz added inline comments to D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.
Apr 22 2022, 10:34 AM · Restricted Project, Restricted Project, Restricted Project
schweitz added inline comments to D124261: [flang] Fix explicit space finalization.
Apr 22 2022, 10:26 AM · Restricted Project, Restricted Project
schweitz committed rG67609cdf09b0: [NFC] Cosmetic changes to OpenACC.cpp. (authored by schweitz).
[NFC] Cosmetic changes to OpenACC.cpp.
Apr 22 2022, 10:21 AM · Restricted Project, Restricted Project
schweitz closed D124272: [NFC] Reduce noise in the diff for upstreaming.
Apr 22 2022, 10:20 AM · Restricted Project, Restricted Project
schweitz requested review of D124272: [NFC] Reduce noise in the diff for upstreaming.
Apr 22 2022, 9:46 AM · Restricted Project, Restricted Project

Apr 20 2022

schweitz added a comment to D122725: [flang][OpenMP] Added lowering support for atomic read and write constructs.

LGTM. Please wait for approval from @clementval/@schweitz for the location of attaching the OpenMP interface and any outstanding comments from the other reviewers.

Apr 20 2022, 9:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 8 2022

schweitz accepted D123285: [flang] add a static assert in CheckUnitNumberInRangeImpl.
Apr 8 2022, 12:43 PM · Restricted Project, Restricted Project

Apr 6 2022

schweitz accepted D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.

Good to see these improvements going in to MLIR's CSE, Valentin.

Apr 6 2022, 1:07 PM · Restricted Project, Restricted Project, Restricted Project
schweitz added inline comments to D122725: [flang][OpenMP] Added lowering support for atomic read and write constructs.
Apr 6 2022, 8:43 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

schweitz added inline comments to D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.
Apr 5 2022, 8:52 AM · Restricted Project, Restricted Project, Restricted Project
schweitz added a comment to D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.

We pledged to retire bbc/tco in favour of flang-new/fir-opt and this change is a step in the opposite direction (at least in it's current format) . I think that we should maintain the interoperability of tests using bbc/tco and flang-new.

Apr 5 2022, 8:48 AM · Restricted Project, Restricted Project, Restricted Project
schweitz added inline comments to D122725: [flang][OpenMP] Added lowering support for atomic read and write constructs.
Apr 5 2022, 8:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
schweitz added inline comments to D122725: [flang][OpenMP] Added lowering support for atomic read and write constructs.
Apr 5 2022, 8:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 1 2022

schweitz added inline comments to D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.
Apr 1 2022, 10:25 AM · Restricted Project, Restricted Project, Restricted Project
schweitz added inline comments to D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.
Apr 1 2022, 10:23 AM · Restricted Project, Restricted Project, Restricted Project
schweitz accepted D122878: [flang][NFC] Add tests for array-value-copy pass with array with pointers.
Apr 1 2022, 10:09 AM · Restricted Project, Restricted Project
schweitz accepted D122881: [flang] Add global and global box initialization tests.

Thanks for upstreaming these, Valentin.

Apr 1 2022, 10:06 AM · Restricted Project, Restricted Project
schweitz accepted D122889: [flang][NFC] Add tests for fir.address_of.
Apr 1 2022, 10:04 AM · Restricted Project, Restricted Project
schweitz accepted D122888: [flang][NFC] Add tests for select constructs.
Apr 1 2022, 10:02 AM · Restricted Project, Restricted Project
schweitz accepted D122899: [flang] add evaluate::IsAllocatableDesignator helper.

LGTM.

Apr 1 2022, 9:59 AM · Restricted Project, Restricted Project
schweitz accepted D122799: [flang] Update the conversion code for fir.coordinate_of.

Thanks for upstreaming these, Andrzej.

Apr 1 2022, 9:54 AM · Restricted Project, Restricted Project

Mar 18 2022

schweitz accepted D122018: [Flang] Lower the sqrt intrinsics.
Mar 18 2022, 11:18 AM · Restricted Project, Restricted Project
schweitz committed rGd50298ddedaf: [NFC][mlir] Run clang-format on file. (authored by schweitz).
[NFC][mlir] Run clang-format on file.
Mar 18 2022, 8:20 AM · Restricted Project
schweitz committed rG1c083e698504: [mlir] Add support for the nest attribute to the LLVM-IR dialect conversion. (authored by schweitz).
[mlir] Add support for the nest attribute to the LLVM-IR dialect conversion.
Mar 18 2022, 8:15 AM · Restricted Project
schweitz closed D121948: [mlir] Add support for the nest attribute to the LLVM-IR dialect conversion..
Mar 18 2022, 8:15 AM · Restricted Project, Restricted Project

Mar 17 2022

schweitz requested review of D121948: [mlir] Add support for the nest attribute to the LLVM-IR dialect conversion..
Mar 17 2022, 1:44 PM · Restricted Project, Restricted Project
schweitz accepted D121928: [flang][lowering] Add support for lowering of the `ior` intrinsic.

Note: The test should be extended to exercise the elemental aspect of IOR when that gets upstreamed as well.

Mar 17 2022, 10:32 AM · Restricted Project, Restricted Project
schweitz accepted D121917: [flang] Lower some numeric intrinsics.
Mar 17 2022, 9:02 AM · Restricted Project, Restricted Project
schweitz accepted D121918: [flang] Add equivalence lowering tests.
Mar 17 2022, 9:01 AM · Restricted Project, Restricted Project
schweitz accepted D121919: [flang] Add more lowering tests for dummy arguments.
Mar 17 2022, 9:01 AM · Restricted Project, Restricted Project
schweitz accepted D121920: [flang] Add IO lowering test.
Mar 17 2022, 9:00 AM · Restricted Project, Restricted Project
schweitz accepted D121832: [Flang] Lower the spacing, rrspacing intrinsics.
Mar 17 2022, 8:42 AM · Restricted Project, Restricted Project

Mar 16 2022

schweitz committed rGfb9926640196: [flang] Remove unused code and redundant assertion. (authored by schweitz).
[flang] Remove unused code and redundant assertion.
Mar 16 2022, 4:10 PM · Restricted Project, Restricted Project
schweitz closed D121864: [flang] Remove unused code and redundant assertion..
Mar 16 2022, 4:09 PM · Restricted Project, Restricted Project
schweitz requested review of D121864: [flang] Remove unused code and redundant assertion..
Mar 16 2022, 3:31 PM · Restricted Project, Restricted Project
schweitz accepted D121841: [flang] Lower array related intrinsics.
Mar 16 2022, 3:28 PM · Restricted Project, Restricted Project
schweitz accepted D121823: [flang] Lower pack|unpack intrinsics.
Mar 16 2022, 10:45 AM · Restricted Project, Restricted Project
schweitz accepted D121828: [flang] Lower numeric related instrinsics.
Mar 16 2022, 10:45 AM · Restricted Project, Restricted Project

Mar 15 2022

schweitz accepted D121704: [flang] Lower random_[init|number|seed] intrinsics.
Mar 15 2022, 12:28 PM · Restricted Project, Restricted Project
schweitz added a comment to D121710: [flang] Relax fir.rebox verifier with characters.

LGTM except for some potential build issue.

Mar 15 2022, 12:27 PM · Restricted Project, Restricted Project
schweitz accepted D121374: [flang][driver] Add support for `-mllvm`.
Mar 15 2022, 12:25 PM · Restricted Project, Restricted Project, Restricted Project
schweitz accepted D121697: [flang] Lower more pointer assignments/disassociation cases.
Mar 15 2022, 8:50 AM · Restricted Project, Restricted Project

Mar 14 2022

schweitz committed rGc2e7e7595439: Write a pass to annotate constant operands on FIR ops. This works (authored by schweitz).
Write a pass to annotate constant operands on FIR ops. This works
Mar 14 2022, 11:15 AM · Restricted Project, Restricted Project
schweitz closed D121625: [flang] Add AnnotateConstant pass.
Mar 14 2022, 11:15 AM · Restricted Project, Restricted Project
schweitz requested review of D121625: [flang] Add AnnotateConstant pass.
Mar 14 2022, 10:20 AM · Restricted Project, Restricted Project

Mar 10 2022

schweitz accepted D121386: [flang] Lower general forall statement.
Mar 10 2022, 10:05 AM · Restricted Project, Restricted Project
schweitz accepted D121384: [flang] Lower pointer component in derived type.
Mar 10 2022, 10:04 AM · Restricted Project, Restricted Project

Mar 9 2022

schweitz accepted D121301: [flang] Lower more array character cases.
Mar 9 2022, 9:54 AM · Restricted Project, Restricted Project
schweitz accepted D121300: [flang] Update ArrayValueCopy to support array_amend and array_access.
Mar 9 2022, 9:53 AM · Restricted Project, Restricted Project
schweitz added inline comments to D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.
Mar 9 2022, 8:28 AM · Restricted Project, Restricted Project, Restricted Project