Page MenuHomePhabricator
People schweitz

schweitz (Eric Schweitz)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 22 2015, 10:25 AM (295 w, 4 d)

Recent Activity
View All

Mon, Jun 14

schweitz added inline comments to D104100: [flang] Add clang-tidy check for braces around if.
Mon, Jun 14, 11:08 AM · Restricted Project, Unknown Object (Project)

Mon, Jun 7

schweitz added inline comments to D103805: [flang] Define the runtime API for CPU_TIME.
Mon, Jun 7, 7:17 AM · Unknown Object (Project), Restricted Project

Wed, Jun 2

schweitz accepted D103540: [flang] Enabling flang to build with BUILD_SHARED_LIBS=On.
Wed, Jun 2, 5:01 PM · Restricted Project, Unknown Object (Project)

Fri, May 28

schweitz added a comment to D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.

LGTM.

Fri, May 28, 9:35 AM · Restricted Project, Restricted Project

May 13 2021

schweitz added inline comments to D102424: [flang] Clean up file formats.
May 13 2021, 11:05 AM · Unknown Object (Project), Restricted Project

Apr 15 2021

schweitz accepted D100576: [flang][OpenMP] Remove `OmpEndLoopDirective` handles from code..
Apr 15 2021, 10:51 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Apr 6 2021

schweitz accepted D99967: [Flang] Changes to mangling code.
Apr 6 2021, 7:50 PM · Restricted Project
schweitz updated subscribers of D98256: [flang] Save AllocateObject and PointerObject analyzed expression.

They are reminders that there are TODOs with PDTs. You can ignore them for the moment.

Apr 6 2021, 7:37 AM · Restricted Project, Unknown Object (Project)

Mar 24 2021

schweitz committed rG97d8972c9cd1: [flang][fir] Add the pre-code gen rewrite pass and codegen ops. (authored by schweitz).
[flang][fir] Add the pre-code gen rewrite pass and codegen ops.
Mar 24 2021, 7:27 PM
schweitz closed D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 24 2021, 7:27 PM · Unknown Object (Project), Restricted Project
schweitz updated the diff for D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..

Respond to review comments.

Mar 24 2021, 7:32 AM · Unknown Object (Project), Restricted Project

Mar 22 2021

schweitz added inline comments to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 22 2021, 3:48 PM · Unknown Object (Project), Restricted Project

Mar 17 2021

schweitz added inline comments to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 17 2021, 12:57 PM · Unknown Object (Project), Restricted Project
schweitz updated the diff for D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 17 2021, 12:42 PM · Unknown Object (Project), Restricted Project

Mar 16 2021

schweitz accepted D98719: [flang] Replace Arithmetic Ops with their builtin conunterpart.
Mar 16 2021, 11:15 AM · Unknown Object (Project), Restricted Project

Mar 12 2021

schweitz accepted D98522: [flang] Build intrinsic .mod files in include/flang.
Mar 12 2021, 10:32 AM · Restricted Project, Unknown Object (Project)

Mar 10 2021

schweitz added a comment to D98283: [flang][fir] Upstream changes to the pre-FIR tree.

Thank you for the quick fix, @awarzynski.

Mar 10 2021, 10:01 AM · Restricted Project, Unknown Object (Project)
schweitz committed rG987ee6e3cc1f: [flang][fir] Upstream the pre-FIR tree changes. (authored by schweitz).
[flang][fir] Upstream the pre-FIR tree changes.
Mar 10 2021, 7:46 AM
schweitz closed D98283: [flang][fir] Upstream changes to the pre-FIR tree.
Mar 10 2021, 7:46 AM · Restricted Project, Unknown Object (Project)

Mar 9 2021

schweitz added a comment to D98162: Switch generatedTypeParser/generatedAttributeParser to return an OptionalParseResult.

Broke flang builds.

Mar 9 2021, 1:17 PM · Restricted Project
schweitz requested review of D98283: [flang][fir] Upstream changes to the pre-FIR tree.
Mar 9 2021, 12:40 PM · Restricted Project, Unknown Object (Project)
schweitz updated the diff for D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 9 2021, 9:01 AM · Unknown Object (Project), Restricted Project

Mar 8 2021

schweitz added inline comments to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 8 2021, 1:25 PM · Unknown Object (Project), Restricted Project
schweitz updated the diff for D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 8 2021, 12:54 PM · Unknown Object (Project), Restricted Project
schweitz added inline comments to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 8 2021, 12:52 PM · Unknown Object (Project), Restricted Project

Mar 5 2021

schweitz requested review of D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 5 2021, 11:21 AM · Unknown Object (Project), Restricted Project
schweitz accepted D97643: [flang][fir] Add FIR Types parser diagnostic tests + cleanup.
Mar 5 2021, 11:17 AM · Restricted Project

Mar 4 2021

schweitz committed rG21c8e1b00aef: [flang][fir][NFC] Update comments. (authored by schweitz).
[flang][fir][NFC] Update comments.
Mar 4 2021, 1:31 PM

Feb 26 2021

schweitz committed rGac473bb2b2ad: [flang][fir] Upstream utility function valueHasFirAttribute() (authored by schweitz).
[flang][fir] Upstream utility function valueHasFirAttribute()
Feb 26 2021, 6:32 PM
schweitz closed D97502: [flang][fir] Upstream utility function valueHasFirAttribute().
Feb 26 2021, 6:32 PM · Restricted Project, Unknown Object (Project)
schweitz added inline comments to D97502: [flang][fir] Upstream utility function valueHasFirAttribute().
Feb 26 2021, 6:14 PM · Restricted Project, Unknown Object (Project)
schweitz committed rG0b785a46b7ee: [flang][fir] Add remaining Ops. Updates to pre-existing Ops. (authored by schweitz).
[flang][fir] Add remaining Ops. Updates to pre-existing Ops.
Feb 26 2021, 5:22 PM
schweitz closed D97500: [flang][fir] Add remaining Ops. Updates to pre-existing Ops..
Feb 26 2021, 5:22 PM · Restricted Project, Unknown Object (Project)
schweitz added inline comments to D97500: [flang][fir] Add remaining Ops. Updates to pre-existing Ops..
Feb 26 2021, 4:50 PM · Restricted Project, Unknown Object (Project)
schweitz added a comment to D97500: [flang][fir] Add remaining Ops. Updates to pre-existing Ops..
In D97500#2591545, @kiranchandramohan wrote:

Did you miss the fir-ops tests for the new ops?

Feb 26 2021, 4:47 PM · Restricted Project, Unknown Object (Project)
schweitz committed rG5077d42cfa42: [flang][fir][NFC] Removes deprecated messages in builds. (authored by schweitz).
[flang][fir][NFC] Removes deprecated messages in builds.
Feb 26 2021, 4:14 PM
schweitz added inline comments to D97500: [flang][fir] Add remaining Ops. Updates to pre-existing Ops..
Feb 26 2021, 8:14 AM · Restricted Project, Unknown Object (Project)

Feb 25 2021

schweitz committed rG67360decc3d4: [flang][fir] Add array value operations. (authored by schweitz).
[flang][fir] Add array value operations.
Feb 25 2021, 7:17 PM
schweitz closed D97421: [flang][fir] Add array value operations..
Feb 25 2021, 7:17 PM · Restricted Project, Unknown Object (Project)
schweitz added inline comments to D97421: [flang][fir] Add array value operations..
Feb 25 2021, 7:15 PM · Restricted Project, Unknown Object (Project)
schweitz requested review of D97502: [flang][fir] Upstream utility function valueHasFirAttribute().
Feb 25 2021, 2:35 PM · Restricted Project, Unknown Object (Project)
schweitz requested review of D97500: [flang][fir] Add remaining Ops. Updates to pre-existing Ops..
Feb 25 2021, 2:11 PM · Restricted Project, Unknown Object (Project)

Feb 24 2021

schweitz committed rG082ec3ab0776: [flang][fir][NFC] Remove dead code. (authored by schweitz).
[flang][fir][NFC] Remove dead code.
Feb 24 2021, 5:32 PM
schweitz closed D97424: [flang][fir][NFC] Remove dead code..
Feb 24 2021, 5:31 PM · Restricted Project, Unknown Object (Project)
schweitz requested review of D97424: [flang][fir][NFC] Remove dead code..
Feb 24 2021, 4:11 PM · Restricted Project, Unknown Object (Project)
schweitz requested review of D97421: [flang][fir] Add array value operations..
Feb 24 2021, 3:56 PM · Restricted Project, Unknown Object (Project)
schweitz accepted D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.
Feb 24 2021, 12:09 PM · Restricted Project
schweitz committed rG330406143230: [flang][fir] Add zero_bits operation. (authored by schweitz).
[flang][fir] Add zero_bits operation.
Feb 24 2021, 8:15 AM
schweitz closed D97331: [flang][fir] Add zero_bits operation..
Feb 24 2021, 8:15 AM · Unknown Object (Project), Restricted Project

Feb 23 2021

schweitz committed rG674069474216: [flang][fir][NFC] remove dead code (authored by schweitz).
[flang][fir][NFC] remove dead code
Feb 23 2021, 1:21 PM
schweitz closed D97328: [flang][fir][NFC] remove unused function.
Feb 23 2021, 1:21 PM · Restricted Project
schweitz requested review of D97331: [flang][fir] Add zero_bits operation..
Feb 23 2021, 1:18 PM · Unknown Object (Project), Restricted Project
schweitz requested review of D97328: [flang][fir][NFC] remove unused function.
Feb 23 2021, 12:32 PM · Restricted Project

Feb 22 2021

schweitz accepted D97190: [flang][NFC] Add source line to lowering TODO messages.
Feb 22 2021, 8:15 AM · Restricted Project, Unknown Object (Project)

Feb 19 2021

schweitz accepted D97093: [flang] Making Scope::FindCommonBlock a const member.
Feb 19 2021, 5:51 PM · Unknown Object (Project)
schweitz committed rGc68d2895a1f4: [flang][fir] Update flang test tool support classes. (authored by schweitz).
[flang][fir] Update flang test tool support classes.
Feb 19 2021, 4:03 PM
schweitz closed D97073: [flang][fir] Update flang test tool support classes..
Feb 19 2021, 4:03 PM · Restricted Project, Unknown Object (Project)
schweitz added inline comments to D97073: [flang][fir] Update flang test tool support classes..
Feb 19 2021, 12:25 PM · Restricted Project, Unknown Object (Project)
schweitz committed rGa88991d78288: [flang][fir][NFC] run clang-format (authored by schweitz).
[flang][fir][NFC] run clang-format
Feb 19 2021, 12:07 PM
schweitz requested review of D97073: [flang][fir] Update flang test tool support classes..
Feb 19 2021, 11:42 AM · Restricted Project, Unknown Object (Project)

Feb 17 2021

schweitz committed rGfd3297dc32fa: [flang][fir][NFC] clang-tidy change. Add include. (authored by schweitz).
[flang][fir][NFC] clang-tidy change. Add include.
Feb 17 2021, 5:52 PM
schweitz closed D96912: [flang][fir][NFC] clang-tidy change. Add include..
Feb 17 2021, 5:52 PM · Restricted Project, Unknown Object (Project)
schweitz committed rG930150781da1: [flang][fir][NFC] Merge tablegen files. (authored by schweitz).
[flang][fir][NFC] Merge tablegen files.
Feb 17 2021, 5:51 PM
schweitz closed D96908: [flang][fir][NFC] Merge tablegen files..
Feb 17 2021, 5:51 PM · Restricted Project
schweitz committed rG0d4534237de3: [flang][fir][NFC] clang-tidy change (authored by schweitz).
[flang][fir][NFC] clang-tidy change
Feb 17 2021, 3:41 PM
schweitz closed D96911: [flang][fir][NFC] clang-tidy change.
Feb 17 2021, 3:41 PM · Restricted Project
schweitz requested review of D96912: [flang][fir][NFC] clang-tidy change. Add include..
Feb 17 2021, 3:38 PM · Restricted Project, Unknown Object (Project)
schweitz requested review of D96911: [flang][fir][NFC] clang-tidy change.
Feb 17 2021, 3:30 PM · Restricted Project
schweitz requested review of D96908: [flang][fir][NFC] Merge tablegen files..
Feb 17 2021, 3:20 PM · Restricted Project

Feb 12 2021

schweitz accepted D96575: [flang][fir][NFC] Move ComplexType to TableGen type definition.
Feb 12 2021, 3:57 PM · Restricted Project
schweitz accepted D96446: [flang][fir][NFC] Move CharacterType and BoxCharType to TableGen type definition.
Feb 12 2021, 3:57 PM · Unknown Object (Project), Restricted Project
schweitz accepted D96610: [flang][fir][NFC] Move FieldType to TableGen type definition.
Feb 12 2021, 3:56 PM · Unknown Object (Project), Restricted Project
schweitz accepted D96514: [flang][fir][NFC] Move BoxProcType to TableGen type definition.
Feb 12 2021, 3:55 PM · Restricted Project
schweitz committed rG8fc219d58feb: [flang][fir][NFC] Minor format changes to FIROps.td. (authored by schweitz).
[flang][fir][NFC] Minor format changes to FIROps.td.
Feb 12 2021, 3:21 PM
schweitz closed D96633: [flang][NFC] Minor format changes, documentation.
Feb 12 2021, 3:20 PM · Restricted Project
schweitz accepted D96535: [flang][fir] Add fir-opt tool.
Feb 12 2021, 3:17 PM · Restricted Project
schweitz committed rGf800a9bd42bf: [flang][fir][NFC] Move code from FIRDialect.h into a new header. (authored by schweitz).
[flang][fir][NFC] Move code from FIRDialect.h into a new header.
Feb 12 2021, 3:16 PM
schweitz closed D96630: [flang][fir][NFC] Move code from FIRDialect.h into a new header..
Feb 12 2021, 3:16 PM · Restricted Project
schweitz requested review of D96633: [flang][NFC] Minor format changes, documentation.
Feb 12 2021, 1:58 PM · Restricted Project
schweitz updated the diff for D96630: [flang][fir][NFC] Move code from FIRDialect.h into a new header..
Feb 12 2021, 1:24 PM · Restricted Project
schweitz requested review of D96630: [flang][fir][NFC] Move code from FIRDialect.h into a new header..
Feb 12 2021, 1:13 PM · Restricted Project

Feb 11 2021

schweitz abandoned D96454: [flang][fir] Update the code generation test tool.
Feb 11 2021, 3:47 PM · Restricted Project, Unknown Object (Project)
schweitz committed rGf47d7c145b89: [flang][fir][NFC] Rename WhereOp to IfOp. (authored by schweitz).
[flang][fir][NFC] Rename WhereOp to IfOp.
Feb 11 2021, 11:34 AM
schweitz committed rG4dc87d101035: [flang][fir] Update the kind mapping class. (authored by schweitz).
[flang][fir] Update the kind mapping class.
Feb 11 2021, 11:12 AM
schweitz closed D96362: [flang][fir] Update the kind mapping class..
Feb 11 2021, 11:12 AM · Restricted Project, Unknown Object (Project)
schweitz added inline comments to D96514: [flang][fir][NFC] Move BoxProcType to TableGen type definition.
Feb 11 2021, 9:13 AM · Restricted Project
schweitz added inline comments to D96454: [flang][fir] Update the code generation test tool.
Feb 11 2021, 7:40 AM · Restricted Project, Unknown Object (Project)

Feb 10 2021

schweitz requested review of D96454: [flang][fir] Update the code generation test tool.
Feb 10 2021, 2:27 PM · Restricted Project, Unknown Object (Project)
schweitz updated the diff for D96362: [flang][fir] Update the kind mapping class..
Feb 10 2021, 1:39 PM · Restricted Project, Unknown Object (Project)
schweitz updated the diff for D96362: [flang][fir] Update the kind mapping class..
Feb 10 2021, 1:37 PM · Restricted Project, Unknown Object (Project)
schweitz added inline comments to D96362: [flang][fir] Update the kind mapping class..
Feb 10 2021, 1:36 PM · Restricted Project, Unknown Object (Project)

Feb 9 2021

schweitz committed rGe090182fe153: [flang][fir] Updates to internal name uniquer. (authored by schweitz).
[flang][fir] Updates to internal name uniquer.
Feb 9 2021, 2:44 PM
schweitz closed D96361: [flang][fir] Updates to internal name uniquer..
Feb 9 2021, 2:43 PM · Restricted Project, Unknown Object (Project)
schweitz updated the diff for D96362: [flang][fir] Update the kind mapping class..

run clang-format on file

Feb 9 2021, 2:22 PM · Restricted Project, Unknown Object (Project)
schweitz updated the diff for D96361: [flang][fir] Updates to internal name uniquer..

run clang-format on file

Feb 9 2021, 2:19 PM · Restricted Project, Unknown Object (Project)
schweitz requested review of D96362: [flang][fir] Update the kind mapping class..
Feb 9 2021, 11:28 AM · Restricted Project, Unknown Object (Project)
schweitz requested review of D96361: [flang][fir] Updates to internal name uniquer..
Feb 9 2021, 11:25 AM · Restricted Project, Unknown Object (Project)
schweitz committed rG399c3d5b2972: [flang][fir] Add shape, shape_shift, and slice types. (authored by schweitz).
[flang][fir] Add shape, shape_shift, and slice types.
Feb 9 2021, 8:56 AM
schweitz closed D96172: [flang][fir] Add shape, shape_shift, and slice types..
Feb 9 2021, 8:56 AM · Unknown Object (Project), Restricted Project

Feb 8 2021

schweitz closed D95751: [flang][NFC] Rename complex type..

Commit message fumbled. Submitted as 59186902555546b9d864065d03eb1c79cb041409

Feb 8 2021, 4:38 PM · Restricted Project, Restricted Project