- User Since
- Oct 22 2015, 10:25 AM (215 w, 6 d)
Tue, Nov 19
Can someone commit this for me? Thanks!
Mon, Nov 18
Nov 5 2019
Thanks for catching the brain cramp.
Nov 4 2019
Apr 11 2019
@probinson Thank you for the reminder.
Apr 5 2019
A couple small changes to correct the issues.
Right, those failures make sense to me.
Apr 4 2019
Thanks for accepting the changes, Adrian.
Apr 3 2019
Removes the target triple from the test.
Thanks, Paul. I can certainly file a bug after this lands for tracking purposes.
Apr 2 2019
Just wondering if there are any more to-dos with this one. Thanks in advance.
Mar 28 2019
Thank you for your patience regarding the protracted schedule here. We're presently reworking some of the support for Fortran debug with respect to type information.
Mar 27 2019
Updated the diff ahead in time.
Mar 26 2019
Mar 13 2019
added documentation blurb to SourceLevelDebugging.rst
Mar 12 2019
Split tests back into 2 files
Mar 11 2019
Mar 8 2019
Merged test files into one. Also deploy CHECK-DAG.
A little more cleanup of our code to minimize the exact change.
Remove note from code.
Rework of D54043 to use the DISPFlag* enum added afterward.
Mar 7 2019
Noting that porting also required https://reviews.llvm.org/D54755
Nov 27 2018
I believe all the comments have been addressed. Is there anything else required on our end with this one?
Or this could go in first and supply additional tests for your new bit format. :)
I believe all the comments have been addressed. Is there anything else required on our end?
Nov 16 2018
Remove alignment (not needed for DW_TAG_common_block).
Remove default dtor. (not needed)
Add both an llc test and a llvm-as | llvm-dis loop test.
minor fix to a comment in the new test
Added an assembler test.
Nov 9 2018
Nov 6 2018
Use bit 15 as the "extends" bit and free up bit 30.
Nov 5 2018
Add the new flags to the C API.
Nov 2 2018
Aug 14 2017
The argument that the DWARF presentation to existing Fortran debug vendors must be changed doesn't seem too compelling.
Aug 11 2017
Section 5.10 of the DWARF standard specifies the correct, vendor-neutral handling of Fortran's CHARACTER string type.
Section 4.4.3 of the Fortran standard explains the semantics of the CHARACTER type.
For what it's worth, the DW_AT_encoding, while not listed in Appendix A of DWARF (Ver. 4), might actually be quite desirable for Fortran compilers and debuggers for encoding the KIND of the CHARACTER type (in particular when supporting unicode).
Aug 9 2017
It is understood that LLVM will add a superfluous DW_AT_encoding attribute as well. This has not been a real issue when testing existing debuggers with our Fortran compilers. It is generally expected that debuggers will ignore attributes that they don't understand in context. This patch enables the display of CHARACTER type variables under gdb when using flang, for example.
Aug 8 2017
It looks like the proper protocol is to note here that I don't have commit privileges and need someone to do that for me. Thanks in advance.
Fixes for Adrian's comments and cut-n-paste errors. (I'm learning Phabricator.)
Attach both change and test.
Adding a test case.
Generally, we have test cases in flang that would exercise this, so it's a little chicken and egg in that regard. I'll try to whittle something down.