In D85828#2213768, @sameeranjoshi wrote:

+1 @DavidTruby - For pointing the reason for MLIR to use .md files.
It's correct that LLVM uses Sphinx infrastructure to build docs for any sub-project except MLIR.

In D83522#2155799, @jurahul wrote:

Fix build failure

In D83522#2152131, @jurahul wrote:

Ping. Not sure if flang is accepting such changes, if not please let me know and I will abandon this.

In D83397#2139202, @echristo wrote:

You also still haven't replied with "what bot/compiler/etc is going to break by making this change". Would you please do that?

I've reverted these models from the upstreamed code for now. It will avoid the warnings.

In D83397#2139131, @echristo wrote:

In D83397#2139111, @schweitz wrote:

Hi Eric,

There is an active development branch for the flang middle end. https://github.com/flang-compiler/f18-llvm-project/tree/fir-dev

That's not part of the llvm project.

That code base is being upstreamed piecemeal. Not all of the code is upstreamed at this point. It is simply a false impression that code in the middle of being upstreamed is "unused" or "unnecessary". Since it not all of it is upstreamed, changing interfaces and support code in llvm-project directly is going to cause problems that can become hard to track and resolve while the upstreaming is ongoing.

It very much is unused and unnecessary as there are no pieces of that code in the repository.

Hi Eric,

This will not compile in our builds.

Thanks for pointing out those comments. Yes, the I/O runtime is much further along now. I'll update them.

Commit 5c02a2421b951a14d1294598d0082b32659c7082

Committed as bd2c3014e120949c4acc1d107ac71c4091f00a3d

In D82693#2120288, @jdoerfert wrote:

In the passes files there are 6 pass creators declared. I failed to find all the definitions in this patch.
It seems sensible to split this into multiple commits. I would also recommend tests for new functionality.

[EDIT: Took too long to write my comments, seems abandoned now]

Did you remove the test_any.sh script in one of these?

In D82164#2106822, @richard.barton.arm wrote:

Note that the test has issues in that it checks for "error:" but the parser diagnostics that are emitted do not start with this. Because of this, the test misses the fact that even without -Mstandard, there is a diagnostic emitted on one of the testcases.
I propose the fix for this test is a separate change.

Do you have any thoughts on matching roots based on their properties such as a supported interface? I could imagine patterns that match on any op that has memory effects, for example.

In D82140#2103666, @kiranchandramohan wrote:

@schweitz did you miss flang/Lower/Support/BoxValue.h or is that in a separate patch?

In D82067#2101516, @kiranchandramohan wrote:

I have a few comments/questions.

Could this have been better as more than one patch? Box, symbolmap in one, RTBuilder in another, and corray in another?

In D82067#2100790, @PeteSteinfeld wrote:

I'm not qualified to comment on the contents of this patch, but everything builds and tests correctly in an out-of-tree build.

minor edits on a comments

Resolve new conflicts.

Not the correct change. See https://reviews.llvm.org/D82050

Rebase and update with the functional unittest.

In D81764#2093204, @sameeranjoshi wrote:

In D81764#2093014, @schweitz wrote:

Unit tests on internal naming don't have that dependency. But they do have a dependency on the fixes included in this patch.

I don't think they have dependency, the tests are updated.

IIRC, first the bugs were found using tests and later changes were made to code in fir-dev.
Here's one[1] such I recall

[1]https://github.com/flang-compiler/f18-llvm-project/pull/98/commits/0d0a47020f233f5ea7c10ffb6cd24fb6b9da7b46

Right, it will take a functional bridge and test driver to run end-to-end tests. Neither has been upstreamed at this point, so it is a bit premature to start adding end-to-end tests.

The dependences should be in now as part of https://reviews.llvm.org/D81692

Add the reference to FIR ops table gen.
Update one of the MLIR table gen dependences (recent name change).