User Details
- User Since
- Apr 13 2020, 9:02 AM (180 w, 2 d)
Wed, Sep 6
Thanks for finding and fixing this!
Tue, Aug 29
All builds and tests correctly and looks good.
Mon, Aug 28
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
Aug 28 2023
All builds and tests correctly and looks good.
Aug 24 2023
All builds, tests, and looks good.
Aug 23 2023
All builds and tests correctly and looks good.
Aug 22 2023
I agree with Peter on the naming of the file.
Aug 16 2023
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
Aug 15 2023
Thanks for the quick fix!
Aug 8 2023
All builds and tests correctly and looks good.
Aug 7 2023
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
Aug 3 2023
All builds and tests correctly and looks good.
Aug 2 2023
Aug 1 2023
Thanks for cleaning this up, Slava.
Jul 31 2023
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
Polishing up the CMake files.
Jul 28 2023
These changes are to try to get builds to succeed on Debian. I'm now testing
both if the quadmath library exists and if the header file quadmath.h exists in
order to enable use of the quadmath library for folding.
Attempting to get Debian to compile.
Jul 27 2023
Responding to Peter's comments.
Jul 25 2023
All builds and tests correctly and looks good.
Jul 17 2023
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
Jul 12 2023
@vzakhari, here's more information on what I did.
Jul 11 2023
I tried building with nvcc, and I ran into problems because it doesn't support the -Wall option. I did succeed using gcc version 9.3.0. I also tried building with a version of the clang compiler that I built based on llvm release 16.0. I could not get this to work, even with using nvcc as my CMAKE_CUDA_COMPILER. You might want to mention that the version of clang that you use to configure the build must support the NVPTX target.
I tried building using the instructions in GettingStarted.md, but I was not successful. Here's the invocation of cmake I used:
cmake \ -G Ninja \ ../llvm \ -DCMAKE_BUILD_TYPE=Release \ -DFLANG_EXPERIMENTAL_CUDA_RUNTIME=on \ -DCMAKE_CUDA_ARCHITECTURES=80 \ -DLLVM_LIT_ARGS=-v \ -DFLANG_ENABLE_WERROR=On \ -DCMAKE_CXX_STANDARD=17 \ -DCMAKE_C_COMPILER=clang \ -DCMAKE_CXX_COMPILER=clang++ \ -DCMAKE_CUDA_COMPILER=clang \ -DCMAKE_CUDA_HOST_COMPILER=clang++ \ -DLLVM_ENABLE_PROJECTS="clang;mlir;flang;compiler-rt;openmp" \ -DLLVM_BUILD_TOOLS=On \ -DLLVM_INSTALL_UTILS=On \ -DLLVM_TARGETS_TO_BUILD=host \ -DLLVM_ENABLE_ASSERTIONS=ON \ -DCMAKE_CXX_LINK_FLAGS="-Wl,-rpath,$LD_LIBRARY_PATH" \ -DCMAKE_INSTALL_PREFIX=$INSTALLDIR
Jul 3 2023
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
Jun 30 2023
All builds and tests correctly and looks good.
Jun 29 2023
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
Jun 27 2023
All builds and tests correctly and looks good.
Jun 26 2023
It looks like something went wrong in your update. These latest changes don't seem related to the description of the patch.
All builds and tests correctly and looks good.
Thanks! Things build for me with this change. Can you please submit an associated fix?
The new test that you added doesn't trigger the crash in the original test.
All builds and tests correctly and looks good.
@kkwli0, I can't build with this change. I see the following messages in my log file:
[7018/7446] Building CXX object tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o FAILED: tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o /home/sw/thirdparty/gcc/gcc-9.3.0/linux86-64/bin/g++ -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D_LIBCPP_ENABLE_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/local/home/psteinfeld/main/test/build/tools/flang/lib/Optimizer/Builder -I/local/home/psteinfeld/main/test/flang/lib/Optimizer/Builder -I/local/home/psteinfeld/main/test/flang/include -I/local/home/psteinfeld/main/test/build/tools/flang/include -I/local/home/psteinfeld/main/test/build/include -I/local/home/psteinfeld/main/test/llvm/include -isystem /local/home/psteinfeld/main/test/llvm/../mlir/include -isystem /local/home/psteinfeld/main/test/build/tools/mlir/include -isystem /local/home/psteinfeld/main/test/build/tools/clang/include -isystem /local/home/psteinfeld/main/test/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy -Wno-ctad-maybe-unsupported -fno-strict-aliasing -fno-semantic-interposition -O3 -DNDEBUG -std=c++17 -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o -MF tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o.d -o tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o -c /local/home/psteinfeld/main/test/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp In file included from /local/home/psteinfeld/main/test/flang/include/flang/Optimizer/Builder/PPCIntrinsicCall.h:13, from /local/home/psteinfeld/main/test/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp:16: /local/home/psteinfeld/main/test/flang/include/flang/Optimizer/Builder/IntrinsicCall.h: In function ‘mlir::Type fir::getTypeHelper(mlir::MLIRContext*, fir::FirOpBuilder&, fir::ParamTypeId, int)’: /local/home/psteinfeld/main/test/flang/include/flang/Optimizer/Builder/IntrinsicCall.h:578:1: error: control reaches end of non-void function [-Werror=return-type] 578 | } | ^ At global scope: cc1plus: error: unrecognized command line option ‘-Wno-ctad-maybe-unsupported’ [-Werror] cc1plus: all warnings being treated as errors
Jun 22 2023
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
Jun 21 2023
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
Thanks for working on this. Once the design is set, could you please document this new build functionality? A good place to do so might be https://github.com/llvm/llvm-project/blob/main/flang/docs/GettingStarted.md.
All builds and tests correctly and looks good.
Jun 20 2023
Aside fromt the question, all builds and tests correctly and looks good.
Jun 5 2023
All builds and tests correctly and looks good.
May 30 2023
May 22 2023
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
May 19 2023
Thanks for working on this, but this code doesn't work for arrays of coarrays. Here's a test case that shows the problem:
Program bug Use Iso_Fortran_Env Implicit None Integer i Type(event_type) :: ev(2)[*] If (This_Image()==Num_Images()) Then Do i=1,Size(ev) Event Post (ev(i)[1]) End Do End If End Program
May 18 2023
All builds and tests correctly and looks good.
All builds and tests correctly and looks good.
Oops. You're correct @ktras. This patch is good to go.
May 17 2023
Thanks, for working on this, @krtras.
All builds and tests correctly and looks good.
Things build OK, but I get errors in check-flang:
FAIL: Flang :: Semantics/implicit13.f90 (1508 of 2183) ******************** TEST 'Flang :: Semantics/implicit13.f90' FAILED ******************** Script: -- : 'RUN: at line 1'; "/usr/bin/python3.6" /local/home/psteinfeld/main/814/flang/test/Semantics/test_errors.py /local/home/psteinfeld/main/814/flang/test/Semantics/implicit13.f90 /local/home/psteinfeld/main/814/build/bin/flang-new -fc1 -- Exit Code: 1
@ktras, this change is causing some of our internal tests to fail. Here's a small test case that illustrates the problem. This test should compile without error, but it gets a semantic error saying:
bug.f90:4:17: error: The event-variable must be a coarray event post (x[1])
Here's the source of the test:
subroutine bug use iso_fortran_env type(event_type), save :: x[*] event post (x[1]) end
All builds and tests correctly and looks good.
All builds and test correctly and looks good.
May 16 2023
All builds and tests correctly and looks good.
May 15 2023
Thanks for the fast action on this, @mehdi_amini! This solves my performance problem, and flang builds correctly and passes all of the lit tests.
May 12 2023
May 11 2023
Apart from a couple of superfluous includes, all builds and tests correctly and looks good.
May 10 2023
All builds and tests correctly and looks good.
May 3 2023
Thanks for fixing this up, Kiran.