Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

PeteSteinfeld (Pete Steinfeld)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2020, 9:02 AM (180 w, 2 d)

Recent Activity

Wed, Sep 6

PeteSteinfeld accepted D159117: [flang] Avoid cycles during instantiation of derived types.

Thanks for finding and fixing this!

Wed, Sep 6, 6:41 AM · Restricted Project, Restricted Project

Tue, Aug 29

PeteSteinfeld accepted D159035: [flang] Accept FINAL forward reference to separate module procedure.

All builds and tests correctly and looks good.

Tue, Aug 29, 1:20 PM · Restricted Project, Restricted Project

Mon, Aug 28

PeteSteinfeld added a comment to D159039: [flang] Support SELECTED_LOGICAL_KIND() up to lowering.

All builds and tests correctly and looks good.

Mon, Aug 28, 8:41 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D159044: [flang] Support PDT KIND parameters in later parameter kind expressions.

All builds and tests correctly and looks good.

Mon, Aug 28, 8:41 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D159039: [flang] Support SELECTED_LOGICAL_KIND() up to lowering.

All builds and tests correctly and looks good.

Mon, Aug 28, 8:38 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D159034: [flang] Enable more usage of generics with forward-referenced specifics in specification parts.

All builds and tests correctly and looks good.

Mon, Aug 28, 5:55 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D159028: [flang] Better error recovery when using erroneous procedures and pointers as intrinsic actual arguments.

All builds and tests correctly and looks good.

Mon, Aug 28, 5:54 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D159027: [flang] Faster implementation of FindScope().

All builds and tests correctly and looks good.

Mon, Aug 28, 5:53 PM · Restricted Project, Restricted Project

Aug 28 2023

PeteSteinfeld accepted D159005: [compiler-rt][BF16] "bfloat -> float -> bfloat" round-trip conversions.

All builds and tests correctly and looks good.

Aug 28 2023, 12:25 PM · Restricted Project, Restricted Project

Aug 24 2023

PeteSteinfeld accepted D158800: [flang] Skip OPTIONAL arguments in LoopVersioning..

All builds, tests, and looks good.

Aug 24 2023, 6:21 PM · Restricted Project, Restricted Project

Aug 23 2023

PeteSteinfeld accepted D158451: [flang] Fix crash from empty -DMACRO= (bug #64837).

All builds and tests correctly and looks good.

Aug 23 2023, 9:17 AM · Restricted Project, Restricted Project

Aug 22 2023

PeteSteinfeld accepted D158549: [flang] Make ISO_Fortran_binding.h a standalone header again..

I agree with Peter on the naming of the file.

Aug 22 2023, 2:44 PM · Restricted Project, Restricted Project

Aug 16 2023

PeteSteinfeld accepted D158039: [flang] Runtime assigned format errors.

All builds and tests correctly and looks good.

Aug 16 2023, 6:34 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D158038: [flang] Separate module procedure variant.

All builds and tests correctly and looks good.

Aug 16 2023, 6:34 AM · Restricted Project, Restricted Project

Aug 15 2023

PeteSteinfeld accepted D157987: [flang] Fix calls to interfaces with logical literal arguments.

Thanks for the quick fix!

Aug 15 2023, 8:39 AM · Restricted Project, Restricted Project

Aug 8 2023

PeteSteinfeld accepted D157360: [flang] Do concurrent locality specifiers.

All builds and tests correctly and looks good.

Aug 8 2023, 7:53 AM · Restricted Project, Restricted Project

Aug 7 2023

PeteSteinfeld accepted D157346: [flang] Allow reference to earlier generic in later interface.

All builds and tests correctly and looks good.

Aug 7 2023, 6:35 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D157345: [flang] Fold MERGE() of derived type values.

All builds and tests correctly and looks good.

Aug 7 2023, 6:35 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D157342: [flang] Foil attempts to require interoperable objects be CONTIGUOUS.

All builds and tests correctly and looks good.

Aug 7 2023, 6:30 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D157340: [flang] Fix folding of character array kind conversion.

All builds and tests correctly and looks good.

Aug 7 2023, 6:18 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D157336: [flang] Don't crash in error recovery situation.

All builds and tests correctly and looks good.

Aug 7 2023, 5:59 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D157335: [flang] Don't complain about implicitly-typed dummy arguments inherited into an IMPLICIT NONE submodule.

All builds and tests correctly and looks good.

Aug 7 2023, 5:57 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D157330: [flang] Don't emit debugging output to module file.

All builds and tests correctly and looks good.

Aug 7 2023, 5:56 PM · Restricted Project, Restricted Project

Aug 3 2023

PeteSteinfeld abandoned D156932: [flang NFC] Run latest clang-format on .h and .cpp files.
Aug 3 2023, 9:18 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D155887: Enable CUDA Fortran support to bbc with -fcuda.

All builds and tests correctly and looks good.

Aug 3 2023, 7:43 AM · Restricted Project, Restricted Project

Aug 2 2023

PeteSteinfeld requested review of D156932: [flang NFC] Run latest clang-format on .h and .cpp files.
Aug 2 2023, 12:20 PM · Restricted Project, Restricted Project

Aug 1 2023

PeteSteinfeld accepted D156808: [flang] Fixed out-of-tree build after D156435..

Thanks for cleaning this up, Slava.

Aug 1 2023, 10:08 AM · Restricted Project, Restricted Project

Jul 31 2023

PeteSteinfeld accepted D156755: [flang] Don't emit false errors on LBOUND/UBOUND of assumed-rank arrays.

All builds and tests correctly and looks good.

Jul 31 2023, 7:36 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D156757: [flang] Catch insufficient actual elements/characters associated with longer dummy argument.

All builds and tests correctly and looks good.

Jul 31 2023, 6:52 PM · Restricted Project, Restricted Project
PeteSteinfeld committed rG478e0b58605c: [flang] Quadmath 128 bit floating point intrinsics (authored by PeteSteinfeld).
[flang] Quadmath 128 bit floating point intrinsics
Jul 31 2023, 11:13 AM · Restricted Project, Restricted Project
PeteSteinfeld closed D156435: [flang] Folding for quadmath 128 bit floating point intrinsics.
Jul 31 2023, 11:12 AM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D156435: [flang] Folding for quadmath 128 bit floating point intrinsics.

Polishing up the CMake files.

Jul 31 2023, 9:08 AM · Restricted Project, Restricted Project

Jul 28 2023

PeteSteinfeld updated the diff for D156435: [flang] Folding for quadmath 128 bit floating point intrinsics.

These changes are to try to get builds to succeed on Debian. I'm now testing
both if the quadmath library exists and if the header file quadmath.h exists in
order to enable use of the quadmath library for folding.

Jul 28 2023, 2:14 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D156435: [flang] Folding for quadmath 128 bit floating point intrinsics.

Attempting to get Debian to compile.

Jul 28 2023, 6:40 AM · Restricted Project, Restricted Project

Jul 27 2023

PeteSteinfeld updated the diff for D156435: [flang] Folding for quadmath 128 bit floating point intrinsics.

Responding to Peter's comments.

Jul 27 2023, 1:53 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D156435: [flang] Folding for quadmath 128 bit floating point intrinsics.
Jul 27 2023, 1:52 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D156435: [flang] Folding for quadmath 128 bit floating point intrinsics.
Jul 27 2023, 9:23 AM · Restricted Project, Restricted Project
PeteSteinfeld retitled D156435: [flang] Folding for quadmath 128 bit floating point intrinsics from [flang] Quadmath 128 bit floating point intrinsics to [flang] Folding for quadmath 128 bit floating point intrinsics.
Jul 27 2023, 7:28 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D156435: [flang] Folding for quadmath 128 bit floating point intrinsics.
Jul 27 2023, 7:26 AM · Restricted Project, Restricted Project

Jul 25 2023

PeteSteinfeld accepted D156246: [flang] Implement procedure IEEE_COPY_SIGN with mlir::math::CopySignOp.

All builds and tests correctly and looks good.

Jul 25 2023, 9:45 AM · Restricted Project, Restricted Project

Jul 17 2023

PeteSteinfeld accepted D155497: [flang] Fix minor nits with INCLUDE line recognition.

All builds and tests correctly and looks good.

Jul 17 2023, 11:45 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D155494: [flang] Avoid bogus errors with LBOUND/UBOUND(assumed rank array, DIM=).

All builds and tests correctly and looks good.

Jul 17 2023, 11:42 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D155493: [flang] Correct disambiguation of possible statement function definitions.

All builds and tests correctly and looks good.

Jul 17 2023, 11:40 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D155492: [flang] Emit errors on vector subscripts with duplicated elements when object must be definable.

All builds and tests correctly and looks good.

Jul 17 2023, 11:39 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D155491: [flang] Fix constraint check on CLASS() entities.

All builds and tests correctly and looks good.

Jul 17 2023, 11:38 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D155489: [flang] Catch impure specifics called in DO CONCURRENT.

All builds and tests correctly and looks good.

Jul 17 2023, 11:16 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D155488: [flang] Disallow noninteroperable dummy procedures from interoperable procedures.

All builds and tests correctly and looks good.

Jul 17 2023, 11:09 AM · Restricted Project, Restricted Project

Jul 12 2023

PeteSteinfeld added a comment to D155029: [flang][runtime] Support in-tree device build of Flang runtime..

@vzakhari, here's more information on what I did.

Jul 12 2023, 11:20 AM · Restricted Project, Restricted Project

Jul 11 2023

PeteSteinfeld accepted D155029: [flang][runtime] Support in-tree device build of Flang runtime..

I tried building with nvcc, and I ran into problems because it doesn't support the -Wall option. I did succeed using gcc version 9.3.0. I also tried building with a version of the clang compiler that I built based on llvm release 16.0. I could not get this to work, even with using nvcc as my CMAKE_CUDA_COMPILER. You might want to mention that the version of clang that you use to configure the build must support the NVPTX target.

Jul 11 2023, 6:51 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D155029: [flang][runtime] Support in-tree device build of Flang runtime..

I tried building using the instructions in GettingStarted.md, but I was not successful. Here's the invocation of cmake I used:

cmake \
  -G Ninja \
  ../llvm \
  -DCMAKE_BUILD_TYPE=Release \
  -DFLANG_EXPERIMENTAL_CUDA_RUNTIME=on \
  -DCMAKE_CUDA_ARCHITECTURES=80 \
  -DLLVM_LIT_ARGS=-v \
  -DFLANG_ENABLE_WERROR=On \
  -DCMAKE_CXX_STANDARD=17 \
  -DCMAKE_C_COMPILER=clang \
  -DCMAKE_CXX_COMPILER=clang++ \
  -DCMAKE_CUDA_COMPILER=clang \
  -DCMAKE_CUDA_HOST_COMPILER=clang++ \
  -DLLVM_ENABLE_PROJECTS="clang;mlir;flang;compiler-rt;openmp" \
  -DLLVM_BUILD_TOOLS=On \
  -DLLVM_INSTALL_UTILS=On \
  -DLLVM_TARGETS_TO_BUILD=host \
  -DLLVM_ENABLE_ASSERTIONS=ON \
  -DCMAKE_CXX_LINK_FLAGS="-Wl,-rpath,$LD_LIBRARY_PATH" \
  -DCMAKE_INSTALL_PREFIX=$INSTALLDIR
Jul 11 2023, 5:12 PM · Restricted Project, Restricted Project

Jul 3 2023

PeteSteinfeld accepted D154377: [flang] Don't warn about a NaN argument to ISNAN().

All builds and tests correctly and looks good.

Jul 3 2023, 12:02 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D154376: [flang] Check constant POS/LEN arguments IBITS even when not both constant.

All builds and tests correctly and looks good.

Jul 3 2023, 12:01 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D154374: [flang] Fix overflow detection for folding SUM/PRODUCT.

All builds and tests correctly and looks good.

Jul 3 2023, 11:56 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D154370: [flang] More actual argument warnings.

All builds and tests correctly and looks good.

Jul 3 2023, 11:53 AM · Restricted Project, Restricted Project

Jun 30 2023

PeteSteinfeld accepted D154216: [flang] add nested DEC STRUCTURE in DerivedTypeDetails component names.

All builds and tests correctly and looks good.

Jun 30 2023, 7:17 AM · Restricted Project, Restricted Project

Jun 29 2023

PeteSteinfeld accepted D154127: [flang] Block containing an interface.

All builds and tests correctly and looks good.

Jun 29 2023, 1:04 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D154086: [flang] Fix array substring emboxing code generation.

All builds and tests correctly and looks good.

Jun 29 2023, 8:16 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D154072: [flang] Support CHARACTER(4) pointer targets.

All builds and tests correctly and looks good.

Jun 29 2023, 6:04 AM · Restricted Project, Restricted Project

Jun 27 2023

PeteSteinfeld accepted D153792: [flang] Avoid crash in error recovery.

All builds and tests correctly and looks good.

Jun 27 2023, 10:48 AM · Restricted Project, Restricted Project

Jun 26 2023

PeteSteinfeld added a comment to D153792: [flang] Avoid crash in error recovery.

It looks like something went wrong in your update. These latest changes don't seem related to the description of the patch.

Jun 26 2023, 6:07 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D153799: [flang] Handle empty array references in DATA statements.

All builds and tests correctly and looks good.

Jun 26 2023, 3:17 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D152938: [flang] add PPC vec_max, vec_min, vec_madd and vec_nmsub intrinsic.

Thanks! Things build for me with this change. Can you please submit an associated fix?

Jun 26 2023, 3:09 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D153792: [flang] Avoid crash in error recovery.

The new test that you added doesn't trigger the crash in the original test.

Jun 26 2023, 3:05 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D153786: [flang] Catch error: COMMON block and implicit interface external subprogram with same name.

All builds and tests correctly and looks good.

Jun 26 2023, 10:59 AM · Restricted Project, Restricted Project
PeteSteinfeld reopened D152938: [flang] add PPC vec_max, vec_min, vec_madd and vec_nmsub intrinsic.

@kkwli0, I can't build with this change. I see the following messages in my log file:

[7018/7446] Building CXX object tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o
FAILED: tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o 
/home/sw/thirdparty/gcc/gcc-9.3.0/linux86-64/bin/g++ -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D_LIBCPP_ENABLE_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/local/home/psteinfeld/main/test/build/tools/flang/lib/Optimizer/Builder -I/local/home/psteinfeld/main/test/flang/lib/Optimizer/Builder -I/local/home/psteinfeld/main/test/flang/include -I/local/home/psteinfeld/main/test/build/tools/flang/include -I/local/home/psteinfeld/main/test/build/include -I/local/home/psteinfeld/main/test/llvm/include -isystem /local/home/psteinfeld/main/test/llvm/../mlir/include -isystem /local/home/psteinfeld/main/test/build/tools/mlir/include -isystem /local/home/psteinfeld/main/test/build/tools/clang/include -isystem /local/home/psteinfeld/main/test/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy -Wno-ctad-maybe-unsupported -fno-strict-aliasing -fno-semantic-interposition -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o -MF tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o.d -o tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o -c /local/home/psteinfeld/main/test/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
In file included from /local/home/psteinfeld/main/test/flang/include/flang/Optimizer/Builder/PPCIntrinsicCall.h:13,
                 from /local/home/psteinfeld/main/test/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp:16:
/local/home/psteinfeld/main/test/flang/include/flang/Optimizer/Builder/IntrinsicCall.h: In function ‘mlir::Type fir::getTypeHelper(mlir::MLIRContext*, fir::FirOpBuilder&, fir::ParamTypeId, int)’:
/local/home/psteinfeld/main/test/flang/include/flang/Optimizer/Builder/IntrinsicCall.h:578:1: error: control reaches end of non-void function [-Werror=return-type]
  578 | }
      | ^
At global scope:
cc1plus: error: unrecognized command line option ‘-Wno-ctad-maybe-unsupported’ [-Werror]
cc1plus: all warnings being treated as errors
Jun 26 2023, 10:58 AM · Restricted Project, Restricted Project

Jun 22 2023

PeteSteinfeld accepted D153569: [flang] Avoid crash in statement function error case.

All builds and tests correctly and looks good.

Jun 22 2023, 1:24 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D153404: [flang][hlfir] Lower user defined assignment.

All builds and tests correctly and looks good.

Jun 22 2023, 6:58 AM · Restricted Project, Restricted Project

Jun 21 2023

PeteSteinfeld accepted D153478: [flang] Fix bug with generic and homonymous specific module procedure.

All builds and tests correctly and looks good.

Jun 21 2023, 7:28 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D153470: [flang] Error recovery in bad specific MIN/MAX calls.

All builds and tests correctly and looks good.

Jun 21 2023, 3:00 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D153465: [flang] Fix looping on LEN type parameter usage.

All builds and tests correctly and looks good.

Jun 21 2023, 2:06 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D153457: [flang] Rewrite "1*j" to "(j)", not "j", when j is a variable.

All builds and tests correctly and looks good.

Jun 21 2023, 1:16 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D153452: [flang] Fix USE with homonymous renaming.

All builds and tests correctly and looks good.

Jun 21 2023, 12:14 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D153426: Support LLVM_BUILD_USER_FORTRAN_LIBS=[shared|static|all] cmake option.

Thanks for working on this. Once the design is set, could you please document this new build functionality? A good place to do so might be https://github.com/llvm/llvm-project/blob/main/flang/docs/GettingStarted.md.

Jun 21 2023, 11:16 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D153379: Remove -flang-experimental-exec flag.

All builds and tests correctly and looks good.

Jun 21 2023, 10:19 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 20 2023

PeteSteinfeld accepted D153385: [flang] Rework name resolution of Cray pointer declarations.

Aside fromt the question, all builds and tests correctly and looks good.

Jun 20 2023, 5:16 PM · Restricted Project, Restricted Project

Jun 5 2023

PeteSteinfeld accepted D152212: [flang] Fix crash in shape analysis of PACK().

All builds and tests correctly and looks good.

Jun 5 2023, 5:46 PM · Restricted Project, Restricted Project

May 30 2023

PeteSteinfeld committed rG5c000df21531: [flang] [NFC] Remove an unneeded include. (authored by PeteSteinfeld).
[flang] [NFC] Remove an unneeded include.
May 30 2023, 10:10 AM · Restricted Project, Restricted Project
PeteSteinfeld closed D151712: [flang] [NFC] Remove an unneeded include..
May 30 2023, 10:10 AM · Restricted Project, Restricted Project
PeteSteinfeld added reviewers for D151712: [flang] [NFC] Remove an unneeded include.: clementval, vdonaldson.
May 30 2023, 7:54 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D151712: [flang] [NFC] Remove an unneeded include..
May 30 2023, 7:52 AM · Restricted Project, Restricted Project

May 22 2023

PeteSteinfeld accepted D151154: [flang][preprocessing] Allow keyword macro to rename a function-like macro.

All builds and tests correctly and looks good.

May 22 2023, 2:17 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D151124: [flang] More precise CONTIGUOUS checking.

All builds and tests correctly and looks good.

May 22 2023, 10:59 AM · Restricted Project, Restricted Project

May 19 2023

PeteSteinfeld requested changes to D150834: [flang] Fix bug that disallows coindexed-object in event-post-stmt.

Thanks for working on this, but this code doesn't work for arrays of coarrays. Here's a test case that shows the problem:

Program bug
  Use Iso_Fortran_Env
  Implicit None
  Integer i
  Type(event_type) :: ev(2)[*]
  If (This_Image()==Num_Images()) Then
    Do i=1,Size(ev)
      Event Post (ev(i)[1])
    End Do
  End If
End Program
May 19 2023, 11:16 AM · Restricted Project, Restricted Project, Restricted Project

May 18 2023

PeteSteinfeld accepted D150915: [flang] Better error handling and testing of generics with homonymous specifics or derived types.

All builds and tests correctly and looks good.

May 18 2023, 5:10 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D150814: [flang] Don't complain about dummy subroutine under IMPLICIT NONE.

All builds and tests correctly and looks good.

May 18 2023, 1:47 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D150834: [flang] Fix bug that disallows coindexed-object in event-post-stmt.

Oops. You're correct @ktras. This patch is good to go.

May 18 2023, 11:17 AM · Restricted Project, Restricted Project, Restricted Project

May 17 2023

PeteSteinfeld requested changes to D150834: [flang] Fix bug that disallows coindexed-object in event-post-stmt.

Thanks, for working on this, @krtras.

May 17 2023, 7:24 PM · Restricted Project, Restricted Project, Restricted Project
PeteSteinfeld accepted D150819: [flang] Allow redudant attributes on use-/host- associated names.

All builds and tests correctly and looks good.

May 17 2023, 5:29 PM · Restricted Project, Restricted Project
PeteSteinfeld requested changes to D150814: [flang] Don't complain about dummy subroutine under IMPLICIT NONE.

Things build OK, but I get errors in check-flang:

FAIL: Flang :: Semantics/implicit13.f90 (1508 of 2183)
******************** TEST 'Flang :: Semantics/implicit13.f90' FAILED ********************
Script:
--
: 'RUN: at line 1';   "/usr/bin/python3.6" /local/home/psteinfeld/main/814/flang/test/Semantics/test_errors.py /local/home/psteinfeld/main/814/flang/test/Semantics/implicit13.f90 /local/home/psteinfeld/main/814/build/bin/flang-new -fc1
--
Exit Code: 1
May 17 2023, 5:29 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D137204: [flang] Add check for constraints on event-stmts.

@PeteSteinfeld, thanks for letting me know. You are right that the event-variable in an event-post-stmt is allowed to be a coindexed-object. It seems like the using the function evaluate::IsCoarray, as I did, to make sure that event-variable is a coarray disallows coindexed-objects. I will make some changes and open a new differential to address this.

May 17 2023, 4:05 PM · Restricted Project, Restricted Project, Restricted Project
PeteSteinfeld added a comment to D137204: [flang] Add check for constraints on event-stmts.

@ktras, this change is causing some of our internal tests to fail. Here's a small test case that illustrates the problem. This test should compile without error, but it gets a semantic error saying:

bug.f90:4:17: error: The event-variable must be a coarray
      event post (x[1])

Here's the source of the test:

subroutine bug
  use iso_fortran_env
  type(event_type), save :: x[*]
    event post (x[1])
end
May 17 2023, 12:49 PM · Restricted Project, Restricted Project, Restricted Project
PeteSteinfeld accepted D150789: [flang] Fix bogus error under IMPLICIT NONE(EXTERNAL).

All builds and tests correctly and looks good.

May 17 2023, 9:19 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D150783: [flang] Better error recovery for missing THEN in IF construct.

All builds and test correctly and looks good.

May 17 2023, 8:57 AM · Restricted Project, Restricted Project

May 16 2023

PeteSteinfeld accepted D150745: [flang] Apply the check for the constraint `C1172` to `unlock-stmt`, `change-team-stmt`, `end-team-stmt`, and `critical-stmt`.

All builds and tests correctly and looks good.

May 16 2023, 7:26 PM · Restricted Project, Restricted Project, Restricted Project

May 15 2023

PeteSteinfeld added a comment to D150540: Cleanup uses of getAttrDictionary() in MLIR to use getDiscardableAttrDictionary() when possible.

Thanks for the fast action on this, @mehdi_amini! This solves my performance problem, and flang builds correctly and passes all of the lit tests.

May 15 2023, 12:09 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D137204: [flang] Add check for constraints on event-stmts.

Unfortunately, I let this patch sitting for a while, but I would like to push this soon. @PeteSteinfeld, thank you for the review and for the acceptance of the patch. Previously, I replied to your comment about moving IsEventType and IsLockType and stating that because of future planned changes to support event_query, it seems to me that these new functions should remain where they are now in this patch. Please let me know if you disagree, otherwise I plan to push this differential within the next couple days based on the revision having been accepted. Let me know if you would like me to hold off for further discussion, thanks.

May 15 2023, 11:08 AM · Restricted Project, Restricted Project, Restricted Project

May 12 2023

PeteSteinfeld added a comment to D150380: [flang] Fixed global name creation for literal constants..

I tried several versions of clang-format on flang/include/flang/Lower/Mangler.h, but they did not make any formatting change. I am not sure why the pre-commit complains about it. @PeteSteinfeld, could you please try clang-format on your side?

May 12 2023, 11:27 AM · Restricted Project, Restricted Project

May 11 2023

PeteSteinfeld accepted D150380: [flang] Fixed global name creation for literal constants..

Apart from a couple of superfluous includes, all builds and tests correctly and looks good.

May 11 2023, 6:33 PM · Restricted Project, Restricted Project

May 10 2023

PeteSteinfeld accepted D150307: [flang] Apply default module accessibility rules a second time (bug#62598).

All builds and tests correctly and looks good.

May 10 2023, 2:39 PM · Restricted Project, Restricted Project

May 3 2023

PeteSteinfeld accepted D149546: [Flang] Change complex divide lowering.

Thanks for fixing this up, Kiran.

May 3 2023, 10:03 AM · Restricted Project, Restricted Project