Thanks for finding and fixing this!

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds, tests, and looks good.

All builds and tests correctly and looks good.

I agree with Peter on the naming of the file.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

Thanks for the quick fix!

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

Thanks for cleaning this up, Slava.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

Polishing up the CMake files.

These changes are to try to get builds to succeed on Debian. I'm now testing
both if the quadmath library exists and if the header file quadmath.h exists in
order to enable use of the quadmath library for folding.

Attempting to get Debian to compile.

Responding to Peter's comments.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

@vzakhari, here's more information on what I did.

I tried building with nvcc, and I ran into problems because it doesn't support the -Wall option. I did succeed using gcc version 9.3.0. I also tried building with a version of the clang compiler that I built based on llvm release 16.0. I could not get this to work, even with using nvcc as my CMAKE_CUDA_COMPILER. You might want to mention that the version of clang that you use to configure the build must support the NVPTX target.

I tried building using the instructions in GettingStarted.md, but I was not successful. Here's the invocation of cmake I used:

cmake \
  -G Ninja \
  ../llvm \
  -DCMAKE_BUILD_TYPE=Release \
  -DFLANG_EXPERIMENTAL_CUDA_RUNTIME=on \
  -DCMAKE_CUDA_ARCHITECTURES=80 \
  -DLLVM_LIT_ARGS=-v \
  -DFLANG_ENABLE_WERROR=On \
  -DCMAKE_CXX_STANDARD=17 \
  -DCMAKE_C_COMPILER=clang \
  -DCMAKE_CXX_COMPILER=clang++ \
  -DCMAKE_CUDA_COMPILER=clang \
  -DCMAKE_CUDA_HOST_COMPILER=clang++ \
  -DLLVM_ENABLE_PROJECTS="clang;mlir;flang;compiler-rt;openmp" \
  -DLLVM_BUILD_TOOLS=On \
  -DLLVM_INSTALL_UTILS=On \
  -DLLVM_TARGETS_TO_BUILD=host \
  -DLLVM_ENABLE_ASSERTIONS=ON \
  -DCMAKE_CXX_LINK_FLAGS="-Wl,-rpath,$LD_LIBRARY_PATH" \
  -DCMAKE_INSTALL_PREFIX=$INSTALLDIR

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

It looks like something went wrong in your update. These latest changes don't seem related to the description of the patch.

All builds and tests correctly and looks good.

Thanks! Things build for me with this change. Can you please submit an associated fix?

The new test that you added doesn't trigger the crash in the original test.

All builds and tests correctly and looks good.

@kkwli0, I can't build with this change. I see the following messages in my log file:

[7018/7446] Building CXX object tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o
FAILED: tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o 
/home/sw/thirdparty/gcc/gcc-9.3.0/linux86-64/bin/g++ -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D_LIBCPP_ENABLE_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/local/home/psteinfeld/main/test/build/tools/flang/lib/Optimizer/Builder -I/local/home/psteinfeld/main/test/flang/lib/Optimizer/Builder -I/local/home/psteinfeld/main/test/flang/include -I/local/home/psteinfeld/main/test/build/tools/flang/include -I/local/home/psteinfeld/main/test/build/include -I/local/home/psteinfeld/main/test/llvm/include -isystem /local/home/psteinfeld/main/test/llvm/../mlir/include -isystem /local/home/psteinfeld/main/test/build/tools/mlir/include -isystem /local/home/psteinfeld/main/test/build/tools/clang/include -isystem /local/home/psteinfeld/main/test/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy -Wno-ctad-maybe-unsupported -fno-strict-aliasing -fno-semantic-interposition -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o -MF tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o.d -o tools/flang/lib/Optimizer/Builder/CMakeFiles/obj.FIRBuilder.dir/PPCIntrinsicCall.cpp.o -c /local/home/psteinfeld/main/test/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
In file included from /local/home/psteinfeld/main/test/flang/include/flang/Optimizer/Builder/PPCIntrinsicCall.h:13,
                 from /local/home/psteinfeld/main/test/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp:16:
/local/home/psteinfeld/main/test/flang/include/flang/Optimizer/Builder/IntrinsicCall.h: In function ‘mlir::Type fir::getTypeHelper(mlir::MLIRContext*, fir::FirOpBuilder&, fir::ParamTypeId, int)’:
/local/home/psteinfeld/main/test/flang/include/flang/Optimizer/Builder/IntrinsicCall.h:578:1: error: control reaches end of non-void function [-Werror=return-type]
  578 | }
      | ^
At global scope:
cc1plus: error: unrecognized command line option ‘-Wno-ctad-maybe-unsupported’ [-Werror]
cc1plus: all warnings being treated as errors

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

Thanks for working on this. Once the design is set, could you please document this new build functionality? A good place to do so might be https://github.com/llvm/llvm-project/blob/main/flang/docs/GettingStarted.md.

All builds and tests correctly and looks good.

Aside fromt the question, all builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

Thanks for working on this, but this code doesn't work for arrays of coarrays. Here's a test case that shows the problem:

Program bug
  Use Iso_Fortran_Env
  Implicit None
  Integer i
  Type(event_type) :: ev(2)[*]
  If (This_Image()==Num_Images()) Then
    Do i=1,Size(ev)
      Event Post (ev(i)[1])
    End Do
  End If
End Program

All builds and tests correctly and looks good.

All builds and tests correctly and looks good.

Oops. You're correct @ktras. This patch is good to go.

Thanks, for working on this, @krtras.

All builds and tests correctly and looks good.

Things build OK, but I get errors in check-flang:

FAIL: Flang :: Semantics/implicit13.f90 (1508 of 2183)
******************** TEST 'Flang :: Semantics/implicit13.f90' FAILED ********************
Script:
--
: 'RUN: at line 1';   "/usr/bin/python3.6" /local/home/psteinfeld/main/814/flang/test/Semantics/test_errors.py /local/home/psteinfeld/main/814/flang/test/Semantics/implicit13.f90 /local/home/psteinfeld/main/814/build/bin/flang-new -fc1
--
Exit Code: 1

In D137204#4350939, @ktras wrote:

@PeteSteinfeld, thanks for letting me know. You are right that the event-variable in an event-post-stmt is allowed to be a coindexed-object. It seems like the using the function evaluate::IsCoarray, as I did, to make sure that event-variable is a coarray disallows coindexed-objects. I will make some changes and open a new differential to address this.

@ktras, this change is causing some of our internal tests to fail. Here's a small test case that illustrates the problem. This test should compile without error, but it gets a semantic error saying:

bug.f90:4:17: error: The event-variable must be a coarray
      event post (x[1])

Here's the source of the test:

subroutine bug
  use iso_fortran_env
  type(event_type), save :: x[*]
    event post (x[1])
end

All builds and tests correctly and looks good.

All builds and test correctly and looks good.

All builds and tests correctly and looks good.

Thanks for the fast action on this, @mehdi_amini! This solves my performance problem, and flang builds correctly and passes all of the lit tests.

In D137204#4342812, @ktras wrote:

Unfortunately, I let this patch sitting for a while, but I would like to push this soon. @PeteSteinfeld, thank you for the review and for the acceptance of the patch. Previously, I replied to your comment about moving IsEventType and IsLockType and stating that because of future planned changes to support event_query, it seems to me that these new functions should remain where they are now in this patch. Please let me know if you disagree, otherwise I plan to push this differential within the next couple days based on the revision having been accepted. Let me know if you would like me to hold off for further discussion, thanks.

In D150380#4337973, @vzakhari wrote:

I tried several versions of clang-format on flang/include/flang/Lower/Mangler.h, but they did not make any formatting change. I am not sure why the pre-commit complains about it. @PeteSteinfeld, could you please try clang-format on your side?

Apart from a couple of superfluous includes, all builds and tests correctly and looks good.

All builds and tests correctly and looks good.

Thanks for fixing this up, Kiran.