Page MenuHomePhabricator

PeteSteinfeld (Pete Steinfeld)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2020, 9:02 AM (5 w, 6 d)

Recent Activity

Fri, May 22

PeteSteinfeld added a project to D80453: [flang] Fixes for problems with declaring procedure entities: Unknown Object (Project).
Fri, May 22, 1:25 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld created D80453: [flang] Fixes for problems with declaring procedure entities.
Fri, May 22, 12:52 PM · Unknown Object (Project), Restricted Project

Wed, May 20

PeteSteinfeld added inline comments to D79851: [Flang] Semantics for SELECT TYPE.
Wed, May 20, 9:30 PM · Restricted Project, Unknown Object (Project)
PeteSteinfeld added a comment to D79851: [Flang] Semantics for SELECT TYPE.

There's a lot to digest here. Let me know if you have questions.

Wed, May 20, 3:28 PM · Restricted Project, Unknown Object (Project)
PeteSteinfeld requested changes to D79851: [Flang] Semantics for SELECT TYPE.

Thanks for working on this!

Wed, May 20, 12:02 PM · Restricted Project, Unknown Object (Project)

Fri, May 15

PeteSteinfeld committed rG38095549c6a1: [flang] Constraint checks C751 to C760 (authored by PeteSteinfeld).
[flang] Constraint checks C751 to C760
Fri, May 15, 7:33 PM
PeteSteinfeld closed D79798: [flang] Constraint checks C751 to C760.
Fri, May 15, 7:33 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld accepted D79798: [flang] Constraint checks C751 to C760.

Changes have been delivered.

Fri, May 15, 7:33 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld updated the diff for D79798: [flang] Constraint checks C751 to C760.

I changed some raw code to calls to BeginAttrs() and EndAttrs() and changed a
nested "if" to an "end if".

Fri, May 15, 2:09 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld added a comment to D79798: [flang] Constraint checks C751 to C760.

I've submitted another update.

Fri, May 15, 2:09 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld added a comment to D79798: [flang] Constraint checks C751 to C760.

@klausler and @tskeith, do these latest changes look good?

Fri, May 15, 1:37 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld closed D79802: Fixed a problem removing temp files.
Fri, May 15, 1:37 PM · Restricted Project
PeteSteinfeld accepted D79802: Fixed a problem removing temp files.
Fri, May 15, 1:37 PM · Restricted Project

Thu, May 14

PeteSteinfeld updated the diff for D79798: [flang] Constraint checks C751 to C760.
  1. Updating D79798: [flang] Constraint checks C751 to C760 #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

Responses to review comments

Thu, May 14, 1:03 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld abandoned D79957: Responses to review comments.
Thu, May 14, 1:03 PM · Restricted Project
PeteSteinfeld created D79957: Responses to review comments.
Thu, May 14, 12:30 PM · Restricted Project
PeteSteinfeld added inline comments to D79798: [flang] Constraint checks C751 to C760.
Thu, May 14, 12:30 PM · Unknown Object (Project), Restricted Project

Wed, May 13

PeteSteinfeld committed rG72416b136ec6: Fixed a problem removing temp files (authored by PeteSteinfeld).
Fixed a problem removing temp files
Wed, May 13, 11:58 AM
PeteSteinfeld closed D79861: Fixed a problem removing temp files.
Wed, May 13, 11:58 AM · Restricted Project
PeteSteinfeld created D79861: Fixed a problem removing temp files.
Wed, May 13, 7:32 AM · Restricted Project
PeteSteinfeld added a comment to D79802: Fixed a problem removing temp files.

I am not on Windows, so I can't reproduce this. Would you be able to debug this so we understand what the problem is? For example, printing the exception object or looking into the error handler of shutil.rmtree(... , onerror=..) might shed light on things [1].

Wed, May 13, 7:32 AM · Restricted Project

Tue, May 12

PeteSteinfeld requested review of D79798: [flang] Constraint checks C751 to C760.
Tue, May 12, 3:37 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld created D79802: Fixed a problem removing temp files.
Tue, May 12, 1:27 PM · Restricted Project
PeteSteinfeld updated the summary of D79798: [flang] Constraint checks C751 to C760.
Tue, May 12, 12:21 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld added a project to D79798: [flang] Constraint checks C751 to C760: Unknown Object (Project).
Tue, May 12, 12:21 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld created D79798: [flang] Constraint checks C751 to C760.
Tue, May 12, 11:49 AM · Unknown Object (Project), Restricted Project
PeteSteinfeld added a comment to D79578: [mlir] NFC: Rename LoopOps dialect to SCF (Structured Control Flow).

Thanks for offering help! Note that I still don't know who "any other member"s are, is there a list? a chat channel?

Tue, May 12, 6:24 AM · Restricted Project

Mon, May 11

PeteSteinfeld added a comment to D79578: [mlir] NFC: Rename LoopOps dialect to SCF (Structured Control Flow).

I don't think this is the request. The request is just "don't break the build".
The pre-merge testing will test flang as well, but you would have had to rebase the patch after you landed the dependent ones first so that the pre-merge testing could work (I think marking the dependencies in Phabricator would have worked also).

In general trying to get the pre-merge testing green before pushing changes is safer.

Mon, May 11, 11:18 AM · Restricted Project
PeteSteinfeld abandoned D79727: [flang] Fix for compilation problems caused by D79578.

Superseded by D79723.

Mon, May 11, 11:17 AM · Unknown Object (Project), Restricted Project
PeteSteinfeld updated subscribers of D79578: [mlir] NFC: Rename LoopOps dialect to SCF (Structured Control Flow).

@ftynse and @antiagainst , note that one of the clients of mlir is the flang project. Since this revision changed the interface of mlir, all clients of mlir should be checked to see if they still build and test correctly before delivering such changes. Note that the person who knows most about flang's dependency on mlir is @schweitz, but any member of the flang team should be able to verify if a change works for flang.

Mon, May 11, 10:11 AM · Restricted Project
PeteSteinfeld added a project to D79727: [flang] Fix for compilation problems caused by D79578: Unknown Object (Project).
Mon, May 11, 10:11 AM · Unknown Object (Project), Restricted Project
PeteSteinfeld created D79727: [flang] Fix for compilation problems caused by D79578.
Mon, May 11, 10:11 AM · Unknown Object (Project), Restricted Project
PeteSteinfeld accepted D79634: [flang][NFC] Simplify semantics test scripts.

Thanks for doing this.

Mon, May 11, 9:07 AM · Restricted Project, Unknown Object (Project)

Wed, May 6

PeteSteinfeld committed rG07b69dcf6677: [flang] Response to Steve Scalpone's suggestion to improve a message (authored by PeteSteinfeld).
[flang] Response to Steve Scalpone's suggestion to improve a message
Wed, May 6, 3:20 PM
PeteSteinfeld closed D79514: [flang] Response to Steve Scalpone's suggestion to improve a message.
Wed, May 6, 3:20 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld accepted D79514: [flang] Response to Steve Scalpone's suggestion to improve a message.

I've pushed a fix to the problem that @kiranchandramohan pointed out.

Wed, May 6, 3:19 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld reopened D79514: [flang] Response to Steve Scalpone's suggestion to improve a message.
Wed, May 6, 2:44 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld committed rGcfce9b67609f: [flang] Response to Steve Scalpone's suggestion to improve a message (authored by PeteSteinfeld).
[flang] Response to Steve Scalpone's suggestion to improve a message
Wed, May 6, 1:01 PM
PeteSteinfeld closed D79514: [flang] Response to Steve Scalpone's suggestion to improve a message.
Wed, May 6, 1:00 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld accepted D79514: [flang] Response to Steve Scalpone's suggestion to improve a message.

This is a non-functional change.

Wed, May 6, 1:00 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld added a project to D79514: [flang] Response to Steve Scalpone's suggestion to improve a message: Unknown Object (Project).
Wed, May 6, 12:26 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld created D79514: [flang] Response to Steve Scalpone's suggestion to improve a message.
Wed, May 6, 12:26 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld added a comment to rG8d0c3c05f2f4: [flang] New implementation for checks for constraints C741 through C750.

I'm not sure how to best make @sscalpone's suggested change with respect to git and Arcanist commands.

Wed, May 6, 6:25 AM

Tue, May 5

PeteSteinfeld committed rG8d0c3c05f2f4: [flang] New implementation for checks for constraints C741 through C750 (authored by PeteSteinfeld).
[flang] New implementation for checks for constraints C741 through C750
Tue, May 5, 9:42 AM
PeteSteinfeld closed D79263: [flang] New implementation for checks for constraints C741 through C750.
Tue, May 5, 9:42 AM · Unknown Object (Project), Restricted Project

Mon, May 4

PeteSteinfeld updated the diff for D79263: [flang] New implementation for checks for constraints C741 through C750.

Response to review comments

Mon, May 4, 10:43 AM · Unknown Object (Project), Restricted Project
PeteSteinfeld abandoned D79333: Response to review comments.

Not sure how this got to be a separate review.

Mon, May 4, 9:37 AM · Restricted Project
PeteSteinfeld created D79333: Response to review comments.
Mon, May 4, 8:32 AM · Restricted Project
PeteSteinfeld added inline comments to D79263: [flang] New implementation for checks for constraints C741 through C750.
Mon, May 4, 8:32 AM · Unknown Object (Project), Restricted Project
PeteSteinfeld committed rGb6f1bad630fa: [flang] Fixed a crash (authored by PeteSteinfeld).
[flang] Fixed a crash
Mon, May 4, 8:00 AM
PeteSteinfeld closed D79282: [flang] Fixed a crash.
Mon, May 4, 8:00 AM · Unknown Object (Project), Restricted Project

Sat, May 2

PeteSteinfeld updated the diff for D79282: [flang] Fixed a crash.
  1. Updating D79282: [flang] Fixed a crash #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

Added a declaration to make the test case crash the compiler

Sat, May 2, 12:42 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld added inline comments to D79282: [flang] Fixed a crash.
Sat, May 2, 12:42 PM · Unknown Object (Project), Restricted Project

Fri, May 1

PeteSteinfeld added a project to D79282: [flang] Fixed a crash: Unknown Object (Project).
Fri, May 1, 9:04 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld created D79282: [flang] Fixed a crash.
Fri, May 1, 8:54 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld added a project to D79263: [flang] New implementation for checks for constraints C741 through C750: Unknown Object (Project).
Fri, May 1, 5:11 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld abandoned D78160: [flang] Checks for constraints C741 through C750.

This review is superseded by D79263.

Fri, May 1, 5:11 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld created D79263: [flang] New implementation for checks for constraints C741 through C750.
Fri, May 1, 5:11 PM · Unknown Object (Project), Restricted Project

Wed, Apr 29

PeteSteinfeld added inline comments to D78160: [flang] Checks for constraints C741 through C750.
Wed, Apr 29, 9:38 AM · Unknown Object (Project), Restricted Project

Mon, Apr 27

PeteSteinfeld updated the diff for D78160: [flang] Checks for constraints C741 through C750.
Mon, Apr 27, 9:06 AM · Unknown Object (Project), Restricted Project

Apr 23 2020

PeteSteinfeld added a comment to D78685: [flang] Add missing check for unresolved name.

LGTM.

Apr 23 2020, 8:38 AM · Unknown Object (Project), Restricted Project

Apr 15 2020

Herald added a reviewer for D78160: [flang] Checks for constraints C741 through C750: DavidTruby.
Apr 15 2020, 9:16 AM · Unknown Object (Project), Restricted Project

Apr 14 2020

PeteSteinfeld updated the summary of D78160: [flang] Checks for constraints C741 through C750.
Apr 14 2020, 3:45 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld updated the summary of D78160: [flang] Checks for constraints C741 through C750.
Apr 14 2020, 3:45 PM · Unknown Object (Project), Restricted Project
PeteSteinfeld created D78160: [flang] Checks for constraints C741 through C750.
Apr 14 2020, 3:12 PM · Unknown Object (Project), Restricted Project

Apr 13 2020

PeteSteinfeld abandoned D78056: Test change.
Apr 13 2020, 3:47 PM · Restricted Project
PeteSteinfeld created D78056: Test change.
Apr 13 2020, 2:07 PM · Restricted Project