Page MenuHomePhabricator

PeteSteinfeld (Pete Steinfeld)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2020, 9:02 AM (122 w, 6 h)

Recent Activity

Wed, Aug 10

PeteSteinfeld added a comment to D129584: Lower F08 bit-population count intrinsics.

@tarunprabhu , this implementation is failing NAG tests. Do you have access to them?

@PeteSteinfeld, no I do not. If you can file a bug report, I can investigate the failure.

Wed, Aug 10, 9:39 AM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D129316: Shift intrinsics.

@tarunprabhu , this implementation is causing failures in the NAG tests. Do you have access to them?

@PeteSteinfeld, no I do not. If you can file a bug report, I can investigate the failure.

Wed, Aug 10, 9:38 AM · Restricted Project, Restricted Project

Tue, Aug 2

PeteSteinfeld added reviewers for D131041: [Flang] Update build documentation: awarzynski, vdonaldson.
Tue, Aug 2, 7:20 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D131041: [Flang] Update build documentation.
Tue, Aug 2, 7:18 PM · Restricted Project, Restricted Project

Mon, Jul 25

PeteSteinfeld accepted D130484: [flang] Runs FIR SimplifyRegionLitePass pass after calling the inliner.

All builds and tests correctly and looks good.

Mon, Jul 25, 7:50 AM · Restricted Project, Restricted Project

Fri, Jul 22

PeteSteinfeld added a comment to D129296: Lower mask intrinsics.

@tarunprabhu , this is causing NAG tests to fail. Do you have access to them?

Fri, Jul 22, 4:49 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D129584: Lower F08 bit-population count intrinsics.

@tarunprabhu , this implementation is failing NAG tests. Do you have access to them?

Fri, Jul 22, 4:48 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D129316: Shift intrinsics.

@tarunprabhu , this implementation is causing failures in the NAG tests. Do you have access to them?

Fri, Jul 22, 4:48 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D130388: [flang] Correct IsHostAssociated() to be true for BLOCK constructs.

All builds and tests correctly and looks good.

Fri, Jul 22, 4:22 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D130382: [flang] Fix name of dummy argument to intrinsic NEW_LINE(A='').

LGTM!

Fri, Jul 22, 4:16 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D130379: [flang] Fold calls to ISHFTC().

All builds and tests correctly and looks good.

Fri, Jul 22, 4:15 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D130376: [flang] Correct folding of TRANSFER(integer, character array).

All builds and tests correctly and looks good.

Fri, Jul 22, 4:07 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D130375: [flang] Fix parsing and semantics for array element substring%KIND/%LEN.

All builds and tests correctly and looks good.

Fri, Jul 22, 4:00 PM · Restricted Project, Restricted Project

Jul 15 2022

PeteSteinfeld requested changes to D129850: [flang] Add dump-symbols option to bbc.
Jul 15 2022, 2:13 PM · Restricted Project, Restricted Project
PeteSteinfeld requested changes to D129850: [flang] Add dump-symbols option to bbc.

I notice that other dump options have names that include "debug", for example, "-fdebug-dump-pre-fir". I have no strong preference which way to go, other than we should be consistent. You might want to talk to Jean before submitting these changes.

Jul 15 2022, 8:50 AM · Restricted Project, Restricted Project

Jul 13 2022

PeteSteinfeld accepted D129681: [flang] Avoid crash from forward referenced derived type.

All builds and tests correctly and looks good.

Jul 13 2022, 1:17 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D129676: [flang] Ensure name resolution visits "=>NULL()" in entity-decl.

All builds and tests correctly and looks good.

Jul 13 2022, 1:07 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D129674: [flang] Refine semantic checks for procedure pointer assignment.

All builds and tests correctly and looks good.

Jul 13 2022, 12:55 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D129620: [flang] Document the Intrinsic Types.

Thanks for doing this. Please be sure to correct the typo on line 79 before updating.

Jul 13 2022, 6:57 AM · Restricted Project, Restricted Project

Jul 11 2022

PeteSteinfeld accepted D129494: [flang] move getKindMapping() calls out of FIROpBuilder ctor calls.

Thanks for figuring this out.

Jul 11 2022, 1:46 PM · Restricted Project, Restricted Project
PeteSteinfeld requested changes to D129494: [flang] move getKindMapping() calls out of FIROpBuilder ctor calls.

These changes look good. But it looks like there are another two instances of this problem in .../flang/lib/Optimizer/CodeGen/TargetRewrite.cpp. Did you take a look at that file?

Jul 11 2022, 9:37 AM · Restricted Project, Restricted Project

Jul 8 2022

PeteSteinfeld added a comment to D106968: [flang][openacc] Use TableGen to generate the clause parser.

All builds and tests correctly and looks good. But I don't understand this code very well. Someone with relevant expertise should approve.

Jul 8 2022, 6:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 7 2022

PeteSteinfeld committed rGe3611f82fc71: [flang] Fix typo in runtime message (authored by PeteSteinfeld).
[flang] Fix typo in runtime message
Jul 7 2022, 2:11 PM · Restricted Project, Restricted Project
PeteSteinfeld closed D129329: [flang] Fix typo in runtime message.
Jul 7 2022, 2:10 PM · Restricted Project, Restricted Project
PeteSteinfeld added a reviewer for D129329: [flang] Fix typo in runtime message: klausler.
Jul 7 2022, 1:56 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D129329: [flang] Fix typo in runtime message.
Jul 7 2022, 1:54 PM · Restricted Project, Restricted Project
PeteSteinfeld committed rG9f9e9d9cfc2e: [flang] SET_EXPONENT(-0.0) should return -0.0 (authored by PeteSteinfeld).
[flang] SET_EXPONENT(-0.0) should return -0.0
Jul 7 2022, 12:44 PM · Restricted Project, Restricted Project
PeteSteinfeld closed D129309: [flang] SET_EXPONENT(-0.0) should return -0.0.
Jul 7 2022, 12:44 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D129309: [flang] SET_EXPONENT(-0.0) should return -0.0.
Jul 7 2022, 12:40 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D129309: [flang] SET_EXPONENT(-0.0) should return -0.0.

Responding to Peter's commend.

Jul 7 2022, 12:40 PM · Restricted Project, Restricted Project
PeteSteinfeld added a reviewer for D129309: [flang] SET_EXPONENT(-0.0) should return -0.0: klausler.
Jul 7 2022, 10:45 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D129309: [flang] SET_EXPONENT(-0.0) should return -0.0.
Jul 7 2022, 10:44 AM · Restricted Project, Restricted Project

Jun 30 2022

PeteSteinfeld accepted D128935: [flang] Fix APFloat conversion cases.

All builds and tests correctly and looks good.

Jun 30 2022, 1:06 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D128922: [flang] Fix "not yet implemented" message for CHARACTER MIN/MAX.

All builds and tests correctly and looks good.

Jun 30 2022, 9:09 AM · Restricted Project, Restricted Project

Jun 29 2022

PeteSteinfeld accepted D128828: [flang] Fix lowering issue with character temp.

All builds and tests correctly and looks good.

Jun 29 2022, 9:43 AM · Restricted Project, Restricted Project
PeteSteinfeld requested changes to D128828: [flang] Fix lowering issue with character temp.

In my previous comments, I mean to request changes!

Jun 29 2022, 9:10 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D128828: [flang] Fix lowering issue with character temp.

I get a build error for this change. Here's what I see in the log file:

[5929/6618] Building CXX object tools/flang/lib/Optimizer/Dialect/CMakeFiles/obj.FIRDialect.dir/FIROps.cpp.o
FAILED: tools/flang/lib/Optimizer/Dialect/CMakeFiles/obj.FIRDialect.dir/FIROps.cpp.o 
/home/sw/thirdparty/gcc/gcc-9.3.0/linux86-64/bin/g++ -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/local/home/psteinfeld/main/temp/build/tools/flang/lib/Optimizer/Dialect -I/local/home/psteinfeld/main/temp/flang/lib/Optimizer/Dialect -I/local/home/psteinfeld/main/temp/flang/include -I/local/home/psteinfeld/main/temp/build/tools/flang/include -I/local/home/psteinfeld/main/temp/build/include -I/local/home/psteinfeld/main/temp/llvm/include -isystem /local/home/psteinfeld/main/temp/llvm/../mlir/include -isystem /local/home/psteinfeld/main/temp/build/tools/mlir/include -isystem /local/home/psteinfeld/main/temp/build/tools/clang/include -isystem /local/home/psteinfeld/main/temp/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy -fno-strict-aliasing -fno-semantic-interposition -O3 -DNDEBUG  -fno-exceptions -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/flang/lib/Optimizer/Dialect/CMakeFiles/obj.FIRDialect.dir/FIROps.cpp.o -MF tools/flang/lib/Optimizer/Dialect/CMakeFiles/obj.FIRDialect.dir/FIROps.cpp.o.d -o tools/flang/lib/Optimizer/Dialect/CMakeFiles/obj.FIRDialect.dir/FIROps.cpp.o -c /local/home/psteinfeld/main/temp/flang/lib/Optimizer/Dialect/FIROps.cpp
/local/home/psteinfeld/main/temp/flang/lib/Optimizer/Dialect/FIROps.cpp: In static member function ‘static mlir::ParseResult fir::CoordinateOp::parse(mlir::OpAsmParser&, mlir::OperationState&)’:
/local/home/psteinfeld/main/temp/flang/lib/Optimizer/Dialect/FIROps.cpp:952:58: error: ignoring returned value of type ‘mlir::ParseResult’, declared with attribute nodiscard [-Werror=unused-result]
  952 |   parser.addTypesToList(funcTy.getResults(), result.types);
      |                                                          ^
In file included from /local/home/psteinfeld/main/temp/mlir/include/mlir/Dialect/Arithmetic/IR/Arithmetic.h:13,
                 from /local/home/psteinfeld/main/temp/flang/include/flang/Optimizer/Dialect/FIROps.h:13,
                 from /local/home/psteinfeld/main/temp/flang/lib/Optimizer/Dialect/FIROps.cpp:13:
/local/home/psteinfeld/main/temp/mlir/include/mlir/IR/OpImplementation.h:1002:15: note: in call to ‘mlir::ParseResult mlir::AsmParser::addTypesToList(llvm::ArrayRef<mlir::Type>, llvm::SmallVectorImpl<mlir::Type>&)’, declared here
 1002 |   ParseResult addTypesToList(ArrayRef<Type> types,
      |               ^~~~~~~~~~~~~~
In file included from /local/home/psteinfeld/main/temp/mlir/include/mlir/IR/StorageUniquerSupport.h:17,
                 from /local/home/psteinfeld/main/temp/mlir/include/mlir/IR/AttributeSupport.h:17,
                 from /local/home/psteinfeld/main/temp/mlir/include/mlir/IR/Attributes.h:12,
                 from /local/home/psteinfeld/main/temp/mlir/include/mlir/IR/BuiltinAttributeInterfaces.h:13,
                 from /local/home/psteinfeld/main/temp/mlir/include/mlir/IR/BuiltinAttributes.h:12,
                 from /local/home/psteinfeld/main/temp/flang/include/flang/Optimizer/Dialect/FIRType.h:16,
                 from /local/home/psteinfeld/main/temp/flang/include/flang/Optimizer/Dialect/FIROps.h:12,
                 from /local/home/psteinfeld/main/temp/flang/lib/Optimizer/Dialect/FIROps.cpp:13:
/local/home/psteinfeld/main/temp/mlir/include/mlir/Support/LogicalResult.h:112:22: note: ‘mlir::ParseResult’ declared here
  112 | class LLVM_NODISCARD ParseResult : public LogicalResult {
      |                      ^~~~~~~~~~~
cc1plus: all warnings being treated as errors
[5930/6618] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRLLVMDialect.dir/IR/LLVMDialect.cpp.o
Jun 29 2022, 9:09 AM · Restricted Project, Restricted Project

Jun 27 2022

PeteSteinfeld accepted D128634: [flang][NFC] Add IO lowering tests.

All builds and tests correctly and looks good.

Jun 27 2022, 5:58 AM · Restricted Project, Restricted Project

Jun 24 2022

PeteSteinfeld accepted D128510: [flang][OpenACC] Lower parallel loop.

All builds and tests correctly and looks good.

Jun 24 2022, 7:05 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D128507: [flang][lowering] handle MERGE with different FSOURCE and TSOURCE types.

All builds and tests correctly and looks good.

Jun 24 2022, 7:02 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D128518: [flang] Explicitly map host associated symbols.

All builds and tests correctly and looks good.

Jun 24 2022, 7:00 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D128509: [flang] Fix LBOUND with assumed size array and non constant DIM.

All builds and tests correctly and looks good.

Jun 24 2022, 6:58 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D128502: [flang] Use descriptors for real/complex input other than kinds 4 and 8.

All builds and tests correctly and looks good.

Jun 24 2022, 6:46 AM · Restricted Project, Restricted Project

Jun 23 2022

PeteSteinfeld accepted D128459: [flang] Fix forall issue with substring operation.

All builds and tests correctly and looks good.

Jun 23 2022, 1:29 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D128438: [flang] Handle boxed characters that are values when doing a conversion.

All builds and tests correctly and looks good.

Jun 23 2022, 7:21 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D128431: [flang] Increase support for intrinsic module procedures.

All builds and tests correctly and looks good.

Jun 23 2022, 7:17 AM · Restricted Project, Restricted Project

Jun 22 2022

PeteSteinfeld accepted D128380: [flang] Fixes several bugs relating to initialization expressions. An (#1493).

All builds and tests correctly and looks good.

Jun 22 2022, 2:38 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D128331: [flang] Add FIR tests missing from fir-dev.

All builds and tests correctly and looks good.

Jun 22 2022, 6:00 AM · Restricted Project, Restricted Project

Jun 21 2022

PeteSteinfeld accepted D128258: [flang] Cleanup code and add test from fir-dev.

All builds and tests correctly and looks good.

Jun 21 2022, 8:34 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D128255: [flang] Add more diagnostics to fir.coordinate_of.

All builds and tests correctly and looks good.

Jun 21 2022, 8:32 AM · Restricted Project, Restricted Project

Jun 17 2022

PeteSteinfeld accepted D128047: [flang] Fix bug in character casting. Add missing sext/trunc in code gen..

All builds and tests correctly and looks good.

Jun 17 2022, 6:43 AM · Restricted Project, Restricted Project

Jun 15 2022

PeteSteinfeld accepted D127849: [flang][NFC] Fix some formatting.

All builds and tests correctly and looks good.

Jun 15 2022, 6:14 AM · Restricted Project, Restricted Project

Jun 13 2022

PeteSteinfeld accepted D127634: [flang][NFC] Add source location information to report unsupported complex types.

Thanks, Valentin!

Jun 13 2022, 10:17 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D127619: [flang][NFC] Add TODOs for KIND = 2.
Jun 13 2022, 9:42 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D127622: [flang] Add TODO for half-precision intrinsic reductions.

All builds and tests correctly and looks good.

Jun 13 2022, 7:39 AM · Restricted Project, Restricted Project
PeteSteinfeld requested changes to D127619: [flang][NFC] Add TODOs for KIND = 2.

All builds and tests correctly, but it would be better to have calls to TODO() rather than fatal unsupported messages.

Jun 13 2022, 7:37 AM · Restricted Project, Restricted Project
PeteSteinfeld requested changes to D127634: [flang][NFC] Add source location information to report unsupported complex types.

All builds and tests correctly, but it would be better to use calls to TODO() to emit not yet implemented messages.

Jun 13 2022, 7:16 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D127633: [flang] Avoid raising a TODO in fir.boxproc rewrite when not needed (#1560).

All builds and tests correctly and looks good.

Jun 13 2022, 6:59 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D127636: [flang] Fix type mismatch in verification error.

Aside from a couple of nits on the comments, all builds and tests correctly and looks good.

Jun 13 2022, 6:58 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D127617: [flang] Handle reversed bounds and negative length in inlined allocation.

All builds and tests correctly and looks good.

Jun 13 2022, 6:49 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D127616: [flang] system_clock intrinsic calls with dynamically optional arguments.

All builds and tests correctly and looks good.

Jun 13 2022, 6:35 AM · Restricted Project, Restricted Project

Jun 8 2022

PeteSteinfeld added a comment to D127297: Fixes assertion that arose from bad FIR being constructed..

All builds and tests correctly and looks good to me. But you should get someone more familiar with lowering code to approve.

Jun 8 2022, 8:42 AM · Restricted Project, Restricted Project

Jun 1 2022

PeteSteinfeld accepted D126798: [flang][NFC] Document intentional non-support for an extension.

Looks good to me!

Jun 1 2022, 1:49 PM · Restricted Project, Restricted Project

May 24 2022

PeteSteinfeld accepted D126176: [flang][NFC] Make semantics test dosemantics03.f90 warning-correct.

Looks good!

May 24 2022, 10:02 AM · Restricted Project, Restricted Project

May 10 2022

PeteSteinfeld committed rGd4609ae47d16: [flang] Change "bad kind" messages in the runtime to "not yet implemented" (authored by PeteSteinfeld).
[flang] Change "bad kind" messages in the runtime to "not yet implemented"
May 10 2022, 8:10 PM · Restricted Project, Restricted Project
PeteSteinfeld closed D125267: [flang] Change "bad kind" messages in the runtime to "not yet implemented".
May 10 2022, 8:09 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D125336: [flang] Upstream fix for performance issue.

All builds and tests correctly and looks good.

May 10 2022, 2:09 PM · Restricted Project, Restricted Project

May 9 2022

PeteSteinfeld added reviewers for D125267: [flang] Change "bad kind" messages in the runtime to "not yet implemented": klausler, jeanPerier.
May 9 2022, 2:14 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D125267: [flang] Change "bad kind" messages in the runtime to "not yet implemented".
May 9 2022, 2:13 PM · Restricted Project, Restricted Project

May 6 2022

PeteSteinfeld accepted D125144: [flang] Allow ENTRY function result symbol usage before the ENTRY.

All builds and tests correctly and looks good.

May 6 2022, 4:45 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D125140: [flang] Upstream code to lower pointer assignment in FORALL constructs.

All builds and tests correctly and looks good.

May 6 2022, 4:00 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D125131: [flang] Refine error checking in specification expressions.

All builds and tests correctly and looks good.

May 6 2022, 3:00 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D125124: [flang] Allow PDTs with LEN parameters in REDUCE().

All builds and tests correctly and looks good.

May 6 2022, 2:49 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D125129: [flang] Allow implicit declaration of DATA objects in inner procedures.

All builds and tests correctly and looks good.

May 6 2022, 2:48 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D125127: [flang] Allow NULL() actual argument for optional dummy procedure.

All builds and tests correctly and looks good.

May 6 2022, 2:45 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D125116: [flang] Ensure that structure constructors fold parameter references.

All builds and tests correctly and looks good.

May 6 2022, 2:35 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D125113: [flang] Correct folding of SPREAD() for higher ranks.

All builds and tests correctly and looks good.

May 6 2022, 2:32 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D125105: [flang] Operands of SIGN() need not have same kind.

All builds and tests correctly and looks good.

May 6 2022, 10:35 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D125100: [flang] Fold intrinsic functions SPACING() and RRSPACING().

All builds and test correctly and looks good.

May 6 2022, 10:28 AM · Restricted Project, Restricted Project

May 5 2022

PeteSteinfeld committed rGebe24a2a3116: [flang] Change "unsupported" messages in the runtime to "not yet implemented" (authored by PeteSteinfeld).
[flang] Change "unsupported" messages in the runtime to "not yet implemented"
May 5 2022, 3:25 PM · Restricted Project, Restricted Project
PeteSteinfeld closed D125046: [flang] Change "unsupported" messages in the runtime to "not yet implemented".
May 5 2022, 3:25 PM · Restricted Project, Restricted Project
PeteSteinfeld added reviewers for D125046: [flang] Change "unsupported" messages in the runtime to "not yet implemented": klausler, vdonaldson.
May 5 2022, 2:56 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D125046: [flang] Change "unsupported" messages in the runtime to "not yet implemented".
May 5 2022, 2:55 PM · Restricted Project, Restricted Project
PeteSteinfeld committed rGd13444220097: [flang][nfc] Use a message class for "not yet implemented" messages (authored by PeteSteinfeld).
[flang][nfc] Use a message class for "not yet implemented" messages
May 5 2022, 7:13 AM · Restricted Project, Restricted Project
PeteSteinfeld closed D124972: [flang][nfc] Use a message class for "not yet implemented" messages.
May 5 2022, 7:12 AM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D124972: [flang][nfc] Use a message class for "not yet implemented" messages.
May 5 2022, 6:45 AM · Restricted Project, Restricted Project

May 4 2022

PeteSteinfeld accepted D124449: [flang][docs] Update -fbackslash option for PGI compilers.

Sorry for the delay. I didn't notice this the first time around.

May 4 2022, 7:09 PM · Restricted Project, Restricted Project
PeteSteinfeld added a reviewer for D124972: [flang][nfc] Use a message class for "not yet implemented" messages: klausler.
May 4 2022, 6:34 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D124972: [flang][nfc] Use a message class for "not yet implemented" messages.
May 4 2022, 6:31 PM · Restricted Project, Restricted Project

May 2 2022

PeteSteinfeld accepted D124732: [flang] Fix semantics check for RETURN statement.

All builds and tests without error and looks good.

May 2 2022, 8:52 AM · Restricted Project, Restricted Project

Apr 27 2022

PeteSteinfeld committed rG9df99d8ac22f: [flang] Fix MAXLOC/MINLOC when MASK is scalar .FALSE. (authored by PeteSteinfeld).
[flang] Fix MAXLOC/MINLOC when MASK is scalar .FALSE.
Apr 27 2022, 2:52 PM · Restricted Project, Restricted Project
PeteSteinfeld closed D124484: [flang] Fix MAXLOC/MINLOC when MASK is scalar .FALSE..
Apr 27 2022, 2:52 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D124484: [flang] Fix MAXLOC/MINLOC when MASK is scalar .FALSE..

Responding to Peter's latest suggestion.

Apr 27 2022, 2:49 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D124484: [flang] Fix MAXLOC/MINLOC when MASK is scalar .FALSE..

Thanks @klausler. I'm tried to follow your suggestion. Please take another look.

Apr 27 2022, 1:38 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D124484: [flang] Fix MAXLOC/MINLOC when MASK is scalar .FALSE..

Responding to Peter's comments. I restricted all changes to extrema.cpp where
I modified TypedPartialMaxOrMinLoc to test for the scalar .FALSE. value of MASK
and, in the case, create the result and set it to all zeroes.

Apr 27 2022, 1:36 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D124544: [flang] Downgrade a fatal error to a warning.

All builds and tests correctly and looks good.

Apr 27 2022, 12:28 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D124484: [flang] Fix MAXLOC/MINLOC when MASK is scalar .FALSE..
Apr 27 2022, 7:19 AM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D124484: [flang] Fix MAXLOC/MINLOC when MASK is scalar .FALSE..

Responding to Jean's comments. Rather than using the presence of a mask in
the ExtremumLocAccumulator object to determine if the MASK argument is a
scalar .FALSE. value, I added an argument to the GetResult function.

Apr 27 2022, 7:17 AM · Restricted Project, Restricted Project

Apr 26 2022

PeteSteinfeld added reviewers for D124484: [flang] Fix MAXLOC/MINLOC when MASK is scalar .FALSE.: klausler, jeanPerier.
Apr 26 2022, 3:22 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D124484: [flang] Fix MAXLOC/MINLOC when MASK is scalar .FALSE..
Apr 26 2022, 3:21 PM · Restricted Project, Restricted Project