Page MenuHomePhabricator

PeteSteinfeld (Pete Steinfeld)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2020, 9:02 AM (40 w, 7 h)

Recent Activity

Fri, Jan 15

PeteSteinfeld accepted D94849: [flang] Refine WhyNotModifiable().

All builds, tests, and looks good.

Fri, Jan 15, 7:40 PM · Restricted Project, Restricted Project
PeteSteinfeld committed rG1e1a011b09d0: [flang] Disallow INTENT attribute on procedure dummy arguments (authored by PeteSteinfeld).
[flang] Disallow INTENT attribute on procedure dummy arguments
Fri, Jan 15, 8:54 AM
PeteSteinfeld closed D94781: [flang] Disallow INTENT attribute on procedure dummy arguments.
Fri, Jan 15, 8:54 AM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D94781: [flang] Disallow INTENT attribute on procedure dummy arguments.
Fri, Jan 15, 7:56 AM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D94781: [flang] Disallow INTENT attribute on procedure dummy arguments: Restricted Project.
Fri, Jan 15, 7:21 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D94781: [flang] Disallow INTENT attribute on procedure dummy arguments.
Fri, Jan 15, 7:06 AM · Restricted Project, Restricted Project

Thu, Jan 14

PeteSteinfeld accepted D94696: [flang] Fix use-associated procedure in generic.

All builds, tests, and looks good.

Thu, Jan 14, 10:24 AM · Restricted Project, Restricted Project

Wed, Jan 13

PeteSteinfeld committed rG3de92ca78cd4: [flang] Add tests for procedure arguments with implicit interfaces (authored by PeteSteinfeld).
[flang] Add tests for procedure arguments with implicit interfaces
Wed, Jan 13, 4:46 PM
PeteSteinfeld closed D94505: [flang] Add tests for passing procedure arguments with implicit interfaces.
Wed, Jan 13, 4:46 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D94505: [flang] Add tests for passing procedure arguments with implicit interfaces.
Wed, Jan 13, 4:35 PM · Restricted Project, Restricted Project
PeteSteinfeld retitled D94505: [flang] Add tests for passing procedure arguments with implicit interfaces from [flang] Fix bogus message passing external procedure as an actual argument to [flang] Add tests for passing procedure arguments with implicit interfaces.
Wed, Jan 13, 4:32 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D94505: [flang] Add tests for passing procedure arguments with implicit interfaces.

I changed this update to just add some tests and a new error message.

Wed, Jan 13, 4:29 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D94602: [flang] Fix accessibility of USEd name in .mod file.

This is an odd quirk of the language.

Wed, Jan 13, 8:24 AM · Restricted Project, Restricted Project

Tue, Jan 12

PeteSteinfeld accepted D94567: [flang] Do not create HostAssoc symbols in derived type scopes.

All builds, tests, and looks good.

Tue, Jan 12, 6:54 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D94505: [flang] Add tests for passing procedure arguments with implicit interfaces.

If a dummy procedure has an explicit interface, the actual procedure must conform to it (15.5.2.9 paragraph 1). Do your changes allow a actual procedure with an implicit interface to be associated with a dummy procedure with an explicit interface?

Tue, Jan 12, 9:43 AM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D94505: [flang] Add tests for passing procedure arguments with implicit interfaces: Restricted Project.
Tue, Jan 12, 9:04 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D94505: [flang] Add tests for passing procedure arguments with implicit interfaces.
Tue, Jan 12, 9:03 AM · Restricted Project, Restricted Project

Fri, Jan 8

PeteSteinfeld committed rGae0d1d2e5cd3: [flang] Fix bogus message on internal subprogram with alternate return (authored by PeteSteinfeld).
[flang] Fix bogus message on internal subprogram with alternate return
Fri, Jan 8, 10:15 AM
PeteSteinfeld closed D94017: [flang] Fix bogus message on internal subprogram with alternate return.
Fri, Jan 8, 10:14 AM · Restricted Project, Restricted Project

Thu, Jan 7

PeteSteinfeld added inline comments to D94017: [flang] Fix bogus message on internal subprogram with alternate return.
Thu, Jan 7, 5:20 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D94017: [flang] Fix bogus message on internal subprogram with alternate return.

Responding to Jean's comments.

Thu, Jan 7, 8:40 AM · Restricted Project, Restricted Project

Wed, Jan 6

PeteSteinfeld added inline comments to D94017: [flang] Fix bogus message on internal subprogram with alternate return.
Wed, Jan 6, 1:11 PM · Restricted Project, Restricted Project
PeteSteinfeld added a reviewer for D94017: [flang] Fix bogus message on internal subprogram with alternate return: schweitz.
Wed, Jan 6, 1:01 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D94017: [flang] Fix bogus message on internal subprogram with alternate return.

With Peter's guidance, I changed the definition of actual arguments to allow
for the value of a statement label and changed the code that processes actual
arguments to put the value of the label into the actual argument.

Wed, Jan 6, 12:34 PM · Restricted Project, Restricted Project

Mon, Jan 4

PeteSteinfeld added a comment to D94017: [flang] Fix bogus message on internal subprogram with alternate return.

But how can it be okay for the actual argument to be missing when the corresponding dummy argument is an alternate return?

Mon, Jan 4, 10:46 AM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D94017: [flang] Fix bogus message on internal subprogram with alternate return.

I'm confused by this change. The call checking code that's been modified pertains to absent actual arguments; but alternate returns can't be optional and must have corresponding positional actual arguments.

Mon, Jan 4, 10:28 AM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D94017: [flang] Fix bogus message on internal subprogram with alternate return: Restricted Project.
Mon, Jan 4, 9:52 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D94017: [flang] Fix bogus message on internal subprogram with alternate return.
Mon, Jan 4, 9:46 AM · Restricted Project, Restricted Project

Dec 18 2020

PeteSteinfeld accepted D93572: [flang] Fix bugs in .mod file for abstract interface.

All builds, tests, and looks good.

Dec 18 2020, 6:24 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D93552: [flang] Fix bug in IMPLICIT NONE(EXTERNAL).

All builds, tests, and looks good.

Dec 18 2020, 11:25 AM · Restricted Project, Restricted Project

Dec 17 2020

PeteSteinfeld accepted D93496: [flang] Fix -intrinsic-module-directory in flang script.

All looks good. I tested the resulting compiler on both in-tree and out-of-tree builds and as able to run "runtest" for all configurations without a problem.

Dec 17 2020, 6:17 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D93496: [flang] Fix -intrinsic-module-directory in flang script.

I was able to invoke the "runtest" on both in-tree and out-of-tree builds. What command were you using to invoke "runtest" that caused the problem?

Dec 17 2020, 4:44 PM · Restricted Project, Restricted Project

Dec 16 2020

PeteSteinfeld committed rG4e90cad6a6b5: [flang] Handle undeclared names in EQUIVALENCE statements (authored by PeteSteinfeld).
[flang] Handle undeclared names in EQUIVALENCE statements
Dec 16 2020, 11:05 AM
PeteSteinfeld closed D93345: [flang] Handle undeclared names in EQUIVALENCE statements.
Dec 16 2020, 11:04 AM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D93345: [flang] Handle undeclared names in EQUIVALENCE statements.

Responses to review comments. I moved the state variable indicating if we're
resolving names in an EQUIVALENCE statement to the class ScopeHandler and used
the existing FindInScope() function to limit name loopups to the current scope
rather than inventing a new interface.

Dec 16 2020, 10:47 AM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D93345: [flang] Handle undeclared names in EQUIVALENCE statements.
Dec 16 2020, 10:42 AM · Restricted Project, Restricted Project

Dec 15 2020

PeteSteinfeld added a comment to D93344: [flang] Handle multiple names for same operator.

I'm not sure how to layer one patch on top of another. I tried doing an "arc patch D93343" followed by "arc patch D93344". The second command said that it successfully committed the patch, but then it said "Cherry Pick Failed!" How do I combine both patches?

Dec 15 2020, 3:32 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D93343: [flang] Fix bug with USE of USE of generic.

All builds, tests, and looks good.

Dec 15 2020, 3:04 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D93345: [flang] Handle undeclared names in EQUIVALENCE statements: Restricted Project.
Dec 15 2020, 2:53 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D93345: [flang] Handle undeclared names in EQUIVALENCE statements.
Dec 15 2020, 2:53 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D93323: [flang] Clean up TODO comments and fix one (DATA constant ambiguity).

All builds, tests, and looks good.

Dec 15 2020, 12:29 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D93319: [flang] Minor fix to list-directed REAL output editing.

All builds, tests, and looks good.

Dec 15 2020, 12:17 PM · Restricted Project, Restricted Project

Dec 11 2020

PeteSteinfeld committed rG84c09ab44599: [flang] Removed an absolute path from the "flang" script (authored by PeteSteinfeld).
[flang] Removed an absolute path from the "flang" script
Dec 11 2020, 2:02 PM
PeteSteinfeld closed D93131: [flang] Removed an absolute path from the "flang" script.
Dec 11 2020, 2:02 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D93131: [flang] Removed an absolute path from the "flang" script: Restricted Project.
Dec 11 2020, 10:44 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D93131: [flang] Removed an absolute path from the "flang" script.
Dec 11 2020, 10:31 AM · Restricted Project, Restricted Project

Dec 10 2020

PeteSteinfeld added inline comments to D92970: [flang] Fix bogus message on index-names in the presence of associated entities.
Dec 10 2020, 7:37 AM · Restricted Project, Restricted Project
PeteSteinfeld committed rG9168a0f515c9: [flang] Fix bogus message on index-names in the presence of associated entities (authored by PeteSteinfeld).
[flang] Fix bogus message on index-names in the presence of associated entities
Dec 10 2020, 7:37 AM
PeteSteinfeld closed D92970: [flang] Fix bogus message on index-names in the presence of associated entities.
Dec 10 2020, 7:36 AM · Restricted Project, Restricted Project

Dec 9 2020

PeteSteinfeld added a project to D92970: [flang] Fix bogus message on index-names in the presence of associated entities: Restricted Project.
Dec 9 2020, 1:55 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D92970: [flang] Fix bogus message on index-names in the presence of associated entities.
Dec 9 2020, 1:54 PM · Restricted Project, Restricted Project

Dec 8 2020

PeteSteinfeld updated the summary of D92501: [flang] Fix bogus message on interface procedure argument names.
Dec 8 2020, 8:15 AM · Restricted Project, Restricted Project

Dec 7 2020

PeteSteinfeld added a comment to D91888: [flang][openacc] Add clause validaty tests for data construct + fix default restriction.

@clementval , never mind. I had a setup error mixing up the "master" and "main" branches.

Dec 7 2020, 11:26 AM · Restricted Project, Restricted Project
PeteSteinfeld added a reviewer for D91888: [flang][openacc] Add clause validaty tests for data construct + fix default restriction: PeteSteinfeld.
Dec 7 2020, 11:12 AM · Restricted Project, Restricted Project
PeteSteinfeld reopened D91888: [flang][openacc] Add clause validaty tests for data construct + fix default restriction.

@clementval , when I build and test an in-tree build, everything works fine. But when I build out-of-tree, the error message associated with line 165 does not appear. Do you know why?

Dec 7 2020, 11:07 AM · Restricted Project, Restricted Project

Dec 3 2020

PeteSteinfeld committed rGf24c642178a5: [flang] Fix bogus message on interface procedure argument names (authored by PeteSteinfeld).
[flang] Fix bogus message on interface procedure argument names
Dec 3 2020, 12:09 PM
PeteSteinfeld closed D92501: [flang] Fix bogus message on interface procedure argument names.
Dec 3 2020, 12:09 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D92501: [flang] Fix bogus message on interface procedure argument names.

I changed my implementation to just not do semantic checking for EQUIVALENCE
statements when in an interface block.

Dec 3 2020, 8:26 AM · Restricted Project, Restricted Project

Dec 2 2020

PeteSteinfeld added a comment to D92501: [flang] Fix bogus message on interface procedure argument names.

I don't think that moving a temporary data structure from declaration processing into a more permanent object like Scope to accomplish scoping is the right way to fix this problem, unfortunately.

The specification-part of an interface block exists only to define the dummy arguments and (if there is one) the function result, so declarations of other local variables are moot in an interface outside of specification inquiries like SIZE(). Since local variables are the only objects that could meaningfully appear in an EQUIVALENCE statement in the specification part of an interface -- dummies can't be EQUIVALENCEd and there's nothing to be learned from an EQUIVALENCE of a function result -- there's no good reason to check such EQUIVALENCE statements for anything. I think that we should warn about their uselessness and otherwise ignore them.

Dec 2 2020, 1:21 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D92501: [flang] Fix bogus message on interface procedure argument names: Restricted Project.
Dec 2 2020, 12:41 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D92501: [flang] Fix bogus message on interface procedure argument names.
Dec 2 2020, 12:41 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D92492: [flang] Fix bugs related to merging generics during USE.

It would be good to also fix the lint changes that were automatically suggested.

Dec 2 2020, 10:33 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D92491: [flang][NFC] Add GetTopLevelUnitContaining functions.

All builds, tests, and looks good.

Dec 2 2020, 10:16 AM · Restricted Project, Restricted Project

Nov 18 2020

PeteSteinfeld committed rGea4973f2068a: [flang] Improve error message on bad LOGICAL compare operations (authored by PeteSteinfeld).
[flang] Improve error message on bad LOGICAL compare operations
Nov 18 2020, 1:54 PM
PeteSteinfeld closed D91736: [flang] Improve error message on bad LOGICAL compare operations.
Nov 18 2020, 1:53 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D91736: [flang] Improve error message on bad LOGICAL compare operations: Restricted Project.
Nov 18 2020, 12:44 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D91736: [flang] Improve error message on bad LOGICAL compare operations.
Nov 18 2020, 12:44 PM · Restricted Project, Restricted Project

Nov 17 2020

PeteSteinfeld accepted D91657: [flang] Correct handling of null pointer initializers.

Aside from the noted items, all builds, tests, and looks good.

Nov 17 2020, 8:35 PM · Restricted Project, Restricted Project
PeteSteinfeld committed rG3fd777403349: [flang] Fix FIR test failures (authored by PeteSteinfeld).
[flang] Fix FIR test failures
Nov 17 2020, 12:30 PM
PeteSteinfeld closed D91654: [flang] Fix FIR test failures.
Nov 17 2020, 12:29 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D91654: [flang] Fix FIR test failures: Restricted Project.
Nov 17 2020, 11:58 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D91654: [flang] Fix FIR test failures.
Nov 17 2020, 11:57 AM · Restricted Project, Restricted Project

Nov 16 2020

PeteSteinfeld committed rG681978d3b4e8: [flang] Duplicate names for ac-implied-do variables erroneously cause errors (authored by PeteSteinfeld).
[flang] Duplicate names for ac-implied-do variables erroneously cause errors
Nov 16 2020, 7:15 PM
PeteSteinfeld closed D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Nov 16 2020, 7:14 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Nov 16 2020, 3:02 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Nov 16 2020, 2:14 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.

I fixed some spelling errors and added a test to verify that the duplicate
ac-implied-do variable names get evaluated correctly in the presence of
constant folding.

Nov 16 2020, 1:30 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Nov 16 2020, 1:27 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors: Restricted Project.
Nov 16 2020, 12:13 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Nov 16 2020, 12:08 PM · Restricted Project, Restricted Project

Nov 13 2020

PeteSteinfeld committed rG5795a81cbab8: [flang] Fix "EQ" comparison of arrays (authored by PeteSteinfeld).
[flang] Fix "EQ" comparison of arrays
Nov 13 2020, 3:24 PM
PeteSteinfeld closed D91440: [flang] Fix "EQ" comparison of arrays.
Nov 13 2020, 3:24 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D91440: [flang] Fix "EQ" comparison of arrays.

Reworked the code to check array shape conformance as suggested by Peter.

Nov 13 2020, 1:01 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D91440: [flang] Fix "EQ" comparison of arrays.
Nov 13 2020, 1:00 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D91440: [flang] Fix "EQ" comparison of arrays: Restricted Project.
Nov 13 2020, 9:34 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D91440: [flang] Fix "EQ" comparison of arrays.
Nov 13 2020, 9:33 AM · Restricted Project, Restricted Project

Nov 12 2020

PeteSteinfeld accepted D91377: [flang] Recognize END FILE as ENDFILE in free form source.

All builds, tests, and looks good.

Nov 12 2020, 12:43 PM · Restricted Project, Restricted Project

Nov 10 2020

PeteSteinfeld accepted D91217: [flang] Allow labels on END statements..

All builds, tests, and looks good.

Nov 10 2020, 7:00 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D91209: [flang] Fix CheckSpecificationExpr handling of associated names.

All builds, tests, and looks good.

Nov 10 2020, 3:11 PM · Restricted Project, Restricted Project

Nov 9 2020

PeteSteinfeld committed rG66a9607557a1: [flang] Avoid calling the linker when "-c" option is used (authored by PeteSteinfeld).
[flang] Avoid calling the linker when "-c" option is used
Nov 9 2020, 10:22 AM
PeteSteinfeld added a project to D91081: [flang] Avoid calling the linker when "-c" option is used: Restricted Project.
Nov 9 2020, 7:44 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D91081: [flang] Avoid calling the linker when "-c" option is used.
Nov 9 2020, 7:44 AM · Restricted Project, Restricted Project

Nov 4 2020

PeteSteinfeld added a project to D90226: [flang] update ODS syntax to use OpBuidlerDAG instead of OpBuilder: Restricted Project.
Nov 4 2020, 9:36 AM · Restricted Project, Restricted Project

Nov 3 2020

PeteSteinfeld accepted D90696: [flang] Dodge gcc 8.2.0 build problem (NFC).

All of the flang front end builds without warnings, and everything tests cleanly.

Nov 3 2020, 12:04 PM · Restricted Project, Restricted Project

Nov 2 2020

PeteSteinfeld accepted D90636: [flang] Fix actual argument character length and length error reporting.

I'm having trouble building and running tests, but all of the changes in this update seem to build and test fine.

Nov 2 2020, 12:59 PM · Restricted Project, Restricted Project

Oct 30 2020

PeteSteinfeld accepted D90495: [flang] Add warning for FINAL pitfall.

All builds, tests, and looks good.

Oct 30 2020, 2:25 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D90493: [flang] Detect and rewrite ambiguous READ(CVAR)[,item-list].

All builds, tests, and looks good.

Oct 30 2020, 2:13 PM · Restricted Project, Restricted Project

Oct 23 2020

PeteSteinfeld committed rGb6b589ca8484: [flang] An erroneous type bound procedure was causing a call to CHECK() (authored by PeteSteinfeld).
[flang] An erroneous type bound procedure was causing a call to CHECK()
Oct 23 2020, 2:06 PM
PeteSteinfeld closed D90074: [flang] An erroneous type bound procedure was causing a call to CHECK().
Oct 23 2020, 2:05 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D90074: [flang] An erroneous type bound procedure was causing a call to CHECK(): Restricted Project.
Oct 23 2020, 1:53 PM · Restricted Project, Restricted Project