There's a lot to digest here. Let me know if you have questions.

Thanks for working on this!

Changes have been delivered.

I changed some raw code to calls to BeginAttrs() and EndAttrs() and changed a
nested "if" to an "end if".

I've submitted another update.

@klausler and @tskeith, do these latest changes look good?

1. Updating D79798: [flang] Constraint checks C751 to C760 #
2. Enter a brief description of the changes included in this update.
3. The first line is used as subject, next lines as comment. #
4. If you intended to create a new revision, use:
5. $ arc diff --create

Responses to review comments

I am not on Windows, so I can't reproduce this. Would you be able to debug this so we understand what the problem is? For example, printing the exception object or looking into the error handler of shutil.rmtree(... , onerror=..) might shed light on things [1].

Thanks for offering help! Note that I still don't know who "any other member"s are, is there a list? a chat channel?

I don't think this is the request. The request is just "don't break the build".
The pre-merge testing will test flang as well, but you would have had to rebase the patch after you landed the dependent ones first so that the pre-merge testing could work (I think marking the dependencies in Phabricator would have worked also).

In general trying to get the pre-merge testing green before pushing changes is safer.

Superseded by D79723.

@ftynse and @antiagainst , note that one of the clients of mlir is the flang project. Since this revision changed the interface of mlir, all clients of mlir should be checked to see if they still build and test correctly before delivering such changes. Note that the person who knows most about flang's dependency on mlir is @schweitz, but any member of the flang team should be able to verify if a change works for flang.

Thanks for doing this.

I've pushed a fix to the problem that @kiranchandramohan pointed out.

This is a non-functional change.

I'm not sure how to best make @sscalpone's suggested change with respect to git and Arcanist commands.

Response to review comments

Not sure how this got to be a separate review.

1. Updating D79282: [flang] Fixed a crash #
2. Enter a brief description of the changes included in this update.
3. The first line is used as subject, next lines as comment. #
4. If you intended to create a new revision, use:
5. $ arc diff --create

Added a declaration to make the test case crash the compiler

This review is superseded by D79263.

• Merge branch 'master' of https://github.com/llvm/llvm-project
• Responses to review comments.

LGTM.