Page MenuHomePhabricator

[IR][VP] Extend the align param attr to vectors of pointers
AcceptedPublic

Authored by frasercrmck on Tue, Nov 23, 2:06 AM.

Details

Summary

This patch extends the types on which the align parameter attribute is
permissible to include vectors of pointers. It does so in order to allow
alignment specification on llvm.vp.gather and llvm.vp.scatter
intrinsics, which lack an explicit alignment parameter.

The default alignment of these intrinsics was previously documented as
being equal to the ABI alignment of the *scalar* type, when in fact that
wasn't the case: the ABI alignment of the vector type was used instead.
This has also been fixed in this patch.

Diff Detail

Event Timeline

frasercrmck created this revision.Tue, Nov 23, 2:06 AM
frasercrmck requested review of this revision.Tue, Nov 23, 2:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Nov 23, 2:06 AM
This revision is now accepted and ready to land.Wed, Nov 24, 11:36 AM
  • rebase and use 'operand' over 'argument'
simoll accepted this revision.Tue, Nov 30, 9:39 AM

LGTM