This patch fixes a case where the 'align' parameter attribute on the
pointer operands to llvm.vp.load and llvm.vp.store was being dropped
during the conversion to the SelectionDAG. The default alignment
equal to the ABI type alignment of the vector type was kept. It also
updates the documentation to reflect the fact that the parameter
attribute is now properly supported.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/docs/LangRef.rst | ||
---|---|---|
19646 | The previous paragraph called this "first operand" now we're using "first argument". |
- rebase and address feedback
llvm/docs/LangRef.rst | ||
---|---|---|
19646 | You make a good argument (sorry!). I've fixed that up. | |
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | ||
7345 | Yeah thanks for reminding me. I saw that patch go through and was going to check what was needed for VP. I'll create a note for myself to come back to this. |
llvm/docs/LangRef.rst | ||
---|---|---|
19656 | "is taken as the align parameter attribute"? To use the same wording as below for vp.store. Also, to make clear that alignment is specified as an attribute of the pointer and not another parameter. |
- rebase and add missing word
llvm/docs/LangRef.rst | ||
---|---|---|
19656 | Oh crumbs yeah I accidentally a word. Fixed! |
The previous paragraph called this "first operand" now we're using "first argument".