This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
clang/docs/
-
docs/
2/3
ReleaseNotes.rst

Differential D111215

clang release notes: document the -Wbool-operation improvement
ClosedPublic

Authored by sylvestre.ledru on Oct 6 2021, 2:39 AM.

Download Raw Diff

Details

Reviewers

xbolva00
nathanchance

Commits

rG9c8f950a0400: clang release notes: document the -Wbool-operation improvement

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

sylvestre.ledru requested review of this revision.Oct 6 2021, 2:39 AM

sylvestre.ledru created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2021, 2:39 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

sylvestre.ledru mentioned this in D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects.Oct 6 2021, 2:41 AM

xbolva00 added inline comments.Oct 6 2021, 2:45 AM

clang/docs/ReleaseNotes.rst
54	-Wbitwise-instead-of-logical (part of -Wbool-operation) warns … ?

Take in account the comment

One small comment about side effects, otherwise LG.

Please wait a +-day for potentional review comments.

clang/docs/ReleaseNotes.rst
54	I think we should mention that with boolean operands which have side effects.

This revision is now accepted and ready to land.Oct 6 2021, 3:00 AM

sylvestre.ledru marked an inline comment as done.Oct 6 2021, 3:00 AM

@xbolva00 sorry but you would like

-Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boolean operands which have side effects

or
-Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boolean operands
Be aware that boolean operands might have side effects.

First form is better I think.

add "which have side effects"

sylvestre.ledru marked an inline comment as done.Oct 6 2021, 3:15 AM

Harbormaster completed remote builds in B127254: Diff 377486.Oct 6 2021, 3:48 AM

Closed by commit rG9c8f950a0400: clang release notes: document the -Wbool-operation improvement (authored by sylvestre.ledru). · Explain WhyOct 10 2021, 12:28 PM

This revision was automatically updated to reflect the committed changes.

sylvestre.ledru added a commit: rG9c8f950a0400: clang release notes: document the -Wbool-operation improvement.

• Quuxplusone added a subscriber: • Quuxplusone.Oct 10 2021, 12:29 PM

• Quuxplusone added inline comments.

clang/docs/ReleaseNotes.rst
54	s/`use of bitwise with`/`use of bitwise operators with`/

@Quuxplusone fixed, thanks

Revision Contents

Path

Size

clang/

docs/

ReleaseNotes.rst

2 lines

Diff 378528

clang/docs/ReleaseNotes.rst

	Show First 20 Lines • Show All 45 Lines • ▼ Show 20 Lines
	Major New Features			Major New Features
	------------------			------------------

	- ...			- ...

	Improvements to Clang's diagnostics			Improvements to Clang's diagnostics
	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^			^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

	- ...			- -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boolean operands which have side effects.
				xbolva00Unsubmitted Done Reply Inline Actions -Wbitwise-instead-of-logical (part of -Wbool-operation) warns … ? xbolva00: -Wbitwise-instead-of-logical (part of -Wbool-operation) warns … ?
				xbolva00Unsubmitted Done Reply Inline Actions I think we should mention that with boolean operands which have side effects. xbolva00: I think we should mention that with boolean operands which have side effects.
				QuuxplusoneUnsubmitted Not Done Reply Inline Actions s/`use of bitwise with`/`use of bitwise operators with`/ Quuxplusone: s/`use of bitwise with`/`use of bitwise operators with`/

	Non-comprehensive list of changes in this release			Non-comprehensive list of changes in this release
	-------------------------------------------------			-------------------------------------------------

	- Maximum _ExtInt size was decreased from 16,777,215 bits to 8,388,608 bits.			- Maximum _ExtInt size was decreased from 16,777,215 bits to 8,388,608 bits.
	Motivation for this was discussed in PR51829.			Motivation for this was discussed in PR51829.

	New Compiler Flags			New Compiler Flags
	▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines