Added omp.sections and omp.section operation according to the
section 2.8.1 of OpenMP Standard 5.0.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks @shraiysh for this patch. Lots of good work here. For ease of review, could you split this into two patches? One for the re-organisation and the parseClause function and another patch for the sections construct.
mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp | ||
---|---|---|
880 | You should not specify the number of aligned element unless you have a good reason. Same for other SmallVector |
Thanks @shraiysh for this patch.
I have a few questions/suggestions for change.
mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td | ||
---|---|---|
155 | Can we use the HasParent trait to ensure that the section op have the sections directive as parent? | |
209 | Can this be a SizedRegion<1> region? Can this specification be moved about the parser declaration? | |
mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp | ||
935 | Can this be removed in favour of specifying sizedregion<1>? |
Can we use the HasParent trait to ensure that the section op have the sections directive as parent?