[MLIR] Add scalar tests for `Same*Shape` traits.

[arames]

Summary

The Same*Shape traits allow scalars.

[silvas]

Personally I think we should deprecate this behavior. In my mind, an i1 doesn't have a shape at all. So it doesn't make sense to say it has the same shape as anything else. Is there a specific use case for this behavior (IIRC this might have fallen out of an implementation detail of an earlier implementation of the trait).

[arames]

In D110764#3031866, @silvas wrote:

Personally I think we should deprecate this behavior. In my mind, an i1 doesn't have a shape at all. So it doesn't make sense to say it has the same shape as anything else. Is there a specific use case for this behavior (IIRC this might have fallen out of an implementation detail of an earlier implementation of the trait).

Not that I am aware of or care about. I would be fine restricting it.
This was just cleaning on the way as I was implementing type inference for the Same*Shape interfaces.

[silvas]

@herhut - thoughts on keeping scalars (i1) as disallowed from Same*Shape traits?

[arames]

In D110764#3031904, @silvas wrote:

@herhut - thoughts on keeping scalars (i1) as disallowed from Same*Shape traits?

Note that this is now out of the chain of reviews, as these interfaces will be handled by providing a default implementation of InferTypeOpInterface instead of having a special path in the type inference.

mlir/test/IR/traits.mlir

 func @failedSameOperandAndResultElementType_no_results(%t1f: tensor<1xf32>) {
   // expected-error@+1 {{expected 1 or more results}}
   "test.same_operand_and_result_element_type"(%t1f) : (tensor<1xf32>) -> ()
 }
 
 // -----
 
 // CHECK: succeededSameOperandShape
-func @succeededSameOperandShape(%t10x10 : tensor<10x10xf32>, %t1: tensor<1xf32>, %m10x10 : memref<10x10xi32>, %tr: tensor<*xf32>) {
+func @succeededSameOperandShape(%t10x10 : tensor<10x10xf32>, %t1: tensor<1xf32>, %m10x10 : memref<10x10xi32>, %tr: tensor<*xf32>, %i1: i1, %i2: i2) {
   "test.same_operand_shape"(%t1, %t1) : (tensor<1xf32>, tensor<1xf32>) -> ()
   "test.same_operand_shape"(%t10x10, %t10x10) : (tensor<10x10xf32>, tensor<10x10xf32>) -> ()
   "test.same_operand_shape"(%t1, %tr) : (tensor<1xf32>, tensor<*xf32>) -> ()
   "test.same_operand_shape"(%t10x10, %m10x10) : (tensor<10x10xf32>, memref<10x10xi32>) -> ()
+  "test.same_operand_shape"(%i1, %i2) : (i1, i2) -> ()
   return
 }
 
 // -----
 
 func @failedSameOperandShape_operand_mismatch(%t10x10 : tensor<10x10xf32>, %t1: tensor<1xf32>) {
   // expected-error@+1 {{requires the same shape for all operands}}
   "test.same_operand_shape"(%t1, %t10x10) : (tensor<1xf32>, tensor<10x10xf32>) -> ()
 }
 
 // -----
 
 func @failedSameOperandShape_no_operands() {
   // expected-error@+1 {{expected 1 or more operands}}
   "test.same_operand_shape"() : () -> ()
 }
 
 // -----
 
 // CHECK: succeededSameOperandAndResultShape
-func @succeededSameOperandAndResultShape(%t10x10 : tensor<10x10xf32>, %t1: tensor<1xf32>, %tr: tensor<*xf32>, %t1d: tensor<?xf32>) {
+func @succeededSameOperandAndResultShape(%t10x10 : tensor<10x10xf32>, %t1: tensor<1xf32>, %tr: tensor<*xf32>, %t1d: tensor<?xf32>, %i1: i1) {
   "test.same_operand_and_result_shape"(%t1, %t1) : (tensor<1xf32>, tensor<1xf32>) -> tensor<1xf32>
   "test.same_operand_and_result_shape"(%t10x10, %t10x10) : (tensor<10x10xf32>, tensor<10x10xf32>) -> tensor<10x10xf32>
   "test.same_operand_and_result_shape"(%t1, %tr) : (tensor<1xf32>, tensor<*xf32>) -> tensor<1xf32>
   "test.same_operand_and_result_shape"(%t1, %t1d) : (tensor<1xf32>, tensor<?xf32>) -> tensor<1xf32>
   "test.same_operand_and_result_shape"(%t1, %t1d) : (tensor<1xf32>, tensor<?xf32>) -> memref<1xf32>
+  "test.same_operand_and_result_shape"(%i1) : (i1) -> (i2)
 
   return
 }
 
 // -----
 
 func @failedSameOperandAndResultShape_operand_result_mismatch(%t10x10 : tensor<10x10xf32>, %t1: tensor<1xf32>) {
   // expected-error@+1 {{requires the same shape for all operands and results}}

 
 // -----
 
 // Check that we can query traits in attributes
 func @failed_attr_traits() {
   // expected-error@+1 {{'attr' attribute should have trait 'TestAttrTrait'}}
   "test.attr_with_trait"() {attr = 42 : i32} : () -> ()
   return
-}
+}
 

mlir/test/lib/Dialect/Test/TestOps.td

 def SameOperandAndResultElementTypeOp :
     TEST_Op<"same_operand_and_result_element_type",
     [SameOperandsAndResultElementType]> {
   let arguments = (ins Variadic<AnyType>);
   let results = (outs Variadic<AnyType>);
 }
 
 def SameOperandShapeOp : TEST_Op<"same_operand_shape", [SameOperandsShape]> {
-  let arguments = (ins Variadic<AnyShaped>);
+  let arguments = (ins Variadic<AnyType>);
 }
 
 def SameOperandAndResultShapeOp : TEST_Op<"same_operand_and_result_shape",
     [SameOperandsAndResultShape]> {
-  let arguments = (ins Variadic<AnyShaped>);
-  let results = (outs Variadic<AnyShaped>);
+  let arguments = (ins Variadic<AnyType>);
+  let results = (outs Variadic<AnyType>);
 }
 
 def SameOperandAndResultTypeOp : TEST_Op<"same_operand_and_result_type",
     [SameOperandsAndResultType]> {
   let arguments = (ins Variadic<AnyType>);
   let results = (outs Variadic<AnyType>);
 }