Page MenuHomePhabricator

arames (Alexandre Rames)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 21 2017, 2:06 PM (221 w, 4 d)

Recent Activity

Tue, Jun 1

arames updated the diff for D102943: Hashing: use a 64-bit storage type on all platforms..

Fix detail namespace.

Tue, Jun 1, 5:17 PM · Restricted Project, Restricted Project, Restricted Project
arames added inline comments to D102943: Hashing: use a 64-bit storage type on all platforms..
Tue, Jun 1, 5:14 PM · Restricted Project, Restricted Project, Restricted Project
arames updated the diff for D102943: Hashing: use a 64-bit storage type on all platforms..

Use llvm::MD5.

Tue, Jun 1, 5:11 PM · Restricted Project, Restricted Project, Restricted Project

Thu, May 27

arames added a comment to D102943: Hashing: use a 64-bit storage type on all platforms..

This new version is an attempt to have modules not rely on llvm::hash_code, but on a new llvm::stable_hash_code.
I understand modifying ADT/Hashing.h is sensitive, so maybe we need to discuss the high-level approach first.

Thu, May 27, 3:40 PM · Restricted Project, Restricted Project, Restricted Project
arames updated the diff for D102943: Hashing: use a 64-bit storage type on all platforms..

Diff against the parent commit.

Thu, May 27, 3:38 PM · Restricted Project, Restricted Project, Restricted Project
arames added a comment to D102943: Hashing: use a 64-bit storage type on all platforms..

The early commits are missing from the PR. Looking out to do this with arc.

Thu, May 27, 3:37 PM · Restricted Project, Restricted Project, Restricted Project
arames updated the diff for D102943: Hashing: use a 64-bit storage type on all platforms..

Introduce and use stable_hash_code instead of modifying hash_code.

Thu, May 27, 3:33 PM · Restricted Project, Restricted Project, Restricted Project

Fri, May 21

arames added a comment to D102943: Hashing: use a 64-bit storage type on all platforms..

why do module hashes need to be stable when cross-compiling?

IIUC, the use case is cross-compiling when building the modules, which are then sent to the target to use when compiling other things.

Fri, May 21, 8:52 PM · Restricted Project, Restricted Project, Restricted Project
arames added a comment to D102943: Hashing: use a 64-bit storage type on all platforms..

Isn't the bug here that module hashing is using hash_code? So shouldn't the correct fix be to use a specific hashing algorithm for module hashes?

Yeah, I tend to agree. I thought modules already used MD5, but maybe just for the AST signature.

Fri, May 21, 8:49 PM · Restricted Project, Restricted Project, Restricted Project
arames added a reviewer for D102943: Hashing: use a 64-bit storage type on all platforms.: t.p.northover.
Fri, May 21, 1:33 PM · Restricted Project, Restricted Project, Restricted Project
arames requested review of D102943: Hashing: use a 64-bit storage type on all platforms..
Fri, May 21, 1:31 PM · Restricted Project, Restricted Project, Restricted Project

May 6 2021

arames added inline comments to D101859: [MLIR] Introduce join/meet type interface..
May 6 2021, 4:34 PM · Restricted Project
arames added inline comments to D101859: [MLIR] Introduce join/meet type interface..
May 6 2021, 4:25 PM · Restricted Project
arames added inline comments to D101859: [MLIR] Introduce join/meet type interface..
May 6 2021, 3:51 PM · Restricted Project
arames added inline comments to D101859: [MLIR] Introduce join/meet type interface..
May 6 2021, 3:48 PM · Restricted Project
arames added inline comments to D101859: [MLIR] Introduce join/meet type interface..
May 6 2021, 3:45 PM · Restricted Project
arames added a comment to D101859: [MLIR] Introduce join/meet type interface..

For reference, related discussion at https://llvm.discourse.group/t/rfc-join-meet-type-interface/3416.

May 6 2021, 9:10 AM · Restricted Project

May 5 2021

arames added inline comments to D101859: [MLIR] Introduce join/meet type interface..
May 5 2021, 9:55 PM · Restricted Project
arames updated the diff for D101859: [MLIR] Introduce join/meet type interface..

Address review comments.

May 5 2021, 9:54 PM · Restricted Project
arames added inline comments to D101859: [MLIR] Introduce join/meet type interface..
May 5 2021, 5:09 PM · Restricted Project
arames added inline comments to D101859: [MLIR] Introduce join/meet type interface..
May 5 2021, 4:12 PM · Restricted Project
arames added inline comments to D101859: [MLIR] Introduce join/meet type interface..
May 5 2021, 4:09 PM · Restricted Project
arames added a comment to D101859: [MLIR] Introduce join/meet type interface..

btw, I think you might need to reupload the patch. I don't see the new code.

May 5 2021, 3:37 PM · Restricted Project
arames added a comment to D101859: [MLIR] Introduce join/meet type interface..

Thanks for the review.

May 5 2021, 3:31 PM · Restricted Project

May 4 2021

arames added reviewers for D101859: [MLIR] Introduce join/meet type interface.: silvas, mehdi_amini.
May 4 2021, 3:54 PM · Restricted Project
arames requested review of D101859: [MLIR] Introduce join/meet type interface..
May 4 2021, 2:25 PM · Restricted Project

Nov 10 2020

arames added a reverting change for rGc67656b994c8: Revert "Allow searching for prebuilt implicit modules.": rG58c586e70188: Allow searching for prebuilt implicit modules..
Nov 10 2020, 10:15 AM
arames committed rG58c586e70188: Allow searching for prebuilt implicit modules. (authored by arames).
Allow searching for prebuilt implicit modules.
Nov 10 2020, 10:15 AM
arames abandoned D90963: Allow searching for prebuilt implicit modules..
Nov 10 2020, 9:24 AM · Restricted Project

Nov 6 2020

arames added a reverting change for rGc67656b994c8: Revert "Allow searching for prebuilt implicit modules.": D90963: Allow searching for prebuilt implicit modules..
Nov 6 2020, 11:54 AM
arames requested review of D90963: Allow searching for prebuilt implicit modules..
Nov 6 2020, 11:54 AM · Restricted Project
arames added a comment to D68997: Allow searching for prebuilt implicit modules..

This change broke the windows lldb bot:

http://lab.llvm.org:8011/#/builders/83/builds/570

Can you please fix this or revert?

Nov 6 2020, 7:28 AM · Restricted Project

Nov 5 2020

arames committed rG71e108cd86e7: Allow searching for prebuilt implicit modules. (authored by arames).
Allow searching for prebuilt implicit modules.
Nov 5 2020, 1:11 PM
arames closed D68997: Allow searching for prebuilt implicit modules..
Nov 5 2020, 1:11 PM · Restricted Project
arames added a comment to D68997: Allow searching for prebuilt implicit modules..

Fixed the trailing whitespace.

Nov 5 2020, 12:34 PM · Restricted Project

Oct 26 2020

arames updated the diff for D68997: Allow searching for prebuilt implicit modules..

Rebased on ToT.

Oct 26 2020, 1:38 PM · Restricted Project

Sep 30 2020

arames added a comment to rG700e63293eea: [Sema] Support Comma operator for fp16 vectors..

Thanks a lot.

Sep 30 2020, 10:29 AM
arames added a comment to D88265: [Sema] Support Comma operator for fp16 vectors..

Oh I think you'd need to edit the revision on Phabricator (top right on this page, edit revision). But if you are fine with it I can commit the patch for you with the adjusted commit title.

Sep 30 2020, 10:03 AM · Restricted Project
arames retitled D88265: [Sema] Support Comma operator for fp16 vectors. from Fix comma with half vectors. to [Sema] Support Comma operator for fp16 vectors..
Sep 30 2020, 10:02 AM · Restricted Project
arames added a comment to D88265: [Sema] Support Comma operator for fp16 vectors..

Could you adjust the commit message to be a bit more descriptive, e.g something like [Sema] Support Comma operator for fp16 vectors.

Sep 30 2020, 9:09 AM · Restricted Project
arames updated the diff for D88265: [Sema] Support Comma operator for fp16 vectors..

Update commit message.

Sep 30 2020, 9:09 AM · Restricted Project

Sep 29 2020

arames added a comment to D88265: [Sema] Support Comma operator for fp16 vectors..

I do not have commit rights, so it would be great if you can land it.

Sep 29 2020, 2:45 PM · Restricted Project
arames updated the diff for D88265: [Sema] Support Comma operator for fp16 vectors..

Address review comments.

Sep 29 2020, 2:00 PM · Restricted Project
arames updated the diff for D88265: [Sema] Support Comma operator for fp16 vectors..

Addressed review comments.

Sep 29 2020, 10:01 AM · Restricted Project
arames added inline comments to D88265: [Sema] Support Comma operator for fp16 vectors..
Sep 29 2020, 10:00 AM · Restricted Project

Sep 24 2020

arames added a reviewer for D88265: [Sema] Support Comma operator for fp16 vectors.: ahatanak.
Sep 24 2020, 3:23 PM · Restricted Project
arames requested review of D88265: [Sema] Support Comma operator for fp16 vectors..
Sep 24 2020, 3:22 PM · Restricted Project

Jul 31 2020

arames added inline comments to D68997: Allow searching for prebuilt implicit modules..
Jul 31 2020, 3:36 PM · Restricted Project
arames updated the diff for D68997: Allow searching for prebuilt implicit modules..

Fix a typo.

Jul 31 2020, 3:34 PM · Restricted Project
arames updated the diff for D68997: Allow searching for prebuilt implicit modules..

Addressed review comments.

Jul 31 2020, 3:29 PM · Restricted Project
arames added inline comments to D68997: Allow searching for prebuilt implicit modules..
Jul 31 2020, 9:56 AM · Restricted Project

Jul 29 2020

arames updated the diff for D68997: Allow searching for prebuilt implicit modules..

Rebase.

Jul 29 2020, 8:18 AM · Restricted Project

Jul 20 2020

arames updated the diff for D68997: Allow searching for prebuilt implicit modules..

Rebase on top-of-tree.

Jul 20 2020, 8:39 AM · Restricted Project

May 18 2020

arames added a comment to D80022: [MLIR] Use `MLIR_INCLUDE_TESTS` to conditionally compile tests..

Could you land it for me Mehdi? I do not have permissions.

May 18 2020, 9:42 AM · Restricted Project

May 15 2020

arames updated the summary of D80022: [MLIR] Use `MLIR_INCLUDE_TESTS` to conditionally compile tests..
May 15 2020, 11:24 AM · Restricted Project
arames created D80022: [MLIR] Use `MLIR_INCLUDE_TESTS` to conditionally compile tests..
May 15 2020, 11:24 AM · Restricted Project

May 14 2020

arames updated the diff for D68997: Allow searching for prebuilt implicit modules..

Rebase on top of tree.

May 14 2020, 2:41 PM · Restricted Project
arames updated the diff for D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`..

Rebase on top of tree.

May 14 2020, 12:30 PM · Restricted Project
arames updated the summary of D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`..
May 14 2020, 11:23 AM · Restricted Project

Mar 13 2020

arames updated the diff for D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`..

Apply clang-format.

Mar 13 2020, 10:11 AM · Restricted Project

Feb 27 2020

arames updated the diff for D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`..

Rename and clarify.

Feb 27 2020, 1:30 PM · Restricted Project

Feb 26 2020

arames added a comment to D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`..

We should either simplify the implementation to reflect that we don't support e. g. *:42 (seems preferable to me) or have the codepaths that are currently not accessible through -fverify tested by other means.

Feb 26 2020, 5:57 PM · Restricted Project

Jan 23 2020

arames updated the diff for D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`..

Address review comments.

Jan 23 2020, 12:07 PM · Restricted Project
arames added inline comments to D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`..
Jan 23 2020, 10:36 AM · Restricted Project

Jan 2 2020

arames added a reviewer for D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.: hfinkel.
Jan 2 2020, 2:39 PM · Restricted Project
arames added a comment to D68997: Allow searching for prebuilt implicit modules..

Ping.

Jan 2 2020, 1:02 PM · Restricted Project
arames added a comment to D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`..

This is for example useful to add a catch-all clause like // expected-note-re@*:* 1+ {{candidate function {{.+}}}}

Jan 2 2020, 1:01 PM · Restricted Project
arames created D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`..
Jan 2 2020, 12:59 PM · Restricted Project
arames added a reviewer for D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.: rsmith.
Jan 2 2020, 12:59 PM · Restricted Project

Dec 3 2019

arames added a reviewer for D68997: Allow searching for prebuilt implicit modules.: cfe-commits.
Dec 3 2019, 12:16 PM · Restricted Project
arames added a comment to D68997: Allow searching for prebuilt implicit modules..

Ping.
Still looking for someone to take a look. Happy to answer any questions.

Dec 3 2019, 12:16 PM · Restricted Project

Nov 19 2019

arames added a comment to D68997: Allow searching for prebuilt implicit modules..

Ping.

Nov 19 2019, 2:42 PM · Restricted Project

Nov 7 2019

arames updated the diff for D68997: Allow searching for prebuilt implicit modules..

Rebase.

Nov 7 2019, 9:42 AM · Restricted Project

Oct 15 2019

arames added a reviewer for D68997: Allow searching for prebuilt implicit modules.: llvm-commits.
Oct 15 2019, 1:28 PM · Restricted Project
arames created D68997: Allow searching for prebuilt implicit modules..
Oct 15 2019, 10:11 AM · Restricted Project
arames updated the summary of D68997: Allow searching for prebuilt implicit modules..
Oct 15 2019, 10:11 AM · Restricted Project

Apr 7 2017

arames abandoned D31292: Improve support for non-llvm intrinsics..
Apr 7 2017, 1:19 PM
arames added a comment to D31292: Improve support for non-llvm intrinsics..

Following some review with Ahmed (ab), we think it will not make sense for upstream.

Apr 7 2017, 1:18 PM

Mar 28 2017

arames added a reviewer for D31292: Improve support for non-llvm intrinsics.: void.
Mar 28 2017, 10:04 AM
arames updated the diff for D31292: Improve support for non-llvm intrinsics..

Rebased on top of tree.

Mar 28 2017, 10:02 AM

Mar 23 2017

arames added a reviewer for D31292: Improve support for non-llvm intrinsics.: qcolombet.
Mar 23 2017, 1:18 PM
arames added a reviewer for D31292: Improve support for non-llvm intrinsics.: rnk.
Mar 23 2017, 9:47 AM
arames updated the summary of D31292: Improve support for non-llvm intrinsics..
Mar 23 2017, 9:45 AM
arames retitled D31292: Improve support for non-llvm intrinsics. from [tblgen] Allow skipping `llvm`. for tgt intrinsics to Improve support for non-llvm intrinsics..
Mar 23 2017, 9:45 AM
arames created D31292: Improve support for non-llvm intrinsics..
Mar 23 2017, 9:37 AM