Page MenuHomePhabricator

arames (Alexandre Rames)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 21 2017, 2:06 PM (288 w, 6 d)

Recent Activity

Mar 30 2022

arames added a comment to D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems.

I was was asked to chime in to assess whether this patch could be a problem for
the prebuilt-implicit clang modules workflow. No problem here.
With prebuilt modules, the output file name has to be specified manually. So the
mapping does not change the existing requirement of managing the file names to
avoid collissions.
Even in the future with implicit modules - as noted by others - : and - are
not allowed in the clang module name in the .modulemap, so there cannot be any
conflict.

Mar 30 2022, 2:51 AM · Restricted Project, Restricted Project

Nov 1 2021

arames updated the diff for D101859: [MLIR] Introduce join/meet type interface..

Rebase on top of tree.

Nov 1 2021, 1:53 PM · Restricted Project
arames updated the diff for D110768: [MLIR] Introduce the type inference pass..

Upload the right patch.

Nov 1 2021, 1:34 PM · Restricted Project
arames updated the diff for D110768: [MLIR] Introduce the type inference pass..

Reworked TI to be a utility class instead of a pass, removing dependency on standard ops.

Nov 1 2021, 1:27 PM · Restricted Project

Oct 29 2021

arames updated the diff for D110768: [MLIR] Introduce the type inference pass..

Address nit for op descriptions.

Oct 29 2021, 11:01 AM · Restricted Project
arames updated the diff for D110768: [MLIR] Introduce the type inference pass..

Introduce mechanism to customize explicit type specialization/relaxation.

Oct 29 2021, 10:33 AM · Restricted Project

Oct 28 2021

arames added inline comments to D110768: [MLIR] Introduce the type inference pass..
Oct 28 2021, 10:11 AM · Restricted Project

Oct 27 2021

arames updated the diff for D110768: [MLIR] Introduce the type inference pass..

Rebase on top of tree.
Slightly factor out the creation of type specialization and relaxation ops in TI.

Oct 27 2021, 1:58 PM · Restricted Project
arames updated the diff for D110767: [MLIR] Allow overriding type constraints for control-flow interfaces..

Rebase on top of tree.

Oct 27 2021, 1:57 PM · Restricted Project
arames updated the diff for D101859: [MLIR] Introduce join/meet type interface..

Fix clang-format warning.

Oct 27 2021, 1:57 PM · Restricted Project
arames updated the diff for D101859: [MLIR] Introduce join/meet type interface..

Rebase on top of tree.

Oct 27 2021, 1:55 PM · Restricted Project
arames committed rG0a06068ac766: [MLIR] Remove the unused `ArithmeticCastOp`. (authored by arames).
[MLIR] Remove the unused `ArithmeticCastOp`.
Oct 27 2021, 10:56 AM
arames closed D112638: [MLIR] Remove the unused `ArithmeticCastOp`..
Oct 27 2021, 10:56 AM · Restricted Project
arames added reviewers for D112638: [MLIR] Remove the unused `ArithmeticCastOp`.: mehdi_amini, silvas.
Oct 27 2021, 10:53 AM · Restricted Project
arames requested review of D112638: [MLIR] Remove the unused `ArithmeticCastOp`..
Oct 27 2021, 10:53 AM · Restricted Project

Oct 13 2021

arames added a comment to D110764: [MLIR] Add scalar tests for `Same*Shape` traits..

@herhut - thoughts on keeping scalars (i1) as disallowed from Same*Shape traits?

Oct 13 2021, 10:59 AM · Restricted Project
arames added inline comments to D101859: [MLIR] Introduce join/meet type interface..
Oct 13 2021, 10:58 AM · Restricted Project
arames updated the diff for D101859: [MLIR] Introduce join/meet type interface..

Address review comments:

  • Fix join/meet for tensors with encodings
  • misc style fixes
Oct 13 2021, 10:56 AM · Restricted Project
arames added inline comments to D101859: [MLIR] Introduce join/meet type interface..
Oct 13 2021, 10:56 AM · Restricted Project

Oct 6 2021

arames added inline comments to D110768: [MLIR] Introduce the type inference pass..
Oct 6 2021, 3:45 PM · Restricted Project
arames added inline comments to D110768: [MLIR] Introduce the type inference pass..
Oct 6 2021, 2:09 PM · Restricted Project
arames updated the diff for D110768: [MLIR] Introduce the type inference pass..

NFC refactor.

Oct 6 2021, 2:08 PM · Restricted Project
arames updated the diff for D110768: [MLIR] Introduce the type inference pass..

Include changes to remove explicit support for Same* traits.
They will be handled in a separate patch by providing a default implementation of InferTypeOpInterface.

Oct 6 2021, 2:04 PM · Restricted Project
arames added inline comments to D110768: [MLIR] Introduce the type inference pass..
Oct 6 2021, 1:57 PM · Restricted Project
arames added inline comments to D110768: [MLIR] Introduce the type inference pass..
Oct 6 2021, 1:34 PM · Restricted Project
arames added inline comments to D110768: [MLIR] Introduce the type inference pass..
Oct 6 2021, 11:59 AM · Restricted Project
arames updated the diff for D110768: [MLIR] Introduce the type inference pass..

Address first round of comments.

Oct 6 2021, 11:14 AM · Restricted Project
arames added inline comments to D110768: [MLIR] Introduce the type inference pass..
Oct 6 2021, 11:05 AM · Restricted Project
arames committed rGfd9613324d30: [MLIR] Rename Shape dialect's `join` to `meet`. (authored by arames).
[MLIR] Rename Shape dialect's `join` to `meet`.
Oct 6 2021, 9:42 AM
arames closed D110766: [MLIR] Rename Shape dialect's `join` to `meet`..
Oct 6 2021, 9:41 AM · Restricted Project

Oct 5 2021

arames added a comment to D110766: [MLIR] Rename Shape dialect's `join` to `meet`..

All the lattice descriptions I could find and decipher in LLVM seemed to match the convention.
Of course, one could absolutely use the other way.

Oct 5 2021, 2:01 PM · Restricted Project
arames updated the summary of D110766: [MLIR] Rename Shape dialect's `join` to `meet`..
Oct 5 2021, 1:54 PM · Restricted Project
arames updated the diff for D110766: [MLIR] Rename Shape dialect's `join` to `meet`..

Expand commit message with details and related instances.

Oct 5 2021, 1:53 PM · Restricted Project

Sep 30 2021

arames added inline comments to D110768: [MLIR] Introduce the type inference pass..
Sep 30 2021, 2:27 PM · Restricted Project
arames added inline comments to D110768: [MLIR] Introduce the type inference pass..
Sep 30 2021, 1:26 PM · Restricted Project
arames updated the diff for D110768: [MLIR] Introduce the type inference pass..

Address minor comments. Still some work to do.

Sep 30 2021, 12:53 PM · Restricted Project
arames added a comment to D110768: [MLIR] Introduce the type inference pass..

I went through the first round of comments.
I addressed the minor ones, and am working on the other open:

  • Consider a different mechanism than specialize_type and relax_type ops.
  • No special case for relax_type (if it is kept).
  • Maybe SameOperandsAndResultType (and similar traits) imply a default implementation of InferTypeOpInterface.
Sep 30 2021, 12:52 PM · Restricted Project

Sep 29 2021

arames added inline comments to D110768: [MLIR] Introduce the type inference pass..
Sep 29 2021, 2:16 PM · Restricted Project
arames added a comment to D110764: [MLIR] Add scalar tests for `Same*Shape` traits..

Personally I think we should deprecate this behavior. In my mind, an i1 doesn't have a shape at all. So it doesn't make sense to say it has the same shape as anything else. Is there a specific use case for this behavior (IIRC this might have fallen out of an implementation detail of an earlier implementation of the trait).

Sep 29 2021, 2:15 PM · Restricted Project
arames requested review of D110768: [MLIR] Introduce the type inference pass..
Sep 29 2021, 1:17 PM · Restricted Project
arames requested review of D110767: [MLIR] Allow overriding type constraints for control-flow interfaces..
Sep 29 2021, 1:15 PM · Restricted Project
arames updated the diff for D101859: [MLIR] Introduce join/meet type interface..

Rebase on parent patches.

Sep 29 2021, 1:14 PM · Restricted Project
arames requested review of D110766: [MLIR] Rename Shape dialect's `join` to `meet`..
Sep 29 2021, 1:12 PM · Restricted Project
arames added reviewers for D110764: [MLIR] Add scalar tests for `Same*Shape` traits.: silvas, rriddle, mehdi_amini.
Sep 29 2021, 1:08 PM · Restricted Project
arames requested review of D110764: [MLIR] Add scalar tests for `Same*Shape` traits..
Sep 29 2021, 1:06 PM · Restricted Project

Sep 25 2021

arames committed rGe21b0ba8c937: [ADT] Add trailing comma on TYPED_TEST_SUITE (authored by arames).
[ADT] Add trailing comma on TYPED_TEST_SUITE
Sep 25 2021, 6:04 PM
arames closed D110283: [ADT] Add trailing comma on TYPED_TEST_SUITE.
Sep 25 2021, 6:04 PM · Restricted Project

Sep 22 2021

arames accepted D110283: [ADT] Add trailing comma on TYPED_TEST_SUITE.
Sep 22 2021, 5:10 PM · Restricted Project

Sep 14 2021

arames committed rGd79bb30dbb08: [NFC] Add trailing comma on TYPED_TEST_SUITE (authored by arames).
[NFC] Add trailing comma on TYPED_TEST_SUITE
Sep 14 2021, 10:00 AM

Sep 7 2021

arames committed rGc3c9312f7049: [Support] Automatically support `hash_value` when `HashBuilder` support is… (authored by arames).
[Support] Automatically support `hash_value` when `HashBuilder` support is…
Sep 7 2021, 9:56 AM
arames closed D109024: [Support] Automatically support `hash_value` when `HashBuilder` support is available..
Sep 7 2021, 9:56 AM · Restricted Project
arames committed rG0e627c93be8c: [NFC][support] Extract `IsHashableData` out of class (authored by arames).
[NFC][support] Extract `IsHashableData` out of class
Sep 7 2021, 9:41 AM
arames closed D109205: [NFC][support] Extract `IsHashableData` out of class.
Sep 7 2021, 9:41 AM · Restricted Project

Sep 3 2021

arames added inline comments to D109024: [Support] Automatically support `hash_value` when `HashBuilder` support is available..
Sep 3 2021, 11:44 AM · Restricted Project
arames committed rG655bea4226b4: [modules] Use `HashBuilder` and `MD5` for the module hash. (authored by arames).
[modules] Use `HashBuilder` and `MD5` for the module hash.
Sep 3 2021, 11:14 AM
arames closed D102943: [modules] Use `HashBuilder` and `MD5` for the module hash..
Sep 3 2021, 11:13 AM · Restricted Project, Restricted Project, Restricted Project

Sep 2 2021

arames updated the diff for D109024: [Support] Automatically support `hash_value` when `HashBuilder` support is available..

Address review comments.

Sep 2 2021, 4:25 PM · Restricted Project
arames updated the diff for D109205: [NFC][support] Extract `IsHashableData` out of class.

run clang-format

Sep 2 2021, 4:15 PM · Restricted Project
arames requested review of D109205: [NFC][support] Extract `IsHashableData` out of class.
Sep 2 2021, 4:10 PM · Restricted Project
arames added a comment to D109024: [Support] Automatically support `hash_value` when `HashBuilder` support is available..

Applied suggestions.

Sep 2 2021, 3:40 PM · Restricted Project
arames updated the diff for D109024: [Support] Automatically support `hash_value` when `HashBuilder` support is available..

Address review comments.

Sep 2 2021, 3:40 PM · Restricted Project
arames abandoned D109195: [Support] Automatically support `hash_value` ....

This was the result of a bad arc command.

Sep 2 2021, 2:10 PM · Restricted Project
arames requested review of D109195: [Support] Automatically support `hash_value` ....
Sep 2 2021, 2:09 PM · Restricted Project
arames added a reviewer for D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.: dexonsmith.
Sep 2 2021, 11:23 AM · Restricted Project, Restricted Project, Restricted Project

Aug 31 2021

arames updated the diff for D109024: [Support] Automatically support `hash_value` when `HashBuilder` support is available..

Fix clang-format warning.

Aug 31 2021, 2:59 PM · Restricted Project
arames added inline comments to D109024: [Support] Automatically support `hash_value` when `HashBuilder` support is available..
Aug 31 2021, 2:16 PM · Restricted Project
arames updated the summary of D109024: [Support] Automatically support `hash_value` when `HashBuilder` support is available..
Aug 31 2021, 2:04 PM · Restricted Project
arames updated the diff for D102943: [modules] Use `HashBuilder` and `MD5` for the module hash..

Address review comments.

Aug 31 2021, 2:02 PM · Restricted Project, Restricted Project, Restricted Project
arames added inline comments to D102943: [modules] Use `HashBuilder` and `MD5` for the module hash..
Aug 31 2021, 2:01 PM · Restricted Project, Restricted Project, Restricted Project
arames requested review of D109024: [Support] Automatically support `hash_value` when `HashBuilder` support is available..
Aug 31 2021, 1:57 PM · Restricted Project

Aug 30 2021

arames added inline comments to D102943: [modules] Use `HashBuilder` and `MD5` for the module hash..
Aug 30 2021, 10:48 AM · Restricted Project, Restricted Project, Restricted Project
arames updated the diff for D102943: [modules] Use `HashBuilder` and `MD5` for the module hash..

Fix to native endianness.

Aug 30 2021, 10:44 AM · Restricted Project, Restricted Project, Restricted Project

Aug 29 2021

arames added inline comments to D102943: [modules] Use `HashBuilder` and `MD5` for the module hash..
Aug 29 2021, 11:50 AM · Restricted Project, Restricted Project, Restricted Project

Aug 27 2021

arames added inline comments to D102943: [modules] Use `HashBuilder` and `MD5` for the module hash..
Aug 27 2021, 4:28 PM · Restricted Project, Restricted Project, Restricted Project
arames added a comment to D102943: [modules] Use `HashBuilder` and `MD5` for the module hash..

I still need to go through earlier comments.

Aug 27 2021, 4:18 PM · Restricted Project, Restricted Project, Restricted Project
arames retitled D102943: [modules] Use `HashBuilder` and `MD5` for the module hash. from Hashing: use a 64-bit storage type on all platforms. to [modules] Use `HashBuilder` and `MD5` for the module hash..
Aug 27 2021, 3:14 PM · Restricted Project, Restricted Project, Restricted Project
arames updated the diff for D102943: [modules] Use `HashBuilder` and `MD5` for the module hash..

Now using the HashBuilder interface.

Aug 27 2021, 3:13 PM · Restricted Project, Restricted Project, Restricted Project

Aug 26 2021

arames committed rG1076082a0d97: [Support]: Introduce the `HashBuilder` interface. (authored by arames).
[Support]: Introduce the `HashBuilder` interface.
Aug 26 2021, 9:21 AM
arames closed D106910: [Support]: Introduce the `HashBuilder` interface..
Aug 26 2021, 9:21 AM · Restricted Project

Aug 25 2021

arames updated the diff for D106910: [Support]: Introduce the `HashBuilder` interface..

Finalize workaround for Windows.

Aug 25 2021, 9:28 PM · Restricted Project
arames updated the diff for D106910: [Support]: Introduce the `HashBuilder` interface..

Remove one of the workarounds for Windows.

Aug 25 2021, 6:20 PM · Restricted Project
arames updated the summary of D106910: [Support]: Introduce the `HashBuilder` interface..
Aug 25 2021, 4:14 PM · Restricted Project
arames updated the diff for D106910: [Support]: Introduce the `HashBuilder` interface..

Propagate variadic expansion workaround to the tuple overload.

Aug 25 2021, 3:10 PM · Restricted Project
arames updated the diff for D106910: [Support]: Introduce the `HashBuilder` interface..

Test different variadic impl for Windows.

Aug 25 2021, 2:00 PM · Restricted Project

Aug 24 2021

arames updated the diff for D106910: [Support]: Introduce the `HashBuilder` interface..

Ran through the address sanitizer and fixed stack-use-after-scope issues with ArrayRef.

Aug 24 2021, 6:08 PM · Restricted Project
arames added inline comments to D106910: [Support]: Introduce the `HashBuilder` interface..
Aug 24 2021, 3:56 PM · Restricted Project
arames updated the diff for D106910: [Support]: Introduce the `HashBuilder` interface..
  • Explicitly disable hashable types for the addHash overload (for the Windows build).
  • Introduce checks to confirm debian x64 test failures (to be removed).
Aug 24 2021, 3:26 PM · Restricted Project
arames updated the diff for D106910: [Support]: Introduce the `HashBuilder` interface..

One more attempt to fix the Windows build.

Aug 24 2021, 2:41 PM · Restricted Project
arames updated the diff for D106910: [Support]: Introduce the `HashBuilder` interface..

Apply clang-format.

Aug 24 2021, 2:33 PM · Restricted Project
arames added inline comments to D106910: [Support]: Introduce the `HashBuilder` interface..
Aug 24 2021, 2:04 PM · Restricted Project
arames updated the diff for D106910: [Support]: Introduce the `HashBuilder` interface..

Main changes:

  • Remove CRTP
  • (Attempt to) fix Windows build
  • Fix nits
Aug 24 2021, 2:04 PM · Restricted Project

Aug 23 2021

arames updated the diff for D106910: [Support]: Introduce the `HashBuilder` interface..

Address review comments.

Aug 23 2021, 10:46 AM · Restricted Project
arames added a comment to D106910: [Support]: Introduce the `HashBuilder` interface..

Thanks - again - for the comments. Please take a look at the update.

Aug 23 2021, 10:44 AM · Restricted Project

Aug 19 2021

arames committed rGcd28003336c7: [Support] Update `MD5` to follow other hashes. (authored by arames).
[Support] Update `MD5` to follow other hashes.
Aug 19 2021, 2:13 PM
arames closed D107781: [Support] Update `MD5` to follow other hashes..
Aug 19 2021, 2:13 PM · Restricted Project
arames committed rG10a126325da2: [NFC][Support] Move `MD5` members in `InternalState`. (authored by arames).
[NFC][Support] Move `MD5` members in `InternalState`.
Aug 19 2021, 2:04 PM
arames closed D108388: [NFC][Support] Move `MD5` members in `InternalState`..
Aug 19 2021, 2:04 PM · Restricted Project
arames retitled D107781: [Support] Update `MD5` to follow other hashes. from [Support] Introduce `SmallString<32> MD5::final()`... to [Support] Update `MD5` to follow other hashes..
Aug 19 2021, 12:22 PM · Restricted Project
arames updated the diff for D107781: [Support] Update `MD5` to follow other hashes..

Address review comments.

Aug 19 2021, 12:00 PM · Restricted Project
arames retitled D108388: [NFC][Support] Move `MD5` members in `InternalState`. from [Support] Move `MD5` members in `InternalState`. to [NFC][Support] Move `MD5` members in `InternalState`..
Aug 19 2021, 11:48 AM · Restricted Project