The __darn family of builtins are only available on Pwr9,
and only __darn_32 is available on both 64 and 32 bit, while the rest
are only available on 64 bit. The patch adds sema checking
for these builtins and separate the __darn_32's 32 bit
test cases.
Details
Details
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Event Timeline
Comment Actions
LGTM.
Pleases address the test issue on commit.
clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c | ||
---|---|---|
13 ↗ | (On Diff #374329) | Isn't this valid for both 32 and 64bit? |
clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c | ||
---|---|---|
13 ↗ | (On Diff #374329) | It is indeed valid for both 32 bit and 64 bit; there is already a runline for 64 bit in the clang/test/CodeGen/builtins-ppc-xlcompat-darn.c test case (which includes __darn_32, which is why I didn't include it here. |
clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c | ||
---|---|---|
13 ↗ | (On Diff #374329) | I agree. I thought __darn_32 is both 32-bit and 64-bit. |
clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c | ||
---|---|---|
13 ↗ | (On Diff #374329) | You removed __darn_32 from that file, so maybe we should add it back. And also, adjust the description of the patch to say that __darn_32 is available for 32 and 64-bit. |