Page MenuHomePhabricator

Conanap (Albion Fung)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 24 2020, 6:53 AM (118 w, 5 d)

Recent Activity

Nov 8 2021

Conanap added a comment to D112680: [OpenMP] Lower printf to __llvm_omp_vprintf.

thanks for reverting!

Nov 8 2021, 12:56 PM · Restricted Project, Restricted Project
Conanap added a comment to D112680: [OpenMP] Lower printf to __llvm_omp_vprintf.

looks like this commit might be causing some failures on PowerPC buildbots, would you be able to take a quick look? Failing test case is Clang :: OpenMP/nvptx_target_printf_codegen.c.

Nov 8 2021, 12:29 PM · Restricted Project, Restricted Project
Conanap updated the diff for D113050: [PowerPC] Exploit XXPERM Instruction.

Updated the SDT definition for PPCxxperm to allow for different types of masks

Nov 8 2021, 11:06 AM · Restricted Project, Restricted Project, Restricted Project

Nov 7 2021

Conanap updated the diff for D113050: [PowerPC] Exploit XXPERM Instruction.

Rebase

Nov 7 2021, 9:52 PM · Restricted Project, Restricted Project, Restricted Project

Nov 3 2021

Conanap updated the diff for D113050: [PowerPC] Exploit XXPERM Instruction.

Fixed unintended changes

Nov 3 2021, 1:38 PM · Restricted Project, Restricted Project, Restricted Project

Nov 2 2021

Conanap requested review of D113050: [PowerPC] Exploit XXPERM Instruction.
Nov 2 2021, 1:53 PM · Restricted Project, Restricted Project, Restricted Project

Oct 12 2021

Conanap committed rGb4b9f9b4b3cf: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX (authored by Conanap).
[PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX
Oct 12 2021, 1:48 PM
Conanap closed D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX.
Oct 12 2021, 1:48 PM · Restricted Project, Restricted Project, Restricted Project

Oct 7 2021

Conanap updated the diff for D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX.

Added mordern assembler check

Oct 7 2021, 2:46 PM · Restricted Project, Restricted Project, Restricted Project
Conanap accepted D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.

lgtm

Oct 7 2021, 8:40 AM · Restricted Project
Conanap accepted D111234: [zorg] [PowerPC] Fix passing cmake args to sanitizer-ppc64le-linux bot..

lgtm

Oct 7 2021, 8:32 AM · Restricted Project

Oct 6 2021

Conanap requested review of D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX.
Oct 6 2021, 12:49 PM · Restricted Project, Restricted Project, Restricted Project
Conanap committed rG13d3cd37e278: [PowerPC] Implement vector float and vector double version for vec_orc builtin (authored by Conanap).
[PowerPC] Implement vector float and vector double version for vec_orc builtin
Oct 6 2021, 12:48 AM
Conanap closed D110858: [PowerPC] Implement vector float and vector double version for vec_orc builtin.
Oct 6 2021, 12:48 AM · Restricted Project, Restricted Project, Restricted Project

Sep 30 2021

Conanap committed rG29bb877499ce: [PowerPC] Fix lharx and lbarx builtin signatures (authored by Conanap).
[PowerPC] Fix lharx and lbarx builtin signatures
Sep 30 2021, 8:36 PM
Conanap closed D110273: [PowerPC] Fix lharx and lbarx builtin signatures.
Sep 30 2021, 8:36 PM · Restricted Project, Restricted Project, Restricted Project
Conanap committed rG4195ed995993: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws (authored by Conanap).
[PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws
Sep 30 2021, 12:31 PM
Conanap closed D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.
Sep 30 2021, 12:31 PM · Restricted Project, Restricted Project, Restricted Project
Conanap requested review of D110858: [PowerPC] Implement vector float and vector double version for vec_orc builtin.
Sep 30 2021, 10:41 AM · Restricted Project, Restricted Project, Restricted Project

Sep 28 2021

Conanap updated the diff for D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.

Updated correct version of the patch

Sep 28 2021, 9:54 PM · Restricted Project, Restricted Project, Restricted Project
Conanap added inline comments to D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.
Sep 28 2021, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.

Added context, changed var names in aptterns

Sep 28 2021, 12:37 PM · Restricted Project, Restricted Project, Restricted Project

Sep 24 2021

Conanap updated the diff for D110273: [PowerPC] Fix lharx and lbarx builtin signatures.

Fixed an old test case

Sep 24 2021, 10:56 AM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.

This modifies a test case introduced in this commit: https://github.com/llvm/llvm-project/commit/3678df5ae6618eec656ae0ea0dab3be09d73bc9a

Sep 24 2021, 10:49 AM · Restricted Project, Restricted Project, Restricted Project
Conanap committed rG3678df5ae661: [PowerPC][NFC] Add test case in preparation for codegen change (authored by Conanap).
[PowerPC][NFC] Add test case in preparation for codegen change
Sep 24 2021, 10:18 AM

Sep 23 2021

Conanap committed rG840afbde48e9: [PowerPC] SemaChecking for darn family of builtins (authored by Conanap).
[PowerPC] SemaChecking for darn family of builtins
Sep 23 2021, 9:39 PM
Conanap closed D110282: [PowerPC] SemaChecking for darn family of builtins.
Sep 23 2021, 9:39 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.

Added P7 and P8 run lines for BE

Sep 23 2021, 10:33 AM · Restricted Project, Restricted Project, Restricted Project
Conanap added inline comments to D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.
Sep 23 2021, 9:06 AM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.

Updated test cases, fixed a typo

Sep 23 2021, 9:06 AM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the summary of D110282: [PowerPC] SemaChecking for darn family of builtins.
Sep 23 2021, 8:26 AM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D110282: [PowerPC] SemaChecking for darn family of builtins.

Moved test case back to original file and use #ifdef __PPC64__ instead

Sep 23 2021, 8:21 AM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D110273: [PowerPC] Fix lharx and lbarx builtin signatures.

Added test cases

Sep 23 2021, 8:11 AM · Restricted Project, Restricted Project, Restricted Project
Conanap added inline comments to D110282: [PowerPC] SemaChecking for darn family of builtins.
Sep 23 2021, 7:24 AM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2021

Conanap updated the diff for D110282: [PowerPC] SemaChecking for darn family of builtins.

Added error testing

Sep 22 2021, 12:39 PM · Restricted Project, Restricted Project, Restricted Project
Conanap requested review of D110282: [PowerPC] SemaChecking for darn family of builtins.
Sep 22 2021, 12:39 PM · Restricted Project, Restricted Project, Restricted Project
Conanap requested review of D110273: [PowerPC] Fix lharx and lbarx builtin signatures.
Sep 22 2021, 11:09 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2021

Conanap updated the diff for D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.

Removed AIX test line as it has the same code gen as BE

Sep 21 2021, 3:53 PM · Restricted Project, Restricted Project, Restricted Project
Conanap committed rGb93359ea3fe5: [PowerPC] Support for vector bool int128 on vector comparison builtins (authored by Conanap).
[PowerPC] Support for vector bool int128 on vector comparison builtins
Sep 21 2021, 2:30 PM
Conanap closed D110084: [PowerPC] Support for vector bool int128 on vector comparison builtins.
Sep 21 2021, 2:29 PM · Restricted Project, Restricted Project, Restricted Project
Conanap added a comment to D109628: [Zorg][PowerPC] Implement a TestSuiteBuilder.

I've removed the steps import in the actual commit. Thanks!

Sep 21 2021, 7:34 AM · Restricted Project
Conanap committed rZORG9d4301d25f09: [PowerPC] Implement a TestSuiteBuilder (authored by Conanap).
[PowerPC] Implement a TestSuiteBuilder
Sep 21 2021, 7:34 AM
Conanap closed D109628: [Zorg][PowerPC] Implement a TestSuiteBuilder.
Sep 21 2021, 7:34 AM · Restricted Project
Conanap updated the summary of D110084: [PowerPC] Support for vector bool int128 on vector comparison builtins.
Sep 21 2021, 7:17 AM · Restricted Project, Restricted Project, Restricted Project

Sep 20 2021

Conanap added a comment to D109628: [Zorg][PowerPC] Implement a TestSuiteBuilder.

gentle ping @gkistanova

Sep 20 2021, 1:00 PM · Restricted Project
Conanap accepted D109780: [PowerPC] Add range check for vec_genpcvm builtins.

lgtm

Sep 20 2021, 11:21 AM · Restricted Project
Conanap accepted D109996: [PowerPC] Fix signature of lxvp and stxvp builtins.

lgtm

Sep 20 2021, 11:15 AM · Restricted Project
Conanap accepted D109652: [PowerPC] Restrict various P10 options to P10 only..

LGTM

Sep 20 2021, 10:58 AM · Restricted Project, Restricted Project, Restricted Project
Conanap requested review of D110084: [PowerPC] Support for vector bool int128 on vector comparison builtins.
Sep 20 2021, 10:33 AM · Restricted Project, Restricted Project, Restricted Project

Sep 17 2021

Conanap added inline comments to D109437: [PowerPC] FP compare and test XL compat builtins..
Sep 17 2021, 11:34 AM · Restricted Project, Restricted Project
Conanap added a comment to D109628: [Zorg][PowerPC] Implement a TestSuiteBuilder.

@gkistanova Thanks! I left it on staging for a day and am pretty happy with where it's at. Let me know if there's anything else you want me to change before approval and commit. Thanks!

Sep 17 2021, 10:47 AM · Restricted Project

Sep 16 2021

Conanap updated the diff for D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.

Removed complexity and restored a test case

Sep 16 2021, 1:05 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the summary of D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.
Sep 16 2021, 11:49 AM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.

Removed unintended change, moved pattern to more appropriate location, reduced added complexity to 600 as it still works.

Sep 16 2021, 11:16 AM · Restricted Project, Restricted Project, Restricted Project
Conanap requested review of D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws.
Sep 16 2021, 11:11 AM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2021

Conanap added a comment to D109628: [Zorg][PowerPC] Implement a TestSuiteBuilder.

@gkistanova this should hopefully have addressed all your concerns. Please let me know if there's anything else, thanks!

Sep 15 2021, 12:42 PM · Restricted Project
Conanap updated the diff for D109628: [Zorg][PowerPC] Implement a TestSuiteBuilder.

Removed jobs option, removed .gitignore changes, removed import rename.

Sep 15 2021, 12:42 PM · Restricted Project
Conanap updated the diff for D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

Removed .gitignore changes, fixed import naming, removed jobs option.

Sep 15 2021, 12:41 PM · Restricted Project, Restricted Project

Sep 10 2021

Conanap updated the summary of D109628: [Zorg][PowerPC] Implement a TestSuiteBuilder.
Sep 10 2021, 1:33 PM · Restricted Project
Conanap added a comment to D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

new patch is here: https://reviews.llvm.org/D109628

Sep 10 2021, 1:31 PM · Restricted Project, Restricted Project
Conanap requested review of D109628: [Zorg][PowerPC] Implement a TestSuiteBuilder.
Sep 10 2021, 1:31 PM · Restricted Project
Conanap added a reverting change for rZORG96033070cd80: [Zorg][PowerPC] Implemented run test suite functionality in two builders: rZORGcf69b5b8eb90: Revert "[Zorg][PowerPC] Implemented run test suite functionality in two….
Sep 10 2021, 7:52 AM
Conanap added a reverting change for D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite: rZORGcf69b5b8eb90: Revert "[Zorg][PowerPC] Implemented run test suite functionality in two….
Sep 10 2021, 7:52 AM · Restricted Project, Restricted Project
Conanap committed rZORGcf69b5b8eb90: Revert "[Zorg][PowerPC] Implemented run test suite functionality in two… (authored by Conanap).
Revert "[Zorg][PowerPC] Implemented run test suite functionality in two…
Sep 10 2021, 7:52 AM
Conanap added a comment to D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

I'll go ahead and revert the commit so that no one goes and use these options. Thanks!

Sep 10 2021, 7:51 AM · Restricted Project, Restricted Project

Sep 9 2021

Conanap added a comment to D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

I'm happy to reimplement this as a separate builder; would you like me to revert the commit or is it alright for me to have the other builder implemented and revert the changes in that commit as well?

Sep 9 2021, 8:06 PM · Restricted Project, Restricted Project
Conanap committed rZORG96033070cd80: [Zorg][PowerPC] Implemented run test suite functionality in two builders (authored by Conanap).
[Zorg][PowerPC] Implemented run test suite functionality in two builders
Sep 9 2021, 12:48 PM
Conanap closed D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.
Sep 9 2021, 12:48 PM · Restricted Project, Restricted Project

Sep 8 2021

Conanap added inline comments to D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.
Sep 8 2021, 7:31 AM · Restricted Project, Restricted Project
Conanap updated the diff for D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

Updated descriptions

Sep 8 2021, 7:29 AM · Restricted Project, Restricted Project
Conanap updated the diff for D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

Added a way for lit arguments to be parsed

Sep 8 2021, 7:26 AM · Restricted Project, Restricted Project

Sep 7 2021

Conanap updated the diff for D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

Addressed Jinsong's comments

Sep 7 2021, 1:36 PM · Restricted Project, Restricted Project
Conanap added inline comments to D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.
Sep 7 2021, 1:32 PM · Restricted Project, Restricted Project

Sep 2 2021

Conanap added inline comments to D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.
Sep 2 2021, 11:31 PM · Restricted Project, Restricted Project
Conanap added a comment to D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

Thanks for the suggestions @jsji , I think this should address all of your comments.

Sep 2 2021, 11:30 PM · Restricted Project, Restricted Project
Conanap updated the diff for D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

Improved implementation

Sep 2 2021, 11:29 PM · Restricted Project, Restricted Project

Aug 31 2021

Conanap updated the diff for D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

Changed implementation to UnifiedTreeBuilder. I kept the clang factory builder implementation too in case that could be useful to others, but can be removed if we think it's not necessary.

Aug 31 2021, 1:44 PM · Restricted Project, Restricted Project

Aug 26 2021

Conanap added a comment to D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

The Unified Tree builder did not have a test suite step, so it was easier to use cmake clang builder which already have a test suite step for us to take advantage of.

OK ... Thanks.
But since we have to add the cmake steps anyhow, the only difference is about source checkout, which should be easy in Unified Tree as well?
Anyway, let us see what is Galina's comments about this first.

Aug 26 2021, 1:55 PM · Restricted Project, Restricted Project
Conanap added a comment to D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.

What is the reason of moving back to clang builder? Looks like we need to add the cmake test-suite for ClangBuilder here as well. Any particular reason that we can not add it as an optional step in UnifiedTreeBuilder?

Aug 26 2021, 1:27 PM · Restricted Project, Restricted Project
Conanap requested review of D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.
Aug 26 2021, 12:40 PM · Restricted Project, Restricted Project

Aug 19 2021

Conanap committed rG9d4faa8ac3e7: [PowerPC] Implement cmplxl builtins (authored by Conanap).
[PowerPC] Implement cmplxl builtins
Aug 19 2021, 7:39 PM
Conanap closed D107138: [PowerPC] Implement cmplxl builtins.
Aug 19 2021, 7:39 PM · Restricted Project, Restricted Project
Conanap added inline comments to D108352: [PowerPC] Fix a test case failure when compiled with libcxx.
Aug 19 2021, 12:22 PM · Restricted Project, Restricted Project, Restricted Project
Conanap updated the diff for D108352: [PowerPC] Fix a test case failure when compiled with libcxx.

De Morgan's for readability

Aug 19 2021, 12:22 PM · Restricted Project, Restricted Project, Restricted Project
Conanap added a comment to D108071: [libcxx] Improve testing in #ifdef..

@Conanap I'm a bit confused now. Do you want me to fix this patch or do you want to land your patch?

Aug 19 2021, 8:41 AM · Restricted Project
Conanap added a comment to D108071: [libcxx] Improve testing in #ifdef..

Sorry for the late reply! There were some internal discussions before we came to a conclusion.

Aug 19 2021, 7:46 AM · Restricted Project

Aug 18 2021

Conanap removed a reviewer for D108352: [PowerPC] Fix a test case failure when compiled with libcxx: Restricted Project.
Aug 18 2021, 10:24 PM · Restricted Project, Restricted Project, Restricted Project
Conanap edited reviewers for D108352: [PowerPC] Fix a test case failure when compiled with libcxx, added: Restricted Project, nemanjai, saghir; removed: Restricted Project.
Aug 18 2021, 10:24 PM · Restricted Project, Restricted Project, Restricted Project
Conanap requested review of D108352: [PowerPC] Fix a test case failure when compiled with libcxx.
Aug 18 2021, 10:23 PM · Restricted Project, Restricted Project, Restricted Project

Aug 10 2021

Conanap updated the diff for D107138: [PowerPC] Implement cmplxl builtins.

Removed unintended change

Aug 10 2021, 1:06 PM · Restricted Project, Restricted Project

Aug 9 2021

Conanap updated the diff for D107138: [PowerPC] Implement cmplxl builtins.

Merged the test case into the existing cmplx test

Aug 9 2021, 2:34 PM · Restricted Project, Restricted Project

Aug 4 2021

Conanap added inline comments to D107138: [PowerPC] Implement cmplxl builtins.
Aug 4 2021, 12:45 PM · Restricted Project, Restricted Project
Conanap updated the diff for D107138: [PowerPC] Implement cmplxl builtins.

Removed backend tests, removed some uneeded definitions,
updated frontend test with regex for variable names.

Aug 4 2021, 12:45 PM · Restricted Project, Restricted Project

Jul 30 2021

Conanap added reviewers for D107138: [PowerPC] Implement cmplxl builtins: Restricted Project, nemanjai.
Jul 30 2021, 1:28 AM · Restricted Project, Restricted Project
Conanap requested review of D107138: [PowerPC] Implement cmplxl builtins.
Jul 30 2021, 1:28 AM · Restricted Project, Restricted Project

Jul 26 2021

Conanap committed rG18526b0d661f: [PowerPC] Changed sema checking range for tdw td builtin (authored by Conanap).
[PowerPC] Changed sema checking range for tdw td builtin
Jul 26 2021, 4:45 PM
Conanap closed D106817: [PowerPC] Changed sema checking range for tdw td builtin.
Jul 26 2021, 4:44 PM · Restricted Project
Conanap updated the summary of D106817: [PowerPC] Changed sema checking range for tdw td builtin.
Jul 26 2021, 1:40 PM · Restricted Project
Conanap updated the diff for D106817: [PowerPC] Changed sema checking range for tdw td builtin.

Updated test cases

Jul 26 2021, 12:23 PM · Restricted Project
Conanap added reviewers for D106817: [PowerPC] Changed sema checking range for tdw td builtin: Restricted Project, nemanjai.
Jul 26 2021, 12:17 PM · Restricted Project