thanks for reverting!

looks like this commit might be causing some failures on PowerPC buildbots, would you be able to take a quick look? Failing test case is Clang :: OpenMP/nvptx_target_printf_codegen.c.

Updated the SDT definition for PPCxxperm to allow for different types of masks

Rebase

Fixed unintended changes

Added mordern assembler check

lgtm

lgtm

Updated correct version of the patch

Added context, changed var names in aptterns

Fixed an old test case

This modifies a test case introduced in this commit: https://github.com/llvm/llvm-project/commit/3678df5ae6618eec656ae0ea0dab3be09d73bc9a

Added P7 and P8 run lines for BE

Updated test cases, fixed a typo

Moved test case back to original file and use #ifdef __PPC64__ instead

Added test cases

Added error testing

Removed AIX test line as it has the same code gen as BE

I've removed the steps import in the actual commit. Thanks!

gentle ping @gkistanova

lgtm

lgtm

LGTM

@gkistanova Thanks! I left it on staging for a day and am pretty happy with where it's at. Let me know if there's anything else you want me to change before approval and commit. Thanks!

Removed complexity and restored a test case

Removed unintended change, moved pattern to more appropriate location, reduced added complexity to 600 as it still works.

@gkistanova this should hopefully have addressed all your concerns. Please let me know if there's anything else, thanks!

Removed jobs option, removed .gitignore changes, removed import rename.

Removed .gitignore changes, fixed import naming, removed jobs option.

new patch is here: https://reviews.llvm.org/D109628

I'll go ahead and revert the commit so that no one goes and use these options. Thanks!

I'm happy to reimplement this as a separate builder; would you like me to revert the commit or is it alright for me to have the other builder implemented and revert the changes in that commit as well?

Updated descriptions

Added a way for lit arguments to be parsed

Addressed Jinsong's comments

Thanks for the suggestions @jsji , I think this should address all of your comments.

Improved implementation

Changed implementation to UnifiedTreeBuilder. I kept the clang factory builder implementation too in case that could be useful to others, but can be removed if we think it's not necessary.

In D108783#2968036, @jsji wrote:

The Unified Tree builder did not have a test suite step, so it was easier to use cmake clang builder which already have a test suite step for us to take advantage of.

OK ... Thanks.
But since we have to add the cmake steps anyhow, the only difference is about source checkout, which should be easy in Unified Tree as well?
Anyway, let us see what is Galina's comments about this first.

In D108783#2968000, @jsji wrote:

What is the reason of moving back to clang builder? Looks like we need to add the cmake test-suite for ClangBuilder here as well. Any particular reason that we can not add it as an optional step in UnifiedTreeBuilder?

De Morgan's for readability

In D108071#2954864, @Mordante wrote:

@Conanap I'm a bit confused now. Do you want me to fix this patch or do you want to land your patch?

Sorry for the late reply! There were some internal discussions before we came to a conclusion.

Removed unintended change

Merged the test case into the existing cmplx test

Removed backend tests, removed some uneeded definitions,
updated frontend test with regex for variable names.

Updated test cases