Rebase and added 64 bit sema checking

This change is no longer needed

ah maybe I missed the word Revision, thank you!

patch did not auto close; was pushed.

Removed an unintended change

Thanks @gkistanova ! I've added the option and tested it on a local server, seems to be pretty happy.
@jsji I've updated the patch, please take a look when you get a a chance. Thanks!

Added enable_runtime="auto".

@gkistanova I've tested this on a local test server and it seems to run alright. We've changed the job number to 192 and found it to be stable. However, the lld will remain at 20 as more jobs seem to cause some issues on our machines. Please take a look when you get a chance, thank you!

Updated buildbot worker to use 192 jobs.

Added big-endian pattern

Updated worker to use 8 jobs

Put back -j20 as we're seeing too many threads being used.

Added compiler-rt compatibility, removed thread limit argument. Bot was tested on a local server.

Rebased and fixed indentations

Updated COPY_TO_REGCLASS to SUBREG_TO_REG, added a test case.

In D101304#2733314, @kzhuravl wrote:

In D101304#2733289, @Conanap wrote:

Hello,

The reland version of this patch for which I cannot find the differential of has broken LLVM::note-amd-valid-v2.test on PowerPC:

/home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test:17:14: error: LLVM-NEXT: expected string not found in input
# LLVM-NEXT: AMD HSA Code Object Version: [Major: 2, Minor: 1]
             ^
<stdin>:15:68: note: scanning from here
 Type: NT_AMD_HSA_CODE_OBJECT_VERSION (AMD HSA Code Object Version)
                                                                   ^
<stdin>:16:2: note: possible intended match here
 AMD HSA Code Object Version: [Major: 33554432, Minor: 16777216]
 ^
Input file: <stdin>
Check file: /home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test
-dump-input=help explains the following input dump.
Input was:
<<<<<<
           .
           .
           .
          10:  Offset: 0x40 
          11:  Size: 0x18 
          12:  Note { 
          13:  Owner: AMD 
          14:  Data size: 0x8 
          15:  Type: NT_AMD_HSA_CODE_OBJECT_VERSION (AMD HSA Code Object Version) 
next:17'0                                                                        X error: no match found
          16:  AMD HSA Code Object Version: [Major: 33554432, Minor: 16777216] 
next:17'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:17'1      ?                                                                possible intended match

Seems like a small fix but if you could have a push for it soon that'd be great. Thanks! FYI @rksharma

Hi,

Reland patch fixed an issue if AMDGPU backend was not built, which was a one liner (I reverted original patch to not create the noise).

Seems like it is an endianness issue.

Unfortunately I don't have PowerPC, will adding these lines in note-amd-valid-v2.test mark it as XFAIL for you:

diff --git a/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test b/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test
index 688bbd50994c..f9cac212ce9f 100644
--- a/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test
+++ b/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test
@@ -1,6 +1,9 @@
 ## This test is checking the handling of valid note entries for AMDGPU code
 ## object v2.

+## Big endian not supported.
+# XFAIL: host-byteorder-big-endian
+
 # RUN: yaml2obj %s -o %t.o
 # RUN: llvm-readobj --notes %t.o | FileCheck %s --match-full-lines --check-prefix=LLVM
 # RUN: llvm-readelf --notes %t.o | FileCheck %s --match-full-lines --check-prefix=GNU

?

The reland version of this patch for which I cannot find the differential of has broken LLVM::note-amd-valid-v2.test on PowerPC:

/home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test:17:14: error: LLVM-NEXT: expected string not found in input
# LLVM-NEXT: AMD HSA Code Object Version: [Major: 2, Minor: 1]
             ^
<stdin>:15:68: note: scanning from here
 Type: NT_AMD_HSA_CODE_OBJECT_VERSION (AMD HSA Code Object Version)
                                                                   ^
<stdin>:16:2: note: possible intended match here
 AMD HSA Code Object Version: [Major: 33554432, Minor: 16777216]
 ^
Input file: <stdin>
Check file: /home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test
-dump-input=help explains the following input dump.
Input was:
<<<<<<
           .
           .
           .
          10:  Offset: 0x40 
          11:  Size: 0x18 
          12:  Note { 
          13:  Owner: AMD 
          14:  Data size: 0x8 
          15:  Type: NT_AMD_HSA_CODE_OBJECT_VERSION (AMD HSA Code Object Version) 
next:17'0                                                                        X error: no match found
          16:  AMD HSA Code Object Version: [Major: 33554432, Minor: 16777216] 
next:17'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:17'1      ?                                                                possible intended match

On PowerPC for LLVM::note-amd-valid-v2.test:

/home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test:17:14: error: LLVM-NEXT: expected string not found in input
# LLVM-NEXT: AMD HSA Code Object Version: [Major: 2, Minor: 1]
             ^
<stdin>:15:68: note: scanning from here
 Type: NT_AMD_HSA_CODE_OBJECT_VERSION (AMD HSA Code Object Version)
                                                                   ^
<stdin>:16:2: note: possible intended match here
 AMD HSA Code Object Version: [Major: 33554432, Minor: 16777216]
 ^
Input file: <stdin>
Check file: /home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test
-dump-input=help explains the following input dump.
Input was:
<<<<<<
           .
           .
           .
          10:  Offset: 0x40 
          11:  Size: 0x18 
          12:  Note { 
          13:  Owner: AMD 
          14:  Data size: 0x8 
          15:  Type: NT_AMD_HSA_CODE_OBJECT_VERSION (AMD HSA Code Object Version) 
next:17'0                                                                        X error: no match found
          16:  AMD HSA Code Object Version: [Major: 33554432, Minor: 16777216] 
next:17'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:17'1      ?                                                                possible intended match

Changed clean to false, removed a flag in favour of passing into arguments.

This patch seems to upset the PowerPC compilers:

Updated to remove uncessary xrsp and other xxsldwi as well

As mentioned above, this seems to be causing segfaults on PPC buildbots; did some builds on a few revisions and this seems to be the cause.

Added test file

Using ninja instead

This doesn't actually seem to affect buildbot's operations so the changes is not likely needed.

Not sure what happened with phabricator, but there's been no change since last diff and this is just for record sake.

Another person had made the same fix for the CMAKE_ARGS variable declaration, so this just adds a conditional to ccache. No longer an urgent issue.

pushed

Sorry to ping you @gkistanova; this one is a bit urgent though. Thanks!

Removed logging as files are not available, updated comment and fix function call

removed incorrect brackets

Incorrectly updated this patch

removed incorrect brackets

Oh that is very weird. Let me reupload the differential for records sake. Would you mind taking a quick peak again @gkistanova, just to be on the safe side? Thank you!

Not sure if there was a glitch but this should be the correct patch again

Updated to align with changes on the patch this depends on.

Changed from using strings to -- to improve portability; changed order of arguments. I'll update the dependent patch to properly reflect the changes made here.

gentle ping

Updated a comment and a test case

Updated some comments.

Updated 2 test cases and some nits

A new test case started failing in the process of upstreaming this patched; updated that test case.