Page MenuHomePhabricator

XFAIL missing-abstract-variable.ll test on ppc64le
Needs ReviewPublic

Authored by tstellar on Tue, Sep 14, 8:26 PM.

Details

Summary

It's seems the strategy with this test is to XFAIL it on all
architectures that it fails on. I wonder if we should be passing
it a specific triple? Also, the test passes for me when LLVM is configured to use the default triple of powerpc64le-unknown-linux-gnu, but fails when I configure the default triple to be ppc64le-redhat-linux-gnu.

Diff Detail

Event Timeline

tstellar created this revision.Tue, Sep 14, 8:26 PM
tstellar requested review of this revision.Tue, Sep 14, 8:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Sep 14, 8:26 PM

when llvm is configured with LLVM_DEFAULT_TARGET_TRIPLE set to a non-empty value,

Do you mean an empty value? I believe this is set to the host by default.

when llvm is configured with LLVM_DEFAULT_TARGET_TRIPLE set to a non-empty value,

Do you mean an empty value? I believe this is set to the host by default.

Yes, you are correct, there is a default value form this variable which comes from config.guess. So I guess this means this test is sensitive to what the target triple is, because it's failing for me when I set the default triple to ppc64le-redhat-linux-gnu, but not when it uses the default triple of powerpc64le-unknown-linux-gnu.

tstellar edited the summary of this revision. (Show Details)Tue, Sep 14, 9:06 PM