This aligns the printer with the parser contract: the operation isn't part of the user-controllable part of the syntax.
Depends On D108803
Paths
| Differential D108804
Change ASM Op printer to print the operation name in the framework instead of leaving it up to each individual operation ClosedPublic Authored by mehdi_amini on Aug 26 2021, 9:58 PM.
Details Summary This aligns the printer with the parser contract: the operation isn't part of the user-controllable part of the syntax. Depends On D108803
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Aug 26 2021, 10:43 PM Comment Actions Fix parseOneResultSameOperandTypeOp to support parsing the generic form emitted by printOneResultOp One consequence of the current patch is that using printGenericOp from a custom printer bondhugula added inline comments.
This revision was landed with ongoing or failed builds.Aug 31 2021, 10:53 AM Closed by commit rGc41b16c26bdb: Change ASM Op printer to print the operation name in the framework instead of… (authored by mehdi_amini). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 369271 flang/include/flang/Optimizer/Dialect/FIROps.td
flang/lib/Optimizer/Dialect/FIROps.cpp
mlir/examples/toy/Ch2/mlir/Dialect.cpp
mlir/examples/toy/Ch3/mlir/Dialect.cpp
mlir/examples/toy/Ch4/mlir/Dialect.cpp
mlir/examples/toy/Ch5/mlir/Dialect.cpp
mlir/examples/toy/Ch6/mlir/Dialect.cpp
mlir/examples/toy/Ch7/mlir/Dialect.cpp
mlir/include/mlir/Dialect/GPU/GPUOps.td
mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td
mlir/include/mlir/Dialect/Utils/ReshapeOpsUtils.h
mlir/include/mlir/IR/OpDefinition.h
mlir/include/mlir/IR/OpImplementation.h
mlir/lib/Dialect/Affine/IR/AffineOps.cpp
mlir/lib/Dialect/Async/IR/Async.cpp
mlir/lib/Dialect/EmitC/IR/EmitC.cpp
mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp
mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
mlir/lib/Dialect/SCF/SCF.cpp
mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
mlir/lib/Dialect/Shape/IR/Shape.cpp
mlir/lib/Dialect/StandardOps/IR/Ops.cpp
mlir/lib/Dialect/Vector/VectorOps.cpp
mlir/lib/IR/AsmPrinter.cpp
mlir/lib/IR/FunctionImplementation.cpp
mlir/lib/IR/Operation.cpp
mlir/test/Dialect/Standard/expand-ops.mlir
mlir/test/IR/invalid-ops.mlir
mlir/test/lib/Dialect/Test/TestDialect.cpp
mlir/tools/mlir-tblgen/OpFormatGen.cpp
|
Is this method named correctly? It's not printing the entire op.