This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add tests for op availability
AbandonedPublic

Authored by antiagainst on Aug 10 2021, 11:27 AM.

Details

Summary

This checks ops declaring version requirements
properly implements various interfaces, with
proper composition of version requirements
coming from multiple parts of the op, including
the op itself and enum attributes.

Depends On D107847

Diff Detail

Event Timeline

antiagainst created this revision.Aug 10 2021, 11:27 AM
antiagainst requested review of this revision.Aug 10 2021, 11:27 AM
mravishankar accepted this revision.Aug 17 2021, 12:13 PM
This revision is now accepted and ready to land.Aug 17 2021, 12:13 PM
rriddle added inline comments.Aug 17 2021, 12:24 PM
mlir/include/mlir/IR/OpBase.td
2345

This looks like a bug fix. Is there a reason this is a separate commit? as opposed to rolling this into the parent(given that it is still under review/hasn't landed)? or would it be possible to move this part to before the parent(i.e. before moving things out of SPIRV), and move the tests into the parent?

Address comments

antiagainst marked an inline comment as done.Aug 18 2021, 11:26 AM
antiagainst added inline comments.
mlir/include/mlir/IR/OpBase.td
2345

SG. I've moved the bug fix to https://reviews.llvm.org/D108312. I can also merge this into its parent but I was worried that it will create a gigantic patch which will make it harder to review. But if you think that's fine, I can merge all patches together since https://reviews.llvm.org/D107846.

antiagainst abandoned this revision.Aug 19 2021, 6:29 AM
antiagainst marked an inline comment as done.

Merged into D107846