This checks ops declaring version requirements
properly implements various interfaces, with
proper composition of version requirements
coming from multiple parts of the op, including
the op itself and enum attributes.
Depends On D107847
Paths
| Differential D107851
[mlir] Add tests for op availability AbandonedPublic Authored by antiagainst on Aug 10 2021, 11:27 AM.
Details
Summary This checks ops declaring version requirements Depends On D107847
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Aug 17 2021, 12:13 PM
antiagainst added a child revision: D108313: [mlir] Add documentation for op availability.Aug 18 2021, 11:23 AM antiagainst added inline comments.
Revision Contents
Diff 365563 mlir/include/mlir/IR/OpBase.td
mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp
mlir/lib/Dialect/SPIRV/Transforms/UpdateVCEPass.cpp
mlir/test/IR/op-availability.mlir
mlir/test/lib/Dialect/SPIRV/TestAvailability.cpp
mlir/test/lib/Dialect/Test/CMakeLists.txt
mlir/test/lib/Dialect/Test/TestDialect.h
mlir/test/lib/Dialect/Test/TestOpAvailability.cpp
mlir/test/lib/Dialect/Test/TestOps.td
mlir/tools/mlir-opt/mlir-opt.cpp
utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
|
This looks like a bug fix. Is there a reason this is a separate commit? as opposed to rolling this into the parent(given that it is still under review/hasn't landed)? or would it be possible to move this part to before the parent(i.e. before moving things out of SPIRV), and move the tests into the parent?