This is an archive of the discontinued LLVM Phabricator instance.

Differential D107189

[z/OS]Remove overriding default attribute aligned value
ClosedPublic

Authored by fanbo-meng on Jul 30 2021, 12:05 PM.

Details

Reviewers
abhina.sreeskantharajan
anirudhp
NancyWang2222
muiez
Commits
rGbdf4c7b738ee: [z/OS]Remove overriding default attribute aligned value
Summary

Make DefaultAlignForAttributeAligned consistent with SystemZ.

Diff Detail

Event Timeline

fanbo-meng requested review of this revision.Jul 30 2021, 12:05 PM
fanbo-meng created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2021, 12:05 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
fanbo-meng added reviewers: abhina.sreeskantharajan, anirudhp, NancyWang2222, muiez.Jul 30 2021, 12:06 PM
anirudhp accepted this revision.Jul 30 2021, 12:37 PM
This revision is now accepted and ready to land.Jul 30 2021, 12:37 PM
abhina.sreeskantharajan accepted this revision.Jul 30 2021, 12:39 PM

LGTM

Harbormaster completed remote builds in B117243: Diff 363178.Jul 30 2021, 12:42 PM
This revision was landed with ongoing or failed builds.Jul 30 2021, 12:51 PM
Closed by commit rGbdf4c7b738ee: [z/OS]Remove overriding default attribute aligned value (authored by fanbo-meng). · Explain Why
This revision was automatically updated to reflect the committed changes.
fanbo-meng added a commit: rGbdf4c7b738ee: [z/OS]Remove overriding default attribute aligned value.

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
1 line
test/
CodeGen/
SystemZ/
2 lines

Diff 363186

clang/lib/Basic/Targets/OSTargets.h

Show First 20 Lines • Show All 790 Lines • ▼ Show 20 Linespublic:
ZOSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts) ZOSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
: OSTargetInfo<Target>(Triple, Opts) { : OSTargetInfo<Target>(Triple, Opts) {
this->WCharType = TargetInfo::UnsignedInt; this->WCharType = TargetInfo::UnsignedInt;
this->MaxAlignedAttribute = 128; this->MaxAlignedAttribute = 128;
this->UseBitFieldTypeAlignment = false; this->UseBitFieldTypeAlignment = false;
this->UseZeroLengthBitfieldAlignment = true; this->UseZeroLengthBitfieldAlignment = true;
this->UseLeadingZeroLengthBitfield = false; this->UseLeadingZeroLengthBitfield = false;
this->ZeroLengthBitfieldBoundary = 32; this->ZeroLengthBitfieldBoundary = 32;
this->DefaultAlignForAttributeAligned = 128;
} }
}; };
void addWindowsDefines(const llvm::Triple &Triple, const LangOptions &Opts, void addWindowsDefines(const llvm::Triple &Triple, const LangOptions &Opts,
MacroBuilder &Builder); MacroBuilder &Builder);
// Windows target // Windows target
template <typename Target> template <typename Target>
▲ Show 20 Lines • Show All 159 Lines • Show Last 20 Lines

clang/test/CodeGen/SystemZ/zos-alignment.c

Show First 20 Lines • Show All 141 Lines • ▼ Show 20 Lines
// CHECK-NEXT: 0:- | unsigned short // CHECK-NEXT: 0:- | unsigned short
// CHECK-NEXT: | [sizeof=0, align=1] // CHECK-NEXT: | [sizeof=0, align=1]
struct s10 { struct s10 {
unsigned int __attribute__((aligned)) a; unsigned int __attribute__((aligned)) a;
} S10; } S10;
// CHECK: 0 | struct s10 // CHECK: 0 | struct s10
// CHECK-NEXT: 0 | unsigned int a // CHECK-NEXT: 0 | unsigned int a
// CHECK-NEXT: | [sizeof=16, align=16] // CHECK-NEXT: | [sizeof=8, align=8]
struct s11 { struct s11 {
char a; char a;
long : 0; long : 0;
char b; char b;
} S11; } S11;
// CHECK: 0 | struct s11 // CHECK: 0 | struct s11
// CHECK-NEXT: 0 | char a // CHECK-NEXT: 0 | char a
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines