Page MenuHomePhabricator

fanbo-meng (Fanbo Meng)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 13 2020, 6:29 AM (104 w, 2 d)

Recent Activity

Jul 11 2022

fanbo-meng accepted D129493: [libc++][NFC] Add MVS guard for locale_mgmt_zos.h.

LGTM

Jul 11 2022, 8:41 AM · Restricted Project, Restricted Project
fanbo-meng accepted D129491: [libcxx][AIX][z/OS] Remove headers included via `_IBMCPP__`.

LGTM

Jul 11 2022, 8:33 AM · Restricted Project, Restricted Project

Mar 24 2022

fanbo-meng added a comment to D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.

ping :) @libcxx

Mar 24 2022, 12:21 PM · Restricted Project, Restricted Project

Mar 9 2022

fanbo-meng updated the diff for D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.

Addressing comments

Mar 9 2022, 6:55 AM · Restricted Project, Restricted Project
fanbo-meng added inline comments to D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.
Mar 9 2022, 6:47 AM · Restricted Project, Restricted Project
fanbo-meng added inline comments to D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.
Mar 9 2022, 6:34 AM · Restricted Project, Restricted Project

Feb 17 2022

fanbo-meng updated the diff for D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.

formatting __config; rename new sources files to have unique names

Feb 17 2022, 6:42 AM · Restricted Project, Restricted Project

Feb 16 2022

fanbo-meng updated the diff for D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.

run clang-format

Feb 16 2022, 1:32 PM · Restricted Project, Restricted Project
fanbo-meng accepted D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.

LGTM

Feb 16 2022, 8:16 AM · Restricted Project, Restricted Project, Restricted Project
fanbo-meng updated the diff for D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.

rebase to latest main

Feb 16 2022, 8:11 AM · Restricted Project, Restricted Project

Feb 15 2022

fanbo-meng updated the diff for D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.

Update zos cmake cache

Feb 15 2022, 9:16 AM · Restricted Project, Restricted Project

Feb 14 2022

fanbo-meng added a comment to D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.

ping :)

Feb 14 2022, 7:13 AM · Restricted Project, Restricted Project

Feb 2 2022

fanbo-meng abandoned D118723: [SystemZ][z/OS]: Manually create lit tmp_dir.
Feb 2 2022, 6:07 AM · Restricted Project

Feb 1 2022

fanbo-meng updated the diff for D118723: [SystemZ][z/OS]: Manually create lit tmp_dir.

update comment

Feb 1 2022, 12:20 PM · Restricted Project
fanbo-meng added reviewers for D118723: [SystemZ][z/OS]: Manually create lit tmp_dir: abhina.sreeskantharajan, NancyWang2222, muiez.
Feb 1 2022, 12:17 PM · Restricted Project
fanbo-meng requested review of D118723: [SystemZ][z/OS]: Manually create lit tmp_dir.
Feb 1 2022, 12:16 PM · Restricted Project

Jan 31 2022

fanbo-meng updated the summary of D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.
Jan 31 2022, 8:50 AM · Restricted Project, Restricted Project
fanbo-meng updated the summary of D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.
Jan 31 2022, 8:50 AM · Restricted Project, Restricted Project
fanbo-meng requested review of D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.
Jan 31 2022, 8:48 AM · Restricted Project, Restricted Project

Jan 6 2022

fanbo-meng committed rG43c5e61b555c: [SystemZ][z/OS][libcxx]:Fix fopen64 undeclared error in 32 bit mode (authored by fanbo-meng).
[SystemZ][z/OS][libcxx]:Fix fopen64 undeclared error in 32 bit mode
Jan 6 2022, 5:58 AM
fanbo-meng closed D111226: [SystemZ][z/OS][libcxx]:Fix fopen64 undeclared error in 32 bit mode.
Jan 6 2022, 5:58 AM · Restricted Project

Dec 16 2021

fanbo-meng committed rG9a3584499015: [z/OS] Implement prologue and epilogue generation for z/OS target. (authored by Everybody0523).
[z/OS] Implement prologue and epilogue generation for z/OS target.
Dec 16 2021, 6:04 AM

Oct 25 2021

fanbo-meng added a comment to D111226: [SystemZ][z/OS][libcxx]:Fix fopen64 undeclared error in 32 bit mode.

@ldionne Could you review this patch please, thanks!

Oct 25 2021, 9:16 AM · Restricted Project

Oct 19 2021

fanbo-meng added a comment to D111226: [SystemZ][z/OS][libcxx]:Fix fopen64 undeclared error in 32 bit mode.

ping for a libc++ group reviewer, thanks.

Oct 19 2021, 9:51 AM · Restricted Project

Oct 14 2021

fanbo-meng added a reviewer for D111226: [SystemZ][z/OS][libcxx]:Fix fopen64 undeclared error in 32 bit mode: ldionne.
Oct 14 2021, 5:59 AM · Restricted Project

Oct 13 2021

fanbo-meng added a comment to D111226: [SystemZ][z/OS][libcxx]:Fix fopen64 undeclared error in 32 bit mode.

ping

Oct 13 2021, 5:56 AM · Restricted Project

Oct 8 2021

fanbo-meng accepted D111320: [test] Use host platform specific error message substitution.
Oct 8 2021, 10:51 AM · Restricted Project

Oct 6 2021

fanbo-meng added reviewers for D111226: [SystemZ][z/OS][libcxx]:Fix fopen64 undeclared error in 32 bit mode: abhina.sreeskantharajan, muiez.
Oct 6 2021, 6:08 AM · Restricted Project
fanbo-meng requested review of D111226: [SystemZ][z/OS][libcxx]:Fix fopen64 undeclared error in 32 bit mode.
Oct 6 2021, 6:07 AM · Restricted Project

Aug 31 2021

fanbo-meng committed rGae206db2d653: [SystemZ][z/OS] Create html report file with text flag (authored by fanbo-meng).
[SystemZ][z/OS] Create html report file with text flag
Aug 31 2021, 8:52 AM
fanbo-meng closed D108998: [SystemZ][z/OS] Create html report file with text flag.
Aug 31 2021, 8:52 AM · Restricted Project
fanbo-meng added reviewers for D108998: [SystemZ][z/OS] Create html report file with text flag: abhina.sreeskantharajan, Kai, muiez, zibi.
Aug 31 2021, 7:49 AM · Restricted Project
fanbo-meng requested review of D108998: [SystemZ][z/OS] Create html report file with text flag.
Aug 31 2021, 7:48 AM · Restricted Project

Aug 27 2021

fanbo-meng committed rG9d7a77c26d2f: [MCParser][z/OS] Mark test as unsupported for the z/OS Target (authored by fanbo-meng).
[MCParser][z/OS] Mark test as unsupported for the z/OS Target
Aug 27 2021, 8:46 AM
fanbo-meng closed D108819: [MCParser][z/OS] Mark test as unsupported for the z/OS Target.
Aug 27 2021, 8:45 AM · Restricted Project
fanbo-meng added reviewers for D108819: [MCParser][z/OS] Mark test as unsupported for the z/OS Target: abhina.sreeskantharajan, anirudhp, muiez, uweigand.
Aug 27 2021, 7:29 AM · Restricted Project
fanbo-meng requested review of D108819: [MCParser][z/OS] Mark test as unsupported for the z/OS Target.
Aug 27 2021, 7:28 AM · Restricted Project

Aug 25 2021

fanbo-meng committed rG6b94777be511: [SystemZ] [NFC] Replace SpecialRegisters field with a unique_ptr instead of a… (authored by Everybody0523).
[SystemZ] [NFC] Replace SpecialRegisters field with a unique_ptr instead of a…
Aug 25 2021, 8:28 AM
fanbo-meng closed D108639: [SystemZ] [NFC] Replace SpecialRegisters field with a unique_ptr instead of a raw pointer..
Aug 25 2021, 8:28 AM · Restricted Project

Aug 5 2021

fanbo-meng added a reverting change for rGd91234b21c1a: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test: rG91e399519580: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value….
Aug 5 2021, 7:14 AM
fanbo-meng committed rG91e399519580: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value… (authored by fanbo-meng).
Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value…
Aug 5 2021, 7:14 AM
fanbo-meng added a reverting change for D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test: rG91e399519580: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value….
Aug 5 2021, 7:14 AM · Restricted Project
fanbo-meng closed D107565: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test".
Aug 5 2021, 7:14 AM · Restricted Project
fanbo-meng added reviewers for D107565: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test": abhina.sreeskantharajan, muiez, NancyWang2222.
Aug 5 2021, 6:24 AM · Restricted Project
fanbo-meng added a reverting change for rGd91234b21c1a: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test: D107565: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test".
Aug 5 2021, 6:24 AM
fanbo-meng requested review of D107565: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test".
Aug 5 2021, 6:24 AM · Restricted Project
fanbo-meng added a reverting change for D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test: D107565: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test".
Aug 5 2021, 6:24 AM · Restricted Project

Jul 30 2021

fanbo-meng committed rGbdf4c7b738ee: [z/OS]Remove overriding default attribute aligned value (authored by fanbo-meng).
[z/OS]Remove overriding default attribute aligned value
Jul 30 2021, 12:52 PM
fanbo-meng closed D107189: [z/OS]Remove overriding default attribute aligned value.
Jul 30 2021, 12:51 PM · Restricted Project
fanbo-meng added reviewers for D107189: [z/OS]Remove overriding default attribute aligned value: abhina.sreeskantharajan, anirudhp, NancyWang2222, muiez.
Jul 30 2021, 12:06 PM · Restricted Project
fanbo-meng requested review of D107189: [z/OS]Remove overriding default attribute aligned value.
Jul 30 2021, 12:05 PM · Restricted Project

Jul 27 2021

fanbo-meng committed rGa2d4b064644b: [z/OS] Make MinGlobalAlign consistent with SystemZ (authored by fanbo-meng).
[z/OS] Make MinGlobalAlign consistent with SystemZ
Jul 27 2021, 12:39 PM
fanbo-meng closed D106890: [z/OS] Make MinGlobalAlign consistent with SystemZ.
Jul 27 2021, 12:39 PM · Restricted Project
fanbo-meng added reviewers for D106890: [z/OS] Make MinGlobalAlign consistent with SystemZ: abhina.sreeskantharajan, muiez, Jonathan.Crowther, SeanP.
Jul 27 2021, 9:48 AM · Restricted Project
fanbo-meng requested review of D106890: [z/OS] Make MinGlobalAlign consistent with SystemZ.
Jul 27 2021, 9:47 AM · Restricted Project

Jun 28 2021

fanbo-meng committed rG8d5c0b8768f7: [libc++] Remove unnecessary reinterpret_cast from typeinfo (authored by Jonathan.Crowther).
[libc++] Remove unnecessary reinterpret_cast from typeinfo
Jun 28 2021, 7:01 AM
fanbo-meng closed D104814: [libc++] Remove unnecessary reinterpret_cast from typeinfo.
Jun 28 2021, 7:00 AM · Restricted Project

Jun 21 2021

fanbo-meng committed rGc02160c17b7f: [libc++] Remove unused variable (authored by fanbo-meng).
[libc++] Remove unused variable
Jun 21 2021, 8:40 AM
fanbo-meng closed D104544: [libc++] Remove unused variable.
Jun 21 2021, 8:40 AM · Restricted Project
fanbo-meng abandoned D104650: [libc++] Remove unused variable.
Jun 21 2021, 8:19 AM · Restricted Project
fanbo-meng requested review of D104650: [libc++] Remove unused variable.
Jun 21 2021, 8:17 AM · Restricted Project

Jun 18 2021

fanbo-meng requested review of D104544: [libc++] Remove unused variable.
Jun 18 2021, 8:55 AM · Restricted Project

May 5 2021

fanbo-meng accepted D101904: [SystemZ][z/OS] Fix return values in AutoConversion functions.

LGTM

May 5 2021, 6:23 AM · Restricted Project

Mar 29 2021

fanbo-meng committed rGbd8dd580ffd2: [NFC] clang-formatting zos-alignment.c (authored by fanbo-meng).
[NFC] clang-formatting zos-alignment.c
Mar 29 2021, 1:48 PM
fanbo-meng closed D99514: [NFC] clang-formatting zos-alignment.c.
Mar 29 2021, 1:48 PM · Restricted Project
fanbo-meng requested review of D99514: [NFC] clang-formatting zos-alignment.c.
Mar 29 2021, 9:13 AM · Restricted Project
fanbo-meng committed rGf1e0c7fdd720: [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile… (authored by fanbo-meng).
[SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile…
Mar 29 2021, 9:06 AM
fanbo-meng closed D99508: [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile struct.
Mar 29 2021, 9:06 AM · Restricted Project
fanbo-meng requested review of D99508: [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile struct.
Mar 29 2021, 7:38 AM · Restricted Project
fanbo-meng committed rG0858f0e09e33: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static… (authored by fanbo-meng).
[SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static…
Mar 29 2021, 6:45 AM
fanbo-meng closed D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target.
Mar 29 2021, 6:44 AM · Restricted Project

Mar 28 2021

fanbo-meng updated the diff for D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target.

rebasing to latest master

Mar 28 2021, 1:44 PM · Restricted Project

Mar 26 2021

fanbo-meng committed rG6f91cf75d7f5: [SystemZ][z/OS] Ignore leading zero width bitfield alignment on z/OS target (authored by fanbo-meng).
[SystemZ][z/OS] Ignore leading zero width bitfield alignment on z/OS target
Mar 26 2021, 7:10 AM
fanbo-meng closed D98890: [SystemZ][z/OS] Ignore leading zero width bitfield alignment on z/OS target.
Mar 26 2021, 7:10 AM · Restricted Project

Mar 18 2021

fanbo-meng requested review of D98890: [SystemZ][z/OS] Ignore leading zero width bitfield alignment on z/OS target.
Mar 18 2021, 12:57 PM · Restricted Project
fanbo-meng updated the diff for D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target.

remove accidentally included diff patch file

Mar 18 2021, 7:24 AM · Restricted Project
fanbo-meng updated the diff for D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target.

clang-formatted

Mar 18 2021, 7:06 AM · Restricted Project
fanbo-meng added a reviewer for D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target: hubert.reinterpretcast.
Mar 18 2021, 6:55 AM · Restricted Project
fanbo-meng requested review of D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target.
Mar 18 2021, 6:49 AM · Restricted Project

Jan 11 2021

fanbo-meng accepted D94432: [SystemZ][z/OS] Fix Permission denied pattern matching.

LGTM

Jan 11 2021, 11:22 AM · Restricted Project

Nov 18 2020

fanbo-meng added inline comments to D88741: [SystemZ/z/OS] Add utility class for char set conversion..
Nov 18 2020, 10:01 AM · Restricted Project

Oct 9 2020

fanbo-meng committed rGd91234b21c1a: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test (authored by fanbo-meng).
[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test
Oct 9 2020, 7:15 AM
fanbo-meng closed D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test.
Oct 9 2020, 7:14 AM · Restricted Project
fanbo-meng requested review of D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test.
Oct 9 2020, 6:32 AM · Restricted Project

Oct 7 2020

fanbo-meng committed rG19bc894da12a: [NFC] Add contributors names to CREDITS.TXT (authored by fanbo-meng).
[NFC] Add contributors names to CREDITS.TXT
Oct 7 2020, 10:23 AM
fanbo-meng retitled D88963: [SystemZ][z/OS] Add test of zero length bitfield type size larger than target zero length bitfield boundary from [SystemZ][z/OS] Add test of zero length bitfield type larger than zero length bitfield boundary to [SystemZ][z/OS] Add test of zero length bitfield type size larger than target zero length bitfield boundary.
Oct 7 2020, 6:20 AM · Restricted Project
fanbo-meng requested review of D88963: [SystemZ][z/OS] Add test of zero length bitfield type size larger than target zero length bitfield boundary.
Oct 7 2020, 6:19 AM · Restricted Project

Oct 5 2020

fanbo-meng set the repository for D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target to rG LLVM Github Monorepo.
Oct 5 2020, 1:37 PM · Restricted Project
fanbo-meng updated the diff for D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target.

fix no newline at end of file

Oct 5 2020, 12:52 PM · Restricted Project
fanbo-meng added a reviewer for D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target: SeanP.
Oct 5 2020, 12:49 PM · Restricted Project
fanbo-meng requested review of D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target.
Oct 5 2020, 12:46 PM · Restricted Project

Sep 16 2020

fanbo-meng set the repository for D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS to rG LLVM Github Monorepo.
Sep 16 2020, 9:56 AM · Restricted Project
fanbo-meng updated the diff for D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.

remove trailing whitespace from diagnostic

Sep 16 2020, 9:56 AM · Restricted Project
fanbo-meng added inline comments to D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.
Sep 16 2020, 9:55 AM · Restricted Project
fanbo-meng updated the diff for D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.

fix typo

Sep 16 2020, 8:56 AM · Restricted Project
fanbo-meng updated the diff for D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.

get platform name from triple instead of hardcoding, and convert its spelling

Sep 16 2020, 8:52 AM · Restricted Project
fanbo-meng accepted D87624: [SystemZ][z/OS] Set default wchar_t type for zOS.

LGTM

Sep 16 2020, 7:52 AM · Restricted Project

Sep 15 2020

fanbo-meng set the repository for D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS to rG LLVM Github Monorepo.
Sep 15 2020, 8:47 AM · Restricted Project
fanbo-meng updated the diff for D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.

merge diagnostics

Sep 15 2020, 8:44 AM · Restricted Project
fanbo-meng added inline comments to D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.
Sep 15 2020, 8:33 AM · Restricted Project