Page MenuHomePhabricator

muiez (Muiez Ahmed)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 27 2020, 8:30 AM (82 w, 3 d)

Recent Activity

Mar 17 2022

muiez added a comment to D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.

Ping :) @libcxx @libcxxabi

Mar 17 2022, 12:22 PM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

muiez added inline comments to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Mar 2 2022, 10:05 AM · Restricted Project, Restricted Project, Restricted Project
muiez added inline comments to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Mar 2 2022, 8:18 AM · Restricted Project, Restricted Project, Restricted Project
muiez added inline comments to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Mar 2 2022, 7:27 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++.: Restricted Project.
Mar 2 2022, 7:24 AM · Restricted Project, Restricted Project, Restricted Project

Mar 1 2022

muiez updated the diff for D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.

Refactor with macros

Mar 1 2022, 1:22 PM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2022

muiez added inline comments to D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.
Feb 23 2022, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
muiez updated the diff for D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.

improve include's

Feb 23 2022, 9:57 AM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2022

muiez updated the diff for D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.

Resolve merge conflicts

Feb 22 2022, 9:47 AM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2022

muiez updated the diff for D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.

kickoff CI

Feb 15 2022, 7:27 AM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2022

muiez updated the diff for D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.

resolve lit failure

Feb 14 2022, 12:48 PM · Restricted Project, Restricted Project, Restricted Project

Feb 10 2022

muiez added a comment to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

@libc++abi Can I get a review please? Thanks

Feb 10 2022, 12:02 PM · Restricted Project
muiez added a comment to D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.

@libc++ Can I get a review please? Thanks

Feb 10 2022, 11:04 AM · Restricted Project, Restricted Project, Restricted Project

Feb 4 2022

muiez accepted D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.

LGTM

Feb 4 2022, 10:13 AM · Restricted Project, Restricted Project
muiez accepted D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

LGTM

Feb 4 2022, 10:12 AM · Restricted Project, Restricted Project, Restricted Project

Feb 3 2022

muiez abandoned D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++.
Feb 3 2022, 9:58 AM · Restricted Project
muiez added a comment to D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++.

Closing since this patch is divided into the following (with comments addressed and better approach):

Feb 3 2022, 9:57 AM · Restricted Project
muiez set the repository for D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS to rG LLVM Github Monorepo.
Feb 3 2022, 7:27 AM · Restricted Project
muiez accepted D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

LGTM

Feb 3 2022, 7:24 AM · Restricted Project

Feb 2 2022

muiez added a comment to D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.

Ping :)

Feb 2 2022, 8:31 AM · Restricted Project, Restricted Project, Restricted Project

Jan 28 2022

muiez added inline comments to D118188: [libcxx] [Windows] Pick a unique bit for __regex_word.
Jan 28 2022, 8:23 AM · Restricted Project

Jan 25 2022

muiez set the repository for D118179: [SystemZ][z/OS] Localize runtime error messages in libc++ to rG LLVM Github Monorepo.
Jan 25 2022, 12:44 PM · Restricted Project, Restricted Project, Restricted Project
muiez requested review of D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.
Jan 25 2022, 12:44 PM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2022

muiez committed rG22b0fe3fd9d4: [SystemZ][z/OS]: fix lit tmp_dir to use - instead of _ (authored by NancyWang2222).
[SystemZ][z/OS]: fix lit tmp_dir to use - instead of _
Jan 24 2022, 2:48 PM
muiez closed D118071: [SystemZ][z/OS]: fix lit tmp_dir to use - instead of _ .
Jan 24 2022, 2:48 PM · Restricted Project

Jan 21 2022

muiez committed rG4f8ea3c84f3d: [SystemZ][z/OS][NFC] Remove extra symbol (authored by muiez).
[SystemZ][z/OS][NFC] Remove extra symbol
Jan 21 2022, 1:21 PM

Jan 20 2022

muiez added a comment to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

Ping :)

Jan 20 2022, 12:19 PM · Restricted Project

Jan 14 2022

muiez committed rGa1da73961d29: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence (authored by muiez).
[SystemZ][z/OS] ASCII/EBCDIC support with no coexistence
Jan 14 2022, 8:37 AM
muiez closed D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.
Jan 14 2022, 8:37 AM · Restricted Project, Restricted Project
muiez updated the diff for D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

addressed comment to be more readable

Jan 14 2022, 8:19 AM · Restricted Project, Restricted Project
muiez added a comment to D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

Great points! Updated to account for this.

Jan 14 2022, 8:01 AM · Restricted Project, Restricted Project
muiez updated the diff for D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

safeguard to z/OS, use double underscore function names

Jan 14 2022, 7:59 AM · Restricted Project, Restricted Project

Jan 13 2022

muiez added inline comments to D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.
Jan 13 2022, 1:49 PM · Restricted Project, Restricted Project
muiez updated the diff for D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

Using inline functions instead of macros

Jan 13 2022, 1:48 PM · Restricted Project, Restricted Project

Jan 11 2022

muiez added a comment to D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

ping @libc++ @libc++ab

Jan 11 2022, 1:45 PM · Restricted Project, Restricted Project

Jan 4 2022

muiez added inline comments to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
Jan 4 2022, 7:00 AM · Restricted Project

Dec 29 2021

muiez updated the diff for D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

Add default encoding

Dec 29 2021, 7:03 AM · Restricted Project, Restricted Project

Dec 24 2021

muiez updated the diff for D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

Remove LIBCXX_BUILD_ZOS_ENCODING

Dec 24 2021, 7:41 AM · Restricted Project, Restricted Project

Dec 23 2021

muiez added a comment to D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

Ping

Dec 23 2021, 7:28 AM · Restricted Project, Restricted Project
muiez accepted D111226: [SystemZ][z/OS][libcxx]:Fix fopen64 undeclared error in 32 bit mode.

LGTM

Dec 23 2021, 7:27 AM · Restricted Project

Dec 14 2021

muiez added a comment to D114457: [z/OS] Implement prologue and epilogue generation for z/OS target..

Hey folks, it looks like this commit has caused the buildbot here to run into failures. Can someone please revert this change, fix it and then commit it again?

Dec 14 2021, 11:25 AM · Restricted Project
muiez added a reverting change for rGffad4d777b22: [z/OS] Implement prologue and epilogue generation for z/OS target.: rGebf5497b269f: Revert "[z/OS] Implement prologue and epilogue generation for z/OS target.".
Dec 14 2021, 11:23 AM
muiez committed rGebf5497b269f: Revert "[z/OS] Implement prologue and epilogue generation for z/OS target." (authored by muiez).
Revert "[z/OS] Implement prologue and epilogue generation for z/OS target."
Dec 14 2021, 11:23 AM
muiez added a reverting change for D114457: [z/OS] Implement prologue and epilogue generation for z/OS target.: rGebf5497b269f: Revert "[z/OS] Implement prologue and epilogue generation for z/OS target.".
Dec 14 2021, 11:23 AM · Restricted Project

Dec 13 2021

muiez committed rGb8c12af9dd76: [SystemZ][z/OS] Fix handling of dirs with filesystem tests (authored by muiez).
[SystemZ][z/OS] Fix handling of dirs with filesystem tests
Dec 13 2021, 8:02 AM
muiez closed D108326: [SystemZ][z/OS] Fix handling of dirs with filesystem tests.
Dec 13 2021, 8:02 AM · Restricted Project

Dec 3 2021

muiez updated the diff for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

Added comment

Dec 3 2021, 9:21 AM · Restricted Project
muiez added a comment to D108326: [SystemZ][z/OS] Fix handling of dirs with filesystem tests.

Ping

Dec 3 2021, 7:00 AM · Restricted Project

Dec 2 2021

muiez updated the diff for D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

Remove LIBCXXABI_BUILD_ZOS_ENCODING

Dec 2 2021, 10:18 AM · Restricted Project, Restricted Project

Nov 30 2021

muiez requested review of D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.
Nov 30 2021, 12:34 PM · Restricted Project, Restricted Project
muiez updated the diff for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

formalize LLVM_EXTERNAL_UNWIND_SOURCE_DIR definition in libcxxabi/CMakeLists.txt

Nov 30 2021, 12:24 PM · Restricted Project
muiez updated the diff for D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++.

Resolve merge conflict with main

Nov 30 2021, 11:00 AM · Restricted Project
muiez added a comment to D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++.

Thanks @ldionne for your detailed feedback and suggestions.

Nov 30 2021, 10:48 AM · Restricted Project

Nov 25 2021

muiez updated the diff for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

renamed zos cache file name

Nov 25 2021, 7:13 AM · Restricted Project

Nov 24 2021

muiez added inline comments to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
Nov 24 2021, 2:08 PM · Restricted Project
muiez updated the diff for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

definition of LLVM_EXTERNAL_UNWIND_SOURCE_DIR added

Nov 24 2021, 2:04 PM · Restricted Project
muiez updated the summary of D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
Nov 24 2021, 10:07 AM · Restricted Project
muiez added a comment to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

Ping, all comments addressed and green CI.

Nov 24 2021, 8:42 AM · Restricted Project

Nov 23 2021

muiez added a reviewer for D114377: [SystemZ][z/OS] Link library path in libc++ testing: bcraig.
Nov 23 2021, 12:23 PM · Restricted Project
muiez added reviewers for D114377: [SystemZ][z/OS] Link library path in libc++ testing: ldionne, Quuxplusone.
Nov 23 2021, 12:22 PM · Restricted Project

Nov 22 2021

muiez requested review of D114377: [SystemZ][z/OS] Link library path in libc++ testing.
Nov 22 2021, 9:33 AM · Restricted Project

Nov 18 2021

muiez committed rG27ea67136ea0: [SystemZ][z/OS] Fix filesystem testing (authored by muiez).
[SystemZ][z/OS] Fix filesystem testing
Nov 18 2021, 12:59 PM
muiez closed D113298: [SystemZ][z/OS] Fix filesystem testing.
Nov 18 2021, 12:59 PM · Restricted Project
muiez committed rG049f6c29a6f0: [libc++] Resolve missing table_size symbol (authored by muiez).
[libc++] Resolve missing table_size symbol
Nov 18 2021, 12:52 PM
muiez closed D110647: [libc++] Resolve missing table_size symbol.
Nov 18 2021, 12:52 PM · Restricted Project
muiez updated the diff for D113298: [SystemZ][z/OS] Fix filesystem testing.

better format

Nov 18 2021, 7:41 AM · Restricted Project
muiez updated the diff for D110647: [libc++] Resolve missing table_size symbol.

Verbose description, added correct symbol on abilist(s).

Nov 18 2021, 7:29 AM · Restricted Project

Nov 17 2021

muiez added a comment to D110647: [libc++] Resolve missing table_size symbol.

Any insight as to why the CI is red? It seems to complain about a new symbol being added _ZNSt3__15ctypeIcE10table_sizeE, which is defined. However, that is the intention since we want to resolve the missing symbol.

The CI is testing that there are no ABI changes. This patch contains an ABI change, since it adds a symbol. The change is not an ABI *break* so it is acceptable, but it is nonetheless a change. You need to update the ABI lists to contain that symbol.

You can see how to do that here: https://libcxx.llvm.org/Contributing.html#exporting-new-symbols-from-the-library. Basically, go to https://buildkite.com/llvm-project/libcxx-ci/builds/6180#75b25b94-130a-472d-a409-72a7f5507f17 and click on Artifacts. The libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist file will contain the new symbol for table_size -- add it to the corresponding file in libcxx/. You'll then need to do the same on macOS (look at the macOS ABI lists in the macOS jobs once the CI gets that far).

Finally, please also add an entry in libcxx/lib/abi/CHANGELOG.TXT.

Nov 17 2021, 7:21 AM · Restricted Project
muiez updated the diff for D110647: [libc++] Resolve missing table_size symbol.

Added symbol in abilists. More detail in test case.

Nov 17 2021, 7:17 AM · Restricted Project
muiez added a comment to D113298: [SystemZ][z/OS] Fix filesystem testing.

Ping :)

Nov 17 2021, 6:29 AM · Restricted Project
muiez added a comment to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

Ping @libc++abi

Nov 17 2021, 6:28 AM · Restricted Project

Nov 11 2021

muiez updated the diff for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

kickoff CI

Nov 11 2021, 9:11 AM · Restricted Project
muiez updated the diff for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
Nov 11 2021, 7:50 AM · Restricted Project

Nov 10 2021

muiez added a comment to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

Ping :)

Nov 10 2021, 11:03 AM · Restricted Project
muiez added a comment to D108326: [SystemZ][z/OS] Fix handling of dirs with filesystem tests.

Ping :)

Nov 10 2021, 10:59 AM · Restricted Project
muiez added a comment to D110647: [libc++] Resolve missing table_size symbol.

Any insight as to why the CI is red? It seems to complain about a new symbol being added _ZNSt3__15ctypeIcE10table_sizeE, which is defined. However, that is the intention since we want to resolve the missing symbol.

Nov 10 2021, 10:59 AM · Restricted Project

Nov 5 2021

muiez requested review of D113298: [SystemZ][z/OS] Fix filesystem testing.
Nov 5 2021, 10:40 AM · Restricted Project
muiez added a comment to D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++.

@ldionne, any thoughts on the approach and/or discussion so far? Your insight would be appreciated.

Nov 5 2021, 10:15 AM · Restricted Project

Nov 2 2021

muiez updated the diff for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

Use external unwind.h header.

Nov 2 2021, 1:32 PM · Restricted Project
muiez updated the diff for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
Nov 2 2021, 7:28 AM · Restricted Project
muiez removed a reviewer for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime: anirudhp.
Nov 2 2021, 7:06 AM · Restricted Project
muiez updated the diff for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

Removed whitespace

Nov 2 2021, 7:06 AM · Restricted Project
muiez updated the diff for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

Address comments. Use common API by getting LSDA from the unwinder using _Unwind_GetLanguageSpecificdata.

Nov 2 2021, 7:02 AM · Restricted Project
muiez commandeered D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
Nov 2 2021, 6:55 AM · Restricted Project
muiez added a comment to D110647: [libc++] Resolve missing table_size symbol.

Ping

Nov 2 2021, 6:52 AM · Restricted Project

Oct 26 2021

muiez added inline comments to D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++.
Oct 26 2021, 9:25 AM · Restricted Project
muiez updated the diff for D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++.

Update design doc to account for alternate solution to translate libcxx err messages based on char-mode.

Oct 26 2021, 9:23 AM · Restricted Project
muiez updated the diff for D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++.

Improved solution for error messages, eliminate #ifs.

Oct 26 2021, 8:49 AM · Restricted Project

Oct 25 2021

muiez updated the diff for D110647: [libc++] Resolve missing table_size symbol.

Clang-format

Oct 25 2021, 7:28 AM · Restricted Project

Oct 20 2021

muiez added a comment to D110647: [libc++] Resolve missing table_size symbol.

Any updates @ldionne? Comments have been addressed.

Oct 20 2021, 11:02 AM · Restricted Project
muiez committed rG6b82adbb4980: Raise compile error when using unimplemented functions (authored by muiez).
Raise compile error when using unimplemented functions
Oct 20 2021, 10:57 AM
muiez closed D111892: Raise compile error when using unimplemented functions.
Oct 20 2021, 10:56 AM · Restricted Project

Oct 19 2021

muiez updated the diff for D110647: [libc++] Resolve missing table_size symbol.

Using out-of-line definition instead of constexpr. This way is more consistent and allows the test case to pass for standards prior to c++17.

Oct 19 2021, 12:52 PM · Restricted Project
muiez updated the diff for D111892: Raise compile error when using unimplemented functions.

Commented out unimplemented functions.

Oct 19 2021, 11:28 AM · Restricted Project

Oct 18 2021

muiez retitled D111892: Raise compile error when using unimplemented functions from [SystemZ][z/OS] Raise assertion error when using unimplemented functions to Raise assertion error when using unimplemented functions.
Oct 18 2021, 7:11 AM · Restricted Project

Oct 15 2021

muiez added a comment to D111892: Raise compile error when using unimplemented functions.

Above my pay grade, but...

(1) Isn't a runtime error vastly less user-friendly than a link-time error? Perhaps you could show an example of the kind of program that would run into this linker error and/or assertion?
(2) Is a plain assert really more appropriate than either _LIBCPP_ASSERT or throw? (I think _LIBCPP_ASSERT would be less appropriate because it compiles away in non-debug modes; but then, so does regular assert in NDEBUG mode.)
(3) Alternatively, how about either just commenting-out, or =delete'ing, these functions, to turn the linker error into a compile-time (and SFINAE'able) ill-formedness?

Oct 15 2021, 1:09 PM · Restricted Project
muiez updated the diff for D111892: Raise compile error when using unimplemented functions.

Cause compile time error instead.

Oct 15 2021, 1:08 PM · Restricted Project
muiez requested review of D111892: Raise compile error when using unimplemented functions.
Oct 15 2021, 8:58 AM · Restricted Project

Oct 13 2021

muiez added inline comments to D110647: [libc++] Resolve missing table_size symbol.
Oct 13 2021, 12:47 PM · Restricted Project
muiez added a comment to D110647: [libc++] Resolve missing table_size symbol.

ping

Oct 13 2021, 12:13 PM · Restricted Project