Ping @libcxx

Ping :)

In D134216#3891898, @ldionne wrote:

I am extremely concerned by the need to introduce these sorts of arcane implementation details in the library for z/OS, especially since we don't have a clear idea of where these patches are going to stop.

libc++ is not a "low level system library". It's a library layered on top of C libraries and other standard (or mostly standard) APIs like POSIX and others. It's fine to have some amount of low level and platform specific stuff, but we're not going to implement from scratch APIs that should be provided by any decent OS.

Refactor

Move z/OS hardware_concurrency implementation to support/ibm directory.

Abort with message instead of silently returning 0.

Include path for unwinder headers.

Ping @libcxx @ldionne

Add script description, use cache file.

@libc++ @ldionne Any review comments? This patch is the first step for setting up the C/I for z/OS.

Ping :) @ldionne @libcxx

Ping :) @ldionne

@libc++ may I get a review please?

@ldionne May I get a review please? Thanks

In D132946#3758769, @Mordante wrote:

LGTM! Does this need to be backported to the LLVM-15 release branch?

Rebase

Ping, can I get a review? @libcxx

@libc++ The CI is green, can I get a review please? Thanks

Rebase with latest main.

kickoff CI

Address comments.

The motivation of this patch is to incrementally integrate a libc++ CI for z/OS.

Will use custom config file instead.

The CI is failing with the following warning (shown as an error):

Ping :) @ldionne @libcxxabi

kickoff CI

Fix warning

Ping :) @ldionne

Correct conflict resolution

kickoff CI

Fix merge conflict.

Add diff context (-U999)

Removed logic for using an external unwinder. The following patch will add support for building/linking an external unwinder in a non-ad hoc way: https://reviews.llvm.org/D128348.

Ping :) @libcxx @libcxxabi

Refactor with macros

improve include's

Resolve merge conflicts

kickoff CI

resolve lit failure

@libc++abi Can I get a review please? Thanks

@libc++ Can I get a review please? Thanks

LGTM

LGTM

Closing since this patch is divided into the following (with comments addressed and better approach):

• Foundational A/E changes: https://reviews.llvm.org/D114813
• Localize runtime error messages: https://reviews.llvm.org/D118179
• Add ASCII/32bit variant: https://reviews.llvm.org/D118503
• Exception derived classes as a separate library for z/OS: https://reviews.llvm.org/D118620

LGTM

Ping :)

Ping :)

addressed comment to be more readable

Great points! Updated to account for this.

safeguard to z/OS, use double underscore function names

Using inline functions instead of macros

ping @libc++ @libc++ab

Add default encoding

Remove LIBCXX_BUILD_ZOS_ENCODING

Ping

LGTM

In D114457#3192772, @shraiysh wrote:

Hey folks, it looks like this commit has caused the buildbot here to run into failures. Can someone please revert this change, fix it and then commit it again?