User Details
- User Since
- Oct 27 2020, 8:30 AM (82 w, 3 d)
Mar 17 2022
Ping :) @libcxx @libcxxabi
Mar 2 2022
Mar 1 2022
Refactor with macros
Feb 23 2022
improve include's
Feb 22 2022
Resolve merge conflicts
Feb 15 2022
kickoff CI
Feb 14 2022
resolve lit failure
Feb 10 2022
@libc++abi Can I get a review please? Thanks
@libc++ Can I get a review please? Thanks
Feb 4 2022
LGTM
LGTM
Feb 3 2022
Closing since this patch is divided into the following (with comments addressed and better approach):
- Foundational A/E changes: https://reviews.llvm.org/D114813
- Localize runtime error messages: https://reviews.llvm.org/D118179
- Add ASCII/32bit variant: https://reviews.llvm.org/D118503
- Exception derived classes as a separate library for z/OS: https://reviews.llvm.org/D118620
LGTM
Feb 2 2022
Ping :)
Jan 28 2022
Jan 25 2022
Jan 24 2022
Jan 21 2022
Jan 20 2022
Ping :)
Jan 14 2022
addressed comment to be more readable
Great points! Updated to account for this.
safeguard to z/OS, use double underscore function names
Jan 13 2022
Using inline functions instead of macros
Jan 11 2022
ping @libc++ @libc++ab
Jan 4 2022
Dec 29 2021
Add default encoding
Dec 24 2021
Remove LIBCXX_BUILD_ZOS_ENCODING
Dec 23 2021
Ping
LGTM
Dec 14 2021
Dec 13 2021
Dec 3 2021
Added comment
Ping
Dec 2 2021
Remove LIBCXXABI_BUILD_ZOS_ENCODING
Nov 30 2021
formalize LLVM_EXTERNAL_UNWIND_SOURCE_DIR definition in libcxxabi/CMakeLists.txt
Resolve merge conflict with main
Thanks @ldionne for your detailed feedback and suggestions.
Nov 25 2021
renamed zos cache file name
Nov 24 2021
definition of LLVM_EXTERNAL_UNWIND_SOURCE_DIR added
Ping, all comments addressed and green CI.
Nov 23 2021
Nov 22 2021
Nov 18 2021
better format
Verbose description, added correct symbol on abilist(s).
Nov 17 2021
Added symbol in abilists. More detail in test case.
Ping :)
Ping @libc++abi
Nov 11 2021
kickoff CI
Nov 10 2021
Ping :)
Ping :)
Any insight as to why the CI is red? It seems to complain about a new symbol being added _ZNSt3__15ctypeIcE10table_sizeE, which is defined. However, that is the intention since we want to resolve the missing symbol.
Nov 5 2021
@ldionne, any thoughts on the approach and/or discussion so far? Your insight would be appreciated.
Nov 2 2021
Use external unwind.h header.
Removed whitespace
Address comments. Use common API by getting LSDA from the unwinder using _Unwind_GetLanguageSpecificdata.
Ping
Oct 26 2021
Update design doc to account for alternate solution to translate libcxx err messages based on char-mode.
Improved solution for error messages, eliminate #ifs.
Oct 25 2021
Clang-format
Oct 20 2021
Any updates @ldionne? Comments have been addressed.
Oct 19 2021
Using out-of-line definition instead of constexpr. This way is more consistent and allows the test case to pass for standards prior to c++17.
Commented out unimplemented functions.
Oct 18 2021
Oct 15 2021
Cause compile time error instead.
Oct 13 2021
ping