Page MenuHomePhabricator

abhina.sreeskantharajan (Abhina Sree)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2020, 9:23 AM (118 w, 6 d)

Recent Activity

Apr 13 2022

abhina.sreeskantharajan added inline comments to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.
Apr 13 2022, 9:50 AM · Restricted Project, Restricted Project

Apr 11 2022

abhina.sreeskantharajan accepted D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

this LGTM from a systemz perspective! thanks for refactoring

Apr 11 2022, 10:31 AM · Restricted Project, Restricted Project

Mar 15 2022

abhina.sreeskantharajan added a comment to D121331: Cleanup include: TableGen.

Thanks for the quick fix! There is another place where a similar situation happened. This header #include "llvm/Support/BCD.h" is being used in llvm/lib/Support/Host.cpp as well.

Mar 15 2022, 4:15 PM · Restricted Project, Restricted Project

Mar 14 2022

abhina.sreeskantharajan abandoned D121628: Only run this test for x86 registed targets..
Mar 14 2022, 11:41 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan updated the summary of D121628: Only run this test for x86 registed targets..
Mar 14 2022, 11:12 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan requested review of D121628: Only run this test for x86 registed targets..
Mar 14 2022, 11:09 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan added a comment to D121331: Cleanup include: TableGen.

Hello, there is a usage of the needConversion function in MemoryBuffer.cpp which requires the following header #include "llvm/Support/AutoConvert.h" for z/OS. Can this header be added back to MemoryBuffer.cpp? I think it's usage was missed because it is guarded for z/OS only.

Mar 14 2022, 6:08 AM · Restricted Project, Restricted Project

Feb 17 2022

abhina.sreeskantharajan added reviewers for D119966: [SystemZ][z/OS] Add OPEN_THREAD version of pthread function call: muiez, fanbo-meng, ldionne, Mordante.
Feb 17 2022, 4:30 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D119966: [SystemZ][z/OS] Add OPEN_THREAD version of pthread function call.

formatting

Feb 17 2022, 4:25 AM · Restricted Project

Feb 16 2022

abhina.sreeskantharajan retitled D119966: [SystemZ][z/OS] Add OPEN_THREAD version of pthread function call from formatting to [SystemZ][z/OS] Add OPEN_THREAD version of pthread function call.
Feb 16 2022, 12:09 PM · Restricted Project
abhina.sreeskantharajan updated the diff for D119966: [SystemZ][z/OS] Add OPEN_THREAD version of pthread function call.

fix patch

Feb 16 2022, 12:09 PM · Restricted Project
abhina.sreeskantharajan requested review of D119966: [SystemZ][z/OS] Add OPEN_THREAD version of pthread function call.
Feb 16 2022, 12:07 PM · Restricted Project

Feb 11 2022

abhina.sreeskantharajan added a project to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header : Restricted Project.
Feb 11 2022, 6:25 AM · Restricted Project

Feb 4 2022

abhina.sreeskantharajan accepted D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

LGTM

Feb 4 2022, 7:21 AM · Restricted Project

Feb 3 2022

abhina.sreeskantharajan added inline comments to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .
Feb 3 2022, 12:59 PM · Restricted Project
abhina.sreeskantharajan accepted D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

LGTM, but I think you need a libc++ group reviewer approval

Feb 3 2022, 12:55 PM · Restricted Project, Restricted Project

Feb 1 2022

abhina.sreeskantharajan accepted D118723: [SystemZ][z/OS]: Manually create lit tmp_dir.

LGTM

Feb 1 2022, 12:38 PM · Restricted Project

Jan 26 2022

abhina.sreeskantharajan committed rG360af60e1728: [SystemZ][z/OS] Add AutoConvert.h header to MemoryBuffer.cpp (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Add AutoConvert.h header to MemoryBuffer.cpp
Jan 26 2022, 6:02 AM
abhina.sreeskantharajan closed D118129: [SystemZ][z/OS] Add AutoConvert.h header to MemoryBuffer.cpp.
Jan 26 2022, 6:02 AM · Restricted Project

Jan 25 2022

abhina.sreeskantharajan requested review of D118129: [SystemZ][z/OS] Add AutoConvert.h header to MemoryBuffer.cpp.
Jan 25 2022, 5:05 AM · Restricted Project

Jan 5 2022

abhina.sreeskantharajan accepted D116603: [AIX][z/OS][Support] Provide no-op mapped_file_region::dontNeedImpl implementation.

LGTM with minor formatting comment

Jan 5 2022, 6:42 AM · Restricted Project

Oct 21 2021

abhina.sreeskantharajan accepted D112172: [SystemZ][z/OS] Additional test coverage for validating dialect instructions for SystemZ.

LGTM

Oct 21 2021, 4:51 AM · Restricted Project

Oct 13 2021

abhina.sreeskantharajan accepted D111226: [SystemZ][z/OS][libcxx]:Fix fopen64 undeclared error in 32 bit mode.

LGTM, but I think you need a group reviewer approval

Oct 13 2021, 6:08 AM · Restricted Project

Oct 8 2021

abhina.sreeskantharajan committed rG7d7b139042e8: [test] Use host platform specific error message substitution (authored by abhina.sreeskantharajan).
[test] Use host platform specific error message substitution
Oct 8 2021, 10:53 AM
abhina.sreeskantharajan closed D111320: [test] Use host platform specific error message substitution.
Oct 8 2021, 10:52 AM · Restricted Project
abhina.sreeskantharajan accepted D111427: [AIX] Ignore case when comparing output from od.

LGTM

Oct 8 2021, 10:07 AM · Restricted Project

Oct 7 2021

abhina.sreeskantharajan added reviewers for D111320: [test] Use host platform specific error message substitution: fanbo-meng, muiez, anirudhp.
Oct 7 2021, 10:22 AM · Restricted Project
abhina.sreeskantharajan requested review of D111320: [test] Use host platform specific error message substitution.
Oct 7 2021, 8:42 AM · Restricted Project

Sep 24 2021

abhina.sreeskantharajan accepted D110077: [SystemZ][z/OS] Introduce the GOFFMCAsmInfo Interface for z/OS.

LGTM

Sep 24 2021, 11:58 AM · Restricted Project

Sep 7 2021

abhina.sreeskantharajan accepted D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout.

LGTM

Sep 7 2021, 9:55 AM · Restricted Project, Restricted Project

Aug 31 2021

abhina.sreeskantharajan accepted D108998: [SystemZ][z/OS] Create html report file with text flag.

LGTM

Aug 31 2021, 8:00 AM · Restricted Project

Aug 27 2021

abhina.sreeskantharajan accepted D108819: [MCParser][z/OS] Mark test as unsupported for the z/OS Target.

LGTM

Aug 27 2021, 7:38 AM · Restricted Project

Aug 5 2021

abhina.sreeskantharajan accepted D107565: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test".

LGTM

Aug 5 2021, 6:39 AM · Restricted Project

Jul 30 2021

abhina.sreeskantharajan accepted D107189: [z/OS]Remove overriding default attribute aligned value.

LGTM

Jul 30 2021, 12:39 PM · Restricted Project

Jul 27 2021

abhina.sreeskantharajan accepted D106890: [z/OS] Make MinGlobalAlign consistent with SystemZ.

LGTM

Jul 27 2021, 10:01 AM · Restricted Project

Jul 14 2021

abhina.sreeskantharajan accepted D105993: [SystemZ][z/OS] Add GOFF support to file magic identification.

LGTM

Jul 14 2021, 1:05 PM · Restricted Project

Jun 30 2021

abhina.sreeskantharajan accepted D105204: [MCParser][z/OS] Mark a few tests as unsupported for the z/OS Target.

LGTM

Jun 30 2021, 10:22 AM · Restricted Project

Jun 22 2021

abhina.sreeskantharajan accepted D104715: [AsmParser][SystemZ][z/OS] Support for emitting labels in upper case.

LGTM

Jun 22 2021, 10:03 AM · Restricted Project

Jun 21 2021

abhina.sreeskantharajan accepted D104544: [libc++] Remove unused variable.

you still need a group reviewer to approve, but this LGTM

Jun 21 2021, 6:52 AM · Restricted Project

Jun 8 2021

abhina.sreeskantharajan committed rG0e8506debae3: [SystemZ][z/OS] Pass OpenFlags when creating tmp files (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Pass OpenFlags when creating tmp files
Jun 8 2021, 11:46 AM
abhina.sreeskantharajan closed D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files.
Jun 8 2021, 11:45 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan committed rGee2a92c29df6: [libcxx] Remove VLA from libcxx locale header (authored by DanielMcIntosh-IBM).
[libcxx] Remove VLA from libcxx locale header
Jun 8 2021, 11:00 AM
abhina.sreeskantharajan closed D103558: [libcxx] Remove VLA from libcxx locale header.
Jun 8 2021, 10:59 AM · Restricted Project

Jun 7 2021

abhina.sreeskantharajan updated the diff for D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files.

Address rnk's comments and rename to ExtraFlags

Jun 7 2021, 12:35 PM · Restricted Project, Restricted Project
abhina.sreeskantharajan added inline comments to D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files.
Jun 7 2021, 10:05 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan added reviewers for D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files: dexonsmith, rnk, amccarth, akhuang, Kai, muiez, zibi.
Jun 7 2021, 7:08 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan committed rG7e176ff2db93: [test] Use host platform specific error message substitution (authored by abhina.sreeskantharajan).
[test] Use host platform specific error message substitution
Jun 7 2021, 7:07 AM
abhina.sreeskantharajan closed D103804: [test] Use host platform specific error message substitution.
Jun 7 2021, 7:06 AM · Restricted Project
abhina.sreeskantharajan requested review of D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files.
Jun 7 2021, 6:03 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan updated the diff for D103804: [test] Use host platform specific error message substitution.

Fixed line endings

Jun 7 2021, 5:47 AM · Restricted Project
abhina.sreeskantharajan requested review of D103804: [test] Use host platform specific error message substitution.
Jun 7 2021, 5:38 AM · Restricted Project

Jun 2 2021

abhina.sreeskantharajan committed rG06e047227d71: [libcxx][NFC] Tidy up calculation of __nbuf in num_put::do_put, and add comments (authored by DanielMcIntosh-IBM).
[libcxx][NFC] Tidy up calculation of __nbuf in num_put::do_put, and add comments
Jun 2 2021, 8:46 AM
abhina.sreeskantharajan closed D103339: [libcxx][NFC] Tidy up calculation of __nbuf in num_put::do_put, and add comments.
Jun 2 2021, 8:46 AM · Restricted Project

May 28 2021

abhina.sreeskantharajan added a comment to D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder.

.ll -> .s tests should be placed in llvm/test/CodeGen/SystemZ, not in clang

May 28 2021, 5:31 AM · Restricted Project

May 12 2021

abhina.sreeskantharajan committed rGcbed6e5b2ff0: [SystemZ][z/OS] Fix warning caused by umask returning a signed integer type (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Fix warning caused by umask returning a signed integer type
May 12 2021, 9:26 AM
abhina.sreeskantharajan closed D102326: [SystemZ][z/OS] Fix warning caused by umask returning a signed integer type.
May 12 2021, 9:26 AM · Restricted Project
abhina.sreeskantharajan added reviewers for D102326: [SystemZ][z/OS] Fix warning caused by umask returning a signed integer type: myiwanch, muiez.
May 12 2021, 7:58 AM · Restricted Project
abhina.sreeskantharajan requested review of D102326: [SystemZ][z/OS] Fix warning caused by umask returning a signed integer type.
May 12 2021, 7:00 AM · Restricted Project

May 5 2021

abhina.sreeskantharajan committed rG6a12875046fd: [SystemZ][z/OS] Fix return values in AutoConversion functions (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Fix return values in AutoConversion functions
May 5 2021, 6:43 AM
abhina.sreeskantharajan closed D101904: [SystemZ][z/OS] Fix return values in AutoConversion functions.
May 5 2021, 6:43 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
May 5 2021, 6:31 AM · Restricted Project
abhina.sreeskantharajan added reviewers for D101904: [SystemZ][z/OS] Fix return values in AutoConversion functions: fanbo-meng, anirudhp, Jonathan.Crowther, muiez.
May 5 2021, 6:03 AM · Restricted Project
abhina.sreeskantharajan requested review of D101904: [SystemZ][z/OS] Fix return values in AutoConversion functions.
May 5 2021, 6:02 AM · Restricted Project

May 3 2021

abhina.sreeskantharajan accepted D101660: [AsmParser][SystemZ][z/OS] Reject character and string literals for HLASM.

LGTM

May 3 2021, 7:37 AM · Restricted Project
abhina.sreeskantharajan committed rG1527a5e4b483: [SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O
May 3 2021, 5:53 AM
abhina.sreeskantharajan closed D100483: [SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O.
May 3 2021, 5:52 AM · Restricted Project

Apr 29 2021

abhina.sreeskantharajan added inline comments to D100872: Use OpenFlags instead of boolean to set a file as text/binary.
Apr 29 2021, 4:40 AM · Restricted Project

Apr 27 2021

abhina.sreeskantharajan added a comment to D100872: Use OpenFlags instead of boolean to set a file as text/binary.

ping :)

Apr 27 2021, 11:09 AM · Restricted Project
abhina.sreeskantharajan added a comment to D100483: [SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O.

Hi Sean @SeanP, are there any more comments on this patch?

Apr 27 2021, 6:37 AM · Restricted Project
abhina.sreeskantharajan accepted D101308: [SystemZ][z/OS] Remove register prefixes when printing out the register..

LGTM

Apr 27 2021, 5:44 AM · Restricted Project

Apr 26 2021

abhina.sreeskantharajan accepted D100959: [AsmParser][SystemZ][z/OS] Use updated framework in AsmLexer to accept special tokens as Identifiers.

Thanks for adding tests. LGTM

Apr 26 2021, 10:44 AM · Restricted Project

Apr 23 2021

abhina.sreeskantharajan accepted D100975: [AsmParser][SystemZ][z/OS] Reject "Dot" as current PC on z/OS.

LGTM

Apr 23 2021, 6:17 AM · Restricted Project

Apr 22 2021

abhina.sreeskantharajan added a reviewer for D100872: Use OpenFlags instead of boolean to set a file as text/binary: dexonsmith.
Apr 22 2021, 7:00 AM · Restricted Project
abhina.sreeskantharajan added reviewers for D93031: Enable fexec-charset option : cor3ntin, joerg.
Apr 22 2021, 6:32 AM · Restricted Project, Restricted Project, Restricted Project
abhina.sreeskantharajan added a comment to D93031: Enable fexec-charset option .

We should use the original source form of the string literal when pretty-printing a StringLiteral or CharacterLiteral; there are a bunch of UTF-8 assumptions baked into StmtPrinter that will need revisiting. And we'll need to modify the handful of places that put the contents of StringLiterals into diagnostics (#warning, #error, static_assert) and make them use a different ConversionState, since our assumption is that diagnostic output should be in UTF-8.

Yes, these are some of the complications we will need to visit in later patches. We may need to somehow save the original string or reverse the translation.

The operation is destructive and therefore cannot be reverted.
So I do believe the correct behavior here would indeed be to keep the original spelling around - with *some* of phase 5 applied (replacement of UCNs and replacement of numeric escape sequences).
An alternative would be to do the conversion lazily when the strings are evaluated, rather than during lexing, although that might be more involved

Apr 22 2021, 6:32 AM · Restricted Project, Restricted Project, Restricted Project
abhina.sreeskantharajan updated the diff for D100483: [SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O.

Remove unnecessary include

Apr 22 2021, 5:59 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D100483: [SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O.
Apr 22 2021, 5:44 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D100483: [SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O.

Changes in this new diff:

  • changed 819,1047 to full names in encoding.ll
  • use #ifdef MVS for consistency
Apr 22 2021, 5:43 AM · Restricted Project
abhina.sreeskantharajan accepted D100992: Fix the triple used in llvm-mca.

LGTM

Apr 22 2021, 4:12 AM · Restricted Project

Apr 21 2021

abhina.sreeskantharajan updated the diff for D93031: Enable fexec-charset option .

Thanks for catching that. This sets the clang_literal_encoding to Opts.ExecCharset or defaults to SystemCharset.

Apr 21 2021, 12:50 PM · Restricted Project, Restricted Project, Restricted Project
abhina.sreeskantharajan added a comment to D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1.

Is it possible to add partial unit tests like you did in your previous patches?

Apr 21 2021, 10:24 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D100872: Use OpenFlags instead of boolean to set a file as text/binary.
Apr 21 2021, 5:26 AM · Restricted Project

Apr 20 2021

abhina.sreeskantharajan updated the summary of D100872: Use OpenFlags instead of boolean to set a file as text/binary.
Apr 20 2021, 12:44 PM · Restricted Project
abhina.sreeskantharajan added reviewers for D100872: Use OpenFlags instead of boolean to set a file as text/binary: rnk, aganea, amccarth, Jonathan.Crowther, anirudhp.
Apr 20 2021, 12:43 PM · Restricted Project
abhina.sreeskantharajan updated the diff for D100483: [SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O.

rebase + removing call to enableAutoConversion in getSTDIN anymore because changeStdinToBinary is no longer called because we are passing the OF_Text flag now

Apr 20 2021, 11:43 AM · Restricted Project
abhina.sreeskantharajan requested review of D100872: Use OpenFlags instead of boolean to set a file as text/binary.
Apr 20 2021, 10:45 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D100483: [SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O.

Address comments, fix bug in lit test

Apr 20 2021, 10:06 AM · Restricted Project

Apr 19 2021

abhina.sreeskantharajan updated the diff for D93031: Enable fexec-charset option .

Rebase + set size of char as 1 when creating a StringRef to fix lit failure

Apr 19 2021, 11:12 AM · Restricted Project, Restricted Project, Restricted Project
abhina.sreeskantharajan committed rG05b4babc9d85: [SystemZ][z/OS] Set more text files as text (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Set more text files as text
Apr 19 2021, 6:32 AM
abhina.sreeskantharajan closed D100654: [SystemZ][z/OS] Set more text files as text.
Apr 19 2021, 6:31 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan committed rGfbc325934661: [SystemZ][z/OS] Set files in FileRemapper.cpp are text (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Set files in FileRemapper.cpp are text
Apr 19 2021, 5:00 AM
abhina.sreeskantharajan closed D100056: [SystemZ][z/OS] Set files in FileRemapper.cpp are text.
Apr 19 2021, 5:00 AM · Restricted Project

Apr 16 2021

abhina.sreeskantharajan added reviewers for D100654: [SystemZ][z/OS] Set more text files as text: Jonathan.Crowther, anirudhp, zibi, rnk, amccarth, muiez.
Apr 16 2021, 12:07 PM · Restricted Project, Restricted Project
abhina.sreeskantharajan updated the diff for D100056: [SystemZ][z/OS] Set files in FileRemapper.cpp are text.

fix formatting

Apr 16 2021, 11:54 AM · Restricted Project
abhina.sreeskantharajan requested review of D100654: [SystemZ][z/OS] Set more text files as text.
Apr 16 2021, 8:33 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan committed rGe71994a239d5: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN (authored by Jonathan.Crowther).
[SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN
Apr 16 2021, 7:09 AM
abhina.sreeskantharajan closed D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN.
Apr 16 2021, 7:08 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan added a comment to D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN.

Personally, I'm not a fan of boolean function parameters because of the inline comments necessary to make the call site understandable. But it appears to be consistent with LLVM Coding Standards and other APIs, so this looks right to me.

I think it would be a reasonable follow-up change to turn these optional boolean parameters into a flags enum.

Apr 16 2021, 6:14 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan added reviewers for D100056: [SystemZ][z/OS] Set files in FileRemapper.cpp are text: amccarth, rnk, anirudhp, Jonathan.Crowther.
Apr 16 2021, 5:10 AM · Restricted Project
abhina.sreeskantharajan committed rG3be2ba0ba38a: [SystemZ][z/OS][Windows] Add new functions that set Text/Binary mode for Stdin… (authored by abhina.sreeskantharajan).
[SystemZ][z/OS][Windows] Add new functions that set Text/Binary mode for Stdin…
Apr 16 2021, 5:09 AM