- User Since
- Feb 15 2020, 9:23 AM (60 w, 1 d)
Fri, Apr 9
Accidentally added dependent patch in this one. Removing that
Rebase + fix CharLiteralParser endian issue by saving the char to a char variable first and then creating a StringRef
Add return value
Thu, Apr 8
Wed, Apr 7
Changes LGTM. You will need to update the title and description to reflect the new approach you took to allow additional comment strings, rather than disable them.
Tue, Apr 6
LGTM, thanks for adding a testcase!
Mon, Apr 5
Is there any more feedback on this patch?
Sat, Apr 3
Fri, Apr 2
Updated comments and assertion
Thu, Apr 1
Update comment in FileSystem.h for OF_TextWithCRLF
@MaskRay is there still any confusion about the problem this patch is trying to solve and concerns about the renaming?
Tue, Mar 30
Specified z/OS in FileSystem.h comments, added an assertion in Window's Path.inc
Set OF_Text for llvm/tools/dsymutil/DwarfLinkerForBinary.cpp instead of OF_TextWithCRLF. This was also another file I recently changed to text from binary.
Mon, Mar 29
mention OF_CRLF is Windows-only
Rebase + I updated the comments in FileSystem.h to be a bit more descriptive.
LGTM, have a small nit
I got some very minor nits about formatting, but overall it looks good
There is one failing mlir unit tests which I suspect might be caused by this patch and should be fixed.
Sat, Mar 27
Fri, Mar 26
Thu, Mar 25
Revert changes that cause errors instead by turning on binary mode again
I created a patch to reorder the args, sorry for missing this case! https://reviews.llvm.org/D99349
I have a two nits, but overall LGTM, your patch may need to be rebased because CI is failing
Rebase and fix formatting.
Wed, Mar 24
I've removed FileSize from getFileAux and WritableMemoryBuffer::getFile as well.
Tue, Mar 23
After going through all the function usages, I realized FileSize is not used anywhere. I can remove this parameter.
Move FileSize to the end because it is never used.
Mon, Mar 22
The new changes LGTM
Fri, Mar 19