abhina.sreeskantharajan (Abhina Sree)
User

Projects

User does not belong to any projects.

User Details

User Since: Feb 15 2020, 9:23 AM (162 w, 3 d)

Recent Activity
View All

Yesterday

abhina.sreeskantharajan added reviewers for D146851: [support] Revise ScopedPrinter formatting tests for floats: hubert.reinterpretcast, daltenty.

I've added reviewers that are more familiar with AIX

Mon, Mar 27, 6:06 AM · Restricted Project, Restricted Project

Fri, Mar 24

abhina.sreeskantharajan added inline comments to D146834: [support] Temporarily disable Inf/NaN testing in PrintNumber.

Fri, Mar 24, 11:30 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan accepted D146834: [support] Temporarily disable Inf/NaN testing in PrintNumber.

LGTM

Fri, Mar 24, 11:29 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan added a comment to D146834: [support] Temporarily disable Inf/NaN testing in PrintNumber.

Would it be better to remove the lines and just leave the FIXME comments? I don't know if leaving commented out code is good style, but please correct me if I'm wrong and this is done elsewhere

Fri, Mar 24, 11:12 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan accepted D146818: [support] Attempt to fix PrintNumber test for Solaris.

LGTM

Fri, Mar 24, 9:32 AM · Restricted Project, Restricted Project

Thu, Mar 23

abhina.sreeskantharajan accepted D146739: [support] Fix PrintNumber Test on AIX.

LGTM

Thu, Mar 23, 10:26 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan added a comment to D146542: [llvm][support] Fix ScopedPrinterTest on AIX.

In D146542#4216973, @paulkirth wrote:

Ugh, I see this issue. I missed that the "INF/inf" discrepancy also happens for JSON output, but only changed the non-JSON test string. I should have a forward fix very soon. If that causes issues, we'll either need to revert the original patch, the 2 fixes and the HasHistogram patch, or disable the test for float/double,until we sort it out.

If you really need the bot to progress, I'm fine w/ you reverting things, though.

Thu, Mar 23, 10:25 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan added a comment to D146542: [llvm][support] Fix ScopedPrinterTest on AIX.

Hi @paulkirth, this testcase is still failing the same way on the AIX bot even after this change https://lab.llvm.org/buildbot/#/builders/214/builds/6557. Can this change be reverted until we figure out the proper fix?

Thu, Mar 23, 8:32 AM · Restricted Project, Restricted Project

Tue, Mar 21

abhina.sreeskantharajan accepted D146542: [llvm][support] Fix ScopedPrinterTest on AIX.

LGTM, thanks for the quick fix!

Tue, Mar 21, 9:48 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan added a comment to D145277: [support] Support printing floats in ScopedPrinter.

Hi, I think this patch is causing a failure on the clang-ppc64-aix bot here https://lab.llvm.org/buildbot/#/builders/214/builds/6531/steps/6/logs/FAIL__LLVM-Unit__83 . Would you be able to take a look?

Tue, Mar 21, 7:49 AM · Restricted Project, Restricted Project

Mon, Mar 20

abhina.sreeskantharajan added a comment to D142084: [RFC][X86][MemFold] Upgrade the mechanism of auto-generated Memory Folding Table.

Hi, this is also causing a failure on the clang-ppc64-aix bot https://lab.llvm.org/buildbot/#/builders/214/builds/6519

Mon, Mar 20, 10:20 AM · Restricted Project, Restricted Project

Thu, Mar 2

abhina.sreeskantharajan accepted D145158: Make clang/test/C/C2x/n2934.c compatible with targets that do not support thread_local storage..

LGTM

Thu, Mar 2, 6:40 AM · Restricted Project, Restricted Project

Feb 22 2023

abhina.sreeskantharajan accepted D144573: [z/OS][NFC] Remove obsolete code..

LGTM

Feb 22 2023, 10:21 AM · Restricted Project, Restricted Project

Feb 13 2023

abhina.sreeskantharajan accepted D143916: [runtimes] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default to ON for OS390.

LGTM

Feb 13 2023, 8:10 AM · Restricted Project, Restricted Project

Nov 18 2022

abhina.sreeskantharajan committed rG625f08da730f: [SystemZ][z/OS] Set text flag correctly for llvm-reduce tool (authored by abhina.sreeskantharajan).

[SystemZ][z/OS] Set text flag correctly for llvm-reduce tool

Nov 18 2022, 10:39 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan closed D138304: [SystemZ][z/OS] Set text flag correctly for llvm-reduce tool.

Nov 18 2022, 10:39 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan added a reviewer for D138304: [SystemZ][z/OS] Set text flag correctly for llvm-reduce tool: arsenm.

Nov 18 2022, 10:17 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan added reviewers for D138304: [SystemZ][z/OS] Set text flag correctly for llvm-reduce tool: fanbo-meng, Kai, muiez, zibi, yusra.syeda.

Nov 18 2022, 9:57 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan requested review of D138304: [SystemZ][z/OS] Set text flag correctly for llvm-reduce tool.

Nov 18 2022, 8:18 AM · Restricted Project, Restricted Project

Sep 16 2022

abhina.sreeskantharajan committed rGce193431141d: [test] Use host platform specific error message substitution (authored by abhina.sreeskantharajan).

[test] Use host platform specific error message substitution

Sep 16 2022, 12:14 PM · Restricted Project, Restricted Project, Restricted Project

abhina.sreeskantharajan closed D134034: [test] Use host platform specific error message substitution.

Sep 16 2022, 12:14 PM · Restricted Project, Restricted Project, Restricted Project

abhina.sreeskantharajan updated the diff for D134034: [test] Use host platform specific error message substitution.

Move subsitution outside regex

Sep 16 2022, 11:20 AM · Restricted Project, Restricted Project, Restricted Project

abhina.sreeskantharajan updated the diff for D134034: [test] Use host platform specific error message substitution.

Add some more tests

Sep 16 2022, 7:51 AM · Restricted Project, Restricted Project, Restricted Project

abhina.sreeskantharajan edited reviewers for D134034: [test] Use host platform specific error message substitution, added: Everybody0523; removed: • neumannh.

Sep 16 2022, 7:41 AM · Restricted Project, Restricted Project, Restricted Project

abhina.sreeskantharajan added reviewers for D134034: [test] Use host platform specific error message substitution: steven.zhang, fanbo-meng, muiez, Kai, zibi, • neumannh.

Sep 16 2022, 7:41 AM · Restricted Project, Restricted Project, Restricted Project

abhina.sreeskantharajan updated the diff for D134034: [test] Use host platform specific error message substitution.

Forgot to add DMSG to one more line

Sep 16 2022, 7:38 AM · Restricted Project, Restricted Project, Restricted Project

abhina.sreeskantharajan retitled D134034: [test] Use host platform specific error message substitution from This patch modifies the testcase to use error substitution so it will pass on all platforms. to [test] Use host platform specific error message substitution.

Sep 16 2022, 6:22 AM · Restricted Project, Restricted Project, Restricted Project

abhina.sreeskantharajan requested review of D134034: [test] Use host platform specific error message substitution.

Sep 16 2022, 6:15 AM · Restricted Project, Restricted Project, Restricted Project

Sep 13 2022

abhina.sreeskantharajan added a comment to D133003: [ELF] Parallelize relocation scanning.

On z/OS this would also break the build because there is no support for TLS. To workaround this we have disabled LLVM_ENABLE_THREADS here https://github.com/llvm/llvm-project/blob/main/llvm/CMakeLists.txt#L478 . Would we be able to move the declaration inside #if LLVM_ENABLE_THREADS? Thanks in advance

Sep 13 2022, 6:38 AM · Restricted Project, Restricted Project

Jul 25 2022

abhina.sreeskantharajan committed rG6e99771a3157: [SystemZ][z/OS] Open YAML text files as text (authored by abhina.sreeskantharajan).

[SystemZ][z/OS] Open YAML text files as text

Jul 25 2022, 5:07 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan closed D130354: [SystemZ][z/OS] Open YAML text files as text.

Jul 25 2022, 5:07 AM · Restricted Project, Restricted Project

Jul 22 2022

abhina.sreeskantharajan retitled D130354: [SystemZ][z/OS] Open YAML text files as text from [SystemZ][z/OS] Open text files as text to [SystemZ][z/OS] Open YAML text files as text.

Jul 22 2022, 6:25 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan requested review of D130354: [SystemZ][z/OS] Open YAML text files as text.

Jul 22 2022, 6:21 AM · Restricted Project, Restricted Project

Jul 11 2022

abhina.sreeskantharajan committed rG6e2329e33ae3: [SystemZ][z/OS] Force alignment to fix build failure on z/OS (authored by abhina.sreeskantharajan).

[SystemZ][z/OS] Force alignment to fix build failure on z/OS

Jul 11 2022, 5:30 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan closed D129369: [SystemZ][z/OS] Force alignment to fix build failure on z/OS.

Jul 11 2022, 5:29 AM · Restricted Project, Restricted Project

Jul 8 2022

abhina.sreeskantharajan added a comment to D129369: [SystemZ][z/OS] Force alignment to fix build failure on z/OS.

Thanks, I have changed it to alignas and removed the static_assert.

Jul 8 2022, 12:35 PM · Restricted Project, Restricted Project

abhina.sreeskantharajan updated the diff for D129369: [SystemZ][z/OS] Force alignment to fix build failure on z/OS.

Update comment

Jul 8 2022, 12:34 PM · Restricted Project, Restricted Project

abhina.sreeskantharajan updated the diff for D129369: [SystemZ][z/OS] Force alignment to fix build failure on z/OS.

Use alignas and remove assert.

Jul 8 2022, 12:32 PM · Restricted Project, Restricted Project

abhina.sreeskantharajan updated the summary of D129369: [SystemZ][z/OS] Force alignment to fix build failure on z/OS.

Jul 8 2022, 9:06 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan updated the diff for D129369: [SystemZ][z/OS] Force alignment to fix build failure on z/OS.

empty commit

Jul 8 2022, 8:12 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan updated the summary of D129369: [SystemZ][z/OS] Force alignment to fix build failure on z/OS.

Jul 8 2022, 6:55 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan updated the summary of D129369: [SystemZ][z/OS] Force alignment to fix build failure on z/OS.

Jul 8 2022, 6:53 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan retitled D129369: [SystemZ][z/OS] Force alignment to fix build failure on z/OS from Force alignment to fix build failure on z/OS. to [SystemZ][z/OS] Force alignment to fix build failure on z/OS.

Jul 8 2022, 6:45 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan requested review of D129369: [SystemZ][z/OS] Force alignment to fix build failure on z/OS.

Jul 8 2022, 6:41 AM · Restricted Project, Restricted Project

Jun 23 2022

Herald added a project to D119966: [SystemZ][z/OS] Add OPEN_THREAD version of pthread function call: Restricted Project.

ping :)

Jun 23 2022, 6:41 AM · Restricted Project, Restricted Project

Jun 10 2022

abhina.sreeskantharajan accepted D127498: [SystemZ/z/OS] Set DWARF version to 4 for z/OS..

LGTM

Jun 10 2022, 7:33 AM · Restricted Project, Restricted Project

Jun 9 2022

abhina.sreeskantharajan accepted D127416: [SystemZ/z/OS] Fix failing dynamic library unit test..

LGTM

Jun 9 2022, 9:55 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan accepted D127412: [Systemz/z/OS] Add llvm.read_register() intrinsic support for zOS.

LGTM

Jun 9 2022, 9:55 AM · Restricted Project, Restricted Project

Apr 13 2022

abhina.sreeskantharajan added inline comments to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

Apr 13 2022, 9:50 AM · Restricted Project, Restricted Project

Apr 11 2022

abhina.sreeskantharajan accepted D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

this LGTM from a systemz perspective! thanks for refactoring

Apr 11 2022, 10:31 AM · Restricted Project, Restricted Project

Mar 15 2022

abhina.sreeskantharajan added a comment to D121331: Cleanup include: TableGen.

Thanks for the quick fix! There is another place where a similar situation happened. This header #include "llvm/Support/BCD.h" is being used in llvm/lib/Support/Host.cpp as well.

Mar 15 2022, 4:15 PM · Restricted Project, Restricted Project

Mar 14 2022

abhina.sreeskantharajan abandoned D121628: Only run this test for x86 registed targets..

Mar 14 2022, 11:41 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan updated the summary of D121628: Only run this test for x86 registed targets..

Mar 14 2022, 11:12 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan requested review of D121628: Only run this test for x86 registed targets..

Mar 14 2022, 11:09 AM · Restricted Project, Restricted Project

abhina.sreeskantharajan added a comment to D121331: Cleanup include: TableGen.

Hello, there is a usage of the needConversion function in MemoryBuffer.cpp which requires the following header #include "llvm/Support/AutoConvert.h" for z/OS. Can this header be added back to MemoryBuffer.cpp? I think it's usage was missed because it is guarded for z/OS only.

Mar 14 2022, 6:08 AM · Restricted Project, Restricted Project