Page MenuHomePhabricator

anirudhp (Anirudh Prasad)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 1 2019, 10:01 AM (71 w, 1 d)

Recent Activity

Today

anirudhp updated the diff for D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
  • Rebase on latest master
Tue, Apr 13, 8:37 AM · Restricted Project
anirudhp committed rGf7eec83932b5: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment… (authored by anirudhp).
[AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment…
Tue, Apr 13, 8:15 AM
anirudhp closed D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..
Tue, Apr 13, 8:15 AM · Restricted Project
anirudhp updated the diff for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..
  • Rebase on latest master
Tue, Apr 13, 7:03 AM · Restricted Project
anirudhp updated the diff for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..
  • Updating repo to rg Github monorepo (no functional changes)
Tue, Apr 13, 6:51 AM · Restricted Project
anirudhp set the repository for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings. to rG LLVM Github Monorepo.
Tue, Apr 13, 6:43 AM · Restricted Project

Yesterday

anirudhp added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Mon, Apr 12, 1:27 PM · Restricted Project
anirudhp added a comment to D99891: [SystemZ][z/OS] Introduce dialect querying helper functions.

Ping :)

Mon, Apr 12, 10:57 AM · Restricted Project

Fri, Apr 9

anirudhp added inline comments to D100130: [SystemZ][z/OS][Windows] Add new functions that set Text/Binary mode for Stdin and Stdout based on OpenFlags.
Fri, Apr 9, 10:58 AM · Restricted Project
anirudhp added a reviewer for D99891: [SystemZ][z/OS] Introduce dialect querying helper functions: myiwanch.
Fri, Apr 9, 6:10 AM · Restricted Project

Thu, Apr 8

anirudhp added reviewers for D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string.: myiwanch, Jonathan.Crowther.
Thu, Apr 8, 9:47 AM · Restricted Project
anirudhp added a reviewer for D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers: myiwanch.
Thu, Apr 8, 9:46 AM · Restricted Project
anirudhp added a reviewer for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings.: myiwanch.
Thu, Apr 8, 9:46 AM · Restricted Project
anirudhp added a comment to D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..

Are there any other review comments on this patch before I merge it in? Thanks!

Thu, Apr 8, 9:44 AM · Restricted Project

Wed, Apr 7

anirudhp accepted D100036: [SystemZ][z/OS][TableGen] TableGen files should be text.

Changes LGTM. I'm assuming there's no additional dependencies for this patch?

Wed, Apr 7, 8:15 AM · Restricted Project
anirudhp retitled D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings. from [AsmParser][SystemZ][z/OS] Add in support to only use CommentString as a possible comment syntax to [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..
Wed, Apr 7, 8:11 AM · Restricted Project

Tue, Apr 6

anirudhp updated the diff for D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..
  • Applying same patch again.
Tue, Apr 6, 2:02 PM · Restricted Project
anirudhp updated the diff for D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..
  • Addressed Comments (Rename of MCAsmInfo attribute)
Tue, Apr 6, 11:14 AM · Restricted Project
anirudhp added a comment to D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1.

Hi All!
Does anyone have feedback on the patch / approach taken? Any opinions would be greatly welcome and appreciated! :)

Tue, Apr 6, 8:07 AM · Restricted Project

Mon, Apr 5

anirudhp added a comment to D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..

It looks like this adds support for X86 identifiers starting with $ (I'm actually surprised this wasn't allowed before).

Mon, Apr 5, 4:42 PM · Restricted Project
anirudhp updated the summary of D99891: [SystemZ][z/OS] Introduce dialect querying helper functions.
Mon, Apr 5, 10:44 AM · Restricted Project
anirudhp added reviewers for D99891: [SystemZ][z/OS] Introduce dialect querying helper functions: uweigand, Kai, abhina.sreeskantharajan, yusra.syeda.
Mon, Apr 5, 10:44 AM · Restricted Project
anirudhp updated the summary of D99891: [SystemZ][z/OS] Introduce dialect querying helper functions.
Mon, Apr 5, 10:38 AM · Restricted Project
anirudhp updated the diff for D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1.
  • Rebasing on latest master + setting the AllowHashInIdentifier in HLASMAsmParser since it has landed.
Mon, Apr 5, 10:31 AM · Restricted Project
anirudhp updated the summary of D99891: [SystemZ][z/OS] Introduce dialect querying helper functions.
Mon, Apr 5, 10:29 AM · Restricted Project
anirudhp requested review of D99891: [SystemZ][z/OS] Introduce dialect querying helper functions.
Mon, Apr 5, 10:29 AM · Restricted Project
anirudhp retitled D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string. from [AsmParser][ms][X86] Fix possible error in parsing of special tokens at start of string. to [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..
Mon, Apr 5, 10:04 AM · Restricted Project
anirudhp added reviewers for D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string.: rnk, MaskRay, thakis, epastor, kzhuravl, scott.linder, ricky26, abhina.sreeskantharajan.
Mon, Apr 5, 10:02 AM · Restricted Project
anirudhp updated the summary of D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..
Mon, Apr 5, 10:01 AM · Restricted Project
anirudhp updated the summary of D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..
Mon, Apr 5, 9:59 AM · Restricted Project
anirudhp updated the summary of D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..
Mon, Apr 5, 9:59 AM · Restricted Project
anirudhp requested review of D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..
Mon, Apr 5, 9:58 AM · Restricted Project
anirudhp updated the diff for D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
  • Appeasing clang-tidy (rename of variable from camelCase to CamelCase)
Mon, Apr 5, 9:25 AM · Restricted Project
anirudhp added inline comments to D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
Mon, Apr 5, 8:43 AM · Restricted Project
anirudhp updated the diff for D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
  • Addressed Comments
  • Moved logic for LexHLASMIntegers to the main block where decimal integers are parsed.
Mon, Apr 5, 8:42 AM · Restricted Project
anirudhp updated the diff for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..
  • Addressed Comments
  • Renamed MCAsmInfo attribute with a more positive meaning
  • Updated tests and AsmLexer with new attribute name.
Mon, Apr 5, 7:47 AM · Restricted Project
anirudhp added a comment to D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..

This does not necessarily mean a conflict. As an concrete example, ld.lld treats # as an additional comment marker for linker scripts. GNU ld don't do this.
The ld.lld way can be seen as an extension. Since there is no meaningful syntax starting with # in GNU ld linker scripts, reserving # for an additional comment marker is totally fine.
My question here is similar. If there is no meaningful syntax starting with /* or //, we don't necessarily detect such cases.

Mon, Apr 5, 7:41 AM · Restricted Project

Sun, Apr 4

anirudhp added a comment to D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..

If the C and BCPL style comments don't cause conflict with HLASM, I'd rather we don't add any code. We don't necessarily reject syntax which are unlikely used incorrectly by the user.

Sun, Apr 4, 10:43 AM · Restricted Project

Sat, Apr 3

anirudhp added a reviewer for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings.: MaskRay.
Sat, Apr 3, 7:02 PM · Restricted Project

Fri, Apr 2

anirudhp added a reviewer for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings.: epastor.
Fri, Apr 2, 7:03 PM · Restricted Project
anirudhp added inline comments to D98519: [M68k] Add support for Motorola literal syntax to AsmParser.
Fri, Apr 2, 10:51 AM · Restricted Project
anirudhp added inline comments to D98519: [M68k] Add support for Motorola literal syntax to AsmParser.
Fri, Apr 2, 10:27 AM · Restricted Project

Thu, Apr 1

anirudhp updated the diff for D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
  • Rebase on latest master
Thu, Apr 1, 2:06 PM · Restricted Project
anirudhp updated the diff for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..
  • Rebasing on latest master.
Thu, Apr 1, 2:01 PM · Restricted Project
anirudhp committed rG7b921a674756: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an… (authored by anirudhp).
[AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an…
Thu, Apr 1, 8:25 AM
anirudhp closed D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.
Thu, Apr 1, 8:25 AM · Restricted Project

Wed, Mar 31

anirudhp added a reviewer for D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers: nickdesaulniers.
Wed, Mar 31, 4:25 PM · Restricted Project
anirudhp added a comment to D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..

Ping :)

Wed, Mar 31, 4:21 PM · Restricted Project
anirudhp updated the summary of D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
Wed, Mar 31, 11:09 AM · Restricted Project
anirudhp added a comment to D98537: [M68k] Implement AsmParser.

The only difference should be in the actual assembly syntax itself, however, you raise an interesting point because in Motorola-flavour assembly %0/%1 would be parsed as a single-bit constant... Which I hadn't thought of.

I'll be honest: at this stage I've not tested inline assembly at all.

Wed, Mar 31, 10:59 AM · Restricted Project
anirudhp added a comment to D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1.

Ping :) :)

Wed, Mar 31, 10:51 AM · Restricted Project
anirudhp updated the diff for D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.
  • Addressed Comments x2 (Reordered the check in isIdentifierChar)
Wed, Mar 31, 9:08 AM · Restricted Project

Tue, Mar 30

anirudhp added reviewers for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings.: nickdesaulniers, thakis.
Tue, Mar 30, 12:07 PM · Restricted Project
anirudhp added inline comments to D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.
Tue, Mar 30, 11:01 AM · Restricted Project
anirudhp added a comment to D98537: [M68k] Implement AsmParser.

I came across the series of patches that are adding Motorola asm support. I have a quick question as I'm not too familiar with Motorola asm.

Tue, Mar 30, 9:42 AM · Restricted Project
anirudhp added a reviewer for D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token: MaskRay.
Tue, Mar 30, 8:13 AM · Restricted Project
anirudhp added a reviewer for D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token: pratlucas.
Tue, Mar 30, 8:12 AM · Restricted Project
anirudhp added a reviewer for D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token: nickdesaulniers.
Tue, Mar 30, 8:05 AM · Restricted Project
anirudhp added a reviewer for D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token: thakis.
Tue, Mar 30, 8:03 AM · Restricted Project

Mon, Mar 29

anirudhp added a comment to D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.

Gentle Ping :)

Mon, Mar 29, 9:39 AM · Restricted Project
anirudhp updated the diff for D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.
  • Rebasing on latest master
Mon, Mar 29, 8:16 AM · Restricted Project
anirudhp updated the diff for D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
  • Addressed comments (Minor formatting changes)
Mon, Mar 29, 7:39 AM · Restricted Project
anirudhp added a comment to D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.

There is one failing mlir unit test which I suspect might be caused by this patch and should be fixed.

Mon, Mar 29, 7:22 AM · Restricted Project

Thu, Mar 25

anirudhp added reviewers for D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1: Jonathan.Crowther, fanbo-meng.
Thu, Mar 25, 1:28 PM · Restricted Project
anirudhp added reviewers for D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers: uweigand, Kai, yusra.syeda, abhina.sreeskantharajan, scott.linder, rnk, efriedma, epastor.
Thu, Mar 25, 1:26 PM · Restricted Project
anirudhp updated the summary of D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
Thu, Mar 25, 1:21 PM · Restricted Project
anirudhp updated the summary of D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
Thu, Mar 25, 1:20 PM · Restricted Project
anirudhp requested review of D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
Thu, Mar 25, 1:19 PM · Restricted Project
anirudhp added a comment to D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1.

Ping Ping! :) :)

Thu, Mar 25, 6:06 AM · Restricted Project
anirudhp accepted D99285: [SystemZ][z/OS] csv files should be text files.
Thu, Mar 25, 6:04 AM · Restricted Project

Wed, Mar 24

anirudhp added a reviewer for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings.: efriedma.
Wed, Mar 24, 12:49 PM · Restricted Project
anirudhp added a reviewer for D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token: efriedma.
Wed, Mar 24, 12:49 PM · Restricted Project
anirudhp updated the summary of D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.
Wed, Mar 24, 12:14 PM · Restricted Project
anirudhp updated the summary of D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.
Wed, Mar 24, 12:14 PM · Restricted Project
anirudhp updated the diff for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..
  • Few formatting changes + making the unittest a bit more robust in the tokens it was checking
Wed, Mar 24, 12:08 PM · Restricted Project
anirudhp updated the diff for D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.
  • Addressed clang-tidy warnings/errors
Wed, Mar 24, 11:45 AM · Restricted Project
anirudhp added reviewers for D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings.: abhina.sreeskantharajan, yusra.syeda, Kai, scott.linder, uweigand, rnk.
Wed, Mar 24, 11:27 AM · Restricted Project
anirudhp updated the summary of D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..
Wed, Mar 24, 11:26 AM · Restricted Project
anirudhp requested review of D99286: [AsmParser][SystemZ][z/OS] Add in support to allow use of additional comment strings..
Wed, Mar 24, 11:24 AM · Restricted Project
anirudhp added inline comments to D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.
Wed, Mar 24, 9:57 AM · Restricted Project
anirudhp updated the diff for D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.
  • Addressing Comments (Changing comment with the updated grammar)
Wed, Mar 24, 9:57 AM · Restricted Project
anirudhp added reviewers for D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token: uweigand, abhina.sreeskantharajan, Kai, yusra.syeda, scott.linder, epastor, rnk.
Wed, Mar 24, 9:42 AM · Restricted Project
anirudhp requested review of D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token.
Wed, Mar 24, 9:36 AM · Restricted Project
anirudhp committed rG301d9261b787: [AsmParser][SystemZ][z/OS] Re-introduce HLASM comment syntax (authored by anirudhp).
[AsmParser][SystemZ][z/OS] Re-introduce HLASM comment syntax
Wed, Mar 24, 7:17 AM
anirudhp closed D99004: [AsmParser][SystemZ][z/OS] Re-introduce HLASM comment syntax.
Wed, Mar 24, 7:17 AM · Restricted Project

Mon, Mar 22

anirudhp accepted D99072: [NFC] Formatting changes.

LGTM

Mon, Mar 22, 7:10 AM · Restricted Project, Restricted Project

Fri, Mar 19

anirudhp updated the summary of D99004: [AsmParser][SystemZ][z/OS] Re-introduce HLASM comment syntax.
Fri, Mar 19, 7:10 PM · Restricted Project
anirudhp updated the summary of D99004: [AsmParser][SystemZ][z/OS] Re-introduce HLASM comment syntax.
Fri, Mar 19, 7:06 PM · Restricted Project
anirudhp requested review of D99004: [AsmParser][SystemZ][z/OS] Re-introduce HLASM comment syntax.
Fri, Mar 19, 7:02 PM · Restricted Project

Thu, Mar 18

anirudhp added a comment to D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1.

Ping :)

Thu, Mar 18, 8:05 AM · Restricted Project

Tue, Mar 16

anirudhp added a reverting change for rGb605cfb33698: [AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax": rG9f5da80013dd: Revert "[AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax"".
Tue, Mar 16, 3:39 PM
anirudhp committed rG9f5da80013dd: Revert "[AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax"" (authored by anirudhp).
Revert "[AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax""
Tue, Mar 16, 3:39 PM
anirudhp added a reverting change for D98666: [AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax": rG9f5da80013dd: Revert "[AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax"".
Tue, Mar 16, 3:39 PM · Restricted Project
anirudhp closed D98744: Revert "[AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax"".
Tue, Mar 16, 3:39 PM · Restricted Project
anirudhp added a comment to D98744: Revert "[AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax"".

Committing this revert without review. While there aren't any building issues with shared libs and static libs, there are failures with the address sanitizer bots https://lab.llvm.org/buildbot/#/builders/5/builds/5697

Tue, Mar 16, 3:34 PM · Restricted Project
anirudhp added a reverting change for rGb605cfb33698: [AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax": D98744: Revert "[AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax"".
Tue, Mar 16, 3:32 PM
anirudhp requested review of D98744: Revert "[AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax"".
Tue, Mar 16, 3:32 PM · Restricted Project
anirudhp added a reverting change for D98666: [AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax": D98744: Revert "[AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax"".
Tue, Mar 16, 3:32 PM · Restricted Project
anirudhp committed rGb605cfb33698: [AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax" (authored by anirudhp).
[AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax"
Tue, Mar 16, 2:12 PM
anirudhp closed D98666: [AsmParser][SystemZ][z/OS] Reland "Introduce HLASM Comment Syntax".
Tue, Mar 16, 2:11 PM · Restricted Project