[AIX][XCOFF] Implement 64-bit relocations tests with llvm-objdump/llvm-readobj

[MaryamBen]

Summary

Support 64-bit tests in the CodeGen directory.

[jhenderson]

Somebody else with XCOFF knowledge will need to review the correctness of the output. It looks okay to me, but I don't really know anything about this code gen.

llvm/test/CodeGen/PowerPC/aix-overflow-toc.py

14–15

All the other cases here use the --code-model=small option. Should this one?

[Helflym]

LGTM on XCOFF part, though I haven't run them.

llvm/test/CodeGen/PowerPC/aix-llvm-intrinsic.ll

 ; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff -mcpu=pwr4 -mattr=-altivec < %s | \
 ; RUN:   FileCheck %s
 
 ; RUN: llc -verify-machineinstrs -mtriple powerpc64-ibm-aix-xcoff -mcpu=pwr4 -mattr=-altivec < %s | \
 ; RUN:   FileCheck %s
 
 ; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff -mcpu=pwr4 \
 ; RUN:     -mattr=-altivec -filetype=obj -o %t.o < %s
 ; RUN: llvm-readobj --symbols %t.o | FileCheck --check-prefixes=CHECKSYM,CHECKSYM32 %s
-; RUN: llvm-objdump -r -d --symbol-description %t.o | FileCheck --check-prefix=CHECKRELOC %s
+; RUN: llvm-objdump -r -d --symbol-description %t.o | FileCheck --check-prefixes=CHECKRELOC,CHECKRELOC32 %s
 
 ; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc64-ibm-aix-xcoff \
 ; RUN:      -mattr=-altivec -filetype=obj -o %t.o  < %s
 ; RUN: llvm-readobj --symbols %t.o | FileCheck --check-prefixes=CHECKSYM,CHECKSYM64 %s
-; RUN: not --crash llvm-objdump -r -d --symbol-description %t.o 2>&1 |  FileCheck --check-prefix=XCOFF64 %s
-; XCOFF64: LLVM ERROR: 64-bit support not implemented yet
+; RUN: llvm-objdump -r -d --symbol-description %t.o | FileCheck --check-prefixes=CHECKRELOC,CHECKRELOC64 %s
 
 %struct.S = type { i32, i32 }
 
 @s = external global %struct.S, align 4
 
 define void @bar() {
 entry:
   %0 = load i32, i32* getelementptr inbounds (%struct.S, %struct.S* @s, i32 0, i32 1), align 4

 ; CHECKSYM32-NEXT:     StabInfoIndex: 0x0
 ; CHECKSYM32-NEXT:     StabSectNum: 0x0
 ; CHECKSYM64-NEXT:     Auxiliary Type: AUX_CSECT (0xFB)
 ; CHECKSYM-NEXT:     }
 ; CHECKSYM-NEXT:   }
 
 ; CHECKRELOC:      00000000 (idx: 7) .bar:
 ; CHECKRELOC-NEXT:        0: 7c 08 02 a6                        mflr 0
-; CHECKRELOC-NEXT:        4: 90 01 00 08                        stw 0, 8(1)
-; CHECKRELOC-NEXT:        8: 94 21 ff c0                        stwu 1, -64(1)
-; CHECKRELOC-NEXT:        c: 80 62 00 00                        lwz 3, 0(2)
+; CHECKRELOC32-NEXT:      4: 90 01 00 08                        stw 0, 8(1)
+; CHECKRELOC32-NEXT:      8: 94 21 ff c0                        stwu 1, -64(1)
+; CHECKRELOC32-NEXT:      c: 80 62 00 00                        lwz 3, 0(2)
+; CHECKRELOC64-NEXT:      4: f8 01 00 10                        std 0, 16(1)
+; CHECKRELOC64-NEXT:      8: f8 21 ff 91                        stdu 1, -112(1)
+; CHECKRELOC64-NEXT:      c: e8 62 00 00                        ld 3, 0(2)
 ; CHECKRELOC-NEXT:                      0000000e:  R_TOC        (idx: 13) s[TC]
 ; CHECKRELOC-NEXT:       10: 80 83 00 04                        lwz 4, 4(3)
 ; CHECKRELOC-NEXT:       14: 7c 85 23 78                        mr 5, 4
 ; CHECKRELOC-NEXT:       18: 4b ff ff e9                        bl 0x0
 ; CHECKRELOC-NEXT:                      00000018:  R_RBR        (idx: 1) .memset[PR]

llvm/test/CodeGen/PowerPC/aix-overflow-toc.py

 # UNSUPPORTED: expensive_checks, debug
 
 # RUN: %python %s > %t.ll
 # RUN: llc -mtriple powerpc-ibm-aix-xcoff -code-model=small -data-sections=false -mcpu=pwr4 -mattr=-altivec -O0 < %t.ll | \
 # RUN:   FileCheck --check-prefix=ASM32 %s
 
 # RUN: llc -mtriple powerpc64-ibm-aix-xcoff -code-model=small -data-sections=false -mcpu=pwr4 -mattr=-altivec -O0 < %t.ll | \
 # RUN:   FileCheck --check-prefix=ASM64 %s
 
 # RUN: llc -mtriple powerpc-ibm-aix-xcoff -code-model=small -data-sections=false -mcpu=pwr4 -mattr=-altivec -O0 \
 # RUN:     -filetype=obj -o %t.o < %t.ll
-# RUN: llvm-objdump -D -r --symbol-description %t.o | FileCheck --check-prefix=DIS32 %s
+# RUN: llvm-objdump -D -r --symbol-description %t.o | FileCheck --check-prefixes=DIS,DIS32 %s
 
 # RUN: llc -mtriple powerpc64-ibm-aix-xcoff -data-sections=false \
-# RUN:     -mcpu=pwr4 -mattr=-altivec -filetype=obj -o %t.o < %t.ll
-# RUN: not --crash llvm-objdump -D -r --symbol-description %t.o 2>&1 |  FileCheck --check-prefix=XCOFF64 %s
-# XCOFF64: LLVM ERROR: 64-bit support not implemented yet
+# RUN:     -mcpu=pwr4 -mattr=-altivec -O0 -filetype=obj -o %t.o < %t.ll
+# RUN: llvm-objdump -D -r --symbol-description %t.o | FileCheck --check-prefixes=DIS,DIS64 %s
 
 numentries = 12290
 for x in range(0, numentries):
     print("@a%d = global i32 0, align 4" % (x))
 
 print("define void @foo() {")
 print("entry:")
 for x in range(0, numentries):

 # ASM64:  ld 4, L..C4096-65536(2) # @a4096
 # ASM64:  ld 4, L..C4097-65536(2) # @a4097
 
 # ASM64:  ld 4, L..C12287-65536(2) # @a12287
 # ASM64:  ld 4, L..C12288-131072(2) # @a12288
 # ASM64:  ld 4, L..C12289-131072(2) # @a12289
 
 # DIS32:   0: 80 82 00 00   lwz 4, 0(2)
-# DIS32:  00000002:  R_TOC  (idx: 24591) a0[TC]
+# DIS64:   0: e8 82 00 00   ld 4, 0(2)
+# DIS:    00000002:  R_TOC  (idx: 24591) a0[TC]
 # DIS32:   c: 80 82 00 04   lwz 4, 4(2)
-# DIS32:  0000000e:  R_TOC  (idx: 24593) a1[TC]
+# DIS64:   c: e8 82 00 08   ld 4, 8(2)
+# DIS:    0000000e:  R_TOC  (idx: 24593) a1[TC]
 
 # DIS32:    fffc: 80 82 7f fc   lwz 4, 32764(2)
-# DIS32:      0000fffe:  R_TOC  (idx: 40973) a8191[TC]
+# DIS64:    fffc: e8 82 ff f8   ld 4, -8(2)
+# DIS:        0000fffe:  R_TOC  (idx: 40973) a8191[TC]
 # DIS32:   10004: 80 82 80 00   lwz 4, -32768(2)
-# DIS32:      00010006:  R_TOC  (idx: 40975) a8192[TC]
+# DIS64:   10004: e8 82 00 00   ld 4, 0(2)
+# DIS:        00010006:  R_TOC  (idx: 40975) a8192[TC]
 # DIS32:   1000c: 80 82 80 04   lwz 4, -32764(2)
-# DIS32:      0001000e:  R_TOC  (idx: 40977) a8193[TC]
+# DIS64:   1000c: e8 82 00 08   ld 4, 8(2)
+# DIS:        0001000e:  R_TOC  (idx: 40977) a8193[TC]
 
 # DIS32:   18004: 80 82 c0 00   lwz 4, -16384(2)
-# DIS32:      00018006:  R_TOC  (idx: 49167) a12288[TC]
+# DIS64:   18004: e8 82 80 00   ld 4, -32768(2)
+# DIS:        00018006:  R_TOC  (idx: 49167) a12288[TC]
 # DIS32:   1800c: 80 82 c0 04   lwz 4, -16380(2)
-# DIS32:      0001800e:  R_TOC  (idx: 49169) a12289[TC]
+# DIS64:   1800c: e8 82 80 08   ld 4, -32760(2)
+# DIS:        0001800e:  R_TOC  (idx: 49169) a12289[TC]

llvm/test/CodeGen/PowerPC/aix-user-defined-memcpy.ll

 ; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff -mcpu=pwr4 \
 ; RUN: -mattr=-altivec -filetype=obj -xcoff-traceback-table=false -o %t.o < %s
 
 ; RUN: llvm-readobj --syms %t.o | FileCheck --check-prefixes=SYM,SYM32 %s
 
 ; RUN: llvm-readobj --relocs --expand-relocs %t.o | FileCheck \
-; RUN: --check-prefix=32-REL %s
+; RUN: --check-prefixes=REL,REL32 %s
 
 ; RUN: llvm-objdump -D %t.o | FileCheck --check-prefixes=DIS,DIS32 %s
 
 ; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff \
 ; RUN:     -mcpu=pwr4 -mattr=-altivec < %s | \
 ; RUN:   FileCheck %s
 
 ; RUN: llc -verify-machineinstrs -mtriple powerpc64-ibm-aix-xcoff -mcpu=pwr4 \
 ; RUN: -mattr=-altivec -filetype=obj -xcoff-traceback-table=false -o %t.o < %s
 
+; RUN: llvm-readobj --relocs --expand-relocs %t.o | FileCheck \
+; RUN: --check-prefixes=REL,REL64 %s
+
 ; RUN: llvm-readobj --syms %t.o | FileCheck --check-prefixes=SYM,SYM64 %s
 
 ; RUN: llvm-objdump -D %t.o | FileCheck --check-prefixes=DIS,DIS64 %s
 
-; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff \
+; RUN: llc -verify-machineinstrs -mtriple powerpc64-ibm-aix-xcoff \
 ; RUN:     -mcpu=pwr4 -mattr=-altivec < %s | \
 ; RUN:   FileCheck %s
 
 ; Test verifies:
 ; If there exists a user-defined function whose name is the same as the
 ; "memcpy" ExternalSymbol's, we pick up the user-defined version, even if this
 ; may lead to some undefined behavior.
 

 ; SYM32-NEXT:    StabInfoIndex: 0x0
 ; SYM32-NEXT:    StabSectNum: 0x0
 ; SYM64-NEXT:    Auxiliary Type: AUX_CSECT (0xFB)
 ; SYM-NEXT:    }
 ; SYM-NEXT:  }
 
 ; SYM-NOT: .memcpy
 
-; 32-REL:      Relocations [
-; 32-REL-NEXT:  Section (index: 2) .data {
-; 32-REL-NEXT:  Relocation {
-; 32-REL-NEXT:    Virtual Address: 0x34
-; 32-REL-NEXT:    Symbol: .memcpy (3)
-; 32-REL-NEXT:    IsSigned: No
-; 32-REL-NEXT:    FixupBitValue: 0
-; 32-REL-NEXT:    Length: 32
-; 32-REL-NEXT:    Type: R_POS (0x0)
-; 32-REL-NEXT:  }
-; 32-REL-NEXT:  Relocation {
-; 32-REL-NEXT:    Virtual Address: 0x38
-; 32-REL-NEXT:    Symbol: TOC (11)
-; 32-REL-NEXT:    IsSigned: No
-; 32-REL-NEXT:    FixupBitValue: 0
-; 32-REL-NEXT:    Length: 32
-; 32-REL-NEXT:    Type: R_POS (0x0)
-; 32-REL-NEXT:  }
-; 32-REL-NEXT:  Relocation {
-; 32-REL-NEXT:    Virtual Address: 0x40
-; 32-REL-NEXT:    Symbol: .call_memcpy (5)
-; 32-REL-NEXT:    IsSigned: No
-; 32-REL-NEXT:    FixupBitValue: 0
-; 32-REL-NEXT:    Length: 32
-; 32-REL-NEXT:    Type: R_POS (0x0)
-; 32-REL-NEXT:  }
-; 32-REL-NEXT:  Relocation {
-; 32-REL-NEXT:    Virtual Address: 0x44
-; 32-REL-NEXT:    Symbol: TOC (11)
-; 32-REL-NEXT:    IsSigned: No
-; 32-REL-NEXT:    FixupBitValue: 0
-; 32-REL-NEXT:    Length: 32
-; 32-REL-NEXT:    Type: R_POS (0x0)
-; 32-REL-NEXT:  }
-; 32-REL-NEXT:  }
-; 32-REL-NEXT: ]
+; REL:      Relocations [
+; REL-NEXT:  Section (index: 2) .data {
+; REL-NEXT:  Relocation {
+; REL32-NEXT:  Virtual Address: 0x34
+; REL64-NEXT:  Virtual Address: 0x38
+; REL-NEXT:    Symbol: .memcpy (3)
+; REL-NEXT:    IsSigned: No
+; REL-NEXT:    FixupBitValue: 0
+; REL32-NEXT:  Length: 32
+; REL64-NEXT:  Length: 64
+; REL-NEXT:    Type: R_POS (0x0)
+; REL-NEXT:  }
+; REL-NEXT:  Relocation {
+; REL32-NEXT:  Virtual Address: 0x38
+; REL64-NEXT:  Virtual Address: 0x40
+; REL-NEXT:    Symbol: TOC (11)
+; REL-NEXT:    IsSigned: No
+; REL-NEXT:    FixupBitValue: 0
+; REL32-NEXT:  Length: 32
+; REL64-NEXT:  Length: 64
+; REL-NEXT:    Type: R_POS (0x0)
+; REL-NEXT:  }
+; REL-NEXT:  Relocation {
+; REL32-NEXT:  Virtual Address: 0x40
+; REL64-NEXT:  Virtual Address: 0x50
+; REL-NEXT:    Symbol: .call_memcpy (5)
+; REL-NEXT:    IsSigned: No
+; REL-NEXT:    FixupBitValue: 0
+; REL32-NEXT:  Length: 32
+; REL64-NEXT:  Length: 64
+; REL-NEXT:    Type: R_POS (0x0)
+; REL-NEXT:  }
+; REL-NEXT:  Relocation {
+; REL32-NEXT:  Virtual Address: 0x44
+; REL64-NEXT:  Virtual Address: 0x58
+; REL-NEXT:    Symbol: TOC (11)
+; REL-NEXT:    IsSigned: No
+; REL-NEXT:    FixupBitValue: 0
+; REL32-NEXT:  Length: 32
+; REL64-NEXT:  Length: 64
+; REL-NEXT:    Type: R_POS (0x0)
+; REL-NEXT:  }
+; REL-NEXT:  }
+; REL-NEXT: ]
 
-; 32-REL-NOT:  Type: R_RBR (0x1A)
+; REL-NOT:  Type: R_RBR (0x1A)
 
 ; DIS:      Disassembly of section .text:
 ; DIS:      00000000 <.text>:
 ; DIS-NEXT:        0: 38 60 00 03                   li 3, 3
 ; DIS-NEXT:        4: 4e 80 00 20                   blr
 ; DIS-NEXT:        8: 60 00 00 00                   nop
 ; DIS-NEXT:        c: 60 00 00 00                   nop
 ; DIS:      00000010 <.call_memcpy>:
 ; DIS-NEXT:       10: 7c 08 02 a6                   mflr 0
-; DIS32:          14: 90 01 00 08                   stw 0, 8(1)
+; DIS32-NEXT:     14: 90 01 00 08                   stw 0, 8(1)
 ; DIS32-NEXT:     18: 94 21 ff c0                   stwu 1, -64(1)
-; DIS64:          14: f8 01 00 10                   std 0, 16(1)
+; DIS64-NEXT:     14: f8 01 00 10                   std 0, 16(1)
 ; DIS64-NEXT:     18: f8 21 ff 91                   stdu 1, -112(1)
 ; DIS-NEXT:       1c: 4b ff ff e5                   bl 0x0
 ; DIS-NEXT:       20: 60 00 00 00                   nop
-; DIS32:          24: 38 21 00 40                   addi 1, 1, 64
+; DIS32-NEXT:     24: 38 21 00 40                   addi 1, 1, 64
 ; DIS32-NEXT:     28: 80 01 00 08                   lwz 0, 8(1)
-; DIS64:          24: 38 21 00 70                   addi 1, 1, 112
+; DIS64-NEXT:     24: 38 21 00 70                   addi 1, 1, 112
 ; DIS64-NEXT:     28: e8 01 00 10                   ld 0, 16(1)
 ; DIS-NEXT:       2c: 7c 08 03 a6                   mtlr 0
 ; DIS-NEXT:       30: 4e 80 00 20                   blr

llvm/test/CodeGen/PowerPC/aix-xcoff-reloc.ll

 ; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc-ibm-aix-xcoff -mattr=-altivec \
 ; RUN:     -xcoff-traceback-table=false -data-sections=false -filetype=obj -o %t.o < %s
 ; RUN: llvm-readobj --section-headers --file-header %t.o | \
 ; RUN: FileCheck --check-prefixes=OBJ,OBJ32 %s
 ; RUN: llvm-readobj --relocs --expand-relocs %t.o | FileCheck --check-prefix=RELOC %s
 ; RUN: llvm-readobj -t %t.o | FileCheck --check-prefixes=SYM,SYM32 %s
 ; RUN: llvm-objdump -D %t.o | FileCheck --check-prefixes=DIS,DIS32 %s
-; RUN: llvm-objdump -r %t.o | FileCheck --check-prefix=DIS_REL %s
+; RUN: llvm-objdump -r %t.o | FileCheck --check-prefixes=DIS_REL,DIS_REL32 %s
 
 ; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc64-ibm-aix-xcoff -mattr=-altivec \
 ; RUN:     -xcoff-traceback-table=false -data-sections=false -filetype=obj -o %t.o < %s
 ; RUN: llvm-readobj --section-headers --file-header %t.o | \
 ; RUN: FileCheck --check-prefixes=OBJ,OBJ64 %s
 ; RUN: llvm-readobj -t %t.o | FileCheck --check-prefixes=SYM,SYM64 %s
 ; RUN: llvm-objdump -D %t.o | FileCheck --check-prefixes=DIS,DIS64 %s
-; RUN: not --crash llvm-objdump -r %t.o 2>&1 | FileCheck --check-prefix=XCOFF64 %s
-; XCOFF64: LLVM ERROR: 64-bit support not implemented yet
+; RUN: llvm-objdump -r %t.o | FileCheck --check-prefixes=DIS_REL,DIS_REL64 %s
 
 @globalA = global i32 1, align 4
 @globalB = global i32 2, align 4
 @arr = global <{ i32, [9 x i32] }> <{ i32 3, [9 x i32] zeroinitializer }>, align 4
 @p = global i32* bitcast (i8* getelementptr (i8, i8* bitcast (<{ i32, [9 x i32] }>* @arr to i8*), i64 16) to i32*), align 4
 
 define i32 @foo() {
 entry:

 ; DIS64-NEXT:       84: 00 00 00 90                   <unknown>
 ; DIS64:      00000090 <globalA>:
 ; DIS64-NEXT:       90: 00 00 00 00                   <unknown>
 ; DIS64-NEXT:       94: 00 00 00 40                   <unknown>
 ; DIS64:      00000098 <globalB>:
 ; DIS64-NEXT:       98: 00 00 00 00                   <unknown>
 ; DIS64-NEXT:       9c: 00 00 00 44                   <unknown>
 
-; DIS_REL:       {{.*}}aix-xcoff-reloc.ll.tmp.o:   file format aixcoff-rs6000
-; DIS_REL:       RELOCATION RECORDS FOR [.text]:
-; DIS_REL-NEXT:  OFFSET   TYPE                     VALUE
-; DIS_REL-NEXT:  00000010 R_RBR                    .bar
-; DIS_REL-NEXT:  0000001a R_TOC                    globalA
-; DIS_REL-NEXT:  0000001e R_TOC                    globalB
-; DIS_REL:       RELOCATION RECORDS FOR [.data]:
-; DIS_REL-NEXT:  OFFSET   TYPE                     VALUE
-; DIS_REL-NEXT:  00000030 R_POS                    arr
-; DIS_REL-NEXT:  00000034 R_POS                    .foo
-; DIS_REL-NEXT:  00000038 R_POS                    TOC
-; DIS_REL-NEXT:  00000040 R_POS                    globalA
-; DIS_REL-NEXT:  00000044 R_POS                    globalB
+; DIS_REL32:      {{.*}}aix-xcoff-reloc.ll.tmp.o:   file format aixcoff-rs6000
+; DIS_REL64:      {{.*}}aix-xcoff-reloc.ll.tmp.o:   file format aix5coff64-rs6000
+; DIS_REL:        RELOCATION RECORDS FOR [.text]:
+; DIS_REL-NEXT:   OFFSET   TYPE                     VALUE
+; DIS_REL-NEXT:   00000010 R_RBR                    .bar
+; DIS_REL-NEXT:   0000001a R_TOC                    globalA
+; DIS_REL-NEXT:   0000001e R_TOC                    globalB
+; DIS_REL:        RELOCATION RECORDS FOR [.data]:
+; DIS_REL-NEXT:   OFFSET   TYPE                     VALUE
+; DIS_REL-NEXT:   00000030 R_POS                    arr
+; DIS_REL32-NEXT: 00000034 R_POS                    .foo
+; DIS_REL32-NEXT: 00000038 R_POS                    TOC
+; DIS_REL32-NEXT: 00000040 R_POS                    globalA
+; DIS_REL32-NEXT: 00000044 R_POS                    globalB
+; DIS_REL64-NEXT: 00000038 R_POS                    .foo
+; DIS_REL64-NEXT: 00000040 R_POS                    TOC
+; DIS_REL64-NEXT: 00000050 R_POS                    globalA
+; DIS_REL64-NEXT: 00000058 R_POS                    globalB