Page MenuHomePhabricator

[AIX][XCOFF] Implement 64-bit relocations tests with llvm-objdump/llvm-readobj
AcceptedPublic

Authored by MaryamBen on Jun 25 2021, 6:46 AM.

Details

Summary

Support 64-bit tests in the CodeGen directory.

Diff Detail

Event Timeline

MaryamBen requested review of this revision.Jun 25 2021, 6:46 AM
MaryamBen created this revision.
MaryamBen updated this revision to Diff 354506.Jun 25 2021, 8:06 AM
MaryamBen retitled this revision from [AIX][XCOFF][llvm-objdump] Implement 64-bit relocations tests to [AIX][XCOFF] Implement 64-bit relocations tests with llvm-objdump/llvm-readobj .
MaryamBen updated this revision to Diff 355543.Jun 30 2021, 7:39 AM
MaryamBen updated this revision to Diff 362303.Jul 28 2021, 1:35 AM

Somebody else with XCOFF knowledge will need to review the correctness of the output. It looks okay to me, but I don't really know anything about this code gen.

llvm/test/CodeGen/PowerPC/aix-overflow-toc.py
13–14

All the other cases here use the --code-model=small option. Should this one?

MaryamBen updated this revision to Diff 363030.Jul 30 2021, 4:20 AM
MaryamBen marked an inline comment as done.
Helflym accepted this revision.Aug 6 2021, 1:13 AM
Helflym added a subscriber: Helflym.

LGTM on XCOFF part, though I haven't run them.

This revision is now accepted and ready to land.Aug 6 2021, 1:13 AM