- User Since
- Jun 4 2021, 12:09 AM (69 w, 4 d)
Aug 20 2021
When I did this work, I had no idea that I could remove "64-bit XCOFF object files are not supported yet." in order to create tests.
Unfortunately, I learned this late,
Thank you so much for your clarifications.
LGTM, apart from minor nits (and possibly follow on tests). I can assist with committing this once you're ready.
I'm sorry, I just saw your comment.
Aug 19 2021
Thanks you for your reviews,
Aug 18 2021
Update tests based on a9854045f6b6
I removed the trailing whitespace.
It would be great if you could commit it, thank you.
Aug 6 2021
Aug 4 2021
Aug 3 2021
Aug 2 2021
Jul 30 2021
Jul 28 2021
Jul 27 2021
Jul 26 2021
I created another patch to replace unwrapOrError with reportUniqueWarning.
Could you suggest someone who can take a look on it ?
Jul 21 2021
Any news regarding the patch?
Jul 7 2021
Jul 6 2021
Thank you for your valuable comments
Jun 30 2021
Jun 28 2021
Jun 25 2021
I kept one test from llvm-objdump. Is it okey, or I should move it to another patch?
Jun 23 2021
Jun 22 2021
formatting the file
Jun 21 2021
Jun 16 2021
Reiterating this, as I think it is really important. This patch is too large to review as is. I understand breaking it up seems like extra work but it is going to go much faster/smoother if we can partition this into some smaller changes. The first patch I think should be the addition of Relocation64 to the XCOFF implementation in the Object library (ie include/llvm/Object/XCOFFObjectFile.h and lib/ObjectXCOFFObjectFile.cpp), any code needed to support that (for example if additions need to be made to include/llvm/BinaryFormat/XCOFF.h) and the 64-bit relocation reading support added to the llvm-readobj XCOFFDumper to exercises the newly added functionality.