Page MenuHomePhabricator

MaryamBen (Maryam)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2021, 12:09 AM (14 w, 6 d)

Recent Activity

Fri, Aug 20

MaryamBen added a comment to D104639: [AIX][XCOFF] Add support for 64-bit file header and section header writing.

When I did this work, I had no idea that I could remove "64-bit XCOFF object files are not supported yet." in order to create tests.
Unfortunately, I learned this late,
Thank you so much for your clarifications.

Fri, Aug 20, 1:54 AM · Restricted Project
MaryamBen updated the diff for D104639: [AIX][XCOFF] Add support for 64-bit file header and section header writing.
Fri, Aug 20, 1:53 AM · Restricted Project
MaryamBen added a comment to D104646: [AIX][XCOFF] 64-bit relocation reading support.

LGTM, apart from minor nits (and possibly follow on tests). I can assist with committing this once you're ready.

I'm sorry, I just saw your comment.

Fri, Aug 20, 12:21 AM · Restricted Project

Thu, Aug 19

MaryamBen added a comment to D104639: [AIX][XCOFF] Add support for 64-bit file header and section header writing.

Thanks you for your reviews,

Thu, Aug 19, 4:37 AM · Restricted Project

Wed, Aug 18

MaryamBen updated the diff for D105010: [AIX][XCOFF] Add support for 64-bit TLS fixup kind.

Update tests based on a9854045f6b6

Wed, Aug 18, 12:51 AM · Restricted Project
MaryamBen added a comment to D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.

I removed the trailing whitespace.
It would be great if you could commit it, thank you.

Wed, Aug 18, 12:35 AM · Restricted Project
MaryamBen updated the diff for D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Wed, Aug 18, 12:32 AM · Restricted Project

Aug 6 2021

MaryamBen added inline comments to D104646: [AIX][XCOFF] 64-bit relocation reading support.
Aug 6 2021, 12:31 AM · Restricted Project

Aug 4 2021

MaryamBen updated the diff for D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Aug 4 2021, 3:56 AM · Restricted Project
MaryamBen added inline comments to D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Aug 4 2021, 2:36 AM · Restricted Project
MaryamBen updated the diff for D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Aug 4 2021, 2:32 AM · Restricted Project
MaryamBen updated the diff for D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Aug 4 2021, 2:04 AM · Restricted Project

Aug 3 2021

MaryamBen updated the diff for D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Aug 3 2021, 6:25 AM · Restricted Project

Aug 2 2021

MaryamBen added inline comments to D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Aug 2 2021, 4:25 AM · Restricted Project
MaryamBen updated the diff for D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Aug 2 2021, 4:25 AM · Restricted Project

Jul 30 2021

MaryamBen updated the diff for D104913: [AIX][XCOFF] Implement 64-bit relocations tests with llvm-objdump/llvm-readobj .
Jul 30 2021, 4:20 AM · Restricted Project
MaryamBen updated the diff for D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Jul 30 2021, 4:07 AM · Restricted Project

Jul 28 2021

MaryamBen updated the diff for D104913: [AIX][XCOFF] Implement 64-bit relocations tests with llvm-objdump/llvm-readobj .
Jul 28 2021, 1:35 AM · Restricted Project
MaryamBen updated the diff for D104646: [AIX][XCOFF] 64-bit relocation reading support.
Jul 28 2021, 1:06 AM · Restricted Project
MaryamBen added inline comments to D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Jul 28 2021, 1:04 AM · Restricted Project
MaryamBen updated the diff for D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Jul 28 2021, 12:56 AM · Restricted Project

Jul 27 2021

MaryamBen updated the diff for D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jul 27 2021, 8:00 AM · Restricted Project
MaryamBen added inline comments to D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jul 27 2021, 7:59 AM · Restricted Project

Jul 26 2021

MaryamBen added inline comments to D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jul 26 2021, 4:35 AM · Restricted Project
MaryamBen updated the diff for D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jul 26 2021, 3:10 AM · Restricted Project
MaryamBen added a comment to D104646: [AIX][XCOFF] 64-bit relocation reading support.

I created another patch to replace unwrapOrError with reportUniqueWarning.
Could you suggest someone who can take a look on it ?
Thank you

Jul 26 2021, 2:59 AM · Restricted Project
MaryamBen updated the diff for D104646: [AIX][XCOFF] 64-bit relocation reading support.
Jul 26 2021, 2:51 AM · Restricted Project
MaryamBen requested review of D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Jul 26 2021, 2:49 AM · Restricted Project

Jul 21 2021

MaryamBen added a comment to D104646: [AIX][XCOFF] 64-bit relocation reading support.

Any news regarding the patch?

Jul 21 2021, 12:25 AM · Restricted Project

Jul 7 2021

MaryamBen updated the diff for D104646: [AIX][XCOFF] 64-bit relocation reading support.
Jul 7 2021, 12:37 AM · Restricted Project

Jul 6 2021

MaryamBen added a comment to D104646: [AIX][XCOFF] 64-bit relocation reading support.

Thank you for your valuable comments

Jul 6 2021, 1:50 PM · Restricted Project
MaryamBen updated the diff for D104646: [AIX][XCOFF] 64-bit relocation reading support.
Jul 6 2021, 1:45 PM · Restricted Project
MaryamBen updated the diff for D104646: [AIX][XCOFF] 64-bit relocation reading support.
Jul 6 2021, 12:58 AM · Restricted Project

Jun 30 2021

MaryamBen updated the diff for D104913: [AIX][XCOFF] Implement 64-bit relocations tests with llvm-objdump/llvm-readobj .
Jun 30 2021, 7:39 AM · Restricted Project
MaryamBen updated the diff for D105010: [AIX][XCOFF] Add support for 64-bit TLS fixup kind.
Jun 30 2021, 7:38 AM · Restricted Project
MaryamBen added inline comments to D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jun 30 2021, 7:33 AM · Restricted Project
MaryamBen updated the diff for D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jun 30 2021, 7:31 AM · Restricted Project

Jun 28 2021

MaryamBen requested review of D105010: [AIX][XCOFF] Add support for 64-bit TLS fixup kind.
Jun 28 2021, 3:24 AM · Restricted Project

Jun 25 2021

MaryamBen updated the diff for D104913: [AIX][XCOFF] Implement 64-bit relocations tests with llvm-objdump/llvm-readobj .
Jun 25 2021, 8:06 AM · Restricted Project
MaryamBen updated the diff for D104646: [AIX][XCOFF] 64-bit relocation reading support.
Jun 25 2021, 7:54 AM · Restricted Project
MaryamBen updated the diff for D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jun 25 2021, 7:50 AM · Restricted Project
MaryamBen added a comment to D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.

This patch from the description is about 64-bit relocation support, so I'm not sure why there's so much changing in the testing. You shouldn't need so many tests for ensuring you have 64-bit relocation support, which implies that the existing tests aren't well designed - they are testing things in a too catch-all manner, and should probably be rewritten to test a small subset of functionality each. Furthermore, why does every test need to cover 64-bit behaviour?

Since I had the fatal error report in 64-bit, I couldn't check the file/section header and symbol table tests. Once I removed this part of the code, I had to implement tests even for the other parts.

report_fatal_error("64-bit XCOFF object files are not supported yet.");

So maybe I could just change the description or do you have another suggestion ?

Could most of the test be rewritten to not require relocations? It seems like relocations shouldn't be necessary in many situations (assuming they work similarly to how they do in ELF). That would allow those tests to be updated as you make the other patches in the test series, which in turn provides accompanying testing for them.

Jun 25 2021, 7:02 AM · Restricted Project
MaryamBen requested review of D104913: [AIX][XCOFF] Implement 64-bit relocations tests with llvm-objdump/llvm-readobj .
Jun 25 2021, 6:46 AM · Restricted Project
MaryamBen updated the diff for D104646: [AIX][XCOFF] 64-bit relocation reading support.

I kept one test from llvm-objdump. Is it okey, or I should move it to another patch?

Jun 25 2021, 6:35 AM · Restricted Project
MaryamBen updated the diff for D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jun 25 2021, 6:26 AM · Restricted Project

Jun 23 2021

MaryamBen added a comment to D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.

This patch from the description is about 64-bit relocation support, so I'm not sure why there's so much changing in the testing. You shouldn't need so many tests for ensuring you have 64-bit relocation support, which implies that the existing tests aren't well designed - they are testing things in a too catch-all manner, and should probably be rewritten to test a small subset of functionality each. Furthermore, why does every test need to cover 64-bit behaviour?

Jun 23 2021, 7:51 AM · Restricted Project
MaryamBen added inline comments to D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jun 23 2021, 7:39 AM · Restricted Project
MaryamBen updated the diff for D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jun 23 2021, 7:34 AM · Restricted Project
MaryamBen added inline comments to D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jun 23 2021, 7:23 AM · Restricted Project

Jun 22 2021

MaryamBen added a comment to D104642: [AIX][XCOFF] Enable support for 64 bit symbol table writing.

Test case?

Jun 22 2021, 1:39 AM · Restricted Project
MaryamBen updated the diff for D104642: [AIX][XCOFF] Enable support for 64 bit symbol table writing.

formatting the file

Jun 22 2021, 1:33 AM · Restricted Project
MaryamBen updated the summary of D104646: [AIX][XCOFF] 64-bit relocation reading support.
Jun 22 2021, 12:31 AM · Restricted Project
MaryamBen updated the summary of D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jun 22 2021, 12:30 AM · Restricted Project
MaryamBen updated the summary of D104642: [AIX][XCOFF] Enable support for 64 bit symbol table writing.
Jun 22 2021, 12:29 AM · Restricted Project

Jun 21 2021

MaryamBen requested review of D104646: [AIX][XCOFF] 64-bit relocation reading support.
Jun 21 2021, 7:50 AM · Restricted Project
MaryamBen requested review of D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests.
Jun 21 2021, 7:23 AM · Restricted Project
MaryamBen retitled D104642: [AIX][XCOFF] Enable support for 64 bit symbol table writing from [AIX][XCOFF64] Enable support for 64 bit symbol table writing to [AIX][XCOFF] Enable support for 64 bit symbol table writing.
Jun 21 2021, 7:18 AM · Restricted Project
MaryamBen retitled D104639: [AIX][XCOFF] Add support for 64-bit file header and section header writing from [AIX][XCOFF64] Add support for 64-bit file header and section header writing to [AIX][XCOFF] Add support for 64-bit file header and section header writing.
Jun 21 2021, 7:17 AM · Restricted Project
MaryamBen requested review of D104642: [AIX][XCOFF] Enable support for 64 bit symbol table writing.
Jun 21 2021, 7:06 AM · Restricted Project
MaryamBen requested review of D104639: [AIX][XCOFF] Add support for 64-bit file header and section header writing.
Jun 21 2021, 6:44 AM · Restricted Project

Jun 16 2021

MaryamBen added inline comments to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.
Jun 16 2021, 5:31 AM · Restricted Project
MaryamBen added inline comments to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.
Jun 16 2021, 5:18 AM · Restricted Project
MaryamBen added a comment to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.

My first suggestion is we need to break up this patch to make it smaller and easier to review. The natural place to partition it is the llvm-readobj functionality. I don't think the YAML tools support generating 64-bit XCOFF objects yet, but we can add a precompiled object file as test input.

Reiterating this, as I think it is really important. This patch is too large to review as is. I understand breaking it up seems like extra work but it is going to go much faster/smoother if we can partition this into some smaller changes. The first patch I think should be the addition of Relocation64 to the XCOFF implementation in the Object library (ie include/llvm/Object/XCOFFObjectFile.h and lib/ObjectXCOFFObjectFile.cpp), any code needed to support that (for example if additions need to be made to include/llvm/BinaryFormat/XCOFF.h) and the 64-bit relocation reading support added to the llvm-readobj XCOFFDumper to exercises the newly added functionality.

Jun 16 2021, 5:11 AM · Restricted Project

Jun 9 2021

MaryamBen added inline comments to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.
Jun 9 2021, 12:41 AM · Restricted Project

Jun 7 2021

MaryamBen added reviewers for D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files: daltenty, hubert.reinterpretcast.
Jun 7 2021, 12:07 AM · Restricted Project

Jun 4 2021

MaryamBen updated the summary of D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.
Jun 4 2021, 6:18 AM · Restricted Project
MaryamBen updated the summary of D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.
Jun 4 2021, 6:13 AM · Restricted Project