Page MenuHomePhabricator

EGuesnet (Guesnet)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 16 2021, 7:27 AM (85 w, 2 d)

Recent Activity

Jan 18 2022

EGuesnet added a comment to D104367: [AIX] Support of Big archive (write).

Hi @DiggerLin , I do not work on LLVM anymore. Please contact Sanket for more information.

Jan 18 2022, 1:50 AM · Restricted Project, Restricted Project

Oct 13 2021

EGuesnet added a comment to D100651: [AIX] Support of Big archive (read).

Hi @jhenderson, @jsji , @DiggerLin,
As I said before, I do not have time to improve this PR before one or two months at least, as our priorities have shifted.
My proposal to @Esme about accepting the patch with minor changes was OK but now there are too much changes requested by reviewers.
So, I accept that you start an improvement / alternative version as long as you credit.

Oct 13 2021, 1:26 AM · Restricted Project

Sep 30 2021

EGuesnet added a comment to D100651: [AIX] Support of Big archive (read).

I do not have time to improve this PR before begin of November. We have other priorities right now.
This PR has nearly 6 months, so, it can wait one more.

Sep 30 2021, 1:25 AM · Restricted Project

Sep 15 2021

EGuesnet added inline comments to D100651: [AIX] Support of Big archive (read).
Sep 15 2021, 3:28 AM · Restricted Project

Sep 14 2021

EGuesnet added inline comments to D100651: [AIX] Support of Big archive (read).
Sep 14 2021, 5:43 AM · Restricted Project
EGuesnet added inline comments to D100651: [AIX] Support of Big archive (read).
Sep 14 2021, 12:51 AM · Restricted Project

Aug 17 2021

EGuesnet added inline comments to D100651: [AIX] Support of Big archive (read).
Aug 17 2021, 5:44 AM · Restricted Project

Jul 23 2021

EGuesnet added a comment to D100651: [AIX] Support of Big archive (read).

Hi @jhenderson,
I cannot follow exactly what you propose, because llvm-ar (and maybe other tools) uses directly child_iterator. As this object does not have access to Archive (=Parent), it seems difficult to transfert Child vector of Archive to child_iterator. Moreover, I want to avoid to un-const Parent in Child.

Jul 23 2021, 8:17 AM · Restricted Project
EGuesnet updated the diff for D100651: [AIX] Support of Big archive (read).

Update D100651.

Jul 23 2021, 8:09 AM · Restricted Project

Jul 13 2021

EGuesnet updated the diff for D100651: [AIX] Support of Big archive (read).

Use of clang-format.

Jul 13 2021, 8:46 AM · Restricted Project
EGuesnet added a comment to D100651: [AIX] Support of Big archive (read).

You should get some people who are more familiar with XCOFF/AIX to help review correctness. There has been a lot of development for this in other tools (e.g. llvm-readobj).

Jul 13 2021, 8:44 AM · Restricted Project
EGuesnet updated the summary of D100651: [AIX] Support of Big archive (read).
Jul 13 2021, 8:25 AM · Restricted Project
EGuesnet updated the diff for D100651: [AIX] Support of Big archive (read).

[AIX] Support of Big archive (read)

Jul 13 2021, 8:24 AM · Restricted Project

Jul 7 2021

EGuesnet added a comment to D100651: [AIX] Support of Big archive (read).

Hi, @rupprecht, @jhenderson,
Any news?
It will be better if this PR (and D104367) can be integrated in next LLVM version, and the merge windows will be closed soon.
Thanks.

Jul 7 2021, 2:07 AM · Restricted Project

Jun 17 2021

EGuesnet added a comment to D100651: [AIX] Support of Big archive (read).

Any news, @rupprecht?

Jun 17 2021, 2:04 AM · Restricted Project

Jun 16 2021

EGuesnet published D104367: [AIX] Support of Big archive (write) for review.
Jun 16 2021, 3:46 AM · Restricted Project, Restricted Project

Jun 14 2021

EGuesnet added a comment to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.

Hello,
For you information, we have had trouble with arcanist configuration, and my account is used to push to review. Patch has been written by @MaryamBen, as confirmed by commit author.
Comments in push message are also made @MaryamBen.
Regards.

Jun 14 2021, 5:36 AM · Restricted Project
EGuesnet updated the diff for D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.

Implement XCOFFRelocation32 and XCOFFRelocation64 properly

Jun 14 2021, 5:25 AM · Restricted Project

Jun 9 2021

EGuesnet updated the diff for D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.

@jhenderson thank you for your comments. It was very helpful.

Jun 9 2021, 2:06 AM · Restricted Project

Jun 8 2021

EGuesnet updated the diff for D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.

Remove the unreachable
@sfertile thank you

Jun 8 2021, 12:40 AM · Restricted Project

Jun 4 2021

EGuesnet requested review of D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.
Jun 4 2021, 5:52 AM · Restricted Project

May 28 2021

EGuesnet added inline comments to D100651: [AIX] Support of Big archive (read).
May 28 2021, 7:09 AM · Restricted Project
EGuesnet added a comment to D100651: [AIX] Support of Big archive (read).

I have modified ArchiveWriter.cpp to avoid the Warning.

May 28 2021, 6:55 AM · Restricted Project
EGuesnet updated the diff for D100651: [AIX] Support of Big archive (read).

Updating D100651: [AIX] Support of Big archive (read)

May 28 2021, 6:51 AM · Restricted Project

May 26 2021

EGuesnet updated the diff for D100651: [AIX] Support of Big archive (read).

[AIX] Support of Big archive (read)

May 26 2021, 5:59 AM · Restricted Project

May 14 2021

EGuesnet updated the diff for D100651: [AIX] Support of Big archive (read).

Updating D100651: [AIX] Support of Big archive (read)

May 14 2021, 5:43 AM · Restricted Project

Apr 23 2021

EGuesnet added a comment to D100651: [AIX] Support of Big archive (read).

First, sorry for the noise, I do not master arc yet.

Apr 23 2021, 2:18 AM · Restricted Project
EGuesnet updated the diff for D100651: [AIX] Support of Big archive (read).

[AIX] Support of Big archive (read)

Apr 23 2021, 1:50 AM · Restricted Project
EGuesnet updated the diff for D100651: [AIX] Support of Big archive (read).
Apr 23 2021, 1:41 AM · Restricted Project
EGuesnet updated the diff for D100651: [AIX] Support of Big archive (read).
Apr 23 2021, 1:36 AM · Restricted Project
EGuesnet updated the diff for D100651: [AIX] Support of Big archive (read).

Add bianry file

Apr 23 2021, 1:30 AM · Restricted Project

Apr 21 2021

EGuesnet updated the summary of D100651: [AIX] Support of Big archive (read).
Apr 21 2021, 8:08 AM · Restricted Project
EGuesnet updated the diff for D100651: [AIX] Support of Big archive (read).

Deal correctly with memory (destructor, operator=), add test. No regression found.
It is OK for review in point of view.

Apr 21 2021, 8:07 AM · Restricted Project

Apr 16 2021

EGuesnet updated the summary of D100651: [AIX] Support of Big archive (read).
Apr 16 2021, 8:00 AM · Restricted Project
EGuesnet requested review of D100651: [AIX] Support of Big archive (read).
Apr 16 2021, 7:58 AM · Restricted Project