Page MenuHomePhabricator

[AIX][XCOFF] Enable support for 64 bit symbol table writing
AcceptedPublic

Authored by MaryamBen on Jun 21 2021, 7:06 AM.

Details

Summary

Support 64 bit symbol table writing.
This patch is part of D103696 partition

Diff Detail

Event Timeline

MaryamBen retitled this revision from [AIX][XCOFF64] Enable support for 64 bit symbol table writing to [AIX][XCOFF] Enable support for 64 bit symbol table writing.Jun 21 2021, 7:18 AM
MaryamBen edited the summary of this revision. (Show Details)Jun 22 2021, 12:29 AM

Test case?

llvm/lib/MC/XCOFFObjectWriter.cpp
584

Please run clang-format.

603
MaryamBen updated this revision to Diff 353577.Jun 22 2021, 1:33 AM

formatting the file

MaryamBen marked 2 inline comments as done.Jun 22 2021, 1:34 AM

Test case?

There is no way to run tests for 64-bit since the writeRelocation isn't implemented.

void XCOFFObjectWriter::writeRelocation(XCOFFRelocation Reloc,
                                        const ControlSection &CSection) {
  if (TargetObjectWriter->is64Bit())
    report_fatal_error("64-bit XCOFF object files are not supported yet.");

Test case?

There is no way to run tests for 64-bit since the writeRelocation isn't implemented.

void XCOFFObjectWriter::writeRelocation(XCOFFRelocation Reloc,
                                        const ControlSection &CSection) {
  if (TargetObjectWriter->is64Bit())
    report_fatal_error("64-bit XCOFF object files are not supported yet.");

Surely you could have a test case without any relocations?

Helflym accepted this revision.Aug 6 2021, 12:55 AM
Helflym added a subscriber: Helflym.

Ok for the XCOFF part

This revision is now accepted and ready to land.Aug 6 2021, 12:55 AM