Page MenuHomePhabricator

[lldb][NFC] Use C++ versions of the deprecated C standard library headers
ClosedPublic

Authored by teemperor on Tue, May 25, 5:29 AM.

Details

Summary

The C headers are deprecated so as requested in D102845, this is replacing them
all with their (not deprecated) C++ equivalent.

Diff Detail

Event Timeline

teemperor created this revision.Tue, May 25, 5:29 AM
teemperor requested review of this revision.Tue, May 25, 5:29 AM

If we do this here, then we might as well do it for all of LLVM. But there are just so many Herald rules I want to trigger for a single review.

Also this means we should use the std version of all the C functions now.

teemperor updated this revision to Diff 347667.Tue, May 25, 6:55 AM
  • Replace a few more header uses that didn't get replaced in the initial version.
shafik accepted this revision.Tue, May 25, 9:57 AM

Thank you for taking care of this, it was on my list of things to do.

We definitely don't use std:: consistently, probably size_t being one of the main ones but fixing that was well would be a lot of code churn. So probably better to change it as folks refactor code.

This revision is now accepted and ready to land.Tue, May 25, 9:57 AM
This revision was landed with ongoing or failed builds.Wed, May 26, 3:46 AM
This revision was automatically updated to reflect the committed changes.